GNU bug report logs - #63117
[PATCH] gnu: yt-dlp: Change input.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63117: closed ([PATCH] gnu: yt-dlp: Change input.)
Date: Thu, 25 May 2023 10:43:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 25 May 2023 12:42:25 +0200
with message-id <87ilcgg0a6.fsf_-_ <at> gnu.org>
and subject line Re: bug#63117: [PATCH] gnu: yt-dlp: Change input.
has caused the debbugs.gnu.org bug report #63117,
regarding [PATCH] gnu: yt-dlp: Change input.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63117: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63117
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dominik Delgado Steuter <d <at> delgado.nrw>
To: guix-patches <at> gnu.org
Cc: Dominik Delgado Steuter <d <at> delgado.nrw>
Subject: [PATCH] gnu: yt-dlp: Change input.
Date: Thu, 27 Apr 2023 16:32:00 +0200

yt-dlp complained when the "--add-metadata" flag was used.
youtube-dl does not need ffmpeg as a propagated-input, though.

* gnu/packages/video.scm (yt-dlp)[inputs]: Remove ffmpeg.
[propagated-inputs]: Add ffmpeg.
---
 gnu/packages/video.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 838dfe7..df6bbc5 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2598,6 +2598,7 @@ (define-public yt-dlp
                 (when tests?
                   (invoke "pytest" "-k" "not download"))))))))
     (inputs (modify-inputs (package-inputs youtube-dl)
+              (delete ffmpeg) ;yt-dlp needs it as propagated-input
               (append python-brotli
                       python-certifi
                       python-mutagen
@@ -2611,6 +2612,8 @@ (define-public yt-dlp
          (list pandoc)
          '())
        (list python-pytest zip)))
+    (propagated-inputs
+     (list ffmpeg))
     (description
      "yt-dlp is a small command-line program to download videos from
 YouTube.com and many more sites.  It is a fork of youtube-dl with a

base-commit: fa685c87eaa9888a4278f39bb2b815673589dced
-- 
2.39.2

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Dominik Delgado Steuter <dds <at> disroot.org>
Cc: liliana.prikler <at> gmail.com, 63117-done <at> debbugs.gnu.org
Subject: Re: bug#63117: [PATCH] gnu: yt-dlp: Change input.
Date: Thu, 25 May 2023 12:42:25 +0200

Hi Dominik,

Dominik Delgado Steuter <dds <at> disroot.org> skribis:

> The old expression did not work; ffmpeg was not found
> when using the --add-metadata flag.
>
> * gnu/packages/video.scm (yt-dlp)
> [arguments]: Adjust substitution in custom 'default-to-the-ffmpeg-input phase.

Applied.  Thank you and thanks to Liliana for reviewing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.