From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 10:32:19 2023 Received: (at submit) by debbugs.gnu.org; 27 Apr 2023 14:32:19 +0000 Received: from localhost ([127.0.0.1]:59486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps2fT-0007tm-DU for submit@debbugs.gnu.org; Thu, 27 Apr 2023 10:32:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:34694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps2fR-0007te-3M for submit@debbugs.gnu.org; Thu, 27 Apr 2023 10:32:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps2fQ-0001K1-TE for guix-patches@gnu.org; Thu, 27 Apr 2023 10:32:16 -0400 Received: from delgado.nrw ([217.160.67.216]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps2fL-0003Ef-Gz for guix-patches@gnu.org; Thu, 27 Apr 2023 10:32:16 -0400 From: Dominik Delgado Steuter DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=delgado.nrw; s=mail; t=1682605928; bh=GMJQ5aWDxPn4BXoJt7uTjinBFYu+fL3TG99cGy49uG8=; h=From:To:Cc:Subject:Date:From; b=ZJhb/BELMeHIZBPjcOoUY5J5Kpg9hse52irHtWlmDGvrvMg42lMZZEea3ZaK9F0Kb M9a7XLuzdkHWduCJ9RnnafG7PNdhVDTnItk/+LWozirlNnD6V7abs4JuJS+80wWjBi 3+Sv2n3ei0so8CMrY+fd3hiDwSqKcA66BZO3A8GPvtnSpv52JWd9rdj+qn9Kux4PVs fiHZveRRhXGe1OAUx69tl4GzjJao6aK116kDsAJfIy7u4XGlQ97fB+iMv4TTnaZPwq RNdBKcZ8O8fcfIOIlhCu7c5pwaFNdV3P2G2+rSjlkepjdhNnCWhsH+Sg+j3iX/4NGW MwDMVUpjZUPXQ== To: guix-patches@gnu.org Subject: [PATCH] gnu: yt-dlp: Change input. Date: Thu, 27 Apr 2023 16:32:00 +0200 Message-Id: <20230427143200.13000-1-d@delgado.nrw> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.160.67.216; envelope-from=d@delgado.nrw; helo=delgado.nrw X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Dominik Delgado Steuter X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) yt-dlp complained when the "--add-metadata" flag was used. youtube-dl does not need ffmpeg as a propagated-input, though. * gnu/packages/video.scm (yt-dlp)[inputs]: Remove ffmpeg. [propagated-inputs]: Add ffmpeg. --- gnu/packages/video.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 838dfe7..df6bbc5 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -2598,6 +2598,7 @@ (define-public yt-dlp (when tests? (invoke "pytest" "-k" "not download")))))))) (inputs (modify-inputs (package-inputs youtube-dl) + (delete ffmpeg) ;yt-dlp needs it as propagated-input (append python-brotli python-certifi python-mutagen @@ -2611,6 +2612,8 @@ (define-public yt-dlp (list pandoc) '()) (list python-pytest zip))) + (propagated-inputs + (list ffmpeg)) (description "yt-dlp is a small command-line program to download videos from YouTube.com and many more sites. It is a fork of youtube-dl with a base-commit: fa685c87eaa9888a4278f39bb2b815673589dced -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 29 00:36:10 2023 Received: (at 63117) by debbugs.gnu.org; 29 Apr 2023 04:36:10 +0000 Received: from localhost ([127.0.0.1]:34856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pscJe-0005mB-97 for submit@debbugs.gnu.org; Sat, 29 Apr 2023 00:36:10 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:49518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pscJb-0005ly-Fq for 63117@debbugs.gnu.org; Sat, 29 Apr 2023 00:36:09 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pscJV-0005g0-B9; Sat, 29 Apr 2023 00:36:01 -0400 Date: Sat, 29 Apr 2023 00:36:01 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: Dominik Delgado Steuter Subject: Re: [bug#63117] [PATCH] gnu: yt-dlp: Change input. In-Reply-To: <20230427143200.13000-1-d@delgado.nrw> Message-ID: References: <20230427143200.13000-1-d@delgado.nrw> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63117 Cc: 63117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 27 Apr 2023, Dominik Delgado Steuter via Guix-patches via wrote: > yt-dlp complained when the "--add-metadata" flag was used. > youtube-dl does not need ffmpeg as a propagated-input, though. Dominik, Thanks for working on improving our yt-dlp package. Can you explain a little more about why yt-dlp needs ffmpeg to be propagated? I haven't looked too closely, but I suspect yt-dlp just want to be able to call ffmpeg at runtime. If that's true, then I think it would be better to use substitute* in a phase so that yt-dlp can use the full path to ffmpeg, and not clutter folks' profiles. If I'm correct, can you provide an updated patch that does that? I'm happy to provide more guidance if you need it. If I'm wrong and ffmpeg needs to be propagated for some other reason, can you add a comment in the code explaining the need? Best, Jack From debbugs-submit-bounces@debbugs.gnu.org Mon May 01 18:39:17 2023 Received: (at 63117) by debbugs.gnu.org; 1 May 2023 22:39:17 +0000 Received: from localhost ([127.0.0.1]:41210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcAu-0000pT-TI for submit@debbugs.gnu.org; Mon, 01 May 2023 18:39:17 -0400 Received: from delgado.nrw ([217.160.67.216]:51416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcAs-0000pD-FJ for 63117@debbugs.gnu.org; Mon, 01 May 2023 18:39:15 -0400 Message-ID: <42c9cb81-aeb2-6fd5-44be-ebe8e73c2682@delgado.nrw> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=delgado.nrw; s=mail; t=1682980748; bh=wKGQODQYRwEMyCKKicp4jX8MslFJkKjqOLiftlqugrk=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From; b=VP5pfnc40EEGFG+ma5y+yI5sVnJUS4RSqUfrCd0oFtX6PkA9myDieuSxQa1VPEgKB uVOuvMzVPBs0pBEY0/ll9AYWnr8CeXhOm7utIm4q3cBNDh/QhP3dsKfVCFi+DIz0g6 PG4V0noRT65t8lBw9NNRC8FgBiWhv6Jo7KRnCbheJ5I+ou/dffZ9ponD7zgQgq57Hm xk1gqJfhIRdChKng9CXysJqn9BUfb4zKIt1iWFHZbQZ/TdYeyVLeJb6BZZSdLGoLYX zaLL+ag5QvHGMu09+y/Ur4ytUiaDqTJOOby1Ygf0d+BjsLvXeulR0o9wQD4jCC/i9x jvNJR9v852jSw== Date: Tue, 2 May 2023 00:39:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [bug#63117] [PATCH] gnu: yt-dlp: Change input. Content-Language: en-US To: Jack Hill References: <20230427143200.13000-1-d@delgado.nrw> From: Dominik Delgado Steuter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 63117 Cc: 63117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi Jack, thanks for reviewing my patch. You are probably right that yt-dlp only needs the path and not necessarily the propagated-input. I will try to figure out how exactly to do that and then send the updated patch. Regards, Dominik Am 29.04.23 um 06:36 schrieb Jack Hill: > On Thu, 27 Apr 2023, Dominik Delgado Steuter via Guix-patches via wrote: > >> yt-dlp complained when the "--add-metadata" flag was used. >> youtube-dl does not need ffmpeg as a propagated-input, though. > > Dominik, > > Thanks for working on improving our yt-dlp package. Can you explain a > little more about why yt-dlp needs ffmpeg to be propagated? I haven't > looked too closely, but I suspect yt-dlp just want to be able to call > ffmpeg at runtime. If that's true, then I think it would be better to > use substitute* in a phase so that yt-dlp can use the full path to > ffmpeg, and not clutter folks' profiles. > > If I'm correct, can you provide an updated patch that does that? I'm > happy to provide more guidance if you need it. > > If I'm wrong and ffmpeg needs to be propagated for some other reason, > can you add a comment in the code explaining the need? > > Best, > Jack From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 20:52:04 2023 Received: (at 63117) by debbugs.gnu.org; 6 May 2023 00:52:04 +0000 Received: from localhost ([127.0.0.1]:57827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv69a-0006Ry-8e for submit@debbugs.gnu.org; Fri, 05 May 2023 20:52:04 -0400 Received: from knopi.disroot.org ([178.21.23.139]:51676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv1SO-0005Yb-UV for 63117@debbugs.gnu.org; Fri, 05 May 2023 15:51:09 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 38BF2402DC; Fri, 5 May 2023 21:51:08 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wHF7bJwjIG0g; Fri, 5 May 2023 21:51:07 +0200 (CEST) From: Dominik Delgado Steuter DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1683316267; bh=mqteeTX9HUf+GM8ZuA3W56up7ZdHgkFgaQcKvEj850I=; h=From:To:Cc:Subject:Date; b=DgTDepAh1sC1NPVXAa0cGm3NlN+t1hAp4AwH9+SljJnus7W7k7WK4Hwnh9ZtQIDsW n/75u8Mn5Sof4wmocHof8OanQWXHyWmDKYV0V5ExOFEKyW4xhW4fJEgQrTJYjXTFo8 2D1M9myPWMnFjZejnhatUVr6fZPDHgbwndoFS/j/WCGXxN/qEzVyr8ksqYKiIJy3vv 9NtBaovketaNczAyspWIBi4IcbVb7CtWtfMrPTX7lLsIv4tmMi/6G8Ijmm7UUUSuFj D/m1hvwTLqIuILoxe8M0QsCzWX9lpXE1cMfkUe0GE2N2sHnOqT0nE5jio2mp161Pxq J4/mIMjjw+ryg== To: 63117@debbugs.gnu.org Subject: [PATCH] gnu: yt-dlp: Fix substitution for ffmpeg path. Date: Fri, 5 May 2023 21:50:53 +0200 Message-Id: <20230505195053.1752-1-dds@disroot.org> MIME-Version: 1.0 X-Debbugs-Cc: jgart@dismail.de X-Debbugs-Cc: lars@6xq.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63117 X-Mailman-Approved-At: Fri, 05 May 2023 20:51:59 -0400 Cc: Dominik Delgado Steuter , jackhill@jackhill.us X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The old expression did not work; ffmpeg was not found when using the --add-metadata flag. * gnu/packages/video.scm (yt-dlp) [arguments]: Adjust substitution in custom 'default-to-the-ffmpeg-input phase. --- gnu/packages/video.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 65fd92e..1301b79 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -64,6 +64,7 @@ ;;; Copyright © 2022 Chadwain Holness ;;; Copyright © 2022 Andy Tai ;;; Copyright © 2023 Ott Joon +;;; Copyright © 2023 Dominik Delgado Steuter ;;; ;;; This file is part of GNU Guix. ;;; @@ -2570,8 +2571,8 @@ (define-public yt-dlp (replace 'default-to-the-ffmpeg-input (lambda _ (substitute* "yt_dlp/postprocessor/ffmpeg.py" - (("\\.get_param\\('ffmpeg_location'\\)" match) - (format #f "~a or '~a'" match (which "ffmpeg")))))) + (("location = self.get_param(.*)$") + (string-append "location = '" #$ffmpeg "/bin'\n"))))) (replace 'build-generated-files (lambda* (#:key inputs #:allow-other-keys) (if (assoc-ref inputs "pandoc") base-commit: 6922069bcbe5c08da09c00e5aad44e390ebd1cc7 -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 00:23:56 2023 Received: (at 63117) by debbugs.gnu.org; 6 May 2023 04:23:56 +0000 Received: from localhost ([127.0.0.1]:58000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv9Se-0006jM-1S for submit@debbugs.gnu.org; Sat, 06 May 2023 00:23:56 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:51482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv9SX-0006iv-2B for 63117@debbugs.gnu.org; Sat, 06 May 2023 00:23:54 -0400 Received: by mail-ej1-f65.google.com with SMTP id a640c23a62f3a-965fc25f009so154287966b.3 for <63117@debbugs.gnu.org>; Fri, 05 May 2023 21:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683347023; x=1685939023; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=zRvMFMY2IZR8yBPYbnnIsSSpBpr2Q1aZUCrWUoChT2w=; b=XetAKDO29SnJYDRseA9c/sy3JNGB9kY0Z3Dxje8OWqcbtLIL2/6i0uK94esUMm393N 8JNExhqlFjDngCT7ejKsPp6NbtokABALAnGylTuTmz3c9D842PyNsSodOxm2AjzwX5C1 Ju9WZcA68M2A57ow22PwuRz+FRAE+k5m0wMYfBw3zGUywzngexQJp5147ZENoNJIXvED /tDCMAIA+C7D6ZFlpWqRBY2zWgzy86YlG4+7Nw50jbN5R1esyR22LLRBHQaVFseinCl2 iZbD6O/CIBcxlPwPQE9GQN9OXaRZ5H/ML+YfGyT8IAc6rpXis06qIKK1Jg7V6ZzTqE2Y I/VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683347023; x=1685939023; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zRvMFMY2IZR8yBPYbnnIsSSpBpr2Q1aZUCrWUoChT2w=; b=i/D3PCw/eLNQQm9TFnlia+I/aAppoC4iLAahRdZwebkfXEfIhxIrqqaS4BQ+Bx4+8F u9KIdMwcDxXkU06UecccOBy+ESvfgbAXQufRVXI8KVGFxTP3hX4oLRfNTeVr6baiLUl+ 3Ol1fYqFzAEo6jVUQ9cpYL/VCA3w4EsLgRo/5+kL0i/sKFO4f5K803VNTbO2Ss8eO0Y1 aIhBhrHcn7ZcWDMWttoc1aWYL903+r4kJHz/BZUt9fpKxHqsur5VgQ49+QL3+QPMDUEQ 2IIjvOjG3jlBtNuYxwHrQCJ9iBIOMYL5pAUyZ/FERQMznqTRR/7EqS0xlqdTQQq37wjd Kb2g== X-Gm-Message-State: AC+VfDzbWqB3GNziCS9zPLOjvsPFibbNVcdW+Ew19DsTS/NlWdVvWGaK ONUlhjlbH+hZMQyETttk0O8= X-Google-Smtp-Source: ACHHUZ7X1+3h2XCuO1wcGSKOTmtkiWSaXtoTB5WFpzGfur2Y5Uqsr5uFPA854THlSmfcOGK82bAqFg== X-Received: by 2002:a17:907:9345:b0:958:4870:8d09 with SMTP id bv5-20020a170907934500b0095848708d09mr2875475ejc.37.1683347023054; Fri, 05 May 2023 21:23:43 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id lh10-20020a170906f8ca00b00965efafa492sm1270340ejb.156.2023.05.05.21.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 21:23:42 -0700 (PDT) Message-ID: <7de4e6cf2831ed22b29da144e85e4aca661ae2bb.camel@gmail.com> Subject: Re: [PATCH] gnu: yt-dlp: Fix substitution for ffmpeg path. From: Liliana Marie Prikler To: Dominik Delgado Steuter , 63117@debbugs.gnu.org Date: Sat, 06 May 2023 06:23:41 +0200 In-Reply-To: <20230505195053.1752-1-dds@disroot.org> References: <20230505195053.1752-1-dds@disroot.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63117 Cc: jackhill@jackhill.us X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gRnJlaXRhZywgZGVtIDA1LjA1LjIwMjMgdW0gMjE6NTAgKzAyMDAgc2NocmllYiBEb21pbmlr IERlbGdhZG8KU3RldXRlcjoKPiBUaGUgb2xkIGV4cHJlc3Npb24gZGlkIG5vdCB3b3JrOyBmZm1w ZWcgd2FzIG5vdCBmb3VuZAo+IHdoZW4gdXNpbmcgdGhlIC0tYWRkLW1ldGFkYXRhIGZsYWcuCj4g Cj4gKiBnbnUvcGFja2FnZXMvdmlkZW8uc2NtICh5dC1kbHApCj4gW2FyZ3VtZW50c106IEFkanVz dCBzdWJzdGl0dXRpb24gaW4gY3VzdG9tICdkZWZhdWx0LXRvLXRoZS1mZm1wZWctCj4gaW5wdXQg cGhhc2UuCj4gLS0tCj4gwqBnbnUvcGFja2FnZXMvdmlkZW8uc2NtIHwgNSArKystLQo+IMKgMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZ251L3BhY2thZ2VzL3ZpZGVvLnNjbSBiL2dudS9wYWNrYWdlcy92aWRlby5zY20KPiBp bmRleCA2NWZkOTJlLi4xMzAxYjc5IDEwMDY0NAo+IC0tLSBhL2dudS9wYWNrYWdlcy92aWRlby5z Y20KPiArKysgYi9nbnUvcGFja2FnZXMvdmlkZW8uc2NtCj4gQEAgLTY0LDYgKzY0LDcgQEAKPiDC oDs7OyBDb3B5cmlnaHQgwqkgMjAyMiBDaGFkd2FpbiBIb2xuZXNzIDxjaGFkd2FpbmhvbG5lc3NA Z21haWwuY29tPgo+IMKgOzs7IENvcHlyaWdodCDCqSAyMDIyIEFuZHkgVGFpIDxhdGFpQGF0YWku b3JnPgo+IMKgOzs7IENvcHlyaWdodCDCqSAyMDIzIE90dCBKb29uIDxvakB2ZXJuLmNjPgo+ICs7 OzsgQ29weXJpZ2h0IMKpIDIwMjMgRG9taW5payBEZWxnYWRvIFN0ZXV0ZXIgPGRkc0BkaXNyb290 Lm9yZz4KPiDCoDs7Owo+IMKgOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4Lgo+IMKg Ozs7Cj4gQEAgLTI1NzAsOCArMjU3MSw4IEBAIChkZWZpbmUtcHVibGljIHl0LWRscAo+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAocmVwbGFjZSAnZGVmYXVsdC10by10aGUtZmZtcGVnLWlucHV0 Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAobGFtYmRhIF8KPiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAoc3Vic3RpdHV0ZSogInl0X2RscC9wb3N0cHJvY2Vzc29yL2Zm bXBlZy5weSIKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoKCJcXC5nZXRf cGFyYW1cXCgnZmZtcGVnX2xvY2F0aW9uJ1xcKSIgbWF0Y2gpCj4gLcKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAoZm9ybWF0ICNmICJ+YSBvciAnfmEnIiBtYXRjaCAod2hpY2gK PiAiZmZtcGVnIikpKSkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgo ImxvY2F0aW9uID0gc2VsZi5nZXRfcGFyYW0oLiopJCIpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAoc3RyaW5nLWFwcGVuZCAibG9jYXRpb24gPSAnIiAjJGZmbXBlZwo+ ICIvYmluJ1xuIikpKSkpClRoZSBwcm9wZXIgZXhwcmVzc2lvbiB3b3VsZCBiZcKgCiAgKGRpcm5h bWUgKHNlYXJjaC1pbnB1dC1maWxlIGlucHV0cyAiYmluL2ZmbXBlZyIpKQpZb3UgYWxzbyBuZWVk IHRvIG1ha2UgdGhlIChsYW1iZGEgXyAuLi4pIGludG8gYcKgCihsYW1iZGEqICgjOmtleSBpbnB1 dHMgIzphbGxvdy1vdGhlci1rZXlzKSAuLi4pCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChy ZXBsYWNlICdidWlsZC1nZW5lcmF0ZWQtZmlsZXMKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIChsYW1iZGEqICgjOmtleSBpbnB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChpZiAoYXNzb2MtcmVmIGlucHV0cyAicGFuZG9jIikK PiAKPiBiYXNlLWNvbW1pdDogNjkyMjA2OWJjYmU1YzA4ZGEwOWMwMGU1YWFkNDRlMzkwZWJkMWNj NwoKQ2hlZXJzCg== From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 09:50:12 2023 Received: (at 63117) by debbugs.gnu.org; 20 May 2023 13:50:12 +0000 Received: from localhost ([127.0.0.1]:58027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0MyK-0007Ze-En for submit@debbugs.gnu.org; Sat, 20 May 2023 09:50:12 -0400 Received: from knopi.disroot.org ([178.21.23.139]:34444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0MyF-0007ZR-Js for 63117@debbugs.gnu.org; Sat, 20 May 2023 09:50:11 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 43EBB40318; Sat, 20 May 2023 15:50:06 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PnmaLUpDHO8Q; Sat, 20 May 2023 15:50:05 +0200 (CEST) From: Dominik Delgado Steuter DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1684590605; bh=+8EK6Vn8JqFJpBqF/4TbgzQ5xWORZFgnka64V2wtN6g=; h=From:To:Cc:Subject:Date; b=j81DSKzaP20qF2O6pelWj/ga2iJLwz+d8EUPshcaPHqp5XFUzSGYnXATUAvo6u//A 5YMruFvpi3Vgjem6gdNH61MHe1Xa5l6UnHhcbUJJhySe5UB4r8MSVAdaHD+NK0h4VL w5V15A2LsjaIQUies4HpjDnskv9d5RhnbRSsQw4ba3eqJDON7dwLoe/w9zE1iE8LuR i9aaIZTUIoKz9+SlWcN7e78DXg77Th2OOCXjUEnRg5/ojst7csVn4qldHDFQMWhLBX CijQMhzBF/XlRJEJZmfr69z5LiphybtjbySvmwrnIeRdhnGboFtLw4u9B5rGN8OELS tzpNSdpqw721Q== To: 63117@debbugs.gnu.org Subject: [PATCH] gnu: yt-dlp: Fix substitution for ffmpeg path. Date: Sat, 20 May 2023 15:49:13 +0200 Message-Id: <20230520134913.14357-1-dds@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63117 Cc: Dominik Delgado Steuter , liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The old expression did not work; ffmpeg was not found when using the --add-metadata flag. * gnu/packages/video.scm (yt-dlp) [arguments]: Adjust substitution in custom 'default-to-the-ffmpeg-input phase. --- gnu/packages/video.scm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index e6c437f..6d2824f 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -64,6 +64,7 @@ ;;; Copyright © 2022 Chadwain Holness ;;; Copyright © 2022 Andy Tai ;;; Copyright © 2023 Ott Joon +;;; Copyright © 2023 Dominik Delgado Steuter ;;; ;;; This file is part of GNU Guix. ;;; @@ -2569,10 +2570,13 @@ (define-public yt-dlp #~(modify-phases #$phases ;; See the comment for the corresponding phase in youtube-dl. (replace 'default-to-the-ffmpeg-input - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) (substitute* "yt_dlp/postprocessor/ffmpeg.py" - (("\\.get_param\\('ffmpeg_location'\\)" match) - (format #f "~a or '~a'" match (which "ffmpeg")))))) + (("location = self.get_param(.*)$") + (string-append + "location = '" + (dirname (search-input-file inputs "bin/ffmpeg")) + "'\n"))))) (replace 'build-generated-files (lambda* (#:key inputs #:allow-other-keys) (if (assoc-ref inputs "pandoc") base-commit: 24b6f94cf9b4ab97ef2eb70d05b2104a06776e62 -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Thu May 25 06:42:35 2023 Received: (at 63117-done) by debbugs.gnu.org; 25 May 2023 10:42:36 +0000 Received: from localhost ([127.0.0.1]:46054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q28QV-0007Rh-Il for submit@debbugs.gnu.org; Thu, 25 May 2023 06:42:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q28QS-0007RU-U5 for 63117-done@debbugs.gnu.org; Thu, 25 May 2023 06:42:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q28QN-00049n-M8; Thu, 25 May 2023 06:42:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=N/aSZVGXV4UbhUp8EMNQ8nFWVFqc/4c9Lumo/xfYaMI=; b=HhSrjO58vTysoYyHuAIK moWwkeQWRwYx8uuYdKaYK3Ucl7e9nUg3/VjL1BfB5wqm5JO6nwg1vml687+KncZJ8z4Y425sWV2Ll 80PQLPXgrZx3IiKEymRhqsuK4+QI1TXpFMceLw+am+aFZeVM2kONOtZ2Pu42v4lFBPymX48obmhdB BsFxxqmAmu5KD5blyoqWFGNGLHjbcS9h9g2fkeCy1ck3YjHV1wygpZ3hXFyouxo54Y/r55vjyLlYO /qhB2cd9bYJMHPS5CQz65KXt0c4sqrUqr1j9zertO8g1fIDUxYvUBOMOZvUg0/wjrbMYf/zNcPlqx JAMd/LCRuODwOQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q28QN-000227-7J; Thu, 25 May 2023 06:42:27 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Dominik Delgado Steuter Subject: Re: bug#63117: [PATCH] gnu: yt-dlp: Change input. References: <20230427143200.13000-1-d@delgado.nrw> <20230520134913.14357-1-dds@disroot.org> Date: Thu, 25 May 2023 12:42:25 +0200 In-Reply-To: <20230520134913.14357-1-dds@disroot.org> (Dominik Delgado Steuter's message of "Sat, 20 May 2023 15:49:13 +0200") Message-ID: <87ilcgg0a6.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63117-done Cc: liliana.prikler@gmail.com, 63117-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Dominik, Dominik Delgado Steuter skribis: > The old expression did not work; ffmpeg was not found > when using the --add-metadata flag. > > * gnu/packages/video.scm (yt-dlp) > [arguments]: Adjust substitution in custom 'default-to-the-ffmpeg-input p= hase. Applied. Thank you and thanks to Liliana for reviewing! Ludo=E2=80=99. From unknown Sat Jun 21 10:42:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 22 Jun 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator