From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 00:16:25 2023 Received: (at submit) by debbugs.gnu.org; 27 Apr 2023 04:16:25 +0000 Received: from localhost ([127.0.0.1]:57315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prt3Q-0004p2-JQ for submit@debbugs.gnu.org; Thu, 27 Apr 2023 00:16:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:59654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prnyk-0003sk-28 for submit@debbugs.gnu.org; Wed, 26 Apr 2023 18:51:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prnyj-0002GR-P8 for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2023 18:51:13 -0400 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prnyi-00031o-2g for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2023 18:51:13 -0400 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-94f7a7a3351so1477953366b.2 for ; Wed, 26 Apr 2023 15:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682549470; x=1685141470; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Tq0XU/LFG0aak2vhXo8Zc3NF7eIIEIJ2osCnVSRAItM=; b=WR0zw8W389SpcRrxXUnrZ/nzp1q4BpeWLIqL/FteBxtnsODMzdooOh/1lcxjwVctR8 6bl/feJvm0SlH4t94MhnqzFJNc4odIO8DZvkZwennES7bf7SeHitavTzNsC7mXr5Juxd 0gLPWLNPqy2SWvOifzNo/iziG0Tw8N7wmJ0/c9SlvT82291jpORzP28/7MYGZLy5BQjS 5S/kXEKKRUGUZW/C1ewpYHE3oLpvyjtpaqEA9hN+mn57yHUkaREZvvyWIRg4IHAAk3O1 USf2TcqH7qcrkCI/AU0AizHfn0x9pxnsswCl8Jh9Nlb99X6vtz8Llh4DY7KWEuKhtIty hw/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682549470; x=1685141470; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Tq0XU/LFG0aak2vhXo8Zc3NF7eIIEIJ2osCnVSRAItM=; b=mHM6UjvXdz7P4b62gkZ5eypyunjZnYNlZrsxACT1WQYW6uL5fW5lFiQGzXxdnYr8q8 hP4XVywIZ9qAPjbCPqlk4x2dja5B4liyRnjPVL4vwRW03a99Cjyw6D2j4oxqGW+BreKl YFs01TbdxLXwQ6/WHz4IZqGpgsFsVviKHlnsvXkYxB3zaoK0JGIRwedSB/Q0aCdFGbRJ q9xW7EgYYD0HkXROTWrf84lYUCSBx5QIv4s0EYxqJBi26ZrVZlZvm43oXT6727BHJqZs FOInOR15OFY9PeBf2X3rCDwbWth5PRuM2LN1adjGrdwwSce/cO7gQQIXCDN/qlGw6hl8 eSdQ== X-Gm-Message-State: AAQBX9fMyZl0lZYqhc+ejvz2yFL6lkVc9eV7w5pzz3q7dkYibDfPQH+F 3MfcnrbLnGVC8W9Gc0yeket/mCeTQoQ= X-Google-Smtp-Source: AKy350YHzXddnrDAeSrdeKgdN81JLBqfLfsgex1TXIuEwdr6ndIruHcqXf8fKmwLwJOOs3Up5Fwncg== X-Received: by 2002:a17:906:4915:b0:94a:5d16:a280 with SMTP id b21-20020a170906491500b0094a5d16a280mr19024892ejq.9.1682549470323; Wed, 26 Apr 2023 15:51:10 -0700 (PDT) Received: from pop-os (78-152-187-146.pool.ic.km.ua. [78.152.187.146]) by smtp.gmail.com with ESMTPSA id mb20-20020a170906eb1400b0094f432f2429sm8782758ejb.109.2023.04.26.15.51.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 15:51:10 -0700 (PDT) From: Maks To: bug-gnu-emacs@gnu.org Subject: 30.0.50; nconc compiler optimization breaks user packages Date: Thu, 27 Apr 2023 01:50:42 +0300 Message-ID: <877cty45rx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=mvproton@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 27 Apr 2023 00:16:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, I'm sorry if you received similar emails from me, there were problems with sending. Commit e6ca5834a6eab91023e9f968b65683d0a74db1e7 ('Improved nconc and append compiler optimisations') breaks vertico.el package. After very long debugging time I figured out that this commit affects behavior of `completion-hilit-commonality` function of minibuffer.el. I don't completely understand how it works buf try do describe some details. If I set breakpoint before breaking commit to 'vertico--affixate then I'll get next stacktrace ``` Debugger entered--entering a function: * vertico--affixate((#("report-emacs-bug" 0 1 (face (completions-first-difference))) #("cd" 0 1 (face (completions-first-difference))) #("5x5" 0 1 (face (completions-first-difference))) #("arp" 0 1 (face (completions-first-difference))) #("dbx" 0 1 (face (completions-first-difference))) #("dig" 0 1 (face (completions-first-difference))) #("erc" 0 1 (face (completions-first-difference))) #("ert" 0 1 (face (completions-first-difference))) #("eww" 0 1 (face (completions-first-difference))) #("ftp" 0 1 (face (completions-first-difference))))) vertico--arrange-candidates() vertico--exhibit() ... ``` buf if I do the same after breaking commit I'll get stacktrace ``` Debugger entered--entering a function: * vertico--affixate((#("report-emacs-bug" 0 1 (face (completions-first-difference))) #("cd" 0 1 (face (completions-first-difference))) #("5x5" 0 1 (face (completions-first-difference))) #("arp" 0 1 (face (completions-first-difference))) #("dbx" 0 1 (face (completions-first-difference))) #("dig" 0 1 (face (completions-first-difference))) #("erc" 0 1 (face (completions-first-difference))) #("ert" 0 1 (face (completions-first-difference))) #("eww" 0 1 (face (completions-first-difference))) #("ftp" 0 1 (face (completions-first-difference))) . 0)) vertico--arrange-candidates() vertico--exhibit() ... ``` As you can see, the difference is in the tail of the list. With the such tail vertico.el package crashed with error: ``` Error in post-command-hook (vertico--exhibit): (wrong-type-argument listp 0) ``` But testing `completion-hilit-commonality` in REPL separetely from vertico.el package give the same result (with 0 at the end of list). Before sending this report I have tried a lot of versions of the vertico.el package and have the same result. So I tend to think that problem is not directly related to package. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 01:34:49 2023 Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 05:34:49 +0000 Received: from localhost ([127.0.0.1]:57373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pruHJ-0007EC-ED for submit@debbugs.gnu.org; Thu, 27 Apr 2023 01:34:49 -0400 Received: from server.qxqx.de ([178.63.65.180]:57665 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pruHG-0007Du-5G for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 01:34:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:Subject:From:To: MIME-Version:Date:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5sDzyFLm534c3aHz9kumG10MsDQ/4ej9XqfP2wUfKzA=; b=ghUT+wotW+siNjKjTtbpoT0qvf HgB5XQWgdxLp2YGC4K7y53y7BTjpdQOx6uq8/XwpaL2MTG9DLDcT19WLaRWGVcuf8ZminLCqUhY5X 8tn6NgN50v9ztpCIkp188NClbwX81hihcd5G6KnSIpXs3HrOEa9xF6Zdhpmd0WvWUsuY=; Message-ID: Date: Thu, 27 Apr 2023 07:34:39 +0200 MIME-Version: 1.0 Content-Language: en-US To: 63103@debbugs.gnu.org From: Daniel Mendler Subject: Re: bug#63103: 30.0.50; nconc compiler optimization breaks user packages Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63103 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The problem is that `(nconc list nil)` is optimized to `list`. However improper lists like `(a b c . 0)` should be turned into `(a b c)`. Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 01:44:03 2023 Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 05:44:03 +0000 Received: from localhost ([127.0.0.1]:57395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pruQE-0007VB-PR for submit@debbugs.gnu.org; Thu, 27 Apr 2023 01:44:03 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pruQA-0007UP-7u for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 01:44:00 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 756B324026D for <63103@debbugs.gnu.org>; Thu, 27 Apr 2023 07:43:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682574231; bh=EHc6RmEXW7YVbYnhd0TVqPW6pWBd5uCxFa2tvp7NltQ=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=H2T79m+/JK1KchGS2YwovqeYKhRy0eKLw1ehz9xFcICxZl3lr0L1l+C+sqCQcl5KP ea95IYRsN9nCwTHtvIF8PTNdwwblxVzo75mrsegYhaGxGKYLnLXM1Oc7TgdJvsFN2k UVYkOmstex/7GdXHN9pDCjoCxvdui97vRB/zwDJQLMixO/EYMBpD/MJFkdQy1tuOiJ 2N9FPw5ASZORc2JaLaFIEY4v9hJv2ncW9NY7HhUkfsuWKqRCZYH9yAIllEuEQ62FpU tXGaPGKnWP40Luz1k46hfj6ueR/LEbt3E/T3WOTGh0XelM1wFi1mj81Ar4DX5Fl74C XkGa7OXUZPzoA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q6Pml13ykz6tn4; Thu, 27 Apr 2023 07:43:51 +0200 (CEST) From: Philip Kaludercic To: Daniel Mendler Subject: Re: bug#63103: 30.0.50; nconc compiler optimization breaks user packages In-Reply-To: (Daniel Mendler's message of "Thu, 27 Apr 2023 07:34:39 +0200") References: <877cty45rx.fsf@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Thu, 27 Apr 2023 05:44:24 +0000 Message-ID: <871qk5516v.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63103 Cc: 63103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Mendler writes: > The problem is that `(nconc list nil)` is optimized to `list`. However > improper lists like `(a b c . 0)` should be turned into `(a b c)`. Where is this behaviour documented? > Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 01:47:39 2023 Received: (at control) by debbugs.gnu.org; 27 Apr 2023 05:47:40 +0000 Received: from localhost ([127.0.0.1]:57405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pruTj-0007bo-Jr for submit@debbugs.gnu.org; Thu, 27 Apr 2023 01:47:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pruTh-0007b9-PS for control@debbugs.gnu.org; Thu, 27 Apr 2023 01:47:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pruTa-0008AM-QJ for control@debbugs.gnu.org; Thu, 27 Apr 2023 01:47:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BSWqc/cbEZXkrtijckfJ3J6NGdJEni1N2bouozHYqXo=; b=Oz9+p/mn8L4s W5q5MjtVbpKVv1CauzQutbVPYnJKEvTkj1AFQYMe1lDTHUOU+TP+PlNpaNA2Zsd297+zC8sEOwGr4 uioXt0ICuQltc7hVFHCxf6U21o3hzp5EN014MNqhWsNnYMix5cnG5PZLPnVouwhE1uWJQYF3jR6jl 14qS9YbGrmKOoxdNP/F+H4kyt5SMcb/I73BfpazUqccjsLXEXo1+BkFVrmSq6Lp3lCqR9oC3sFPjT ZzOgpayDj4LrN+w54OW74NM61iUdy5zQltoRy+JNhS62Or+pe60q8dVkufSGbUtQW6qYRQXEGqs15 Y8yJgOE/ABxQZvilCcbr9g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pruTZ-000743-5W for control@debbugs.gnu.org; Thu, 27 Apr 2023 01:47:30 -0400 Date: Thu, 27 Apr 2023 08:48:01 +0300 Message-Id: <835y9hub8u.fsf@gnu.org> From: Eli Zaretskii To: control@debbugs.gnu.org In-Reply-To: <87o7na8wly.fsf@gmail.com> (message from Maks on Wed, 26 Apr 2023 18:57:29 +0300) Subject: Re: bug#63101: 30.0.50; nconc compiler optimization breaks user packages References: <87o7na8wly.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 63101 63103 63100 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 02:37:48 2023 Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 06:37:48 +0000 Received: from localhost ([127.0.0.1]:57454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prvGG-0003A6-GI for submit@debbugs.gnu.org; Thu, 27 Apr 2023 02:37:48 -0400 Received: from server.qxqx.de ([178.63.65.180]:57529 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prvGD-00039o-DH for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 02:37:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=49K4bxdEGkJSkFQnlZS8Xj+HtP8sTi4QFzEF20qv6Ys=; b=Uctp8gOfdvhppDHw3uYGxi3BG6 XbSRepWulkZcNn2Pu4DI7ePIFdAvmXiODX1qMozvTdkJ4bGQZEyDvWj26yyiqi3euIlFn1N3aRO35 1DBdlYr2r4ME7a1rsdN8v2vVxAdkb05ksUi8mS1+wpFfNi+GI69SvE282HtQHKCeuhK8=; Message-ID: Date: Thu, 27 Apr 2023 08:37:36 +0200 MIME-Version: 1.0 Subject: Re: bug#63103: 30.0.50; nconc compiler optimization breaks user packages Content-Language: en-US To: Philip Kaludercic References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> From: Daniel Mendler In-Reply-To: <871qk5516v.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63103 Cc: mattiase@acm.org, Stefan Monnier , 63103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 4/27/23 07:44, Philip Kaludercic wrote: >> The problem is that `(nconc list nil)` is optimized to `list`. However >> improper lists like `(a b c . 0)` should be turned into `(a b c)`. > > Where is this behaviour documented? This behavior is not documented explicitly. However the docstring states that "Only the last argument is not altered, and need not be a list". Due to symmetry reasons it is not far-fetched to assume that when `nconc' can be used to turn a proper list into an improper list, that the inverse works too. Most of the docstrings do not specify functions on such a detailed and formal level. Maybe Stefan can give a bit more background regarding the support of improper list for Elisp functions. The main use case I've observed is for `completion-all-completions' which uses the last cdr to return the base position of the completion. Iirc `cl-loop' also handles improper lists. Generally I'd be wary about changing the semantics of functions since this leads to bugs which are hard to debug. One could decide to restrict `nconc' to proper lists only, not only via the bytecompiler optimization but also by erroring out if improper lists are passed as argument. Probably it is easier to explicitly allow the last nil argument in the bytecode optimizer specially to retain the existing behavior for improper lists. Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 05:47:25 2023 Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 09:47:25 +0000 Received: from localhost ([127.0.0.1]:57595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pryDk-0008VO-RV for submit@debbugs.gnu.org; Thu, 27 Apr 2023 05:47:25 -0400 Received: from mail229c50.megamailservers.eu ([91.136.10.239]:54572 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pryDi-0008VE-Lf for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 05:47:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1682588837; bh=sf4zJOf3YOdDzOovifpUuRJ31LssX6tjLloL+7PNhV4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=G4WhFv+eh3Jbhz61xuSnh6sPXc5K1HMCBLh+W4t2/Pe6PDBDS/zWKkBYVqEkyQ2Rs CnJP3UneFJizDfbNuAT6RAQxF94/I2CvxQRCZ5RRwXyuSifhvtfUJvs6B9QVqh4Wyk e4ONH1Gug5wAuuo5zltrSaVlhCkVxAKFbSexwXEs= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 33R9lEkS123048; Thu, 27 Apr 2023 09:47:16 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63103: 30.0.50; nconc compiler optimization breaks user packages From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Thu, 27 Apr 2023 11:47:13 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> To: Daniel Mendler X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduiedgvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepveekffdujefhkeehvdfgffeikefghfefvdekueffleegfeekueelhfejieefkefgnecukfhppedukeekrdduhedtrdduieehrddvfeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudekkedrudehtddrudeihedrvdefhedphhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpmhgrihhlfhhrohhmpehmrghtthhirghsvgesrggtmhdrohhrghdpnhgspghrtghpthhtohepgedprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvghnughlvghrrdguvgdprhgtphhtthhopehphhhilhhiphhksehpohhsthgvohdrnhgvthdprhgtphhtthhopeeifedutdefseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggr X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 63103 Cc: Philip Kaludercic , Stefan Monnier , 63103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 27 apr. 2023 kl. 08.37 skrev Daniel Mendler : > This behavior is not documented explicitly. However the docstring = states > that "Only the last argument is not altered, and need not be a list". Indeed. It's clear that this behaviour was never really intended, but = also that it was a natural consequence of most Lisp implementations. For = instance, Common Lisp specifies this behaviour but only did so after = errata. Although the utility of accepting dotted lists is very slight and = requiring proper list for all but the last argument would have made it = easier for us, this obviously needs to be a well-reasoned change if made = at all. I'll remove the troublesome compiler transform right away. > Due to symmetry reasons it is not far-fetched to assume that when > `nconc' can be used to turn a proper list into an improper list, that > the inverse works too. I don't think that's a valid assumption -- when the documentation says = that arguments are lists, then they should be proper lists. The = behaviour for improper lists needs to be specified explicitly, in = particular in this case when the function actually overwrites arbitrary = information in the input, not just a terminating nil. Thank you very much for finding this bug! From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 06:42:29 2023 Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 10:42:29 +0000 Received: from localhost ([127.0.0.1]:57654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prz53-0001lS-1M for submit@debbugs.gnu.org; Thu, 27 Apr 2023 06:42:29 -0400 Received: from server.qxqx.de ([178.63.65.180]:35519 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prz50-0001lE-6r for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 06:42:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fASm2ba/g7QmSjGWfZyABSn1EUVh7fWAOAms6ECAT4Y=; b=ay28GqiFgjN54MBZlzVabDwxKD B0dUa/EOsV9gZPTSUSD7ybI5aEYCRzxl7mH/f6TQd+ActVzecfrLAnDa4TV33BsqADkA6Azf1CDrP dtpZXpEgl9hgIx0qbc1RexMsCRQt9RcZc7AkY+EYXtzd7Q2yr+Tp3cS5HjXE4G4llEGQ=; Message-ID: <679f4102-4e3f-656f-18d9-4a3cc68ce595@daniel-mendler.de> Date: Thu, 27 Apr 2023 12:42:17 +0200 MIME-Version: 1.0 Subject: Re: bug#63103: 30.0.50; nconc compiler optimization breaks user packages To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> Content-Language: en-US From: Daniel Mendler In-Reply-To: <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63103 Cc: Philip Kaludercic , Stefan Monnier , 63103@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 4/27/23 11:47, Mattias Engdegård wrote: > Although the utility of accepting dotted lists is very slight and requiring proper list for all but the last argument would have made it easier for us, this obviously needs to be a well-reasoned change if made at all. I'll remove the troublesome compiler transform right away. Thanks for fixing the issue! I agree that improper lists are of limited utility. It wasn't the best idea to use them for the `completion-all-completions' API since this makes manipulation of the result for API users less convenient from my experience. >> Due to symmetry reasons it is not far-fetched to assume that when >> `nconc' can be used to turn a proper list into an improper list, that >> the inverse works too. > > I don't think that's a valid assumption -- when the documentation says that arguments are lists, then they should be proper lists. The behaviour for improper lists needs to be specified explicitly, in particular in this case when the function actually overwrites arbitrary information in the input, not just a terminating nil. Well, my assumption didn't completely stand on its own. Given that the last argument can be a non-list suggests that the last argument is not inspected or mutated, but just overwrites the cdr of the second to last argument. This then implies that the second to last argument could also be an improper list. Given that CL and Elisp have behaved like this for a long time, it seems better to preserve this property. I think it is kind of nice that `nconc' can be used as a tool to turn a proper list into an improper list and vice versa. It may be good to document this in the `nconc' docstring and the Elisp manual. Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 08:29:09 2023 Received: (at 63103-done) by debbugs.gnu.org; 27 Apr 2023 12:29:09 +0000 Received: from localhost ([127.0.0.1]:57703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps0kH-0007IG-Dl for submit@debbugs.gnu.org; Thu, 27 Apr 2023 08:29:09 -0400 Received: from mail70c50.megamailservers.eu ([91.136.10.80]:42066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps0kE-0007I6-Fv for 63103-done@debbugs.gnu.org; Thu, 27 Apr 2023 08:29:07 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1682598541; bh=dtvntlcq80k85ufkjyh2yYQcL1mrUWkyL8e8sBJODyg=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=RBAGx6w4sG2+mnutHk5n85MYG5qiIKo4Ph5xOPwRfTS4jSPqQXZd/M7gY+tZBLkX4 AsC2DYxOptJL0muzWXBw063tIa3MWsEwe7kfx6aCz6VIT1o3wSFsv6jTxL0h6IgXCV KxD56z4Kekefut1o1YX70Aeq6BzKzzNlrhQS/G70= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 33RCSwC6001684; Thu, 27 Apr 2023 12:29:00 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63103: 30.0.50; nconc compiler optimization breaks user packages From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <679f4102-4e3f-656f-18d9-4a3cc68ce595@daniel-mendler.de> Date: Thu, 27 Apr 2023 14:28:58 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> <679f4102-4e3f-656f-18d9-4a3cc68ce595@daniel-mendler.de> To: Daniel Mendler X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduiedghedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepveekffdujefhkeehvdfgffeikefghfefvdekueffleegfeekueelhfejieefkefgnecukfhppedukeekrdduhedtrdduieehrddvfeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudekkedrudehtddrudeihedrvdefhedphhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpmhgrihhlfhhrohhmpehmrghtthhirghsvgesrggtmhdrohhrghdpnhgspghrtghpthhtohepgedprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvghnughlvghrrdguvgdprhgtphhtthhopehphhhilhhiphhksehpohhsthgvohdrnhgvthdprhgtphhtthhopeeifedutdefqdguohhnvgesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehmohhnnhhivghrsehirhhordhumhhonhhtrhgvrghlrdgtrg X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 63103-done Cc: Philip Kaludercic , Stefan Monnier , 63103-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 27 apr. 2023 kl. 12.42 skrev Daniel Mendler : > I think it is > kind of nice that `nconc' can be used as a tool to turn a proper list > into an improper list and vice versa. It's a bit obscure, though -- (setcdr (last X) nil) is a lot clearer than (nconc X nil) and when the latter is preferred for performance, a comment might be = polite to the reader. Anyway, a fix has been pushed to master, and the manual entry for = `nconc` got an extra example. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 08:55:13 2023 Received: (at 63103-done) by debbugs.gnu.org; 27 Apr 2023 12:55:13 +0000 Received: from localhost ([127.0.0.1]:57726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps19V-00086Q-6V for submit@debbugs.gnu.org; Thu, 27 Apr 2023 08:55:13 -0400 Received: from server.qxqx.de ([178.63.65.180]:40305 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps19T-00085I-4J for 63103-done@debbugs.gnu.org; Thu, 27 Apr 2023 08:55:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FuvncDiBYchlayF349oxaxP3064CPz4jZ4baDS5Oa1Y=; b=seMjLyHDAFjkLKIEgC3k88PHON eOekQ1ILaHKXG2zLK9RTWgIIx8TSHyMTMBK1DO8cDS6Se3T0iuIIdTk1XFfzm9bA7Stfcrv0OoDEb acm7eO4Bs2SNnamqiDfefbTWk7+piqG8SH5gpd4oRhVBjygY1KVh9k9+Z7TnPMuy830g=; Message-ID: Date: Thu, 27 Apr 2023 14:55:00 +0200 MIME-Version: 1.0 Subject: Re: bug#63103: 30.0.50; nconc compiler optimization breaks user packages To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> <679f4102-4e3f-656f-18d9-4a3cc68ce595@daniel-mendler.de> Content-Language: en-US From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63103-done Cc: Philip Kaludercic , Stefan Monnier , 63103-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 4/27/23 14:28, Mattias Engdegård wrote: > 27 apr. 2023 kl. 12.42 skrev Daniel Mendler : > >> I think it is >> kind of nice that `nconc' can be used as a tool to turn a proper list >> into an improper list and vice versa. > > It's a bit obscure, though -- Probably. I am not sure if I came up with this pattern independently. It is likely that I've seen it in some other packages. So it is good that this is fixed. > (setcdr (last X) nil) > > is a lot clearer than > > (nconc X nil) > > and when the latter is preferred for performance, a comment might be polite to the reader. The problem is that `setcdr' of `last' is not correct for the empty list. The two lines are not equivalent. > Anyway, a fix has been pushed to master, and the manual entry for `nconc` got an extra example. Thanks. Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 09:33:08 2023 Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 13:33:08 +0000 Received: from localhost ([127.0.0.1]:57964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps1kC-0003MG-0e for submit@debbugs.gnu.org; Thu, 27 Apr 2023 09:33:08 -0400 Received: from mail-ej1-f42.google.com ([209.85.218.42]:59866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps1kA-0003Lo-2N for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 09:33:07 -0400 Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-956ff2399c9so1518161966b.3 for <63103@debbugs.gnu.org>; Thu, 27 Apr 2023 06:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682602380; x=1685194380; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=wwZw//4Vfw5LrSNyLLUohBxOJltlfuvX8/DX9QX2Y8U=; b=WivmbgTwD+6iilb+f6lT2Q0MTHbuDNQ+58mQJnD+FJNWHkuozzzpmsb015HBUmN+mj HXc5mSpGWp7zh0tlnbeavbSCR/dGw87U+N0j08c0V+hWJsuG/l4NPTeoMBWosjXZhD80 CRlrehvlN/5DTeu5ygTfDnZq2JsyyXfWLuvXjU/SvhisoTwc2KB3rV3LJxooyy6losYz ULo3kqTczFpMlWts0s5fpe7QiniI2M+xUlqAzA3F3L4pj5MLM8JMlg41TdS3l7hRtjBP pcvDeREIt8DER0aTwWaC2KdyqwNbO5CafG5THPfYfRkEXn++HpQeu+SqvRZkAk6p2VjL LU5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682602380; x=1685194380; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wwZw//4Vfw5LrSNyLLUohBxOJltlfuvX8/DX9QX2Y8U=; b=NqFZOxEN2SAHvzs+rgxKou8Mt86r9Huwe1XlTHaPRrJQRbGx4gAoVc0aDFyWUcisBh RxOGHMaHYb+ApyR6lxjoOLMBUPEhx/V9xdXoqZCC51iSEOdkl/TyxUSzA2r4gJwe59A7 nuV7SqtKAAep+voE4J+OJzXkV0g/vpMQYUrnKyqK1rNzl5iIPQYoatxGW2MS/LEOOMsM cJsqCY9fqws6/rwxaJQBXL2IHEM1MuC/Rp6wgBNgrAzxy4IHnKk47iVPU1qX/yt3E8Hx jTrDvRtOsOYnPUvdHu1I4M2BkphylnNePhvXKj3cXULq+lzykyP5MeZLglxrjMUVvcaL KGBQ== X-Gm-Message-State: AC+VfDwyzwCpaABbSMbu2XlntNCCflCbTcQcofyO7tNGoGLwHvZZ+IAB cnvczioUerDU7OI89V2E09+wYqkLrF0= X-Google-Smtp-Source: ACHHUZ5wF1UrRQggIQQ7JrXCatmkfPcE5LvifwPH1jVeoaTGRjI07Yh//cVehaEwsUFZUtPugMhPAA== X-Received: by 2002:a17:907:7b9b:b0:94f:3f92:c7b0 with SMTP id ne27-20020a1709077b9b00b0094f3f92c7b0mr1780759ejc.60.1682602379659; Thu, 27 Apr 2023 06:32:59 -0700 (PDT) Received: from pop-os (78-152-187-146.pool.ic.km.ua. [78.152.187.146]) by smtp.gmail.com with ESMTPSA id jx17-20020a170907761100b0094f698073e0sm9620182ejc.123.2023.04.27.06.32.59 for <63103@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 06:32:59 -0700 (PDT) From: Maks To: 63103@debbugs.gnu.org Subject: Re: bug#63103: 30.0.50; nconc compiler optimization breaks user packages Date: Thu, 27 Apr 2023 16:32:37 +0300 Message-ID: <87o7n9pi16.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63103 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the fix, it works! From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 09:55:12 2023 Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 13:55:12 +0000 Received: from localhost ([127.0.0.1]:57998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps25Y-0006Xk-24 for submit@debbugs.gnu.org; Thu, 27 Apr 2023 09:55:12 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:8354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps25T-0006Wx-N1 for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 09:55:11 -0400 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33RCO86l010212; Thu, 27 Apr 2023 13:54:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=WFF25dCRGCZbtdx/o355dB5sH0Wd7MIbjYPKxYyEXVg=; b=2UCVSzfJldKgr4KgMNmT1pK/EulbWzYKVPxs+M8s3Lqsp8m5lS6XhQnT77hnaCqhdvyi ViCrg29S9QivIkkmvc9x0sODOjfQMAUhfp1s4ZYuDgcGMKXlQpwCtGoO3uMAJ7LUjoxq 6IrE2V1YkE5o72rHFOSrjHXmiZTClAqbhEydPC/qCI4n1sD8MlU4KT1k7/4+NSKy4VsJ 5ZNr+WKB1yv9YlJppsiKzT0m8EMBuPprwohlcBlUFnewzK6k/+ivKz60UoLiL3WAesT6 yDCj3rGq9h2KsLGR+CW+yJVAhlEJp30NGoOXdhVM+e3XVjiylTCCr+b4445PB23X55Fl tA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3q46c4c2tp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Apr 2023 13:54:59 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33RDFQF0032787; Thu, 27 Apr 2023 13:54:58 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3q4619kvu6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Apr 2023 13:54:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fgrV56vuzizpQc4bfhsNASBH7myu16hettZfgsK9g19ykqXZ6AF662a9dd5Y+/pRR5Y1q7YQmqXLbTfjGS3YY7rxHSSNT/d9vLPQhg/2XVw5ruCy1GKSRSORB3v3BXY6PE4UG4vDpnLbW4/5ULyDOu+m+/QkpPIBHSFxoDQOsrqhINOYSxtsyQglfchdZ4rajnWpQa6l8heaIfcxDahyVfWz8y+rweGid5h+AI7SDpLyQl+lNxCtTUvILCd3Ol0X8TL54pgcGv3OZt960dx1nEQBDWjmV16rO4YJ5Zf1dnv36p8CaK5WpCHopQBntUfaHCqaEAWpxPZxp+LWIHWzDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WFF25dCRGCZbtdx/o355dB5sH0Wd7MIbjYPKxYyEXVg=; b=bNbRwb7OdVXqmcJ3O1P4sHzrDZdn16NBzsSRga4iBaO7+fklSBY7i/TEqDXeY4tudc+nKNxjTDE3KieAfLXzd/GL5hUX3lt5WceGl23uyRFwzTT97DZaXV+NxJ6VCDXEdYXo262xVhXkJgCZ5nqZQOwtx5jmTpiT2+SMJdA/C2+OH4VhNcS/lM42d9OkIsRZ59uKq3gOHh2XzOyC/nXW+Fkcs1M1cVIID94w3u9N/MVANLue8Gay4sQtO9gqga2/MjSsADUpty40naz4CB6JxftPxF8mAiG/62qpJcEYC2ITXw6/4cbRm7cj1BH3Kuc5CeCoxZSyAdalS4oZqyzZqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFF25dCRGCZbtdx/o355dB5sH0Wd7MIbjYPKxYyEXVg=; b=NaDn9k/gyzrtTxMr3wnWgrjKoCIkjINkWo2TZ5GtiO58owLJxD42o2ROjwAmUQs9Ab1hANECk+5lwQZoBau9z83a2YNOsQAZShy0zVRQClmq0Mg07mdIPAxaJi3Op39daC5NnefeCOMAZY5u+qu0RujQOKRszLLfXzkgtLxK4Vs= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SA1PR10MB6296.namprd10.prod.outlook.com (2603:10b6:806:253::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Thu, 27 Apr 2023 13:54:55 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::a995:2ae5:2745:24ff]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::a995:2ae5:2745:24ff%5]) with mapi id 15.20.6340.021; Thu, 27 Apr 2023 13:54:55 +0000 From: Drew Adams To: Daniel Mendler , =?utf-8?B?TWF0dGlhcyBFbmdkZWfDpXJk?= Subject: RE: [External] : bug#63103: 30.0.50; nconc compiler optimization breaks user packages Thread-Topic: [External] : bug#63103: 30.0.50; nconc compiler optimization breaks user packages Thread-Index: AQHZePUbMJ+7X2kVFUqSUp4orNSnWa8/KSXg Date: Thu, 27 Apr 2023 13:54:55 +0000 Message-ID: References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> <679f4102-4e3f-656f-18d9-4a3cc68ce595@daniel-mendler.de> In-Reply-To: <679f4102-4e3f-656f-18d9-4a3cc68ce595@daniel-mendler.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|SA1PR10MB6296:EE_ x-ms-office365-filtering-correlation-id: 54f5e1ff-84a0-4d35-5c73-08db4726fb8d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FxwICPyU3kJTF+VFWHsEr1ZPl+1sxUaVWdsVIcCpKgO+rHMEMY1M5OpA4wVleuIxETPgbO/sYyINbI8xbw2Q8JwUUL6baYPkHA6Oe3wZsM53KiIAHlM1DPumLpnDBhZ/Fxsv8glmUisZfnAsgzN8fybVGlLnSylvR2oVQmIGmqj0hE2IHQsrUOA55DapfWArxGu1ejwQqOBWUAzkMi2JoiQAuZ9jT+lXLee6EjaPpJrDnah8WyqP7e+MgQQwe+mB37efc3e2n/UvBFTx1/mVKFEBH90UjJHW3yxzC2rReUVWAtjkv5vTyeI1Lux1aIBHpnYPLGjnfgWx5U9/ZLRqd3lTCdNOvbYYflFsoew4CFvfd869jbDeUMB/Ce1CDdRa4xx0s9Tn8xDCEmoMF63EB2gky6rumCn5pbfEuQMk3GDmmjnmj4z/gRbZhdaR36i2RxKpxAUyzFboHktiGElZapTeXipTm/Z7I29N+7uGAZXX/22fHaRCtQp8RDAsgUgBc4Lsf5Uyfu1DA59RFIN0Senno05waDDAUg2bKVTvO9RzIzMuL6JB74Dn3ZYKcs5Ilg48PjjfdP/UOSTChWOlmGFC8kpA6W1sH6tn/5LrPwdlKpOn5CbWIpxfQAamvuX/ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199021)(478600001)(110136005)(54906003)(52536014)(5660300002)(8936002)(8676002)(38070700005)(2906002)(33656002)(86362001)(44832011)(4326008)(55016003)(76116006)(64756008)(66946007)(316002)(66446008)(66556008)(66476007)(41300700001)(38100700002)(9686003)(6506007)(26005)(186003)(122000001)(83380400001)(71200400001)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UXArdThmYld3U2VTOGVCTUNLa3BUMUxadG8zM05tdjFLV1lrUFdaQnNzK0R4?= =?utf-8?B?a2hlQnhTTHltWkdIZDYyOHo3aHpOUENUU2U1N3paWE9jOXpTOUtvTTA3WHli?= =?utf-8?B?VEh0MHQydnJVTE5zR0wzdkZaeXFSeWYvYUdHYkxFa05Icm9Ha1JzRmZvWXdj?= =?utf-8?B?T3lYSzFadE5MTm1hVjVTRS9NWEtjVDliNjBiSUJRTEFYVDNnMjVKamYxV2sr?= =?utf-8?B?MGU5bm1VN1hBVkJSTnV3bENQUXFYN2JncTJMV0dtSks3ejd5QkpsY0pxaWhi?= =?utf-8?B?U1BiQ1h0UHlqaFRBcWdaZElicjJhcU1TbkZUeWJRWFJFd3NCcVZvc2RNNi9D?= =?utf-8?B?QTZDRVl6ZWgvN2lobmc0TElTVWpyY1ZuNU43ZzdJYUNXbTlSZDlGOWpvckxq?= =?utf-8?B?VWY3cHJvMUxpczM5VkducWZkOUpRTnV1NFlXaC8wRDRGdTVwZk1uTi92TlVt?= =?utf-8?B?OTVyeFlJQ3VRT1UrTDZDdUhmbDZaYk1SaUtkT0gzeXhOOVV2RUx6dVY2VHJO?= =?utf-8?B?UmpURGRzcXVHS0Z4UWtzQ1J2WEMxKzh6NXdKUlVyWDhqWStwanFlT1F4VC9z?= =?utf-8?B?c2pNM3YvOGRRWVhEKzZhT2tHRkZydVcveTJSSlVaSm9YU3BmVjBkckNNOUdS?= =?utf-8?B?amVKUmUrME42clFDeExnRUh1MEVYUGUyZC9iSkVSWFY2d1RRTXRtcXR2UTha?= =?utf-8?B?ZjZEL05EZm9CLytWRmRMa25FSE5RSFB1QlkzUlFkUHZyck94T2JUK2tvNFgy?= =?utf-8?B?SGt1UGpvc1cwbEpsd0M2ZXNWRHlDMkJvNjJYVU5BNDdCQ1lic3dHU3g0b0tO?= =?utf-8?B?d3VxVE5XUFZOcHBGNlFFc2RkZm1lQzZ0RTFZTUNqN0o1bCthelB1Z2hJRFFK?= =?utf-8?B?MXJTaGNURkYySCtvWjlHZ29NZ0tTSlhzbnRZYUcrY3BaVEFYOVhIMG5mSmR1?= =?utf-8?B?cnJudmZTVHdYNGRhS1NQanVOcUxQZ29Md3Zid0RGTTAxS0p4V2RSMHN0S1Zr?= =?utf-8?B?Y1N6ZWt2WUt4a28wbjRPWVVRd3VSK0RPckR4K0x4NDNkNCtCQjViK1JvYzRJ?= =?utf-8?B?YVJ5LzhBZWdNUDZ1bWNyRVY5WS9YNWd3OTVESVlIRVNpeHpzWEgwQWMrZ00z?= =?utf-8?B?dmVZbXB6N29RV29EbHhxU3NPM3Jyb1VHUE1CQW1qYVRqdlhxUEUxZitROVcy?= =?utf-8?B?dHdYbVIwckdlU0gySndrenFYZGVpdVYreGF1a3hEaWdnRE5zN21VbTlKU3BW?= =?utf-8?B?cEJmdXhub0FYY2NaSlJaRndEVEI1ZS9CR0NNK1JwMUNRNTlxcEtuU2M4UGZV?= =?utf-8?B?VHJYbGt0NkRRTGtCS1p2K0dUNXpIZU9jcU12a2VxdnlqNlF1YnZ4N2FLM0Z5?= =?utf-8?B?dWhlVGtnT003NFZ3WklteHhpL0hkaGpNZW5XcVk4elZNelJObnE0a3NPcHhK?= =?utf-8?B?S1gxR1p1YnRuTnIvTTQzOGVEVWtsWkd5TWlnWjY4allsTWtDdy85UUtvNmdl?= =?utf-8?B?VCtjbjFhNjhjb1FTbDNMS1R0bFptVXRpQnZScXU4T1ljQUsxT2tpZ3NVaW9M?= =?utf-8?B?UmNGcmFpOHI4aDhKQjBTZHQrbm12cVVlVkNRZ3AvOHE0b0ZMZU9lNEVhanNU?= =?utf-8?B?TXE2OG05aVVrK2QxS2xTSFVlVXEvb2g0d3BBZVU2NEF6M1M3SGxxYkJEaHhs?= =?utf-8?B?NGhvRkNKOG4vNTNKL2hUTCsxTXlrMTV3NHhPUlRLTzFieUN3TFcwWDJzUWNB?= =?utf-8?B?R01uWndMWDFBdXRTRWxIL2JHMmY2RkFNS09Cb21nZWU3eG9jeEpjdXpDeC90?= =?utf-8?B?ODBHQ3JVNTBIZjBDM0pxNFpiaHh4SGdPNUtiZUdYUnV4TFJjL0FJcXNkSUhi?= =?utf-8?B?OHNSOTFpT2ZRVjNONFFOUXJCZGpkSFRSWmQ3V2dZT29OZWZua2RRT0lvTGYx?= =?utf-8?B?RHc3TzhxUzVySW05eTVhdThrUUxmTDhzTUVZQUhyakxhd2laT1VMWk8yZDFi?= =?utf-8?B?WTgwSWFvNzd0dnhWM1R4WXQ0UEZIYUNjbDdpVFRlcC9HY21oUVY2S2lyLzR3?= =?utf-8?B?L0tKL1B6ZmNFSEZhU3pLWjQvZW1BVVVIUlpORHIyV3pTQ2gycjhXWVdUKzl5?= =?utf-8?Q?oZ9H+O8jjRnEC5m1nVnGe6sQs?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Yo8nBddKfy3gMnxP7QpP9HRVntqPiaKMoUymM3XvHiySUMrplXriZnHr7TUAY1tSA0oKpoSDzcA3caMdWal5FApXla9iPC6ebuILJi4sz52hB0KjEuaugXA0DKE7OhfF0pXPWLdaZjlx0UMxRjTs7kTJlyNCXzTW9TQW/IyVDzkJCJpmhVxdNEkBIaEtDEmTlzLDnzW/bKJwMvLoT+CKE9x+KFF7dlDK+4iDvD2LL3OzC5BHaKO0yswWDOIFJlWYzrPl3YrK3ndpKrU2tl8OWx8smdvNPqVzwxLy6t7qTrHmnf655OeD05ypDX2Ne9g++Za8cAOlQk2zfGPjaVPHL3rvV+HmOX6zekX56K2vy1IHucUArdtyF3fEH+pc/HljJczMrBryHhMesNr+nuX9E52jsfwpewSLuUJmuiMIusyh6fNhkhWm4UkLk/2Nm4CaQdHRc5HZJiq6ep88B+upMmRWFh2E9EWJ8Qo5zyHSEgAfyzt8LX86mbk2tB/J16O3l1QWQNSTS/RKa6gqpasWh5cQz5Cw9Klv0c2hjX3Ejjil/NqdYk2Du6ydCPK4j7r1QokKRcbLsIC+DTzFKXDGdDR9odI36Vz10btq4x9+vFaHMDjRUdF8v8la70vpgMxxbmVXJM7wBFdFRUuYguVX9jHHm5hLLXe49CGeGWi8F8P3ibH7kcryf7L3KQQ3NP+LBUiuXn/afWsDDZvAxAVBsaV7Vek99q5X3ExIsES8yOqcqWFsApBAa2WrnUFT9Pa16QuYCE8U0xqIzqc1/3IyOy83t9nQp4o8TGfca1Jx+TQSVTZPgKYaKNirUFsPZOQx8MOwW/41+/SPL0oxWFGsf6irPm4nn0pzWLD6MYBl5t5s+SW8YGopaHFYzKx2YyDbmpeiniYMYyo1N1z1JygO4Q== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54f5e1ff-84a0-4d35-5c73-08db4726fb8d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 13:54:55.7117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pKLWUIYBIiSHqxJ9aTEuQC8oPxPM1g6CHC7KLxcLEYTfYTbdZU1Db3/nTaHWTQuAvdNAC2/C6WSvWOOCyjsBwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6296 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-27_07,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304270123 X-Proofpoint-GUID: AZ8iffiMHNni0mYPLXBgdc_OGFa3pjEC X-Proofpoint-ORIG-GUID: AZ8iffiMHNni0mYPLXBgdc_OGFa3pjEC X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 63103 Cc: Philip Kaludercic , Stefan Monnier , "63103@debbugs.gnu.org" <63103@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiBUaGUgYmVoYXZpb3VyDQo+IGZvciBpbXByb3BlciBsaXN0cyBuZWVkcyB0byBiZSBzcGVjaWZp ZWQgZXhwbGljaXRseSwgaW4gcGFydGljdWxhciBpbg0KPiB0aGlzIGNhc2Ugd2hlbiB0aGUgZnVu Y3Rpb24gYWN0dWFsbHkgb3ZlcndyaXRlcyBhcmJpdHJhcnkgaW5mb3JtYXRpb24gaW4NCj4gdGhl IGlucHV0LCBub3QganVzdCBhIHRlcm1pbmF0aW5nIG5pbC4NCg0KWWVzLCB0aGUgdXNlIG9mIGEg ZG90dGVkIGxpc3QgKGEgdGVybSB0aGF0J3MgY2xlYXJlcg0KYW5kIG1vcmUgc3ltcGF0aGV0aWMg dGhhbiAiaW1wcm9wZXIgbGlzdCIpIGZvciBhbGwNCmJ1dCB0aGUgbGFzdCBhcmcgbmVlZHMgdG8g YmUgZG9jdW1lbnRlZC4NCg0KKE5vdGU6ICpBTEwqIGJ1dCB0aGUgbGFzdC4pDQoNCj4gV2VsbCwg bXkgYXNzdW1wdGlvbiBkaWRuJ3QgY29tcGxldGVseSBzdGFuZCBvbiBpdHMgb3duLiBHaXZlbiB0 aGF0IHRoZQ0KPiBsYXN0IGFyZ3VtZW50IGNhbiBiZSBhIG5vbi1saXN0IHN1Z2dlc3RzIHRoYXQg dGhlIGxhc3QgYXJndW1lbnQgaXMgbm90DQo+IGluc3BlY3RlZCBvciBtdXRhdGVkLCBidXQganVz dCBvdmVyd3JpdGVzIHRoZSBjZHIgb2YgdGhlIHNlY29uZCB0byBsYXN0DQo+IGFyZ3VtZW50LiBU aGlzIHRoZW4gaW1wbGllcyB0aGF0IHRoZSBzZWNvbmQgdG8gbGFzdCBhcmd1bWVudCBjb3VsZCBh bHNvDQo+IGJlIGFuIGltcHJvcGVyIGxpc3QuIEdpdmVuIHRoYXQgQ0wgYW5kIEVsaXNwIGhhdmUg YmVoYXZlZCBsaWtlIHRoaXMgZm9yDQo+IGEgbG9uZyB0aW1lLCBpdCBzZWVtcyBiZXR0ZXIgdG8g cHJlc2VydmUgdGhpcyBwcm9wZXJ0eS4gSSB0aGluayBpdCBpcw0KPiBraW5kIG9mIG5pY2UgdGhh dCBgbmNvbmMnIGNhbiBiZSB1c2VkIGFzIGEgdG9vbCB0byB0dXJuIGEgcHJvcGVyIGxpc3QNCj4g aW50byBhbiBpbXByb3BlciBsaXN0IGFuZCB2aWNlIHZlcnNhLiBJdCBtYXkgYmUgZ29vZCB0byBk b2N1bWVudCB0aGlzIGluDQo+IHRoZSBgbmNvbmMnIGRvY3N0cmluZyBhbmQgdGhlIEVsaXNwIG1h bnVhbC4NCg0KKzEuDQoNCllvdSBib3RoIGFncmVlIHRoYXQgdGhpcyBiZWhhdmlvciAoMSkgc2hv dWxkbid0IGJlDQpsb3N0IGFuZCAoMikgc2hvdWxkIGJlIGRvY3VtZW50ZWQuICBUaGF0J3MgZXhh Y3RseQ0KdGhlIHBvc2l0aW9uIHRha2VuIGJ5IENvbW1vbiBMaXNwLg0KDQpQbGVhc2UgZG9jdW1l bnQgdGhpcyBiZWhhdmlvciBhcyBwYXJ0IG9mIHRoZSBidWcNCmZpeCwgaWYgeW91IGhhdmVuJ3Qg YWxyZWFkeS4NCg== From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 10:02:37 2023 Received: (at 63103) by debbugs.gnu.org; 27 Apr 2023 14:02:37 +0000 Received: from localhost ([127.0.0.1]:59439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps2Cj-00077z-2R for submit@debbugs.gnu.org; Thu, 27 Apr 2023 10:02:37 -0400 Received: from server.qxqx.de ([178.63.65.180]:33049 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps2Cf-00077g-0P for 63103@debbugs.gnu.org; Thu, 27 Apr 2023 10:02:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6nCO0fvbfj1r1szrKq90ULOfZEz3y6D3DFUJ7mWSAac=; b=zXMwy/Nc6vONY+/wSp2ykQQUnx IfmD6ZuPXH+xsL+9M85tHmQG2rws7yJZV8oYLWJA0onyw/2OHQWQBmpQ3FWxfB5hEIMqVAy8MhKEE ddt41H2L+hMS2IrtKTus+1s/Med67zTdWD704Wf7Y+AT/YU9HkG8eflbL7zNlGgTikHc=; Message-ID: <00a455d5-8c78-7d5d-0239-849bd4f60098@daniel-mendler.de> Date: Thu, 27 Apr 2023 16:02:22 +0200 MIME-Version: 1.0 Subject: Re: [External] : bug#63103: 30.0.50; nconc compiler optimization breaks user packages To: Drew Adams , =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> <679f4102-4e3f-656f-18d9-4a3cc68ce595@daniel-mendler.de> Content-Language: en-US From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63103 Cc: Philip Kaludercic , Stefan Monnier , "63103@debbugs.gnu.org" <63103@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 4/27/23 15:54, Drew Adams wrote: >> Well, my assumption didn't completely stand on its own. Given that the >> last argument can be a non-list suggests that the last argument is not >> inspected or mutated, but just overwrites the cdr of the second to last >> argument. This then implies that the second to last argument could also >> be an improper list. Given that CL and Elisp have behaved like this for >> a long time, it seems better to preserve this property. I think it is >> kind of nice that `nconc' can be used as a tool to turn a proper list >> into an improper list and vice versa. It may be good to document this in >> the `nconc' docstring and the Elisp manual. > > +1. > > You both agree that this behavior (1) shouldn't be > lost and (2) should be documented. That's exactly > the position taken by Common Lisp. > > Please document this behavior as part of the bug > fix, if you haven't already. Mattias already documented the behavior for dotted lists in the Elisp manual and added a regression test. See commit 5ead8c5f69b0a69bac4641d5003ee422d6b67038. Daniel From unknown Tue Aug 19 06:31:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 26 May 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator