From unknown Tue Aug 19 11:03:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63100: 30.0.50; nconc compiler optimization breaks user packages Resent-From: Maks Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Apr 2023 04:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63100 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 63100@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168256898218526 (code B ref -1); Thu, 27 Apr 2023 04:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Apr 2023 04:16:22 +0000 Received: from localhost ([127.0.0.1]:57309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prt3L-0004od-9z for submit@debbugs.gnu.org; Thu, 27 Apr 2023 00:16:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:40222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prhDQ-0007R5-OI for submit@debbugs.gnu.org; Wed, 26 Apr 2023 11:37:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prhDO-0003U9-UD for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2023 11:37:55 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prhDN-0005fT-AM for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2023 11:37:54 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-95f4c5cb755so121900366b.0 for ; Wed, 26 Apr 2023 08:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682523471; x=1685115471; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=82vT6fp+WzG7VVHratAI1bouRE2/La9zxLtYiZkA5CE=; b=GTIoxetWyniYdfT/vT3TrsQCVWg/LguesGzzoMHW03EBEec45KXtj4ZYKSTEzFhO2a 0bT8TUWMLT7EHmVKSkEKS2MkWDZzUJ7P8sedXi5GH6EK0O7tRsyb9ej9kwD1QsaqjL1k JYVgargpbLdWIB8EanzOubIlzQh4gfBPf3ln0ygJ3SA/prJRQ/kGR6gSEHjnB5Ne5GMB GdTA7VdPe7/Oaaelb2wf5Rqbc7O8kx0PJDMYEQ3WgocP1tgPCAViBGQjR/01ocwPBXOd DaR3p/3FM+oRjAq4ASd4xLSivdBxFwWe0jUC77kZ1OtL5GcaMnsZ1b2M6kGRn/CLdF5x fF1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682523471; x=1685115471; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=82vT6fp+WzG7VVHratAI1bouRE2/La9zxLtYiZkA5CE=; b=MWixU/HV9wQhpze+3LHE3YENo2zefCvqxt/cvdSHnXWPCtWnEXoWYmoZmXB9vr9K/y ghJ+JS4fHNm3gQqFzxVJr/WPH9QS9o3suK2Fc9s+9AMoZUPfPQm7UPM1j4g8NvXaGYOi KCL2UoOmQqImyNO/aDQIH4C3zttKtIWxJWaQl+Ks1w4PiM8soHX4t8Pz6Wu6A1wFVrAc Ct+iuGss5V8YPmPI3gMc90WmqjaKJTEOBghsjARLlNtMMPOT34fF/J7Nmp9VUp9vbJbU JKltsMAAfG/4rc+SPAGGukFbCwBg0qSE+CCZ0XsQbfXshVg2jUs+KPjFs4TmNiPkRIF8 lxbw== X-Gm-Message-State: AAQBX9fcHXV72N3sTD/9InzTwc1cgnrRKtVpoACQSvBcH5cTTE0diuN3 fdczdGZY577G+n6LN8806xAFr+k7GyM= X-Google-Smtp-Source: AKy350aII6IeP0k8iRbbnkxs95ts55Vr2BqXL0/GuYlG3YzxGpdQobKXYgBRoL4SDdT9nV+gu4s17A== X-Received: by 2002:a17:906:52cc:b0:94a:658e:1180 with SMTP id w12-20020a17090652cc00b0094a658e1180mr14830958ejn.26.1682523471286; Wed, 26 Apr 2023 08:37:51 -0700 (PDT) Received: from pop-os (78-152-187-146.pool.ic.km.ua. [78.152.187.146]) by smtp.gmail.com with ESMTPSA id la5-20020a170906ad8500b0094e877ec197sm8535319ejb.148.2023.04.26.08.37.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 08:37:51 -0700 (PDT) From: Maks Date: Wed, 26 Apr 2023 18:37:42 +0300 Message-ID: <87pm7q8xix.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=mvproton@gmail.com; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Thu, 27 Apr 2023 00:16:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, after long debugging time I figured out that commit e6ca5834a6eab91023e9f968b65683d0a74db1e7 ('Improved nconc and append compiler optimisations') breaks package vertico.el. I'm not completely understanding how it works but try to describe the problem. If I set breakpoint before breaking commit I get the following stacktrace: ``` Debugger entered--entering a function: * vertico--affixate((#("report-emacs-bug" 0 1 (face (completions-first-difference))) #("cd" 0 1 (face (completions-first-difference))) #("5x5" 0 1 (face (completions-first-difference))) #("arp" 0 1 (face (completions-first-difference))) #("dbx" 0 1 (face (completions-first-difference))) #("dig" 0 1 (face (completions-first-difference))) #("erc" 0 1 (face (completions-first-difference))) #("ert" 0 1 (face (completions-first-difference))) #("eww" 0 1 (face (completions-first-difference))) #("ftp" 0 1 (face (completions-first-difference))))) vertico--arrange-candidates() vertico--exhibit() ``` , but after breaking commit I get slightly different stacktrace: ``` Debugger entered--entering a function: * vertico--affixate((#("report-emacs-bug" 0 1 (face (completions-first-difference))) #("cd" 0 1 (face (completions-first-difference))) #("5x5" 0 1 (face (completions-first-difference))) #("arp" 0 1 (face (completions-first-difference))) #("dbx" 0 1 (face (completions-first-difference))) #("dig" 0 1 (face (completions-first-difference))) #("erc" 0 1 (face (completions-first-difference))) #("ert" 0 1 (face (completions-first-difference))) #("eww" 0 1 (face (completions-first-difference))) #("ftp" 0 1 (face (completions-first-difference))) . 0)) vertico--arrange-candidates() vertico--exhibit() ``` As you can see, the difference is in the tail of the input list. This list comes from completion-hilit-commonality function from minibuffer.el and it has nconc call. But testing completion-hilit-commonality in REPL separetely from vertico.el package give the same result (with 0 at the end of list). Before sending this report I have tried a lot of versions of the vertico.el package and have the same result. So I tend to think that problem is not directly related to package. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 01:47:39 2023 Received: (at control) by debbugs.gnu.org; 27 Apr 2023 05:47:40 +0000 Received: from localhost ([127.0.0.1]:57405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pruTj-0007bo-Jr for submit@debbugs.gnu.org; Thu, 27 Apr 2023 01:47:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pruTh-0007b9-PS for control@debbugs.gnu.org; Thu, 27 Apr 2023 01:47:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pruTa-0008AM-QJ for control@debbugs.gnu.org; Thu, 27 Apr 2023 01:47:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BSWqc/cbEZXkrtijckfJ3J6NGdJEni1N2bouozHYqXo=; b=Oz9+p/mn8L4s W5q5MjtVbpKVv1CauzQutbVPYnJKEvTkj1AFQYMe1lDTHUOU+TP+PlNpaNA2Zsd297+zC8sEOwGr4 uioXt0ICuQltc7hVFHCxf6U21o3hzp5EN014MNqhWsNnYMix5cnG5PZLPnVouwhE1uWJQYF3jR6jl 14qS9YbGrmKOoxdNP/F+H4kyt5SMcb/I73BfpazUqccjsLXEXo1+BkFVrmSq6Lp3lCqR9oC3sFPjT ZzOgpayDj4LrN+w54OW74NM61iUdy5zQltoRy+JNhS62Or+pe60q8dVkufSGbUtQW6qYRQXEGqs15 Y8yJgOE/ABxQZvilCcbr9g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pruTZ-000743-5W for control@debbugs.gnu.org; Thu, 27 Apr 2023 01:47:30 -0400 Date: Thu, 27 Apr 2023 08:48:01 +0300 Message-Id: <835y9hub8u.fsf@gnu.org> From: Eli Zaretskii To: control@debbugs.gnu.org In-Reply-To: <87o7na8wly.fsf@gmail.com> (message from Maks on Wed, 26 Apr 2023 18:57:29 +0300) Subject: Re: bug#63101: 30.0.50; nconc compiler optimization breaks user packages References: <87o7na8wly.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 63101 63103 63100 thanks