GNU bug report logs - #63098
[PATCH] gnu: guitarix: Update to 0.44.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63098 in the body.
You can then email your comments to 63098 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Felix Lechner <felix.lechner <at> lease-up.com>
Cc: guix-devel <at> gnu.org, Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: guitarix: Update to 0.44.1.
Date: Wed, 26 Apr 2023 22:28:34 +0000

[Message part 1 (text/plain, inline)]

Hi Felix,

On Wed, Apr 26, 2023 at 02:57 PM, Felix Lechner via \"Development of
GNU Guix and the GNU System distribution.\" wrote:

> Hi,
>
> With a recent checkout of Guix, guitarix fails to build from source.
> It may be a Python issue. A pertinent excerpt of the log is below.
>
> Without a patch ready, I wasn't sure where and how to file this report. Thanks!
>

The usual bug-guix <at> gnu.org list will do just fine I would say.

In any event, I'm cc'ing the patch list with a quick patch that
updates the package which builds fine for me locally; I didn't test
running it though. I also updated to gexps and removed the
native-inputs label. Since this was an update and the package
currently doesn't build, I put it as one patch, but maybe it should be
split up? I'm not sure (I think usually as separate commit, but here a
fix/update for broken package seemed opportune), feel free to chime in
anyone. I also did this super quickly, apologies for any silly
mistakes.

Thanks for the report!
John

> Kind regards
> Felix
>
> * * *
>
> [ 477/1048] Compiling src/gx_head/engine/gx_resampler.cpp
> In file included from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gi18n.h:21,
>                  from
> /gnu/store/cbjgz6f8nrb7804nnmmlvpd4y78p8zf3-glibmm-2.64.5/include/glibmm-2.4/glibmm/i18n.h:23,
>                  from ../src/headers/engine.h:43,
>                  from ../src/gx_head/engine/gx_resampler.cpp:27:
> ../src/headers/gx_system.h: In function ‘bool
> gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
> error: invalid conversion from ‘volatile void*’ to ‘void*’
> [-fpermissive]
>   163 |     __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
> (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
>       |                                            ^~~~~~~~~~~~~~
>       |                                            |
>       |                                            volatile void*
> ../src/headers/gx_system.h:115:12: note: in expansion of macro
> ‘g_atomic_int_compare_and_exchange’
>   115 |     return g_atomic_int_compare_and_exchange(p, oldv, newv);
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In file included from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
>                  from ../src/headers/guitarix.h:35,
>                  from ../src/gx_head/gui/gx_main_boxes.cpp:25:
> ../src/headers/gx_system.h: In function ‘bool
> gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
> error: invalid conversion from ‘volatile void*’ to ‘void*’
> [-fpermissive]
>   163 |     __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
> (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
>       |                                            ^~~~~~~~~~~~~~
>       |                                            |
>       |                                            volatile void*
> ../src/headers/gx_system.h:115:12: note: in expansion of macro
> ‘g_atomic_int_compare_and_exchange’
>   115 |     return g_atomic_int_compare_and_exchange(p, oldv, newv);
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In file included from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
>                  from ../src/headers/guitarix.h:35,
>                  from ../src/gx_head/gui/gx_main_midi.cpp:25:
> ../src/headers/gx_system.h: In function ‘bool
> gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
> error: invalid conversion from ‘volatile void*’ to ‘void*’
> [-fpermissive]
>   163 |     __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
> (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
>       |                                            ^~~~~~~~~~~~~~
>       |                                            |
>       |                                            volatile void*
> ../src/headers/gx_system.h:115:12: note: in expansion of macro
> ‘g_atomic_int_compare_and_exchange’
>   115 |     return g_atomic_int_compare_and_exchange(p, oldv, newv);
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In file included from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
>                  from
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
>                  from
> /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
>                  from ../src/headers/guitarix.h:35,
>                  from ../src/headers/avahi_discover.h:26,
>                  from ../src/gx_head/gui/avahi_discover.cpp:21:
> ../src/headers/gx_system.h: In function ‘bool
> gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
> /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
> error: invalid conversion from ‘volatile void*’ to ‘void*’
> [-fpermissive]
>   163 |     __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
> (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
>       |                                            ^~~~~~~~~~~~~~
>       |                                            |
>       |                                            volatile void*
> ../src/headers/gx_system.h:115:12: note: in expansion of macro
> ‘g_atomic_int_compare_and_exchange’
>   115 |     return g_atomic_int_compare_and_exchange(p, oldv, newv);
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Waf: Leaving directory
> `/tmp/guix-build-guitarix-0.43.1.drv-0/guitarix-0.43.1/build'
> Build failed
>  -> task in 'guitarix' failed with exit status 1 (run with -v to
> display more information)
>  -> task in 'guitarix' failed with exit status 1 (run with -v to
> display more information)
>  -> task in 'guitarix' failed with exit status 1 (run with -v to
> display more information)
>  -> task in 'guitarix' failed with exit status 1 (run with -v to
> display more information)
> error: in phase 'build': uncaught exception:
> %exception #<&invoke-error program: "python" arguments: ("waf"
> "build") exit-status: 1 term-signal: #f stop-signal: #f>
> phase `build' failed after 68.7 seconds
> command "python" "waf" "build" failed with status 1

[0001-gnu-guitarix-Update-to-0.44.1.patch (text/x-patch, attachment)]

Message #8 received at 63098 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: guix-devel <at> gnu.org, 63098 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: guitarix: Update to 0.44.1.
Date: Thu, 27 Apr 2023 07:42:11 -0700

Hi John,

On Wed, Apr 26, 2023 at 3:28 PM John Kehayias
<john.kehayias <at> protonmail.com> wrote:
>
> a quick patch that
> updates the package which builds fine for me locally; I didn't test
> running it though.

Thanks for looking into it! An untested executable strikes me as
superior to one that does not build. I would commit the patch,
regardless of form, at the earliest opportunity.

Kind regards
Felix

P.S. You may find the X-Debbugs-CC header helpful. [1]

[1] https://debbugs.gnu.org/Reporting.html#xcc

Message #11 received at 63098 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: guix-devel <at> gnu.org, Felix Lechner <felix.lechner <at> lease-up.com>,
 63098 <at> debbugs.gnu.org
Subject: Re: bug#63098: [PATCH] gnu: guitarix: Update to 0.44.1.
Date: Sun, 30 Apr 2023 22:34:10 +0200

Hi John,

John Kehayias <john.kehayias <at> protonmail.com> skribis:

> From c652ee7b7339d287b623692190d66c3f5f3a90ee Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias <at> protonmail.com>
> Date: Wed, 26 Apr 2023 18:25:35 -0400
> Subject: [PATCH] gnu: guitarix: Update to 0.44.1.
>
> * gnu/packages/audio.scm (guitarix): Update to 0.44.1.
> [arguments]: Use gexps.
> [native-inputs]: Remove labels

LGTM, thanks!

Ludo’.

Message #16 received at 63098-done <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 63098-done <at> debbugs.gnu.org, Felix Lechner <felix.lechner <at> lease-up.com>
Subject: Re: bug#63098: [PATCH] gnu: guitarix: Update to 0.44.1.
Date: Tue, 02 May 2023 04:59:10 +0000

On Sun, Apr 30, 2023 at 10:34 PM, Ludovic Courtès wrote:

> Hi John,
>
> John Kehayias <john.kehayias <at> protonmail.com> skribis:
>
>> From c652ee7b7339d287b623692190d66c3f5f3a90ee Mon Sep 17 00:00:00 2001
>> From: John Kehayias <john.kehayias <at> protonmail.com>
>> Date: Wed, 26 Apr 2023 18:25:35 -0400
>> Subject: [PATCH] gnu: guitarix: Update to 0.44.1.
>>
>> * gnu/packages/audio.scm (guitarix): Update to 0.44.1.
>> [arguments]: Use gexps.
>> [native-inputs]: Remove labels
>
> LGTM, thanks!
>

Thanks! Pushed as 854c57c3525325070e261a2e6f81d4016ef44bfa

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.