GNU bug report logs - #63089
[PATCH] Display offscreen matched openparen

Previous Next

Full log

View this message in rfc822 format

From: Shynur Xie <one.last.kiss <at> outlook.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "63089 <at> debbugs.gnu.org" <63089 <at> debbugs.gnu.org>
Subject: bug#63089: [PATCH] Display offscreen matched openparen
Date: Sun, 30 Apr 2023 10:09:18 +0000

[Message part 1 (text/plain, inline)]

>    From: Eli Zaretskii
> Subject: bug#63089
>    Date: Sat, 29 Apr 2023 14:05:56 +0300
>      To: Shynur Xie
>
> Backticks usually imply some run-time processing, which AFAIU here
> is not required.

Have replaced backtickes with `list's and `cons'es.

>> +  "Set face for the matched offscreen openparen shown in the echo area.
>
> "Face for showing in the echo area matched open paren that is off-screen."

Have changed to the latter.

> I think the default value should be the default face.

Its default value is nil now.  I struggled with whether `nil' (it can
be seen as an empty anonymous face) was better or `default'.

> "face will be propertized" is incorrect: we propertize text with a
> face, we don't propertize the face.

Have replaced
"the openparen's face will be propertized by this option"
with
"the openparen will be propertized with a face based on the value of
 this option".

> This should be "30.1".  Emacs doesn't have NN.0 versions.

Got it.

>> +  "Return the line string that contains the openparen at POS.
>> +Remove the line string's properties but give the openparen a face."
>
> This should include the name of the face,

The name of the face has been added:
"...... give the openparen a face based on the option
 `show-paren-openparen-face-in-message'."

______________________

New patch is attached.

Will keep your guidance in mind.  Thanks!

--
shynur

[0001-Display-offscreen-matched-openparen.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.