GNU bug report logs - #63086
29.0.90; go-ts-mode treesit-query-error during jit-lock

Previous Next

Full log

Message #49 received at 63086-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 63086-done <at> debbugs.gnu.org, casouri <at> gmail.com,
 Jimmy Wong <wyuenho <at> gmail.com>
Subject: Re: bug#63086: 29.0.90; go-ts-mode treesit-query-error during jit-lock
Date: Thu, 4 May 2023 00:58:22 +0300

On 02/05/2023 03:29, Randy Taylor wrote:
> On Friday, April 28th, 2023 at 06:05, Dmitry Gutov <dmitry <at> gutov.dev> wrote:
>> On 28/04/2023 04:35, Randy Taylor wrote:
>>
>>> Maybe I'm missing something, but doesn't treesit-query-string with an empty string do nothing and always error, since it queries on whatever string you pass in?
>>
>>
>> It would return nil, not error (querying an empty buffer). And we should
>> be checking for error.
>>
>> This is the part that java-ts-mode--string-highlight-helper got right, BTW.
> 
> Sorry, I was operating under false assumptions and somehow convinced myself that treesit-query-string with an empty string returning nil meant the query wasn't supported, hence me thinking it achieved nothing. I am no longer under such delusions :).
> 
>>
>> go-ts-mode--iota-query-supported-p in your patch relies on the condition
>> that the file, at the time the mode is enabled, already contains at
>> least one "iota" node.
> 
> Good point. I've attached a patch using treesit-query-string with an empty string. It now works properly when iota is missing but inserted later.

Thanks! I've pushed this to emacs-29, so the bug can be closed.

Stylistically, I think I prefer the original way (with condition-case), 
but we'll have plenty of time to refine this on master later.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.