Subject: bug#63082: [PATCH 06/17] services: mympd: Fix log file name.

From: Maxim Cournoyer <[email-masked]>
Date: Fri, 28 Apr 2023 21:49:18 -0400

Hi,

Bruno Victal <[email-masked]> writes:

> On 2023-04-28 15:26, Maxim Cournoyer wrote:
>> * gnu/services/audio.scm (mympd-configuration): Adjust log file name to match
>> documentation.
>> ---
>>  gnu/services/audio.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
>> index 1dc3204fc0..0b7a25d9ef 100644
>> --- a/gnu/services/audio.scm
>> +++ b/gnu/services/audio.scm
>> @@ -744,7 +744,7 @@ (define-configuration/no-serialization mympd-configuration
>>     "How much detail to include in logs, possible values: @code{0} to @code{7}.")
>>  
>>    (log-to
>> -   (string-or-symbol "/var/log/mympd/log")
>> +   (string-or-symbol "/var/log/mympd.log")
>>     "Where to send logs. By default, the service logs to
>>  @file{/var/log/mympd.log}. The alternative is @code{'syslog}, which
>>  sends output to the running syslog service under the @samp{daemon} facility."
>
> No, this is correct although perhaps /var/log/mympd/mympd.log would have been less error prone?
> IIRC mympd is supposed to write to a subdirectory within /var/log and
> this change would break the service.

The only consumer of a 'log-to' is Shepherd, as far as I can see; so
mympd doesn't get to know where the log is going (its output goes to
stdout/stderr, captured by Shepherd), so shouldn't be writing anything
under /var/log/mympd.  Looking at upstream, they ship a fancy systemd
service which wouldn't log to text files but to the journal, closer in
spirit to syslog.

For symmetry with mpd, I've now adjusted logging of mympd to default to
syslog (and found it had an erroneous requirement on 'syslog rather than
syslogd with the test :-)).

-- 
Thanks,
Maxim