GNU bug report logs - #63077
[PATCH] gnu: gnutls: skip examples on mingw.

Previous Next

Package: guix;

Reported by: Vivien Kraus <vivien <at> planete-kraus.eu>

Date: Tue, 25 Apr 2023 21:43:01 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 63077 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guix <at> gnu.org:
bug#63077; Package guix. (Tue, 25 Apr 2023 21:43:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Vivien Kraus <vivien <at> planete-kraus.eu>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Tue, 25 Apr 2023 21:43:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: bug-guix <at> gnu.org
Subject: [PATCH] gnu: gnutls: skip examples on mingw.
Date: Tue, 25 Apr 2023 23:26:52 +0200

* gnu/packages/tls.scm (gnutls): Skip the doc/examples subdir on mingw,
because the gnulib modules are not correct.
---
 gnu/packages/tls.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index 6d7cff41b0..9e16b04702 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -253,6 +253,15 @@ (define-public gnutls
                    (substitute* "tests/fastopen.sh"
                      (("^unset RETCODE")
                       "exit 77\n"))))   ;skip
+               #$@(if (target-mingw?)
+                      #~((add-after 'unpack 'skip-doc-examples
+                           ;; The examples in doc do not link to correct
+                           ;; gnulib modules.
+                           (lambda _
+                             (substitute* "doc/Makefile.in"
+                               (("SUBDIRS = examples")
+                                "SUBDIRS =")))))
+                      #~())
                #$@(if (target-ppc32?)
                       ;; https://gitlab.com/gnutls/gnutls/-/issues/1354
                       ;; Extend the test timeout from the default of 20 * 1000

base-commit: e287a0e402ee15eefa80c2804e487025507fe3b1
-- 
2.39.2
Information forwarded to bug-guix <at> gnu.org:
bug#63077; Package guix. (Fri, 05 Jan 2024 18:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 63077 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 63077 <at> debbugs.gnu.org
Subject: Re: bug#63077: [PATCH] gnu: gnutls: skip examples on mingw.
Date: Fri, 05 Jan 2024 13:06:55 -0500

Hi Vivien,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/tls.scm (gnutls): Skip the doc/examples subdir on mingw,
> because the gnulib modules are not correct.
> ---
>  gnu/packages/tls.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
> index 6d7cff41b0..9e16b04702 100644
> --- a/gnu/packages/tls.scm
> +++ b/gnu/packages/tls.scm
> @@ -253,6 +253,15 @@ (define-public gnutls
>                     (substitute* "tests/fastopen.sh"
>                       (("^unset RETCODE")
>                        "exit 77\n"))))   ;skip
> +               #$@(if (target-mingw?)
> +                      #~((add-after 'unpack 'skip-doc-examples
> +                           ;; The examples in doc do not link to correct
> +                           ;; gnulib modules.
> +                           (lambda _
> +                             (substitute* "doc/Makefile.in"
> +                               (("SUBDIRS = examples")
> +                                "SUBDIRS =")))))
> +                      #~())

Did you report it upstream?  Perhaps they'd know how to properly fix it.

-- 
Thanks,
Maxim
Information forwarded to bug-guix <at> gnu.org:
bug#63077; Package guix. (Mon, 11 Mar 2024 14:54:02 GMT) Full text and rfc822 format available.

Message #11 received at 63077 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Vivien Kraus
 <vivien <at> planete-kraus.eu>
Cc: 63077 <at> debbugs.gnu.org
Subject: Re: bug#63077: [PATCH] gnu: gnutls: skip examples on mingw.
Date: Fri, 08 Mar 2024 18:22:20 +0100

Hi,

On ven., 05 janv. 2024 at 13:06, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
> Vivien Kraus <vivien <at> planete-kraus.eu> writes:
>
>> * gnu/packages/tls.scm (gnutls): Skip the doc/examples subdir on mingw,
>> because the gnulib modules are not correct.
>> ---
>>  gnu/packages/tls.scm | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
>> index 6d7cff41b0..9e16b04702 100644
>> --- a/gnu/packages/tls.scm
>> +++ b/gnu/packages/tls.scm
>> @@ -253,6 +253,15 @@ (define-public gnutls
>>                     (substitute* "tests/fastopen.sh"
>>                       (("^unset RETCODE")
>>                        "exit 77\n"))))   ;skip
>> +               #$@(if (target-mingw?)
>> +                      #~((add-after 'unpack 'skip-doc-examples
>> +                           ;; The examples in doc do not link to correct
>> +                           ;; gnulib modules.
>> +                           (lambda _
>> +                             (substitute* "doc/Makefile.in"
>> +                               (("SUBDIRS = examples")
>> +                                "SUBDIRS =")))))
>> +                      #~())
>
> Did you report it upstream?  Perhaps they'd know how to properly fix it.

Digging all bugs, what about this?

It could be nice if it is fixed upstream.  On the other, we could also
apply a fix waiting such fix.

WDYT?

Cheers,
simon
Information forwarded to bug-guix <at> gnu.org:
bug#63077; Package guix. (Mon, 11 Mar 2024 17:49:01 GMT) Full text and rfc822 format available.

Message #14 received at 63077 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Simon Tournier <zimon.toutoune <at> gmail.com>, Maxim Cournoyer
 <maxim.cournoyer <at> gmail.com>
Cc: 63077 <at> debbugs.gnu.org
Subject: Re: bug#63077: [PATCH] gnu: gnutls: skip examples on mingw.
Date: Mon, 11 Mar 2024 18:47:44 +0100

Hello,

Le vendredi 08 mars 2024 à 18:22 +0100, Simon Tournier a écrit :
> > > +               #$@(if (target-mingw?)
> > > +                      #~((add-after 'unpack 'skip-doc-examples
> > > +                           ;; The examples in doc do not link to
> > > correct
> > > +                           ;; gnulib modules.
> > > +                           (lambda _
> > > +                             (substitute* "doc/Makefile.in"
> > > +                               (("SUBDIRS = examples")
> > > +                                "SUBDIRS =")))))
> > > +                      #~())
> > 
> > Did you report it upstream?  Perhaps they'd know how to properly
> > fix it.
> 
> Digging all bugs, what about this?
> 
> It could be nice if it is fixed upstream.  On the other, we could
> also
> apply a fix waiting such fix.

I reported it, and I believe upstream fixed it:

https://gitlab.com/gnutls/gnutls/-/merge_requests/1761/diffs?commit_id=5db0db2e83da54d799f55984dc33039d6b22c933

However it’s difficult to check because libidn2 fails (maybe the more
recent 2.3.7 does not).  This libidn2 failure seems to have been
reported here:

https://gitlab.com/libidn/libidn2/-/issues/113

I notice that libidn2 uses its own libunistring instead of the guix’
one, because libunistring is not an input of libidn2.  Is this intended
to avoid a cycle?

Best regards,

Vivien
This bug report was last modified 1 year and 92 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.