GNU bug report logs - #63071
[PATCH] gnu: Add emacs-riscv-mode

Previous Next

Package: guix-patches;

Reported by: Gabriel Wicki <gabriel <at> erlikon.ch>

Date: Tue, 25 Apr 2023 17:25:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


Message #28 received at 63071-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 63071-done <at> debbugs.gnu.org, Gabriel Wicki <liliana.prikler <at> gmail.com>
Subject: Re: [bug#63071] [PATCH] gnu: Add emacs-riscv-mode.
Date: Wed, 03 May 2023 14:28:56 +0200
Hello,

Andrew Tropin <andrew <at> trop.in> writes:

>> +(define-public emacs-riscv-mode
>> +  (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7")
>> +        (revision "1"))
>
> Revision should be 0 here, everything else LGTM.

FWIW, I noticed that revision 1 for version V tells Repology that it was
released after V. This is not the case for revision 0. So I think
starting at 1 is not bad either.

I applied the latest version of patch.

Thanks to everyone.

Regards,
-- 
Nicolas Goaziou




This bug report was last modified 2 years and 79 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.