GNU bug report logs - #63071
[PATCH] gnu: Add emacs-riscv-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63071: closed ([PATCH] gnu: Add emacs-riscv-mode)
Date: Wed, 03 May 2023 12:30:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 03 May 2023 14:28:56 +0200
with message-id <87v8h9vbsn.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#63071] [PATCH] gnu: Add emacs-riscv-mode.
has caused the debbugs.gnu.org bug report #63071,
regarding [PATCH] gnu: Add emacs-riscv-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63071: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63071
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: guix-patches <at> gnu.org
Cc: liliana.prikler <at> gmail.com, andrew <at> trop.in
Subject: [PATCH] gnu: Add emacs-riscv-mode
Date: Tue, 25 Apr 2023 19:23:15 +0200

Hello!

I hope this email finds you in a state of well-being!

I've come around to package this small little emacs-package which is
supposed to aid RISC-V assembly development.  Please let me know if I
can fix/improve/adjust anything with the patch.

It is based on commit 8c5ba69d6e9e4b1b9d6b5e9cd28859b19e8e180c


Best wishes,
gabber

From 3046e712491fa0bdc21c4d7aef62eedc134df783 Mon Sep 17 00:00:00 2001
Message-Id: <3046e712491fa0bdc21c4d7aef62eedc134df783.1682443077.git.gabriel <at> erlikon.ch>
From: Gabriel Wicki <gabriel <at> erlikon.ch>
Date: Tue, 25 Apr 2023 17:48:41 +0200
Subject: [PATCH] gnu: Add emacs-riscv-mode.

* gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7c8af093fc..7b10bed7df 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -35854,6 +35854,32 @@ (define-public emacs-nasm-mode
 Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.")
     (license license:unlicense)))
 
+(define-public emacs-riscv-mode
+  (let ((url "https://github.com/AdamNiederer/riscv-mode")
+        (commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7")
+        (revision "1")
+        (version "0"))
+    (package
+      (name "emacs-riscv-mode")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url url)
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4"))))
+      (build-system emacs-build-system)
+      (home-page url)
+      (synopsis "RISC-V assembly major mode")
+      (description
+       "RISC-V mode is a major mode for editing RISC-V assembly programs.
+It includes syntax highlighting, syntactic indentation and code evaluation
+with spike.")
+      (license license:gpl3))))
+
 (define-public emacs-validate-html
   ;; XXX: Upstream did not tag commits yet.  However, commit below matches the
   ;; last version bump.  Version is extracted from the keyword in main file.
-- 
2.39.2

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 63071-done <at> debbugs.gnu.org, Gabriel Wicki <liliana.prikler <at> gmail.com>
Subject: Re: [bug#63071] [PATCH] gnu: Add emacs-riscv-mode.
Date: Wed, 03 May 2023 14:28:56 +0200

Hello,

Andrew Tropin <andrew <at> trop.in> writes:

>> +(define-public emacs-riscv-mode
>> +  (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7")
>> +        (revision "1"))
>
> Revision should be 0 here, everything else LGTM.

FWIW, I noticed that revision 1 for version V tells Repology that it was
released after V. This is not the case for revision 0. So I think
starting at 1 is not bad either.

I applied the latest version of patch.

Thanks to everyone.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.