From unknown Mon Aug 18 02:38:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63071 <63071@debbugs.gnu.org> To: bug#63071 <63071@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add emacs-riscv-mode Reply-To: bug#63071 <63071@debbugs.gnu.org> Date: Mon, 18 Aug 2025 09:38:53 +0000 retitle 63071 [PATCH] gnu: Add emacs-riscv-mode reassign 63071 guix-patches submitter 63071 Gabriel Wicki severity 63071 normal tag 63071 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 13:24:03 2023 Received: (at submit) by debbugs.gnu.org; 25 Apr 2023 17:24:03 +0000 Received: from localhost ([127.0.0.1]:53498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prMOZ-0005O7-70 for submit@debbugs.gnu.org; Tue, 25 Apr 2023 13:24:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:43556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prMOX-0005Np-Oh for submit@debbugs.gnu.org; Tue, 25 Apr 2023 13:24:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prMOX-00055N-IE for guix-patches@gnu.org; Tue, 25 Apr 2023 13:24:01 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prMOV-00021P-Ep for guix-patches@gnu.org; Tue, 25 Apr 2023 13:24:01 -0400 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by chimborazo.ee.ethz.ch (Postfix) with ESMTP id 08139401A2; Tue, 25 Apr 2023 19:23:23 +0200 (CEST) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from chimborazo.ee.ethz.ch ([129.132.2.15]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10026) with ESMTP id buMLmFxa_ZDt; Tue, 25 Apr 2023 19:23:18 +0200 (CEST) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA; Tue, 25 Apr 2023 19:23:18 +0200 (CEST) From: Gabriel Wicki To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-riscv-mode Date: Tue, 25 Apr 2023 19:23:15 +0200 Message-ID: <875y9jj2po.fsf@erlikon.ch> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=129.132.2.15; envelope-from=gabriel@erlikon.ch; helo=chimborazo.ee.ethz.ch X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: liliana.prikler@gmail.com, andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello! I hope this email finds you in a state of well-being! I've come around to package this small little emacs-package which is supposed to aid RISC-V assembly development. Please let me know if I can fix/improve/adjust anything with the patch. It is based on commit 8c5ba69d6e9e4b1b9d6b5e9cd28859b19e8e180c Best wishes, gabber >From 3046e712491fa0bdc21c4d7aef62eedc134df783 Mon Sep 17 00:00:00 2001 Message-Id: <3046e712491fa0bdc21c4d7aef62eedc134df783.1682443077.git.gabriel@erlikon.ch> From: Gabriel Wicki Date: Tue, 25 Apr 2023 17:48:41 +0200 Subject: [PATCH] gnu: Add emacs-riscv-mode. * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. --- gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 7c8af093fc..7b10bed7df 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -35854,6 +35854,32 @@ (define-public emacs-nasm-mode Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.") (license license:unlicense))) +(define-public emacs-riscv-mode + (let ((url "https://github.com/AdamNiederer/riscv-mode") + (commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7") + (revision "1") + (version "0")) + (package + (name "emacs-riscv-mode") + (version (git-version version revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url url) + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4")))) + (build-system emacs-build-system) + (home-page url) + (synopsis "RISC-V assembly major mode") + (description + "RISC-V mode is a major mode for editing RISC-V assembly programs. +It includes syntax highlighting, syntactic indentation and code evaluation +with spike.") + (license license:gpl3)))) + (define-public emacs-validate-html ;; XXX: Upstream did not tag commits yet. However, commit below matches the ;; last version bump. Version is extracted from the keyword in main file. -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 14:21:22 2023 Received: (at 63071) by debbugs.gnu.org; 25 Apr 2023 18:21:22 +0000 Received: from localhost ([127.0.0.1]:53554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prNI1-0006vo-K5 for submit@debbugs.gnu.org; Tue, 25 Apr 2023 14:21:21 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:49162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prNHy-0006vb-SR for 63071@debbugs.gnu.org; Tue, 25 Apr 2023 14:21:20 -0400 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-94f6c285d22so1135917066b.2 for <63071@debbugs.gnu.org>; Tue, 25 Apr 2023 11:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682446873; x=1685038873; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=od3enJp8jqwvrT1jadMI6mWWmimla41Tcoz4487Wp4g=; b=eIjwP8rHS4wkXKCeAnuyDo8PAiVsCm9ljVCi/Muut7RwlNNY8TrP9DLSSNmohN+l8M 89Y8Etvo0VPezPHy5Os8EHYr26TLwg2RQmcbgVgTXLiMeE+E/R3ijdXxfFTSSRtAJh8Y u4rz0Xkfu56mDgX1cc8v1SgTf2WUXgBGTjlWCHEG6fyewxN0CUj6GxVhvrdx4vKE0P4G OdhLkX0OwoQWdlhRCsOH4JRVjCxuIHrYnvMe+iyvPsqKvM7Re6c0ZZWiaS65MaAxcSlK NZHTz32pfUjZS1vnsX1nvI4m+ezGu4+CzY1Dq3X8jU5FQTQ0OS5LcZ0yd0+Mq/649PXk MZfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682446873; x=1685038873; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=od3enJp8jqwvrT1jadMI6mWWmimla41Tcoz4487Wp4g=; b=j4ipi3kAg2FBw/Sbwxl3b4eeowW0z1ZEwTBvN4J2/OG35kG5pF4YIm95IkW8cNAK6d pEozKCC0yKfcxifFgpNeqHkJ1acdpVyjweNyy1qQMpScA4X38P1ifPb96VZpVgYMsXgl RqhkNtyNlPjfPIwwhbMdoFzVX3/Gk1slK9bxeq82i4Ds6OHwW0BrodCXBCaF7vxjBhiP NLl463bJgigvBsAC3yhgeAihBPelWJKn4sQPnwyWwqh4IHt3MXb3CfnMF92MqWx1yeCP V2N1L4ShJgEhrcxY/xDUGO/1qaLECirah0CEkdTpalSpsxIOhZKqLDZFuSxQTHvFSfZ9 guMw== X-Gm-Message-State: AAQBX9eDe//nFA7eSoq3FDvutrS3yIeQiXfqmLjA2YbLxvkfb2YVgP6f M54/x7n92u092jFmvVGfWx4= X-Google-Smtp-Source: AKy350ZVbQsbgM5nVYGEdcb8cIiIYQFweANHDx6f0gjM711JcNiXwgkvD5y32ORuhf33xChk9iPSlQ== X-Received: by 2002:a17:907:1a52:b0:94f:432f:2435 with SMTP id mf18-20020a1709071a5200b0094f432f2435mr12191855ejc.65.1682446872671; Tue, 25 Apr 2023 11:21:12 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id sd14-20020a170906ce2e00b0094f5d1bbb21sm7014030ejb.102.2023.04.25.11.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 11:21:12 -0700 (PDT) Message-ID: <4e725f264cf10b43986a29d3d12bc405a62e7f3c.camel@gmail.com> Subject: Re: [PATCH] gnu: Add emacs-riscv-mode From: Liliana Marie Prikler To: Gabriel Wicki , 63071@debbugs.gnu.org Date: Tue, 25 Apr 2023 20:21:11 +0200 In-Reply-To: <875y9jj2po.fsf@erlikon.ch> References: <875y9jj2po.fsf@erlikon.ch> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63071 Cc: andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 25.04.2023 um 19:23 +0200 schrieb Gabriel Wicki: > Hello! >=20 > I hope this email finds you in a state of well-being! >=20 > I've come around to package this small little emacs-package which is > supposed to aid RISC-V assembly development.=C2=A0 Please let me know if = I > can fix/improve/adjust anything with the patch. >=20 > It is based on commit 8c5ba69d6e9e4b1b9d6b5e9cd28859b19e8e180c >=20 >=20 > Best wishes, > gabber >=20 > From 3046e712491fa0bdc21c4d7aef62eedc134df783 Mon Sep 17 00:00:00 > 2001 > Message-Id: > <3046e712491fa0bdc21c4d7aef62eedc134df783.1682443077.git.gabriel@erli > kon.ch> > From: Gabriel Wicki > Date: Tue, 25 Apr 2023 17:48:41 +0200 > Subject: [PATCH] gnu: Add emacs-riscv-mode. >=20 > * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. > --- > =C2=A0gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++ > =C2=A01 file changed, 26 insertions(+) >=20 > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 7c8af093fc..7b10bed7df 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -35854,6 +35854,32 @@ (define-public emacs-nasm-mode > =C2=A0Unlike Emacs' generic ASM mode, it understands NASM-specific > syntax.") > =C2=A0=C2=A0=C2=A0=C2=A0 (license license:unlicense))) > =C2=A0 > +(define-public emacs-riscv-mode > +=C2=A0 (let ((url "https://github.com/AdamNiederer/riscv-mode") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit "8e335b9c93de93ed8dd0= 63d702b0f5ad48eef6d7") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (revision "1") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (version "0")) No need to let-bind url and version, please use their values in the right locations below. > +=C2=A0=C2=A0=C2=A0 (package > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (name "emacs-riscv-mode") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (version (git-version version revision co= mmit)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (source (origin > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (method git-fetch) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (uri (git-reference > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (url url) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit commit))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (file-name (git-file-name name version)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (sha256 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (base32 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4")))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (build-system emacs-build-system) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (home-page url) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (synopsis "RISC-V assembly major mode") Better: "Emacs major mode for RISC-V assembly" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (description > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "RISC-V mode is a major mode for ed= iting RISC-V assembly > programs. > +It includes syntax highlighting, syntactic indentation and code > evaluation > +with spike.") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl3)))) > + Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 14:27:25 2023 Received: (at 63071) by debbugs.gnu.org; 25 Apr 2023 18:27:25 +0000 Received: from localhost ([127.0.0.1]:53573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prNNt-00076E-GF for submit@debbugs.gnu.org; Tue, 25 Apr 2023 14:27:25 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:40049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prNNr-00075z-F0 for 63071@debbugs.gnu.org; Tue, 25 Apr 2023 14:27:23 -0400 Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA id 6AAC74019D; Tue, 25 Apr 2023 20:27:16 +0200 (CEST) Date: Tue, 25 Apr 2023 20:27:13 +0200 From: Gabriel Wicki To: Liliana Marie Prikler Subject: Re: [PATCH] gnu: Add emacs-riscv-mode Message-ID: <20230425182713.hcbaj2vqa5vzce7s@blackbox> References: <875y9jj2po.fsf@erlikon.ch> <4e725f264cf10b43986a29d3d12bc405a62e7f3c.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e725f264cf10b43986a29d3d12bc405a62e7f3c.camel@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63071 Cc: 63071@debbugs.gnu.org, andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Apr 25, 2023 at 08:21:11PM +0200, Liliana Marie Prikler wrote: > No need to let-bind url and version, please use their values in the > right locations below. I thought I'd bind them since the values were used multiple times. Anyhow, I've corrected the patch. Thank you for that super-quick reply! >From ed779ffef71167d18256a21dbcab99d27c3a5176 Mon Sep 17 00:00:00 2001 Message-Id: From: Gabriel Wicki Date: Tue, 25 Apr 2023 17:48:41 +0200 Subject: [PATCH] gnu: Add emacs-riscv-mode. * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. --- gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 7c8af093fc..33c745d029 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -35854,6 +35854,30 @@ (define-public emacs-nasm-mode Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.") (license license:unlicense))) +(define-public emacs-riscv-mode + (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7") + (revision "1")) + (package + (name "emacs-riscv-mode") + (version (git-version "0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/AdamNiederer/riscv-mode") + (commit commit))) + (file-name (git-file-name name "0")) + (sha256 + (base32 + "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4")))) + (build-system emacs-build-system) + (home-page "https://github.com/AdamNiederer/riscv-mode") + (synopsis "Emacs major mode for RISC-V assembly") + (description + "RISC-V mode is a major mode for editing RISC-V assembly programs. +It includes syntax highlighting, syntactic indentation and code evaluation +with spike.") + (license license:gpl3)))) + (define-public emacs-validate-html ;; XXX: Upstream did not tag commits yet. However, commit below matches the ;; last version bump. Version is extracted from the keyword in main file. -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 15:07:38 2023 Received: (at 63071) by debbugs.gnu.org; 25 Apr 2023 19:07:38 +0000 Received: from localhost ([127.0.0.1]:53601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prO0o-0008MG-7t for submit@debbugs.gnu.org; Tue, 25 Apr 2023 15:07:38 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:55297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prO0i-0008Lu-GN for 63071@debbugs.gnu.org; Tue, 25 Apr 2023 15:07:36 -0400 Received: by mail-ed1-f67.google.com with SMTP id 4fb4d7f45d1cf-5052caa1e32so11009656a12.2 for <63071@debbugs.gnu.org>; Tue, 25 Apr 2023 12:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682449646; x=1685041646; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=56ilPkdg/on0O5H04OkyWuZqfEtXAjzBfo+oP7t/76Q=; b=SSA1LwgL43yBJru7NCXrHdBTjD3nrYJsWyF7RAoZUQ4d6aUdMp4gCWtvfuJutMT49Z snWWTmC8Gd/qsQWSTz429E4+0VDxzlhmlkubju6UWWLTqC/zMyYCfgpaRGR6h2UKr3BF 6ynY/Vwl76VABKrTcQ3OwRpT1uFj09Pf5/aOLfjvh0JMQOUveVVovz1ddqBL7aqsy8Ip BiP+Z1byYDyfWwhbwxfYfOzVQNiFXKGS0pztqgS3o2ytoeQRn+qlfQRetgQR34fpZSXB Qlwz5s6ikHC/TDNDJVXAP39ui25VtBLNOR9HW3MfwNB/jyO1KdbzHif3jHrZR7lShgZW gWbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682449646; x=1685041646; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=56ilPkdg/on0O5H04OkyWuZqfEtXAjzBfo+oP7t/76Q=; b=IPtavf+G20hbNIk6bqBW1wyu0r4wvxPwmNlwiBnLPkpYLq2QeK/B88rhcyxnAeyxc2 0+bnRC5q2rNnYUW5BL3xRSj5E1rSaQ9ml71WT1I2SqRlih0oWUYmz20ptfIrr+4Oq5f0 Ful6yUIUkx+oDpPX6f4aNS0eoOs8ATyPCmYvNTp6gxIJSh84Me7TnidxdkHYBTPAJxWC g0ZPuZEXubfQGLOgT0ABZ1jsH2j06DNbKrPJfWdHbtRva6N9MMTZo/1IRnT6reylrQkX 4sNcA8oL7uX55T7RQ0AfLAb3EgUAxjkpbgACV/9fxIxnpaXQ06eWGxYqEh7lPC7Csc9n 91jA== X-Gm-Message-State: AAQBX9eZTUe7IzBkPceErjxetboU6x4szLm6RP/AbM8+njCrKKdJ9Dui /WqyH4PT0zNslhB7kgH4enk= X-Google-Smtp-Source: AKy350bAtN0MHdsph8W9qZzrAvi0Fx6uWDAWcMGKQqrJXi3VcmLsOcbcuKanw5fbDSf+XtlzUfuZCA== X-Received: by 2002:a05:6402:18c:b0:505:47a:7ae8 with SMTP id r12-20020a056402018c00b00505047a7ae8mr16669902edv.4.1682449646202; Tue, 25 Apr 2023 12:07:26 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u11-20020aa7d0cb000000b0050687dbb5dasm5970495edo.31.2023.04.25.12.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 12:07:23 -0700 (PDT) Message-ID: <038cfa65746b53fd739bbbb2920064391e625ffe.camel@gmail.com> Subject: Re: [PATCH] gnu: Add emacs-riscv-mode From: Liliana Marie Prikler To: Gabriel Wicki Date: Tue, 25 Apr 2023 21:07:22 +0200 In-Reply-To: <20230425182713.hcbaj2vqa5vzce7s@blackbox> References: <875y9jj2po.fsf@erlikon.ch> <4e725f264cf10b43986a29d3d12bc405a62e7f3c.camel@gmail.com> <20230425182713.hcbaj2vqa5vzce7s@blackbox> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63071 Cc: 63071@debbugs.gnu.org, andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 2023-04-25 at 20:27 +0200, Gabriel Wicki wrote: > On Tue, Apr 25, 2023 at 08:21:11PM +0200, Liliana Marie Prikler > wrote: > > No need to let-bind url and version, please use their values in the > > right locations below. > I thought I'd bind them since the values were used multiple times. >=20 > Anyhow, I've corrected the patch.=C2=A0 Thank you for that super-quick > reply! >=20 >=20 > From ed779ffef71167d18256a21dbcab99d27c3a5176 Mon Sep 17 00:00:00 > 2001 > Message-Id: > kon.ch> > From: Gabriel Wicki > Date: Tue, 25 Apr 2023 17:48:41 +0200 > Subject: [PATCH] gnu: Add emacs-riscv-mode. >=20 > * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. > --- > =C2=A0gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++ > =C2=A01 file changed, 24 insertions(+) >=20 > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 7c8af093fc..33c745d029 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -35854,6 +35854,30 @@ (define-public emacs-nasm-mode > =C2=A0Unlike Emacs' generic ASM mode, it understands NASM-specific > syntax.") > =C2=A0=C2=A0=C2=A0=C2=A0 (license license:unlicense))) > =C2=A0 > +(define-public emacs-riscv-mode > +=C2=A0 (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (revision "1")) > +=C2=A0=C2=A0=C2=A0 (package > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (name "emacs-riscv-mode") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (version (git-version "0" revision commit= )) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (source (origin > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (method git-fetch) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (uri (git-reference > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (url > "https://github.com/AdamNiederer/riscv-mode") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit commit))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (file-name (git-file-name name "0")) Use "version" here. It won't refer to "0", but instead to the expanded (git-version ...) -- it's basically syntactic sugar for (package- version this-package). > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (sha256 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (base32 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4")))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (build-system emacs-build-system) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (home-page "https://github.com/AdamNieder= er/riscv-mode") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (synopsis "Emacs major mode for RISC-V as= sembly") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (description > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "RISC-V mode is a major mode for ed= iting RISC-V assembly > programs. > +It includes syntax highlighting, syntactic indentation and code > evaluation > +with spike.") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl3)))) License should be gpl3+ going by the README. Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 15:15:15 2023 Received: (at 63071) by debbugs.gnu.org; 25 Apr 2023 19:15:15 +0000 Received: from localhost ([127.0.0.1]:53612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prO8A-00006g-Kc for submit@debbugs.gnu.org; Tue, 25 Apr 2023 15:15:14 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:53447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prO86-00006H-7J for 63071@debbugs.gnu.org; Tue, 25 Apr 2023 15:15:13 -0400 Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA id 838AA40093; Tue, 25 Apr 2023 21:15:02 +0200 (CEST) Date: Tue, 25 Apr 2023 21:14:58 +0200 From: Gabriel Wicki To: Liliana Marie Prikler Subject: Re: [PATCH] gnu: Add emacs-riscv-mode Message-ID: <20230425191458.dwuwvygyo3pmvrxq@blackbox> References: <875y9jj2po.fsf@erlikon.ch> <4e725f264cf10b43986a29d3d12bc405a62e7f3c.camel@gmail.com> <20230425182713.hcbaj2vqa5vzce7s@blackbox> <038cfa65746b53fd739bbbb2920064391e625ffe.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <038cfa65746b53fd739bbbb2920064391e625ffe.camel@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63071 Cc: 63071@debbugs.gnu.org, andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks, again :) >From b7e9ef4f2f19858ef5feca32bed72a77fd96c968 Mon Sep 17 00:00:00 2001 Message-Id: From: Gabriel Wicki Date: Tue, 25 Apr 2023 17:48:41 +0200 Subject: [PATCH] gnu: Add emacs-riscv-mode. * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. --- gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 7c8af093fc..588bc0248d 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -127,6 +127,7 @@ ;;; Copyright © 2023 Dominik Delgado Steuter ;;; Copyright © 2023 Juliana Sims ;;; Copyright © 2023 Evgeny Pisemsky +;;; Copyright © 2023 Gabriel Wicki ;;; ;;; This file is part of GNU Guix. ;;; @@ -35854,6 +35855,30 @@ (define-public emacs-nasm-mode Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.") (license license:unlicense))) +(define-public emacs-riscv-mode + (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7") + (revision "1")) + (package + (name "emacs-riscv-mode") + (version (git-version "0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/AdamNiederer/riscv-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4")))) + (build-system emacs-build-system) + (home-page "https://github.com/AdamNiederer/riscv-mode") + (synopsis "Emacs major mode for RISC-V assembly") + (description + "RISC-V mode is a major mode for editing RISC-V assembly programs. +It includes syntax highlighting, syntactic indentation and code evaluation +with spike.") + (license license:gpl3+)))) + (define-public emacs-validate-html ;; XXX: Upstream did not tag commits yet. However, commit below matches the ;; last version bump. Version is extracted from the keyword in main file. -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 16:08:34 2023 Received: (at 63071) by debbugs.gnu.org; 25 Apr 2023 20:08:34 +0000 Received: from localhost ([127.0.0.1]:53651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prOxl-0001iH-KI for submit@debbugs.gnu.org; Tue, 25 Apr 2023 16:08:34 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:49326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prOxd-0001hx-Mu for 63071@debbugs.gnu.org; Tue, 25 Apr 2023 16:08:31 -0400 Received: by mail-ed1-f67.google.com with SMTP id 4fb4d7f45d1cf-505934ccc35so10817738a12.2 for <63071@debbugs.gnu.org>; Tue, 25 Apr 2023 13:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682453299; x=1685045299; h=mime-version:message-id:cc:to:subject:date:from:from:to:cc:subject :date:message-id:reply-to; bh=w+AXWQcYoiz3HVOiHfX44qcFDOxS6P9oZGdwVYq4Efc=; b=UqWhVM8kupfwe1UZFxCSOKy1cyOS8c29VxdAUDJ41zVbrjvqjZ31BhXiBKxk16g7/K 7NuXKswQwpboHMjYxxeC1FUGK5/30hjDHNN7OrD8llB77uTyul90/dylmfF8T3B+DdTR 2OaCSd0UiMe6cKn/zExMu9fFrcx6ANLZROIsg0XcHWbmIYyH0pGBG+34XhZ4/UnE/Fp5 m33kJ1GspdVuZBX5tZrg5bdkCEkvfjUHBRlzpdwSuvusTTvlf1OzWbJIVA0ckq4X+d4c sak69q6GpAJTeb4B28Ai1Y++C1jQm9xsdRk975kktewjDkD5yWS9cekOUJKSEQiL+4Dn /Tpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682453299; x=1685045299; h=mime-version:message-id:cc:to:subject:date:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=w+AXWQcYoiz3HVOiHfX44qcFDOxS6P9oZGdwVYq4Efc=; b=mEmWtY02VBXNqTYV+dxrkXwObJ25JBjrEn5MoVbrsOyJKf5taqytVMP8+E2nBuYym0 q4AsJrKGjYqVAyxBfmunWrdT3d3oEhqAkVcoqHjki4yPRu7/QX3nc7KBIWmDzI6rqhy+ SrOdfoSMWFi6bEUc/cCQ6bUPMytk3+SQ5o7V0Ox6aepDpvuFHkfuauoffaLL2foPfVIm qN/3pqnZ5ej7SxLjmzPm4VEGfmWVHB+gKKLlW7yhdo439ITR7cQjVba7sRnVgdJlVOdm drNiBZiq1wZSKC+MOKUOytW5UGQ0niy9nfVuBUICnEC1/uR76Pss+M8hqWQsFX0lAbgP Vugg== X-Gm-Message-State: AAQBX9cr6sW51DJNd/XliY2vuOoDlUmdeHkZchjS7EvaT+yb44o8LGBH SEoSWMVtrnoMP4OMY564MFq1hDFhWWg71w== X-Google-Smtp-Source: AKy350bbhZIBtnS64ZGEvx/ybBALulBoTimkVavkWb4Xn+O4ycWd6p4uroNoiD9/j5DiQzQsDsI4ng== X-Received: by 2002:a05:6402:146:b0:506:75d4:44 with SMTP id s6-20020a056402014600b0050675d40044mr14595123edu.25.1682453299565; Tue, 25 Apr 2023 13:08:19 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id p21-20020a056402075500b0050684020babsm5929665edy.27.2023.04.25.13.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 13:08:19 -0700 (PDT) From: Gabriel Wicki X-Google-Original-From: Gabriel Wicki Date: Tue, 25 Apr 2023 17:48:41 +0200 Subject: [PATCH] gnu: Add emacs-riscv-mode. to: 63071@debbugs.gnu.org Message-ID: <6e8f134d43202eb43e72b1be2ac5dd520968f75d.camel@erlikon.ch> MIME-Version: 1.0 X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. --- Hi Gabriel, your patch didn't apply cleanly thanks to some coding issues, but I got them to work with a little bit of work. Below is an expanded patch that also makes sure that spike actually exists. It also uses [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.67 listed in wl.mailspike.net] 0.0 PP_MIME_FAKE_ASCII_TEXT BODY: MIME text/plain claims to be ASCII but isn't X-Debbugs-Envelope-To: 63071 Cc: Liliana Marie Prikler , andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. --- Hi Gabriel, your patch didn't apply cleanly thanks to some coding issues, but I got them to work with a little bit of work. Below is an expanded patch that also makes sure that spike actually exists. It also uses 0.1 as base version, taken from riscv-mode.el. Cheers, Liliana gnu/packages/emacs-xyz.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 7c8af093fc..3d4b9998ce 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -127,6 +127,7 @@ ;;; Copyright © 2023 Dominik Delgado Steuter ;;; Copyright © 2023 Juliana Sims ;;; Copyright © 2023 Evgeny Pisemsky +;;; Copyright © 2023 Gabriel Wicki ;;; ;;; This file is part of GNU Guix. ;;; @@ -259,6 +260,7 @@ (define-module (gnu packages emacs-xyz) #:use-module (gnu packages erlang) #:use-module (gnu packages statistics) #:use-module (gnu packages libcanberra) + #:use-module (gnu packages virtualization) #:use-module (gnu packages web-browsers) #:use-module (gnu packages wget) #:use-module (guix utils) @@ -35854,6 +35856,39 @@ (define-public emacs-nasm-mode Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.") (license license:unlicense))) +(define-public emacs-riscv-mode + (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7") + (revision "1")) + (package + (name "emacs-riscv-mode") + (version (git-version "0.1" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/AdamNiederer/riscv-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4")))) + (build-system emacs-build-system) + (arguments + (list #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'hardcode-spike + (lambda* (#:key inputs #:allow-other-keys) + (emacs-substitute-variables "riscv-mode.el" + ("riscv-interpreter" + (search-input-file inputs "bin/spike")))))))) + (inputs (list spike)) + (home-page "https://github.com/AdamNiederer/riscv-mode") + (synopsis "Emacs major mode for RISC-V assembly") + (description + "RISC-V mode is a major mode for editing RISC-V assembly programs. +It includes syntax highlighting, syntactic indentation and code evaluation +with spike.") + (license license:gpl3+)))) + (define-public emacs-validate-html ;; XXX: Upstream did not tag commits yet. However, commit below matches the ;; last version bump. Version is extracted from the keyword in main file. -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 00:29:15 2023 Received: (at 63071) by debbugs.gnu.org; 26 Apr 2023 04:29:15 +0000 Received: from localhost ([127.0.0.1]:53948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prWmI-0007QT-Qh for submit@debbugs.gnu.org; Wed, 26 Apr 2023 00:29:15 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prWmF-0007QB-AO for 63071@debbugs.gnu.org; Wed, 26 Apr 2023 00:29:13 -0400 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id 29268C0002; Wed, 26 Apr 2023 04:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1682483344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n1QQGCfpK7qggRhDWXlBMXxyZ6u7NuSTggYYTkJytrg=; b=h+GnhNmhxNzSFEyqB6YQwpJrbyvxuHBooEwph08p/yX6YMUCkAgs/eeZuqQCOZlqCYD8P3 5ITb9PRmlu7ihXWDXOuWDh3a5CdOIbxjQ0ye89am24C8DqaKpP5/nIyeuaFXLJd+ywCgxn wRFewQdr5103k61ZfbOx0hjhgElXo2X14RwGgRYijnFDtQa9htxtTbJ7J0wGc1uu6+KHRb VLGO6ivZSLKBO37oEJN+n/ivyuWbiEZfNiC6hU0NM/ODY+67k9Nbvim7XEiTUq6SzUZtdW Kn35qvZa+HsTf2Ngc/vBbrQWI0cLPlSOrtvHeLnLznRkjc1dw+ScBxko6NeQjw== From: Andrew Tropin To: Gabriel Wicki , 63071@debbugs.gnu.org Subject: Re: [PATCH] gnu: Add emacs-riscv-mode. In-Reply-To: <6e8f134d43202eb43e72b1be2ac5dd520968f75d.camel@erlikon.ch> References: <6e8f134d43202eb43e72b1be2ac5dd520968f75d.camel@erlikon.ch> Date: Wed, 26 Apr 2023 08:29:00 +0400 Message-ID: <87o7nbe06r.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 63071 Cc: Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-04-25 17:48, Gabriel Wicki wrote: > * gnu/packages/emacs-xyz.scm (emacs-riscv-mode): New variable. > --- > Hi Gabriel, > > your patch didn't apply cleanly thanks to some coding issues, but I got > them to work with a little bit of work. Below is an expanded patch that > also makes sure that spike actually exists. It also uses 0.1 as base > version, taken from riscv-mode.el. > > Cheers, > Liliana > > gnu/packages/emacs-xyz.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 7c8af093fc..3d4b9998ce 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -127,6 +127,7 @@ > ;;; Copyright =C2=A9 2023 Dominik Delgado Steuter > ;;; Copyright =C2=A9 2023 Juliana Sims > ;;; Copyright =C2=A9 2023 Evgeny Pisemsky > +;;; Copyright =C2=A9 2023 Gabriel Wicki > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -259,6 +260,7 @@ (define-module (gnu packages emacs-xyz) > #:use-module (gnu packages erlang) > #:use-module (gnu packages statistics) > #:use-module (gnu packages libcanberra) > + #:use-module (gnu packages virtualization) > #:use-module (gnu packages web-browsers) > #:use-module (gnu packages wget) > #:use-module (guix utils) > @@ -35854,6 +35856,39 @@ (define-public emacs-nasm-mode > Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.") > (license license:unlicense))) >=20=20 > +(define-public emacs-riscv-mode > + (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7") > + (revision "1")) Revision should be 0 here, everything else LGTM. > + (package > + (name "emacs-riscv-mode") > + (version (git-version "0.1" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/AdamNiederer/riscv-mode") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "06jlf84mx49scw3zm1wjj25zinr2yr9abiyh83rli78wb1hdc0l4"= )))) > + (build-system emacs-build-system) > + (arguments > + (list #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'hardcode-spike > + (lambda* (#:key inputs #:allow-other-keys) > + (emacs-substitute-variables "riscv-mode.el" > + ("riscv-interpreter" > + (search-input-file inputs "bin/spike")))))))) > + (inputs (list spike)) > + (home-page "https://github.com/AdamNiederer/riscv-mode") > + (synopsis "Emacs major mode for RISC-V assembly") > + (description > + "RISC-V mode is a major mode for editing RISC-V assembly programs. > +It includes syntax highlighting, syntactic indentation and code evaluati= on > +with spike.") > + (license license:gpl3+)))) > + > (define-public emacs-validate-html > ;; XXX: Upstream did not tag commits yet. However, commit below match= es the > ;; last version bump. Version is extracted from the keyword in main f= ile. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmRIqIwACgkQIgjSCVjB 3rD0vQ//TCskaY+2bhrIfrb1qZkxSRUNK4khuqaT0QrkjcGZlyCf6Q/LVQJn//dz sLtzsxQVQ3HWJH5ttj0ir9v3yEKQdoIItM+bwxzijGkFMAE8N5Lmq7GT92KEzkI+ djRrHANGjoK7BjNptlXqL/D2lFN6+FEFfFOfoHzt3XmPK097r64wmMcJnWc1pZ8H cJdxlIxNT7msKoKhs9ZxI6rEGb6DKMrCyR9KnucoAjIncE3G8YMwA1JN/+ZIdues n7j4G/yEofo7dtUg0Xjv3KkMvQibax71Dxsx9f0bsH7EwVanFetXox1W97iLYeXk BoTqlWQdF3ZBxxvIn2OnXCKc5WLjcNaJeZZx25MXKBIBoaHRR8Dr6VINuXXb1Vgv idDDBd7DwMeF7P2ISBF8waWQg3fa33FYyKxVUyDSX6HKZeuDGZibcQpV1mz2C+79 t1pZTVnBMpWhuCPyQOjLwEJDLLDXGCfiuKqJ+m0soD+OG4Wzq9AM+9Ajd2SjTY0l IzqE3pm/CER1mEl6S7auSdSBh72Gh37DUCP1GTe3vs35yEPeXdkL9MP6wRAtkaNP Hwotw34AW09mJ9h5DYslE0hhr654PtbqvQgnpfXeg16ZT8zvka28Xzuot/pEFEd0 UpsFUVeQvhmw3DJj8MRuOkVi/ZVyLThYcTLSHdaiAg+/DOezeZo= =nVWV -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 03 08:29:08 2023 Received: (at 63071-done) by debbugs.gnu.org; 3 May 2023 12:29:08 +0000 Received: from localhost ([127.0.0.1]:45838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puBbY-0001xw-36 for submit@debbugs.gnu.org; Wed, 03 May 2023 08:29:08 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:45453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puBbU-0001x6-RE for 63071-done@debbugs.gnu.org; Wed, 03 May 2023 08:29:06 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id D1252FF80C; Wed, 3 May 2023 12:28:57 +0000 (UTC) From: Nicolas Goaziou To: Andrew Tropin Subject: Re: [bug#63071] [PATCH] gnu: Add emacs-riscv-mode. References: <6e8f134d43202eb43e72b1be2ac5dd520968f75d.camel@erlikon.ch> <87o7nbe06r.fsf@trop.in> Date: Wed, 03 May 2023 14:28:56 +0200 In-Reply-To: <87o7nbe06r.fsf@trop.in> (Andrew Tropin's message of "Wed, 26 Apr 2023 08:29:00 +0400") Message-ID: <87v8h9vbsn.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 63071-done Cc: 63071-done@debbugs.gnu.org, Gabriel Wicki X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Andrew Tropin writes: >> +(define-public emacs-riscv-mode >> + (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7") >> + (revision "1")) > > Revision should be 0 here, everything else LGTM. FWIW, I noticed that revision 1 for version V tells Repology that it was released after V. This is not the case for revision 0. So I think starting at 1 is not bad either. I applied the latest version of patch. Thanks to everyone. Regards, -- Nicolas Goaziou From unknown Mon Aug 18 02:38:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 01 Jun 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator