GNU bug report logs - #6305
24.0.50; Regression: most, but not all, keyboard shortcuts are missing

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6305 in the body.
You can then email your comments to 6305 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; Regression: most, but not all, keyboard shortcuts are missing
Date: Sat, 29 May 2010 14:38:03 -0700

[Message part 1 (text/plain, inline)]

This is a regression from 23.1 to 23.2.

I don't have a recipe from emacs -Q.  I'm sure you could create one.
 
In Emacs 22 and 23.1, keyboard shortcuts ("equivalents", if you
prefer) are indicated correctly in menus.  In both Emacs 23.2 and
the recent build noted below, this is horribly broken.

See the three attached screenshots, for Emacs 22 (OK), Emacs 23.1
(OK), and Emacs 23.2 (broken - build noted below or the release 23.2).
 
There is absolutely nothing particular about the three shortcuts
that Emacs 23.2 does happen to show correctly.  The code defining
their menu items is the same as the code that defines the other
items whose shortcuts do not show.

The code that builds the menu is straightforward:
 
(defvar bookmarkp-jump-map nil "...")
(define-prefix-command 'bookmarkp-jump-map)
(define-key ctl-x-map "j" bookmarkp-jump-map)

(define-key bookmarkp-jump-map "B" 'bookmarkp-bookmark-list-jump)
(define-key bookmarkp-jump-map "v" 'bookmarkp-varlist-jump)
...
(define-key bookmarkp-bmenu-jump-menu ; SHORTCUT `C-x j v' OK
  [bookmarkp-varlist-jump]
  '(menu-item "Variable List..." bookmarkp-varlist-jump
  :help "..."))
(define-key bookmarkp-bmenu-jump-menu ; SHORTCUT `C-x j B' MISSING
  [bookmarkp-bookmark-list-jump]
  '(menu-item "Bookmark List..." bookmarkp-bookmark-list-jump
    :help "..."))
...

 
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-05-23 on G41R2F1
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/xpm/include'
 

[bug-emacs-23-2-menu-shortcuts.png (image/png, attachment)]

[bug-emacs-22-menu-shortcuts.png (image/png, attachment)]

[bug-emacs-23-1-menu-shortcuts.png (image/png, attachment)]

Message #8 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 6305 <at> debbugs.gnu.org
Subject: Re: bug#6305: 24.0.50; Regression: most, but not all, keyboard 
	shortcuts are missing
Date: Sun, 30 May 2010 00:11:13 +0200

On Sat, May 29, 2010 at 11:38 PM, Drew Adams <drew.adams <at> oracle.com> wrote:
> This is a regression from 23.1 to 23.2.
>
> I don't have a recipe from emacs -Q.  I'm sure you could create one.
>
> In Emacs 22 and 23.1, keyboard shortcuts ("equivalents", if you
> prefer) are indicated correctly in menus.  In both Emacs 23.2 and
> the recent build noted below, this is horribly broken.
>
> See the three attached screenshots, for Emacs 22 (OK), Emacs 23.1
> (OK), and Emacs 23.2 (broken - build noted below or the release 23.2).
>
> There is absolutely nothing particular about the three shortcuts
> that Emacs 23.2 does happen to show correctly.  The code defining
> their menu items is the same as the code that defines the other
> items whose shortcuts do not show.
>
> The code that builds the menu is straightforward:
>
> (defvar bookmarkp-jump-map nil "...")
> (define-prefix-command 'bookmarkp-jump-map)


I have also noticed that key bindings are not always shown in the
menus, but I wondered if that was because I was using
overriding-terminal-local-map there. I havn't had time to check,
however key bindings in global map and normal minor mode maps seems to
show up fine in the menus.

Message #11 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Lennart Borgman'" <lennart.borgman <at> gmail.com>
Cc: 6305 <at> debbugs.gnu.org
Subject: RE: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard shortcuts are missing
Date: Sat, 29 May 2010 15:18:01 -0700

> I have also noticed that key bindings are not always shown in the
> menus, but I wondered if that was because I was using
> overriding-terminal-local-map there. I havn't had time to check,
> however key bindings in global map and normal minor mode maps seems to
> show up fine in the menus.

I am not using `overriding-terminal-local-map'.

---

Note that a similar bug was reported as #6171.  That was also a regression, but
that problem started with 23.1.  Stefan reported that he fixed that bug after
23.1.

The current bug is a problem that does not show up in 23.1.  Dunno whether the
fix of #6171 might have introduced this bug.  Just mentioning #6171 in case it
helps somehow.

Message #14 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 6305 <at> debbugs.gnu.org
Subject: Re: bug#6305: 24.0.50; Regression: most, but not all, keyboard 
	shortcuts are missing
Date: Sun, 30 May 2010 03:45:24 +0200

On Sun, May 30, 2010 at 12:18 AM, Drew Adams <drew.adams <at> oracle.com> wrote:
>> I have also noticed that key bindings are not always shown in the
>> menus, but I wondered if that was because I was using
>> overriding-terminal-local-map there. I havn't had time to check,
>> however key bindings in global map and normal minor mode maps seems to
>> show up fine in the menus.
>
> I am not using `overriding-terminal-local-map'.


OK. Then it is at least partly another bug.

In the C code it looks up key bindings like this:

  (where-is-internal 'ido-kill-buffer nil t nil nil)

However it seems like key remapping is forgotten there.
where-is-internal does not handle remapping.

Could someone who knows remapping please look at that?

Message #17 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 6305 <at> debbugs.gnu.org
Subject: Re: bug#6305: 24.0.50; Regression: most, but not all, keyboard 
	shortcuts are missing
Date: Sun, 30 May 2010 03:49:15 +0200

On Sun, May 30, 2010 at 3:45 AM, Lennart Borgman
<lennart.borgman <at> gmail.com> wrote:
> On Sun, May 30, 2010 at 12:18 AM, Drew Adams <drew.adams <at> oracle.com> wrote:
>>> I have also noticed that key bindings are not always shown in the
>>> menus, but I wondered if that was because I was using
>>> overriding-terminal-local-map there. I havn't had time to check,
>>> however key bindings in global map and normal minor mode maps seems to
>>> show up fine in the menus.
>>
>> I am not using `overriding-terminal-local-map'.
>
>
> OK. Then it is at least partly another bug.
>
> In the C code it looks up key bindings like this:
>
>  (where-is-internal 'ido-kill-buffer nil t nil nil)
>
> However it seems like key remapping is forgotten there.
> where-is-internal does not handle remapping.
>
> Could someone who knows remapping please look at that?


Maybe I should say that this happens in parse_menu_item in keyboard.c.

Message #20 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6305 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard  shortcuts are missing
Date: Mon, 31 May 2010 11:31:53 -0400

>> This is a regression from 23.1 to 23.2.
>> I don't have a recipe from emacs -Q.  I'm sure you could create one.

That would be *very* helpful.

>> In Emacs 22 and 23.1, keyboard shortcuts ("equivalents", if you
>> prefer) are indicated correctly in menus.  In both Emacs 23.2 and
>> the recent build noted below, this is horribly broken.

That's bad.

> I have also noticed that key bindings are not always shown in the
> menus, but I wondered if that was because I was using
> overriding-terminal-local-map there. I havn't had time to check,
> however key bindings in global map and normal minor mode maps seems to
> show up fine in the menus.

I don't know where to start looking without a reproducible recipe.
The fix for 6171 only touched tmm.el so it can't affect GUI menus.

> In the C code it looks up key bindings like this:
>   (where-is-internal 'ido-kill-buffer nil t nil nil)
> However it seems like key remapping is forgotten there.

In which sense?

> where-is-internal does not handle remapping.

There are many different ways to "handle" remapping.  where-is-internal
most definitely has code to do something specific with remapping.

> Could someone who knows remapping please look at that?

Look at what?


        Stefan

Message #23 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6305 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#6305: 24.0.50; Regression: most, but not all, keyboard 
	shortcuts are missing
Date: Mon, 31 May 2010 18:33:45 +0200

On Mon, May 31, 2010 at 5:31 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
>
>> I have also noticed that key bindings are not always shown in the
>> menus, but I wondered if that was because I was using
>> overriding-terminal-local-map there. I havn't had time to check,
>> however key bindings in global map and normal minor mode maps seems to
>> show up fine in the menus.
>
> I don't know where to start looking without a reproducible recipe.
> The fix for 6171 only touched tmm.el so it can't affect GUI menus.


I think the problem is this:

- Fwhere_is_internal calls Fcurrent_active_maps, but the latter does
not include overriding-terminal-local-map if the first arg is Qnil. It
is Qnil in this case so overriding-terminal-local-map is not
considered.

However using Qt for the first arg is no good either since then only
the overriding map(s) are considered. Obviously Fcurrent_active_maps
behaves this way for the key lookup in the command loop.

Perhaps there should be something like Freally_active_maps ()?


>> In the C code it looks up key bindings like this:
>>   (where-is-internal 'ido-kill-buffer nil t nil nil)
>> However it seems like key remapping is forgotten there.
>
> In which sense?


What was I thinking, I really should learn to be more explicit ... ;-)

Yes, of course it looks at remapping, but for menus it would be good
if this situation was handled too:

- Let us say `kill-buffer' is in the menus.
- It got remapped to `ido-kill-buffer'.

The code in parse_menu_item around line 8008 calls

	  keys = Fwhere_is_internal (def, Qnil, Qt, Qnil, Qnil);

Since the last arg is nil it does not find any binding for
`kill-buffer' AFAICS. Or do I miss something?

Message #26 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Lennart Borgman'" <lennart.borgman <at> gmail.com>,
	"'Stefan Monnier'" <monnier <at> iro.umontreal.ca>
Cc: 6305 <at> debbugs.gnu.org
Subject: RE: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard shortcuts are missing
Date: Mon, 31 May 2010 10:33:32 -0700

This thread seems to be getting diverted.
This is not particularly about REMAPPED keys.

The missing shortcuts in the screenshots I sent are NOT for REMAPPED
commands/keys. If you need to access the source code that produces those menus
it is here: http://www.emacswiki.org/emacs/bookmark%2b.el.

Lennart seems to be referring to only a PART of the problem this bug report is
about - or perhaps even to a separate problem altogether.

The problem I reported is more general. If you want to file a separate bug
report for a remapping problem, please do so. If you think there is a relation
between the two problems, you can cross-reference this bug report.

But this thread is not about REMAPPED keys in particular.

Message #29 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 6305 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6305: 24.0.50; Regression: most, but not all, keyboard 
	shortcuts are missing
Date: Mon, 31 May 2010 20:05:17 +0200

On Mon, May 31, 2010 at 7:33 PM, Drew Adams <drew.adams <at> oracle.com> wrote:
> This thread seems to be getting diverted.
> This is not particularly about REMAPPED keys.
>
> The missing shortcuts in the screenshots I sent are NOT for REMAPPED
> commands/keys. If you need to access the source code that produces those menus
> it is here: http://www.emacswiki.org/emacs/bookmark%2b.el.
>
> Lennart seems to be referring to only a PART of the problem this bug report is
> about - or perhaps even to a separate problem altogether.
>
> The problem I reported is more general. If you want to file a separate bug
> report for a remapping problem, please do so. If you think there is a relation
> between the two problems, you can cross-reference this bug report.
>
> But this thread is not about REMAPPED keys in particular.


I see, but I think I have said all that is needed so it seems a bit
overkill to open a new bug report.

Message #32 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 6305 <at> debbugs.gnu.org, 'Lennart Borgman' <lennart.borgman <at> gmail.com>
Subject: Re: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard shortcuts are missing
Date: Mon, 31 May 2010 14:23:23 -0400

> The missing shortcuts in the screenshots I sent are NOT for REMAPPED
> commands/keys. If you need to access the source code that produces
> those menus it is here: http://www.emacswiki.org/emacs/bookmark%2b.el.

What do I do with this file?  Again: Please provide a recipe.

> Lennart seems to be referring to only a PART of the problem this bug
> report is about - or perhaps even to a separate problem altogether.

I think he's talking about two problems, both of which are unrelated
to yours.


        Stefan

Message #35 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Stefan Monnier'" <monnier <at> iro.umontreal.ca>
Cc: 6305 <at> debbugs.gnu.org, 'Lennart Borgman' <lennart.borgman <at> gmail.com>
Subject: RE: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard shortcuts are missing
Date: Mon, 31 May 2010 11:58:03 -0700

> What do I do with this file?  Again: Please provide a recipe.

My bad altogether.  I will close this bug.

I was seeing this in my setup because of a minor-mode keymap override.
Turning off the minor mode brings back the shortcuts.

Very sorry for the noise.

Message #38 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6305 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#6305: 24.0.50; Regression: most, but not all, keyboard 
	shortcuts are missing
Date: Mon, 31 May 2010 21:07:29 +0200

On Mon, May 31, 2010 at 8:23 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
>> The missing shortcuts in the screenshots I sent are NOT for REMAPPED
>> commands/keys. If you need to access the source code that produces
>> those menus it is here: http://www.emacswiki.org/emacs/bookmark%2b.el.
>
> What do I do with this file?  Again: Please provide a recipe.
>
>> Lennart seems to be referring to only a PART of the problem this bug
>> report is about - or perhaps even to a separate problem altogether.
>
> I think he's talking about two problems, both of which are unrelated
> to yours.

Yes, it seems so. Can we then continue here (since Drew says he has no
problem with the original bug here)?

Message #41 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Lennart Borgman'" <lennart.borgman <at> gmail.com>,
	"'Stefan Monnier'" <monnier <at> iro.umontreal.ca>
Cc: 6305 <at> debbugs.gnu.org
Subject: RE: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard shortcuts are missing
Date: Mon, 31 May 2010 12:37:28 -0700

> I'm sorry, I closed the bug.  But you can reopen it I imagine.

You're in luck.  The close failed because I forgot to include the bug number.
So this is still open.

Message #44 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Lennart Borgman'" <lennart.borgman <at> gmail.com>,
	"'Stefan Monnier'" <monnier <at> iro.umontreal.ca>
Cc: 6305 <at> debbugs.gnu.org
Subject: RE: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard shortcuts are missing
Date: Mon, 31 May 2010 12:19:10 -0700

> > I think he's talking about two problems, both of which are unrelated
> > to yours.
> 
> Yes, it seems so. Can we then continue here (since Drew says he has no
> problem with the original bug here)?

I'm sorry, I closed the bug.  But you can reopen it I imagine.

BTW, the missing bindings I reported were in fact due to remappings (second mea
culpa).  In the minor-mode map, I remap those commands, so in the minor-mode map
they should show up correctly but they are missing altogether.

Message #47 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Lennart Borgman'" <lennart.borgman <at> gmail.com>,
	"'Stefan Monnier'" <monnier <at> iro.umontreal.ca>
Cc: 6305 <at> debbugs.gnu.org
Subject: RE: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard shortcuts are missing
Date: Wed, 2 Jun 2010 06:37:49 -0700

Maybe see also bug #788. Dunno whether it's related, since this worked in Emacs
23.1 (i.e. after the temporary disabling done to "fix" #788). Probably
unrelated, but who knows?

Message #50 received at 6305 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 6305 <at> debbugs.gnu.org, 'Lennart Borgman' <lennart.borgman <at> gmail.com>
Subject: Re: bug#6305: 24.0.50;
	Regression: most, but not all, keyboard shortcuts are missing
Date: Wed, 02 Jun 2010 10:13:51 -0400

> Maybe see also bug #788. Dunno whether it's related, since this worked
> in Emacs 23.1 (i.e. after the temporary disabling done to "fix" #788).
> Probably unrelated, but who knows?

AFAIK 788 is now fixed "right" with my latest change.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.