GNU bug report logs - #63044
[PATCH] gnu: python-setuptools: Disable date checking in bdist_egg.py

Previous Next

Package: guix-patches;

Reported by: Brian Cully <bjc <at> spork.org>

Date: Mon, 24 Apr 2023 00:20:01 UTC

Severity: normal

Tags: patch

Full log


View this message in rfc822 format

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Brian Cully <bjc <at> spork.org>
Cc: jgart <jgart <at> dismail.de>, Ludovic Courtès <ludo <at> gnu.org>, 63044 <at> debbugs.gnu.org
Subject: [bug#63044] [PATCH] gnu: python-setuptools: Disable date checking in bdist_egg.py
Date: Sat, 13 May 2023 09:11:38 +0200
Hi,

> --8<---------------cut here---------------start------------->8---
> diff --git a/guix/build/python-build-system.scm 
> b/guix/build/python-build-system.scm
> index aa04664b25..1236ea62cd 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -270,7 +270,8 @@ (define* (ensure-no-mtimes-pre-1980 #:rest _)
>    ;; timestamps before 1980.
>    (let ((early-1980 315619200))  ; 1980-01-02 UTC
>      (ftw "." (lambda (file stat flag)
> -               (unless (<= early-1980 (stat:mtime stat))
> +               (unless (or (<= early-1980 (stat:mtime stat))
> +                           (eq? (stat:type stat) 'symlink))
>                   (utime file early-1980 early-1980))
>                 #t))))
>  
> --8<---------------cut here---------------end--------------->8---

I’m going to include this patch in the python-team branch. We’re
looking at a massive rebuild due to #63139 anyways, as you said. In
theory there’s nothing wrong with patching setuptools like this, but
I’d like to avoid it, because that substitute* can just break silently
in the future.

Cheers,
Lars





This bug report was last modified 2 years and 36 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.