From unknown Fri Jun 20 07:11:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6304 <6304@debbugs.gnu.org> To: bug#6304 <6304@debbugs.gnu.org> Subject: Status: 23.2; advising yank Reply-To: bug#6304 <6304@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:24 +0000 retitle 6304 23.2; advising yank reassign 6304 emacs submitter 6304 Leo severity 6304 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 29 16:05:04 2010 Received: (at submit) by debbugs.gnu.org; 29 May 2010 20:05:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OISHH-0004Jf-QR for submit@debbugs.gnu.org; Sat, 29 May 2010 16:05:04 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OISHF-0004JJ-EG for submit@debbugs.gnu.org; Sat, 29 May 2010 16:05:02 -0400 Received: from lists.gnu.org ([199.232.76.165]:46713) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OISHA-0007Zk-KF for submit@debbugs.gnu.org; Sat, 29 May 2010 16:04:56 -0400 Received: from [140.186.70.92] (port=36001 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OISH9-000852-1J for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 16:04:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OISFV-0000XO-8C for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 16:03:14 -0400 Received: from ppsw-32.csi.cam.ac.uk ([131.111.8.132]:37876) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OISFV-0000X9-2I for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 16:03:13 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc1-cmbg13-0-0-cust596.cmbg.cable.ntl.com ([86.9.122.85]:51407 helo=Victoria.local) by ppsw-32.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.158]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1OISFT-0003sS-A3 (Exim 4.70) for bug-gnu-emacs@gnu.org (return-path ); Sat, 29 May 2010 21:03:11 +0100 From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.2; advising yank Date: Sat, 29 May 2010 21:03:09 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) I have been seeing this for a while but just find this reproducible case: 1. (defadvice yank (after random-advice activate) (message "hello world")) 2. C-h f yank RET The string "This function is advised." is not highlighted with the warning face. In GNU Emacs 23.2.5 (x86_64-apple-darwin10.3.0) of 2010-05-28 Leo From debbugs-submit-bounces@debbugs.gnu.org Sat May 29 20:22:31 2010 Received: (at 6304) by debbugs.gnu.org; 30 May 2010 00:22:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIWIP-00064L-MV for submit@debbugs.gnu.org; Sat, 29 May 2010 20:22:30 -0400 Received: from smtprelay-h12.telenor.se ([62.127.194.5]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIWIM-00064E-25 for 6304@debbugs.gnu.org; Sat, 29 May 2010 20:22:27 -0400 Received: from ipb3.telenor.se (ipb3.telenor.se [195.54.127.166]) by smtprelay-h12.telenor.se (Postfix) with ESMTP id 4EE7C15303 for <6304@debbugs.gnu.org>; Sun, 30 May 2010 02:22:20 +0200 (CEST) X-SENDER-IP: [85.228.198.97] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuE9AP5MAUxV5MZhPGdsb2JhbACHaJZTDAEBAQE1Lbw4hRYE X-IronPort-AV: E=Sophos;i="4.53,324,1272837600"; d="scan'208";a="528040637" Received: from c-61c6e455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.198.97]) by ipb3.telenor.se with ESMTP; 30 May 2010 02:22:20 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id E18BE484247; Sun, 30 May 2010 02:22:19 +0200 (CEST) From: bojohan@gnu.org (Johan =?utf-8?Q?Bockg=C3=A5rd?=) To: Leo Subject: Re: bug#6304: 23.2; advising yank References: Mail-Copies-To: never Date: Sun, 30 May 2010 02:22:18 +0200 In-Reply-To: (Leo's message of "Sat, 29 May 2010 21:03:09 +0100") Message-ID: <871vcuck79.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 6304 Cc: 6304@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) Leo writes: > 1. (defadvice yank (after random-advice activate) > (message "hello world")) > > 2. C-h f yank RET > > The string "This function is advised." is not highlighted with the > warning face. The highlighting is removed by substitute-command-keys: Returns original STRING if no substitutions were made. Otherwise, a new string, without any text properties, is returned. From debbugs-submit-bounces@debbugs.gnu.org Sun May 30 01:57:07 2010 Received: (at 6304) by debbugs.gnu.org; 30 May 2010 05:57:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIbWE-0000lG-TT for submit@debbugs.gnu.org; Sun, 30 May 2010 01:57:07 -0400 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIbWB-0000kn-Tr for 6304@debbugs.gnu.org; Sun, 30 May 2010 01:57:04 -0400 Received: by wye20 with SMTP id 20so1678051wye.3 for <6304@debbugs.gnu.org>; Sat, 29 May 2010 22:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=+g2DOGZBFhH3qiu+fZhWh0hC5kaDJgc6HmCeYSP1vag=; b=UAvBdjstRcYydiZoZAfPI1ZuUfXE0bLJB2LlQIuwr2pAzmMuo4LLKN6d17iNEHz9vG Jn+LeaMQgVw8vjN355LSHnAg+b4Q6BK3eTKiZ69gwyrvXi4bFbayH/Ja0rVIQP94Ds6n kbwdqeCNFXtwY4tDBYMpg3TwcGQyJ+kWB2q20= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ZLOYy0j77u3BThkOCn0G1r1w0BvJgOqcuiH2LptPILcu6sx03r0dapBBoU9pCktvIy 8yhNvbFZPOwXCzrfJAYJc5b5tUlSCLWRc4GXThucvKz38PMudJd8e7/WzW7MQRYOsCa/ WSQuFaBVjeNAOMWdwamqQ7NS1x5iDiXLvdZok= MIME-Version: 1.0 Received: by 10.216.185.202 with SMTP id u52mr3019487wem.46.1275199020278; Sat, 29 May 2010 22:57:00 -0700 (PDT) Received: by 10.216.188.139 with HTTP; Sat, 29 May 2010 22:57:00 -0700 (PDT) In-Reply-To: <871vcuck79.fsf@gnu.org> References: <871vcuck79.fsf@gnu.org> Date: Sun, 30 May 2010 06:57:00 +0100 Message-ID: Subject: Re: bug#6304: 23.2; advising yank From: Leo To: =?ISO-8859-1?Q?Johan_Bockg=E5rd?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 6304 Cc: 6304@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 30 May 2010 01:22, Johan Bockg=E5rd wrote: > The highlighting is removed by substitute-command-keys: > > =A0 =A0Returns original STRING if no substitutions were made. Otherwise, = a > =A0 =A0new string, without any text properties, is returned. That explains a lot. Looks like an oversight/bug on substitute-command-keys. The new additional doc-string from advice was added quite recently. Thanks. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 21 22:42:59 2011 Received: (at 6304) by debbugs.gnu.org; 22 Jan 2011 03:42:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PgUNP-0003GE-IC for submit@debbugs.gnu.org; Fri, 21 Jan 2011 22:42:59 -0500 Received: from mail-px0-f172.google.com ([209.85.212.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PgUNN-0003G1-6H for 6304@debbugs.gnu.org; Fri, 21 Jan 2011 22:42:57 -0500 Received: by pxi6 with SMTP id 6so435894pxi.3 for <6304@debbugs.gnu.org>; Fri, 21 Jan 2011 19:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:user-agent :mime-version:content-type; bh=dh6HTKpdPdUj1q9yPihzB0MPBc2zt6XPbiA5GHYVxL8=; b=VYW7NXR4UcmqT7suF00idLPWOvGMjgyJvO3ZQ+SBGdIOAv2GmGdmawjsT6MclzcyhE UAd5WU7ngwLqiBGLp0NxrDPVheYbWgbJn6vtVQz3mqmqfmFunCnijNQjTa6gyXz9CRjD AnBQ+/PrFwAKPWy4Kev8M7qgyHVf58CxQvbbI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:user-agent:mime-version :content-type; b=xVY5oN+GsYxoBA7tohn97/g1q9v59tzfZnaS+/PmHo7brpoNeFrp7N6uJSQ6AwMx9n /STyhy6T+y8JLkA1giQ6ExIwk3J3/wWMrwHtH/FO7wtxYgGBMThdf/mz5JcVhQYxt2Y2 0fZ5t5pZ20G4zJj7pjhpmM49FyuNr2cd4Iacw= Received: by 10.142.245.3 with SMTP id s3mr637030wfh.198.1295668252126; Fri, 21 Jan 2011 19:50:52 -0800 (PST) Received: from Victoria.local ([222.79.249.212]) by mx.google.com with ESMTPS id e14sm13575359wfg.8.2011.01.21.19.50.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 21 Jan 2011 19:50:50 -0800 (PST) From: Leo To: 6304@debbugs.gnu.org Subject: Re: 23.2; [PATCH] advising yank Date: Sat, 22 Jan 2011 11:50:37 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.91 (Mac OS X 10.6.6) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: 6304 Cc: Johan =?iso-8859-1?Q?Bockg=E5rd?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.6 (-) >From 238f221401cbdafe1df6634cbb69480e2748cced Mon Sep 17 00:00:00 2001 Date: Sat, 22 Jan 2011 11:40:15 +0800 Subject: [PATCH] Fix bug #6304 The text property in the documentation string may be removed by substitute-command-keys. --- lisp/emacs-lisp/advice.el | 4 +--- lisp/help-mode.el | 7 +++++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index 9267bc8a..02696d9e 100644 --- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -3007,9 +3007,7 @@ (defun ad-make-advised-docstring (function &optional style) (setq usage (if (null usage) t (setq origdoc (cdr usage)) (car usage))) (if origdoc (setq paragraphs (list origdoc))) (unless (eq style 'plain) - (push (propertize (concat "This " origtype " is advised.") - 'face 'font-lock-warning-face) - paragraphs)) + (push (concat "This " origtype " is advised.") paragraphs)) (ad-dolist (class ad-advice-classes) (ad-dolist (advice (ad-get-enabled-advices function class)) (setq advice-docstring diff --git a/lisp/help-mode.el b/lisp/help-mode.el index f115e425..14ff164e 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -302,6 +302,13 @@ (defun help-mode-finish () ;; View mode's read-only status of existing *Help* buffer is lost ;; by with-output-to-temp-buffer. (toggle-read-only 1) + (save-excursion + (goto-char (point-min)) + (let ((inhibit-read-only t)) + (when (re-search-forward "^This \\w+ is advised.$" nil t) + (put-text-property (match-beginning 0) + (match-end 0) + 'face 'font-lock-warning-face)))) (help-make-xrefs (current-buffer)))) ;; Grokking cross-reference information in doc strings and -- 1.7.4.rc1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 16:34:13 2011 Received: (at 6304) by debbugs.gnu.org; 28 Jan 2011 21:34:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PivxN-0004MJ-E7 for submit@debbugs.gnu.org; Fri, 28 Jan 2011 16:34:13 -0500 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PivxH-0004M3-II for 6304@debbugs.gnu.org; Fri, 28 Jan 2011 16:34:11 -0500 Received: from furball (dhcp128036014130.central.yale.edu [128.36.14.130]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p0SLgKNH032024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 28 Jan 2011 16:42:20 -0500 Received: by furball (Postfix, from userid 1000) id C3E561602C5; Fri, 28 Jan 2011 16:42:21 -0500 (EST) From: Chong Yidong To: Leo Subject: Re: bug#6304: 23.2; [PATCH] advising yank References: Date: Fri, 28 Jan 2011 16:42:21 -0500 In-Reply-To: (Leo's message of "Sat, 22 Jan 2011 11:50:37 +0800") Message-ID: <877hdo903m.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6304 Cc: 6304@debbugs.gnu.org, Johan =?utf-8?Q?Bockg=C3=A5rd?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Leo writes: > From 238f221401cbdafe1df6634cbb69480e2748cced Mon Sep 17 00:00:00 2001 > Date: Sat, 22 Jan 2011 11:40:15 +0800 > Subject: [PATCH] Fix bug #6304 > > The text property in the documentation string may be removed by > substitute-command-keys. Committed, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 16:34:20 2011 Received: (at control) by debbugs.gnu.org; 28 Jan 2011 21:34:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PivxU-0004Me-Ol for submit@debbugs.gnu.org; Fri, 28 Jan 2011 16:34:20 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PivxT-0004MO-2Y for control@debbugs.gnu.org; Fri, 28 Jan 2011 16:34:19 -0500 Received: from furball (dhcp128036014130.central.yale.edu [128.36.14.130]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p0SLgWUi019363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 28 Jan 2011 16:42:32 -0500 Received: by furball (Postfix, from userid 1000) id 78AB31602C5; Fri, 28 Jan 2011 16:42:33 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 6304 Date: Fri, 28 Jan 2011 16:42:33 -0500 Message-ID: <87fwsczovq.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 6304 thanks From unknown Fri Jun 20 07:11:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Feb 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator