GNU bug report logs - #63021
[PATCH] gnu: Add diffpdf.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63021 in the body.
You can then email your comments to 63021 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: guix-patches <at> gnu.org
Cc: Olivier Dion <olivier.dion <at> polymtl.ca>
Subject: [PATCH] gnu: Add diffpdf.
Date: Sat, 22 Apr 2023 12:57:10 -0400

* gnu/packages/pdf.scm (diffpdf): New variable.
---
 gnu/packages/pdf.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 17637af0f6..357fed0a61 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -78,6 +78,7 @@ (define-module (gnu packages pdf)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
   #:use-module (gnu packages javascript)
+  #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages lesstif)
   #:use-module (gnu packages libffi)
   #:use-module (gnu packages linux)
@@ -165,6 +166,38 @@ (define-public a4pdf
 convert data in any way.")
     (license license:asl2.0)))
 
+(define-public diffpdf
+  (let ((commit "ba68231d3d05e0cb3a2d4a4fca8b70d4044f4303"))
+    (package
+      (name "diffpdf")
+      (version "2.1.2")
+      (source
+       (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/eang/diffpdf")
+             (commit commit)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1vwgv28b291lrcs9fljnlbnicv16lwj4vvl4bz6w3ldp9n5isjmf"))))
+      (build-system cmake-build-system)
+      (arguments
+       `(#:tests? #f))
+      (inputs
+       (list
+        extra-cmake-modules
+        qtbase-5
+        qttools-5
+        poppler-qt5))
+      (native-inputs
+       (list pkg-config))
+      (home-page "http://www.qtrac.eu/diffpdf-foss.html")
+      (synopsis "Compare two PDF files")
+      (description
+       "@command{diffpdf} offers three comparison modes: Words, Characters,
+and Appearance.")
+      (license license:gpl2))))
+
 (define-public extractpdfmark
   (package
     (name "extractpdfmark")
-- 
2.39.2

Message #10 received at 63021-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Olivier Dion <olivier.dion <at> polymtl.ca>
Cc: 63021-done <at> debbugs.gnu.org
Subject: Re: bug#63021: [PATCH] gnu: Add diffpdf.
Date: Sun, 30 Apr 2023 22:46:33 +0200

[Message part 1 (text/plain, inline)]

Hi,

Olivier Dion <olivier.dion <at> polymtl.ca> skribis:

> * gnu/packages/pdf.scm (diffpdf): New variable.

Applied with the changes below: addressing ‘guix lint’ warnings, using a
version string that matches the latest tag, and passing it through ‘guix
style’.

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 6eea3c68d0..ddac5537f0 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -168,35 +168,30 @@ (define-public a4pdf
     (license license:asl2.0)))
 
 (define-public diffpdf
-  (let ((commit "ba68231d3d05e0cb3a2d4a4fca8b70d4044f4303"))
+  (let ((commit "ba68231d3d05e0cb3a2d4a4fca8b70d4044f4303")
+        (revision "1"))
     (package
       (name "diffpdf")
-      (version "2.1.2")
-      (source
-       (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://gitlab.com/eang/diffpdf")
-             (commit commit)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "1vwgv28b291lrcs9fljnlbnicv16lwj4vvl4bz6w3ldp9n5isjmf"))))
+      (version (git-version "2.1.3.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://gitlab.com/eang/diffpdf")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1vwgv28b291lrcs9fljnlbnicv16lwj4vvl4bz6w3ldp9n5isjmf"))))
       (build-system cmake-build-system)
       (arguments
        `(#:tests? #f))
-      (inputs
-       (list
-        extra-cmake-modules
-        qtbase-5
-        qttools-5
-        poppler-qt5))
-      (native-inputs
-       (list pkg-config))
+      (inputs (list qtbase-5 qttools-5 poppler-qt5))
+      (native-inputs (list pkg-config extra-cmake-modules))
       (home-page "http://www.qtrac.eu/diffpdf-foss.html")
       (synopsis "Compare two PDF files")
       (description
-       "@command{diffpdf} offers three comparison modes: Words, Characters,
-and Appearance.")
+       "@command{diffpdf} lets you compare PDF files, offering three
+comparison modes: words, characters, and appearance.")
       (license license:gpl2))))
 
 (define-public extractpdfmark

Message #13 received at 63021-done <at> debbugs.gnu.org (full text, mbox):

From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 63021-done <at> debbugs.gnu.org
Subject: Re: bug#63021: [PATCH] gnu: Add diffpdf.
Date: Sun, 30 Apr 2023 17:20:24 -0400

On Sun, 30 Apr 2023, Ludovic Courtès <ludo <at> gnu.org> wrote:
> Hi,
>
> Olivier Dion <olivier.dion <at> polymtl.ca> skribis:
>
>> * gnu/packages/pdf.scm (diffpdf): New variable.
>
> Applied with the changes below: addressing ‘guix lint’ warnings, using a
> version string that matches the latest tag, and passing it through ‘guix
> style’.

Thanks!  Sorry for the inconveniences!

-- 
Olivier Dion
oldiob.dev

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.