Subject: [bug#63015] [PATCH] gnu: Add emacs-gemini.

From: Nicolas Goaziou <[email-masked]>
Date: Sat, 22 Apr 2023 16:50:01 +0200

Hello,

Evgeny Pisemsky <[email-masked]> writes:

> From 7c2de9e0137927140df056f20cb8de635c8aa4ce Mon Sep 17 00:00:00 2001
> From: Evgeny Pisemsky <[email-masked]>
> Date: Sat, 22 Apr 2023 15:00:00 +0300
> Subject: [PATCH] gnu: Add emacs-gemini.
>
> * gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.

Thank you. Some comments follow.

> +(define-public emacs-gemini
> +  (let ((version "1.2.0")
> +        (revision "0")
> +        (commit "a7dd7c6ea4e036d0d5ecc4a5d284874c400f10ba"))

This particular commit you're using is actually a version bump. Since
upstream does not tag such bumps, I suggest to make it the exact "1.2.0"
version, instead of "1.2.0-0.a7dd7c6".

IOW, you can drop revision binding, and version too.

> +    (package
> +      (name "emacs-gemini")
> +      (version (git-version version revision commit))

Here (version "1.2.0") is enough.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://git.carcosa.net/jmcbray/gemini.el.git")

Nitpick: I suggest to drop the ".git" suffix for consistency with other
packages.

> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1pvlk56mhh4xh4gwzqldfk79jsjbcpivv5scd9811pv3afc30gsx"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://git.carcosa.net/jmcbray/gemini.el")
> +      (synopsis "Syntax highlighting for text/gemini")
> +      (description
> +       "This is a very simple syntax-highlighting mode for text/gemini documents.
> +Currently, support is not complete, but it should be enough to help with basic
> +documents.")
> +      (license license:agpl3+))))

Otherwise LGTM.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou