GNU bug report logs - #63015
[PATCH] gnu: Add emacs-gemini.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63015 in the body.
You can then email your comments to 63015 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-gemini.
Date: Sat, 22 Apr 2023 15:45:15 +0300

[0001-gnu-Add-emacs-gemini.patch (text/x-patch, attachment)]

From 7c2de9e0137927140df056f20cb8de635c8aa4ce Mon Sep 17 00:00:00 2001
From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Date: Sat, 22 Apr 2023 15:00:00 +0300
Subject: [PATCH] gnu: Add emacs-gemini.

* gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b9bece1365..b76099d81d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -126,6 +126,7 @@
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew <at> trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d <at> delgado.nrw>
 ;;; Copyright © 2023 Juliana Sims <juli <at> incana.org>
+;;; Copyright © 2023 Evgeny Pisemsky <evgeny <at> pisemsky.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -31367,6 +31368,31 @@ (define-public emacs-elpher
 connections using TLS encryption.")
     (license license:gpl3+)))
 
+(define-public emacs-gemini
+  (let ((version "1.2.0")
+        (revision "0")
+        (commit "a7dd7c6ea4e036d0d5ecc4a5d284874c400f10ba"))
+    (package
+      (name "emacs-gemini")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.carcosa.net/jmcbray/gemini.el.git")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1pvlk56mhh4xh4gwzqldfk79jsjbcpivv5scd9811pv3afc30gsx"))))
+      (build-system emacs-build-system)
+      (home-page "https://git.carcosa.net/jmcbray/gemini.el")
+      (synopsis "Syntax highlighting for text/gemini")
+      (description
+       "This is a very simple syntax-highlighting mode for text/gemini documents.
+Currently, support is not complete, but it should be enough to help with basic
+documents.")
+      (license license:agpl3+))))
+
 (define-public emacs-zerodark-theme
   (package
     (name "emacs-zerodark-theme")

base-commit: 5b545763ed9b8a3fade7f756d543819fc090953f
-- 
2.39.2

Message #8 received at 63015 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Cc: 63015 <at> debbugs.gnu.org
Subject: Re: [bug#63015] [PATCH] gnu: Add emacs-gemini.
Date: Sat, 22 Apr 2023 16:50:01 +0200

Hello,

Evgeny Pisemsky <evgeny <at> pisemsky.com> writes:

> From 7c2de9e0137927140df056f20cb8de635c8aa4ce Mon Sep 17 00:00:00 2001
> From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
> Date: Sat, 22 Apr 2023 15:00:00 +0300
> Subject: [PATCH] gnu: Add emacs-gemini.
>
> * gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.

Thank you. Some comments follow.

> +(define-public emacs-gemini
> +  (let ((version "1.2.0")
> +        (revision "0")
> +        (commit "a7dd7c6ea4e036d0d5ecc4a5d284874c400f10ba"))

This particular commit you're using is actually a version bump. Since
upstream does not tag such bumps, I suggest to make it the exact "1.2.0"
version, instead of "1.2.0-0.a7dd7c6".

IOW, you can drop revision binding, and version too.

> +    (package
> +      (name "emacs-gemini")
> +      (version (git-version version revision commit))

Here (version "1.2.0") is enough.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://git.carcosa.net/jmcbray/gemini.el.git")

Nitpick: I suggest to drop the ".git" suffix for consistency with other
packages.

> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1pvlk56mhh4xh4gwzqldfk79jsjbcpivv5scd9811pv3afc30gsx"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://git.carcosa.net/jmcbray/gemini.el")
> +      (synopsis "Syntax highlighting for text/gemini")
> +      (description
> +       "This is a very simple syntax-highlighting mode for text/gemini documents.
> +Currently, support is not complete, but it should be enough to help with basic
> +documents.")
> +      (license license:agpl3+))))

Otherwise LGTM.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 63015 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 63015 <at> debbugs.gnu.org
Subject: Re: [bug#63015] [PATCH] gnu: Add emacs-gemini.
Date: Sat, 22 Apr 2023 18:18:49 +0300

[Message part 1 (text/plain, inline)]

Hello!

Here is the updated patch.

[0001-gnu-Add-emacs-gemini.patch (text/x-patch, attachment)]

Message #16 received at 63015-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Cc: 63015-done <at> debbugs.gnu.org
Subject: Re: [bug#63015] [PATCH] gnu: Add emacs-gemini.
Date: Sun, 23 Apr 2023 17:10:05 +0200

Hello,

Evgeny Pisemsky <evgeny <at> pisemsky.com> writes:

> Hello!
>
> Here is the updated patch.

[...]

> Subject: [PATCH] gnu: Add emacs-gemini.
>
> * gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.

Perfect! Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.