Subject: bug#6300: browse-url-encode need to encode more

From: Lennart Borgman <[email-masked]>
Date: Sat, 29 May 2010 13:29:21 +0200

The character ?" needs to be escaped at least on w32 because otherwise
ShellExecute will not work. Maybe this part of the patch should be
platform specific, I do not know.

Both Google Chrome and Firefox still thinks that it is good manner to
also escape blanks as ?+.

I suggest the following patch (this is agains a checkout from 2010-05-22):

=== modified file 'lisp/net/browse-url.el'
--- trunk/lisp/net/browse-url.el	2010-04-29 14:04:33 +0000
+++ patched/lisp/net/browse-url.el	2010-05-29 10:52:33 +0000
@@ -634,7 +634,8 @@
   ;; FIXME: Is there an actual example of a web browser getting
   ;; confused?  (This used to encode commas, but at least Firefox
   ;; handles commas correctly and doesn't accept encoded commas.)
-  (browse-url-url-encode-chars url "[)$]"))
+  (replace-regexp-in-string " " "+"
+                            (browse-url-url-encode-chars url "[\"()$]")))