Subject: bug#62994: [PATCH v5] Add support for colored and styled underlines on tty frames

From: Mohsin Kaleem <[email-masked]>
Date: Sun, 10 Mar 2024 18:10:13 +0000

Jim Porter <[email-masked]> writes:

> On 2/11/2024 10:05 AM, [email-masked] wrote:
>> @@ -7229,6 +7343,9 @@ syms_of_xfaces (void)
>>     DEFSYM (QCposition, ":position");
>>     DEFSYM (Qline, "line");
>>     DEFSYM (Qwave, "wave");
>> +  DEFSYM (Qdouble, "double");
>> +  DEFSYM (Qdotted, "dotted");
>> +  DEFSYM (Qdashed, "dashed");
>>     DEFSYM (Qreleased_button, "released-button");
>>     DEFSYM (Qpressed_button, "pressed-button");
>>     DEFSYM (Qflat_button, "flat-button");
>
> This is very minor, but for consistency with the existing styles ("line" 
> and "wave"), maybe we should use a noun form for the new styles. For 
> example "dots", "dashes", and maybe "double-line"? That would hopefully 
> be easier for programmers to remember, and leaves the door open for some 
> other kind of doubled underline in the future too (e.g. a double wave).

The current names were just what kitty decided to call the related
underline styles [1] but no reason to stick to that. I'll update as
suggested. Just to clarify wave will stay wave (instead of wavy) but the
remaining will be converted to nouns.

[1]: https://sw.kovidgoyal.net/kitty/underlines/

-- 
Mohsin Kaleem