Subject: Re: [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus

From: Nicolas Goaziou <[email-masked]>
Date: Fri, 21 Apr 2023 16:05:44 +0200

Hello,

kyle <[email-masked]> writes:

> +(define-public emacs-bookmark-plus
> +  (package
> +   (name "emacs-bookmark-plus")
> +   (version "2022.11.05")
> +   (source
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +	    (url "https://github.com/emacsmirror/bookmark-plus")
> +	    (commit "3db369056a722c42b3eafd10a91831f87d056dfa")))
> +      (sha256
> +       (base32
> +	"0fnq24f597zfr8jj5h3vr87kdil5lhy11m81q6ayqc03qm0jymrf"))))

Nitpick: indentation is a bit off here.

> +   (build-system emacs-build-system)
> +   (home-page "https://github.com/emacsmirror/bookmark-plus")
> +   (synopsis "Extensions to the bookmark.el library in Emacs")

Nitpick: Bookmark (the library) instead of "bookmark.el" (the file).

> +   (description
> +    "Bookmarks are a powerful Emacs feature. This package makes them even more
> +versatile. You can bookmark many more kinds of data. You can add tags. There
> +are many more ways to organize and display your bookmarks. I recommend reading
> +the extensive documentation about BookmarkPlus on the Emacs Wiki.")

Guix usually puts two spaces between sentences.

> +   (license license:gpl3)))

License is actually GPL3+.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou