GNU bug report logs - #62993
[PATCH] gnu: Add emacs-bookmark-plus

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62993 in the body.
You can then email your comments to 62993 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kyle <kyle <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kyle Andrews <kyle <at> posteo.net>
Subject: [PATCH] gnu: Add emacs-bookmark-plus
Date: Fri, 21 Apr 2023 13:14:40 +0000

From: Kyle Andrews <kyle <at> posteo.net>

---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6618aac332..6522012cdd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -349,6 +349,29 @@ (define-public emacs-ace-jump-helm-line
        "This package allows using Ace jump to a candidate in Helm window.")
       (license license:gpl3+))))
 
+(define-public emacs-bookmark-plus
+  (package
+   (name "emacs-bookmark-plus")
+   (version "2022.11.05")
+   (source
+    (origin
+      (method git-fetch)
+      (uri (git-reference
+	    (url "https://github.com/emacsmirror/bookmark-plus")
+	    (commit "3db369056a722c42b3eafd10a91831f87d056dfa")))
+      (sha256
+       (base32
+	"0fnq24f597zfr8jj5h3vr87kdil5lhy11m81q6ayqc03qm0jymrf"))))
+   (build-system emacs-build-system)
+   (home-page "https://github.com/emacsmirror/bookmark-plus")
+   (synopsis "Extensions to the bookmark.el library in Emacs")
+   (description
+    "Bookmarks are a powerful Emacs feature. This package makes them even more
+versatile. You can bookmark many more kinds of data. You can add tags. There
+are many more ways to organize and display your bookmarks. I recommend reading
+the extensive documentation about BookmarkPlus on the Emacs Wiki.")
+   (license license:gpl3)))
+
 (define-public emacs-cfrs
   (package
     (name "emacs-cfrs")
-- 
2.39.2

Message #8 received at 62993 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: kyle <kyle <at> posteo.net>
Cc: 62993 <at> debbugs.gnu.org
Subject: Re: [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus
Date: Fri, 21 Apr 2023 16:05:44 +0200

Hello,

kyle <kyle <at> posteo.net> writes:

> +(define-public emacs-bookmark-plus
> +  (package
> +   (name "emacs-bookmark-plus")
> +   (version "2022.11.05")
> +   (source
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +	    (url "https://github.com/emacsmirror/bookmark-plus")
> +	    (commit "3db369056a722c42b3eafd10a91831f87d056dfa")))
> +      (sha256
> +       (base32
> +	"0fnq24f597zfr8jj5h3vr87kdil5lhy11m81q6ayqc03qm0jymrf"))))

Nitpick: indentation is a bit off here.

> +   (build-system emacs-build-system)
> +   (home-page "https://github.com/emacsmirror/bookmark-plus")
> +   (synopsis "Extensions to the bookmark.el library in Emacs")

Nitpick: Bookmark (the library) instead of "bookmark.el" (the file).

> +   (description
> +    "Bookmarks are a powerful Emacs feature. This package makes them even more
> +versatile. You can bookmark many more kinds of data. You can add tags. There
> +are many more ways to organize and display your bookmarks. I recommend reading
> +the extensive documentation about BookmarkPlus on the Emacs Wiki.")

Guix usually puts two spaces between sentences.

> +   (license license:gpl3)))

License is actually GPL3+.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

Message #11 received at 62993 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: kyle <kyle <at> posteo.net>
Cc: 62993 <at> debbugs.gnu.org
Subject: Re: [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus
Date: Fri, 21 Apr 2023 16:09:26 +0200

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Otherwise, LGTM.

And thanks for the patch, of course!

Message #14 received at 62993 <at> debbugs.gnu.org (full text, mbox):

From: kyle <kyle <at> posteo.net>
To: 62993 <at> debbugs.gnu.org
Cc: Kyle Andrews <kyle <at> posteo.net>
Subject: [PATCH v2] gnu: Add emacs-bookmark-plus
Date: Fri, 21 Apr 2023 22:00:43 +0000

From: Kyle Andrews <kyle <at> posteo.net>

---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6618aac332..ff2bbf0bd7 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -349,6 +349,29 @@ (define-public emacs-ace-jump-helm-line
        "This package allows using Ace jump to a candidate in Helm window.")
       (license license:gpl3+))))
 
+(define-public emacs-bookmark-plus
+  (package
+    (name "emacs-bookmark-plus")
+    (version "2022.11.05")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+	     (url "https://github.com/emacsmirror/bookmark-plus")
+	     (commit "3db369056a722c42b3eafd10a91831f87d056dfa")))
+       (sha256
+        (base32
+	 "0fnq24f597zfr8jj5h3vr87kdil5lhy11m81q6ayqc03qm0jymrf"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/emacsmirror/bookmark-plus")
+    (synopsis "Extensions to the Bookmark library in Emacs")
+    (description
+     "Bookmarks are a powerful Emacs feature.  This package makes them even
+more versatile. You can bookmark many more kinds of data.  You can add tags.
+There are many more ways to organize and display your bookmarks.  I recommend
+reading the extensive documentation about BookmarkPlus on the Emacs Wiki.")
+    (license license:gpl3+)))
+
 (define-public emacs-cfrs
   (package
     (name "emacs-cfrs")
-- 
2.39.2

Message #19 received at 62993-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: kyle <kyle <at> posteo.net>
Cc: 62993-done <at> debbugs.gnu.org
Subject: Re: [bug#62993] [PATCH v2] gnu: Add emacs-bookmark-plus
Date: Sat, 22 Apr 2023 12:09:20 +0200

Hello,

kyle <kyle <at> posteo.net> writes:

> +(define-public emacs-bookmark-plus

I normalized the commit message and applied your patch. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.