GNU bug report logs - #62967
[PATCH core-updates 1/2] gnu: lz4: Remove valgrind from native-inputs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: zimoun <zimon.toutoune <at> gmail.com>
Subject: bug#62967: closed (Re: [PATCH core-updates 2/2] gnu: valgrind:
 Update to 3.20.0.)
Date: Wed, 26 Apr 2023 12:32:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#62967: [PATCH core-updates 1/2] gnu: lz4: Remove valgrind from native-inputs.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 62967 <at> debbugs.gnu.org.

-- 
62967: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62967
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andreas Enge <andreas <at> enge.fr>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 62967-done <at> debbugs.gnu.org
Subject: Re: [PATCH core-updates 2/2] gnu: valgrind: Update to 3.20.0.
Date: Wed, 26 Apr 2023 14:31:26 +0200

And without a button to compare with current master, it is difficult to
judge. But r-minimal has built, as well as lots of R packages; I checked
a few missing ones, for which indeed a different input (not related to
valgrind) fails. KDE packages also do not build due to a test failure in
kpimcommon, which also appears on master.

So I am going to push.

Andreas

[Message part 3 (message/rfc822, inline)]

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH core-updates 1/2] gnu: lz4: Remove valgrind from native-inputs.
Date: Thu, 20 Apr 2023 15:17:14 +0200

* gnu/compression.scm (lz4)[native-inputs]: Remove valgrind.
[arguments]<phases>: Remove trailing #t.
---
 gnu/packages/compression.scm | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 7283a05050..8a8b94c07b 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -840,11 +840,7 @@ (define-public lz4
     (build-system gnu-build-system)
     (outputs (list "out" "static"))
     (native-inputs
-     (append
-       (list python)    ;; For tests.
-       (if (member (%current-system) (package-supported-systems valgrind))
-         (list valgrind)
-         '())))
+     (list python)) ;; For tests.
     (arguments
      `(;; Not designed for parallel testing.
        ;; See https://github.com/lz4/lz4/issues/957#issuecomment-737419821
@@ -860,16 +856,14 @@ (define-public lz4
              (substitute* "tests/Makefile"
                ;; This fails when $prefix is not a single top-level directory.
                (("^test: (.*) test-install" _ targets)
-                (string-append "test: " targets)))
-             #t))
+                (string-append "test: " targets)))))
          (add-after 'install 'move-static-library
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out"))
                    (static (assoc-ref outputs "static")))
                (mkdir-p (string-append static "/lib"))
                (rename-file (string-append out "/lib/liblz4.a")
-                            (string-append static "/lib/liblz4.a"))
-               #t))))))
+                            (string-append static "/lib/liblz4.a"))))))))
     (home-page "https://www.lz4.org")
     (synopsis "Compression algorithm focused on speed")
     (description "LZ4 is a lossless compression algorithm, providing

base-commit: c0ac055918ec1eee53c7e14f62c2e3516321588b
-- 
2.38.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.