GNU bug report logs - #62947
30.0.50; ERC 5.6: Improve partitioning of outgoing messages

Previous Next

Full log

Message #20 received at 62947 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 62947 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#62947: 30.0.50; ERC 5.6: Improve partitioning of outgoing
 messages
Date: Wed, 06 Dec 2023 23:19:18 -0800

[Message part 1 (text/plain, inline)]

This fix introduced an innocuous though technically breaking change in
the definition of `erc-input' (the struct). Basically, it added a new
slot, `refoldp', to allow users access to something resembling the
pre-5.6 behavior, where protocol-oriented message splitting would take
place after `erc-pre-send-functions' ran. That is, setting the slot to t
is meant to buy you some of that old functionality in the form of a
second split. (The new behavior of only splitting beforehand favors
interactive client users over bot/module authors.)

However, reflecting back on this, I think it wouldn't kill us to account
for the unlikely possibility of someone "subclassing" `erc-input' for
use outside this hook. In most cases, I believe simply recompiling their
dependent libraries would solve the issue, but why chance it if we don't
have to? Hence the attached change, which removes the slot but "spoofs"
its would-be accessor, `erc-input-refoldp', while the hook runs. I
originally went with a name that differed from that of the would-be
accessor, but this feature has been on HEAD for a while, so keeping it
seemed the less disruptive option.

[0006-5.6-Make-erc-input-s-refoldp-slot-conditionally-avai.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.