Subject: [bug#62921] [PATCH] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode.

From: Nicolas Goaziou <[email-masked]>
Date: Tue, 18 Apr 2023 15:29:52 +0200

Hello,

Juliana Sims <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-gerbil-mode): Add
> emacs-gerbil-mode.

Thank you. Some comments follow.

> +(define-public emacs-gerbil-mode
> +  (package
> +    (name "emacs-gerbil-mode")
> +    (version "0.17.0")

Note: according to "gerbil-mode.el", the version is actually "1.0".
However, I understand that the file is "tagged" as 0.17.0 as a part of
the whole Gerbil package.

Maybe the whole package should inherit from `gerbil' package so version,
source, home-page and license are already set in the parent. WDYT?

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/vyzo/gerbil")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0c0nspm659ybgmqlppdv7sxzll4hwkvcp9qmcsip6d0kz0p8r9c3"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     (list #:phases
> +           #~(modify-phases %standard-phases
> +               (add-before 'install 'change-directory
> +                 (lambda _
> +                   (chdir "etc"))))))
> +    (home-page "https://github.com/vyzo/gervil")

Typo: gervil -> gerbil

> +    (synopsis "Emacs major-mode for editing Gerbil code")
> +    (description
> +     "Gerbil mode provides font-lock, indentation, navigation, and REPL for
> +Gerbil code within Emacs.")
> +    (license (list license:lgpl2.1 license:asl2.0))))

First license is lgpl2.1+. You should also mention in a comment that one
can choose either.

Regards,
-- 
Nicolas Goaziou