GNU bug report logs - #62921
[PATCH] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62921 in the body.
You can then email your comments to 62921 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juliana Sims <juli <at> incana.org>
To: guix-patches <at> gnu.org
Cc: Juliana Sims <juli <at> incana.org>
Subject: [PATCH] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode.
Date: Mon, 17 Apr 2023 23:37:54 -0400

* gnu/packages/emacs-xyz.scm (emacs-gerbil-mode): Add emacs-gerbil-mode.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c1748e7f36..185dde1672 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -125,6 +125,7 @@
 ;;; Copyright © 2022 Demis Balbach <db <at> minikn.xyz>
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew <at> trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d <at> delgado.nrw>
+;;; Copyright © 2023 Juliana Sims <juli <at> incana.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -35994,6 +35995,33 @@ (define-public emacs-fennel-mode
 Fennel code within Emacs.")
       (license license:gpl3+))))
 
+(define-public emacs-gerbil-mode
+  (package
+    (name "emacs-gerbil-mode")
+    (version "0.17.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/vyzo/gerbil")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0c0nspm659ybgmqlppdv7sxzll4hwkvcp9qmcsip6d0kz0p8r9c3"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-before 'install 'change-directory
+                 (lambda _
+                   (chdir "etc"))))))
+    (home-page "https://github.com/vyzo/gervil")
+    (synopsis "Emacs major-mode for editing Gerbil code")
+    (description
+     "Gerbil mode provides font-lock, indentation, navigation, and REPL for
+Gerbil code within Emacs.")
+    (license (list license:lgpl2.1 license:asl2.0))))
+
 (define-public emacs-org-modern
   (package
    (name "emacs-org-modern")

base-commit: 774a6fb12c884766856c86c00adaa8f2a1d42508
-- 
2.39.2

Message #8 received at 62921 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Juliana Sims <juli <at> incana.org>
Cc: 62921 <at> debbugs.gnu.org, liliana.prikler <at> gmail.com
Subject: Re: [bug#62921] [PATCH] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode.
Date: Tue, 18 Apr 2023 15:29:52 +0200

Hello,

Juliana Sims <juli <at> incana.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-gerbil-mode): Add
> emacs-gerbil-mode.

Thank you. Some comments follow.

> +(define-public emacs-gerbil-mode
> +  (package
> +    (name "emacs-gerbil-mode")
> +    (version "0.17.0")

Note: according to "gerbil-mode.el", the version is actually "1.0".
However, I understand that the file is "tagged" as 0.17.0 as a part of
the whole Gerbil package.

Maybe the whole package should inherit from `gerbil' package so version,
source, home-page and license are already set in the parent. WDYT?

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/vyzo/gerbil")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0c0nspm659ybgmqlppdv7sxzll4hwkvcp9qmcsip6d0kz0p8r9c3"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     (list #:phases
> +           #~(modify-phases %standard-phases
> +               (add-before 'install 'change-directory
> +                 (lambda _
> +                   (chdir "etc"))))))
> +    (home-page "https://github.com/vyzo/gervil")

Typo: gervil -> gerbil

> +    (synopsis "Emacs major-mode for editing Gerbil code")
> +    (description
> +     "Gerbil mode provides font-lock, indentation, navigation, and REPL for
> +Gerbil code within Emacs.")
> +    (license (list license:lgpl2.1 license:asl2.0))))

First license is lgpl2.1+. You should also mention in a comment that one
can choose either.

Regards,
-- 
Nicolas Goaziou

Message #11 received at 62921 <at> debbugs.gnu.org (full text, mbox):

From: Juliana Sims <juli <at> incana.org>
To: 62921 <at> debbugs.gnu.org
Cc: Juliana Sims <juli <at> incana.org>
Subject: [PATCH v2] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode.
Date: Tue, 18 Apr 2023 13:05:32 -0400

Hi,

> Maybe the whole package should inherit from `gerbil' package so version,
> source, home-page and license are already set in the parent. WDYT?

I think that's a great idea! This version of the patch does that and also
sets this package version to 1.0.

Thanks,
Juli

---------BEGIN-PATCH---------

* gnu/packages/emacs-xyz.scm (emacs-gerbil-mode): Add emacs-gerbil-mode.
---
 gnu/packages/emacs-xyz.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6618aac332..9699fa6f32 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -125,6 +125,7 @@
 ;;; Copyright © 2022 Demis Balbach <db <at> minikn.xyz>
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew <at> trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d <at> delgado.nrw>
+;;; Copyright © 2023 Juliana Sims <juli <at> incana.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -36015,6 +36016,22 @@ (define-public emacs-fennel-mode
 Fennel code within Emacs.")
       (license license:gpl3+))))
 
+(define-public emacs-gerbil-mode
+  (package
+    (inherit gerbil)
+    (name "emacs-gerbil-mode")
+    (version "1.0")
+    (build-system emacs-build-system)
+    (arguments
+     (list #:phases #~(modify-phases %standard-phases
+                        (add-before 'install 'change-directory
+                          (lambda _
+                            (chdir "etc"))))))
+    (synopsis "Emacs major-mode for editing Gerbil code")
+    (description
+     "Gerbil mode provides font-lock, indentation, navigation, and REPL for
+Gerbil code within Emacs.")))
+
 (define-public emacs-org-modern
   (package
    (name "emacs-org-modern")

base-commit: 286cdf0bc55a29d5a63f7191edde7ea4dbd8cf2a
-- 
2.39.2

Message #16 received at 62921-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Juliana Sims <juli <at> incana.org>
Cc: liliana.prikler <at> gmail.com, 62921-done <at> debbugs.gnu.org
Subject: Re: bug#62921: [PATCH] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode.
Date: Fri, 21 Apr 2023 17:02:02 +0200

Hi Juliana,

Juliana Sims <juli <at> incana.org> skribis:

>> Maybe the whole package should inherit from `gerbil' package so version,
>> source, home-page and license are already set in the parent. WDYT?
>
> I think that's a great idea! This version of the patch does that and also
> sets this package version to 1.0.

Applied!  Thank you & thanks Nicolas for reviewing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.