GNU bug report logs - #62918
[PATCH] gnu: schismtracker: Update to 20221201.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62918: closed ([PATCH] gnu: schismtracker: Update to 20221201.)
Date: Tue, 25 Apr 2023 09:30:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 25 Apr 2023 10:28:58 +0100
with message-id <87o7nc48ej.fsf <at> cbaines.net>
and subject line Re: [bug#62918] [PATCH] gnu: schismtracker: Update to 20221201.
has caused the debbugs.gnu.org bug report #62918,
regarding [PATCH] gnu: schismtracker: Update to 20221201.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62918: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62918
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Antero Mejr <antero <at> mailbox.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: schismtracker: Update to 20221201.
Date: Tue, 18 Apr 2023 01:39:31 +0000

* gnu/packages/music.scm (schismtracker): Update to 20221201.
[source]: Convert snippet to gexp.
[arguments]: Convert to gexp, add configure flags for FLAC and Wayland
support.
[inputs]: Remove libx11, libxext, and sdl; add flac and sdl2.
---
Tested working in XWayland and pure Wayland on a AMD64 pulseaudio system.

 gnu/packages/music.scm | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 0a66ece40a..3c0ebcfd82 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4127,7 +4127,7 @@ (define-public milkytracker
 (define-public schismtracker
   (package
     (name "schismtracker")
-    (version "20190805")
+    (version "20221201")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -4136,26 +4136,27 @@ (define-public schismtracker
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0qqps20vvn3rgpg8174bjrrm38gqcci2z5z4c1r1vhbccclahgsd"))
+                "11yy5zrdfvnwzwdwmc3s3lx1ymwiyp1si5mmv4h9qxipd9j96ijp"))
               (modules '((guix build utils)))
               (snippet
                ;; Remove use of __DATE__ and __TIME__ for reproducibility.
-               `(begin
-                  (substitute* "schism/version.c"
-                    (("Schism Tracker built %s %s.*$")
-                     (string-append "Schism Tracker version " ,version "\") ;")))
-              #t))))
+               #~(substitute* "schism/version.c"
+                   (("Schism Tracker built %s %s.*$")
+                    (string-append
+                     "Schism Tracker version " #$version "\") ;"))))))
     (build-system gnu-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-before 'configure 'link-libm
-           (lambda _ (setenv "LIBS" "-lm") #t)))))
+     (list #:configure-flags #~(list "--with-flac=yes" "--with-x11=no")
+           #:phases #~(modify-phases %standard-phases
+                        (add-before 'configure 'link-libm
+                          (lambda _
+                            (setenv "LIBS" "-lm"))))))
     (native-inputs
      (list autoconf automake python))
     (inputs
      (list alsa-lib ; for asound dependency
-           libx11 libxext sdl))
+           flac
+           sdl2))
     (home-page "https://schismtracker.org")
     (synopsis "Oldschool sample-based music composition tool")
     (description
-- 
2.39.2

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Antero Mejr <antero <at> mailbox.org>
Cc: 62918-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#62918] [PATCH] gnu: schismtracker: Update to 20221201.
Date: Tue, 25 Apr 2023 10:28:58 +0100

[Message part 4 (text/plain, inline)]

Antero Mejr via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/music.scm (schismtracker): Update to 20221201.
> [source]: Convert snippet to gexp.
> [arguments]: Convert to gexp, add configure flags for FLAC and Wayland
> support.
> [inputs]: Remove libx11, libxext, and sdl; add flac and sdl2.
> ---
> Tested working in XWayland and pure Wayland on a AMD64 pulseaudio system.
>
>  gnu/packages/music.scm | 25 +++++++++++++------------
>  1 file changed, 13 insertions(+), 12 deletions(-)

Sounds good to me, I've pushed this to master as
8a5b6d53829fb94018c4aba15fc5571a3231c9a4.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.