GNU bug report logs - #62906
[PATCH] gnu: python-pytest-trio: Disable tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62906 in the body.
You can then email your comments to 62906 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: python-pytest-trio: Disable tests.
Date: Mon, 17 Apr 2023 10:27:44 -0500

See the following GitHub issue on the project page:
https://github.com/python-trio/pytest-trio/issues/122

* gnu/packages/python-check.scm (python-pytest-trio)[arguments]: Disable
broken tests.
---

Hi,

pytest-trio currently causes guix pull to fail because the tests are broken.

I have diabled the tests and linked the associated issue from the project page detailing more.

all best,

jgart

 gnu/packages/python-check.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index 1046602800..613fa23a99 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -1095,7 +1095,9 @@ (define-public python-pytest-trio
         (base32 "0c8cqf9by2884riksrqymqfp2g1d2d798a2zalcw9hmf34c786y0"))))
     (build-system python-build-system)
     (arguments
-     `(#:phases
+     `(;; https://github.com/python-trio/pytest-trio/issues/122
+       #:tests? #f ; Tests are currently broken.
+       #:phases
        (modify-phases %standard-phases
          (replace 'check
            (lambda* (#:key tests? inputs outputs #:allow-other-keys)
-- 
2.39.2

Message #8 received at 62906 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Lars-Dominik Braun" <lars <at> 6xq.net>, 62906 <at> debbugs.gnu.org
Date: Mon, 17 Apr 2023 15:33:14 +0000

Hi,

I forgot to add that there is also an issue reporting the pytest-trio failure here by bdju:

https://issues.guix.gnu.org/62871

62906 fixes the problem by disabling the tests for pytest-trio.

all best,

jgart

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Re: [bug#62906]
Date: Mon, 17 Apr 2023 10:19:23 -0600

On 4/17/23 9:33 AM, jgart via Guix-patches via wrote:
> Hi,
> 
> I forgot to add that there is also an issue reporting the pytest-trio failure here by bdju:
> 
> https://issues.guix.gnu.org/62871
> 
> 62906 fixes the problem by disabling the tests for pytest-trio.
> 
> all best,
> 
> jgart

I'm also also running into this. I can confirm that it looks like the 
issue is upstream, and an issue is open for it.

+1 for disabling the tests (I don't have merge abilities).

Message #16 received at 62906-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 62906-done <at> debbugs.gnu.org
Subject: Re: bug#62906: [PATCH] gnu: python-pytest-trio: Disable tests.
Date: Mon, 17 Apr 2023 22:12:38 -0400

Hello,

jgart <jgart <at> dismail.de> writes:

> See the following GitHub issue on the project page:
> https://github.com/python-trio/pytest-trio/issues/122
>
> * gnu/packages/python-check.scm (python-pytest-trio)[arguments]: Disable
> broken tests.
> ---
>
> Hi,
>
> pytest-trio currently causes guix pull to fail because the tests are broken.
>
> I have diabled the tests and linked the associated issue from the project page detailing more.
>
> all best,

I don't understand how that was breaking 'guix pull' for you, it
shouldn't have played a role.  I suspect extra channels.

I've pushed an updated to 0.8.0, with two tests disable in commit
27a4bfbd07022ebabc352a419c7588fcfc881d88.  Closing!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.