GNU bug report logs - #62894
[PATCH core-updates 0/2] gnu: samba: Fix build on i686-linux.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: John Kehayias <john.kehayias <at> protonmail.com>
Subject: bug#62894: closed (Re: bug#62894: [PATCH core-updates 0/2] gnu:
 samba: Fix build on i686-linux.)
Date: Fri, 12 May 2023 20:11:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#62894: [PATCH core-updates 0/2] gnu: samba: Fix build on i686-linux.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 62894 <at> debbugs.gnu.org.

-- 
62894: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62894
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 62894-done <at> debbugs.gnu.org
Subject: Re: bug#62894: [PATCH core-updates 0/2] gnu: samba: Fix build on
 i686-linux.
Date: Fri, 12 May 2023 20:09:46 +0000

On Tue, Apr 18, 2023 at 12:35 PM, Maxim Cournoyer wrote:

> Hi,
>
> I pushed this to master, fixing the graft at the same time (it was not
> applied to 'samba').
>
> I'll look for core-updates later.

Thanks. Since applied/merged so we're all set.

John

[Message part 3 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH core-updates 0/2] gnu: samba: Fix build on i686-linux.
Date: Mon, 17 Apr 2023 04:23:49 +0000

Hi Guix,

Two patches here:

1. Fix samba building on i686-linux, as the selftest configure option requires python-cryptography, which relies on rust and thus won't work on i686 currently. So conditionally enable this flag and that native-input.

   The check here happens twice, better to have a let form for the whole package (or even reduce it to a "rust?" variable)? I went with the check we use for librsvg, but haven't checked on aarch64 if this does build. I did test that samba builds for x86_64 and i686-linux and this allows wine on x86_64 to build for me as well.

2. In doing this I noticed that samba is outdated and vulnerable to CVEs so I updated it in the next patch. I separately verified the download's signature, though samba's key is expired, so...

I didn't push this directly since I wasn't sure if there was a more elegant way to do this check and since I'm not certain on the rust architectures question.

A similar fix is needed on master I believe, but since the inheritance is flipped there I wasn't sure if this will just confuse the upcoming merge more. If the core-updates merge is happening soon we can wait? Or once this is good for core-updates I'll push the same fix to master.

Thanks!
John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.