GNU bug report logs - #62867
segfault in describe_vector

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62867: closed (segfault in describe_vector)
Date: Sun, 16 Apr 2023 05:54:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 16 Apr 2023 08:53:05 +0300
with message-id <83ttxgbcfy.fsf <at> gnu.org>
and subject line Re: bug#62867: segfault in describe_vector
has caused the debbugs.gnu.org bug report #62867,
regarding segfault in describe_vector
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62867: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62867
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Xinyang Chen <chenxy <at> mit.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: segfault in describe_vector
Date: Sat, 15 Apr 2023 08:07:07 -0400

[Message part 3 (text/plain, inline)]

to reproduce:

(package-initialize)
(require 'evil)
(setq testmap (make-sparse-keymap))
(define-key testmap (kbd "SPC") #'test)
(evil-define-key 'motion global-map (kbd "SPC") testmap)
(evil-mode)
(describe-keymap global-map)

This appears to be caused by keymap.c line 3313
SYMBOL_NAME (shadowed_by)
where shadowed_by don't have to be a symbol (In this case its a keymap)

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 62867-done <at> debbugs.gnu.org, chenxy <at> mit.edu
Subject: Re: bug#62867: segfault in describe_vector
Date: Sun, 16 Apr 2023 08:53:05 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Xinyang Chen <chenxy <at> mit.edu>,  62867 <at> debbugs.gnu.org
> Date: Sat, 15 Apr 2023 18:16:32 -0400
> 
> > Stefan, can we do better than the below?
> 
> The patch looks about right to me.
> 
> Only detail is that `shadowed_by` contains a binding, so it can be
> a keymap, but it can also be a lambda expression, or a keyboard macro,
> so we shouldn't say "shadowed by a keymap" but just "shadowed" (unless
> we go through the extra trouble of checking if it's a keymap, or if it's
> a ...).

Thanks, installed on the emacs-29 branch with that change, and closing
the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.