GNU bug report logs - #62864
30.0.50; Interactive forms that fail to provide required arguments

Previous Next

Full log

Message #8 received at 62864 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 62864 <at> debbugs.gnu.org
Subject: Re: bug#62864: 30.0.50;
 Interactive forms that fail to provide required arguments
Date: Sat, 06 May 2023 11:32:12 +0300

> Date: Sat, 15 Apr 2023 19:34:58 +0300
> From:  Eshel Yaron via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> I've noticed that dictionary.el defines some functions with an
> `interactive' form that doesn't provide their required arguments.
> 
> For example, `dictionary-new-search' must be called with at least one
> argument, but when called interactively it gets called with no
> arguments.  The other two such cases in dictionary.el are
> `dictionary-definition' and `dictionary-switch-tooltip-mode'.
> 
> IIUC, these "commands" are never actually called interactively, and it
> should be safe to simply drop the `interactive' form so they don't show
> up in `M-x dictionary- TAB'.
> 
> A quick scan of the lisp/ directory of emacs.git reveals a similar issue
> with the following function definitions:

Thanks, I've now fixed many of those on the master branch.  Notable
exceptions are Org files and those in the lisp/obsolete subdirectory.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.