From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Apr 2023 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 62845@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168150883415795 (code B ref -1); Fri, 14 Apr 2023 21:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Apr 2023 21:47:14 +0000 Received: from localhost ([127.0.0.1]:47842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnRGE-00046f-Am for submit@debbugs.gnu.org; Fri, 14 Apr 2023 17:47:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:48148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnRGC-00046Y-Cr for submit@debbugs.gnu.org; Fri, 14 Apr 2023 17:47:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnRGB-0005y1-WA for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 17:47:12 -0400 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnRGA-0000Iy-7o for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 17:47:11 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Pyqm83RZ5z1sBpv for ; Fri, 14 Apr 2023 23:47:04 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Pyqm82PFLz1qqlS for ; Fri, 14 Apr 2023 23:47:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id AEzbifzSLDXn for ; Fri, 14 Apr 2023 23:47:03 +0200 (CEST) X-Auth-Info: rdEuTWXJGeUP8Jsc1QVu/eSPNYPbo46/9M0hBB7SxKo524lasankGY9lpnEtn26Y Received: from igel.home (aftr-82-135-86-95.dynamic.mnet-online.de [82.135.86.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA for ; Fri, 14 Apr 2023 23:47:03 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 582C52C131E; Fri, 14 Apr 2023 23:47:03 +0200 (CEST) From: Andreas Schwab X-Yow: Thousands of days of civilians ... have produced a... feeling for the aesthetic modules -- Date: Fri, 14 Apr 2023 23:47:03 +0200 Message-ID: <87a5zauofc.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:a60:0:28:0:1:25:1; envelope-from=whitebox@nefkom.net; helo=mail-out.m-online.net X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) When the connection to the nntp server times out (if nntp-connection-timeout is non-nil) nntp-with-open-group-function kills the process buffer. But that is the current buffer at this point if called from nntp-finish-retrieve-group-infos, causing the latter function to try to read (and modify!) a random buffer that happend to be the LRU buffer at that point. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Apr 2023 06:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168154113230691 (code B ref 62845); Sat, 15 Apr 2023 06:46:01 +0000 Received: (at 62845) by debbugs.gnu.org; 15 Apr 2023 06:45:32 +0000 Received: from localhost ([127.0.0.1]:48143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnZfA-0007yw-2p for submit@debbugs.gnu.org; Sat, 15 Apr 2023 02:45:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnZf8-0007yi-OR for 62845@debbugs.gnu.org; Sat, 15 Apr 2023 02:45:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnZf2-00035A-JQ; Sat, 15 Apr 2023 02:45:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kTI+0e3G7hUx433bo6j82uIEFL2VDOivzx5+2r0nsZs=; b=gUNzatzJAY9H czXD7vuViMj9CmFNKjkB6G7S5DU157Rrvf/8D2tUKGK1MflULHL+lPTA2rYziGZ/DN2CMtbKSnH/w RZzwRSzU+GVYdQ26h2IQPzPuUTRoaP48kLGkb+Q5svx/TNci/5vVfrISLs7OBv1TYB7yCPDvAR5dy enzjIQ0/9khEc2blNxCR+09XDeGfHqRwBkRinJUr1XiVqGWAuskhVdlOpqUVL5OBKV/q5LJ8Z4vl2 oOWhfUZbXufwFoHvoSDz0uCzcTCTI53HhQ4frv0TASVQBe0AnStZMMtmxgh4R4QcXVy/wQDLWXfe1 QIUdKsfd7NgzNw5Vn8Gx/Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnZf0-0004r0-1y; Sat, 15 Apr 2023 02:45:24 -0400 Date: Sat, 15 Apr 2023 09:45:20 +0300 Message-Id: <83pm85ej9b.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87a5zauofc.fsf@igel.home> (message from Andreas Schwab on Fri, 14 Apr 2023 23:47:03 +0200) References: <87a5zauofc.fsf@igel.home> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andreas Schwab > Date: Fri, 14 Apr 2023 23:47:03 +0200 > > When the connection to the nntp server times out (if > nntp-connection-timeout is non-nil) nntp-with-open-group-function kills > the process buffer. But that is the current buffer at this point if > called from nntp-finish-retrieve-group-infos, causing the latter > function to try to read (and modify!) a random buffer that happend to be > the LRU buffer at that point. Thanks. If this is a recent regression, could you perhaps bisect to find the offending commit(s)? From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Apr 2023 23:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: eric@ericabrahamsen.net, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168255298221356 (code B ref 62845); Wed, 26 Apr 2023 23:50:02 +0000 Received: (at 62845) by debbugs.gnu.org; 26 Apr 2023 23:49:42 +0000 Received: from localhost ([127.0.0.1]:57207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1protK-0005YO-8X for submit@debbugs.gnu.org; Wed, 26 Apr 2023 19:49:42 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:37550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1protE-0005YB-MS for 62845@debbugs.gnu.org; Wed, 26 Apr 2023 19:49:41 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Q6Fvz3DfQz1r1Mk; Thu, 27 Apr 2023 01:49:35 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Q6Fvz1tvBz1qqlS; Thu, 27 Apr 2023 01:49:35 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id BSD9yNZxTxV8; Thu, 27 Apr 2023 01:49:34 +0200 (CEST) X-Auth-Info: tfuzUxGg7psVkrALvIaPXIKG61lZ3gD1MDvxKsAaaNWn2th0jTAnalhecRTUOJ1r Received: from igel.home (aftr-82-135-86-255.dynamic.mnet-online.de [82.135.86.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 27 Apr 2023 01:49:34 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 486532C12AB; Thu, 27 Apr 2023 01:49:34 +0200 (CEST) From: Andreas Schwab In-Reply-To: <83pm85ej9b.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Apr 2023 09:45:20 +0300") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> X-Yow: PUNK ROCK!! DISCO DUCK!! BIRTH CONTROL!! Date: Thu, 27 Apr 2023 01:49:34 +0200 Message-ID: <87edo619wx.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) commit 032969e8c65 "Don't have nntp-report signal an error" From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Apr 2023 03:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: Eli Zaretskii , 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168256494610886 (code B ref 62845); Thu, 27 Apr 2023 03:10:01 +0000 Received: (at 62845) by debbugs.gnu.org; 27 Apr 2023 03:09:06 +0000 Received: from localhost ([127.0.0.1]:57282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prs0I-0002pW-52 for submit@debbugs.gnu.org; Wed, 26 Apr 2023 23:09:06 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:39390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prs0E-0002or-Kb for 62845@debbugs.gnu.org; Wed, 26 Apr 2023 23:09:05 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 9B244FA096; Thu, 27 Apr 2023 03:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1682564934; bh=df0KGjDS1VbTMzo7CEmf8O35nqixZ7v8ARFC0PxVa24=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oJdrZF7vx47UYsKtpq9ZuBuF4ozNfL7mu/KXcclQ4aTQL578fmGSc7kLn9HZ5ae/2 AnAcqs6fXIwMpfKuC6IaJ6mQC2c2DpSpoTQtWjngF3IbQ+kdGnvSDTyvHQp62UVvmF g6V47uolnknwSGOji2gV9aHF15NB5cuMiwAdF/YE= From: Eric Abrahamsen In-Reply-To: <87edo619wx.fsf@igel.home> (Andreas Schwab's message of "Thu, 27 Apr 2023 01:49:34 +0200") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> Date: Wed, 26 Apr 2023 20:08:53 -0700 Message-ID: <87leieqawq.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Andreas Schwab writes: > commit 032969e8c65 "Don't have nntp-report signal an error" Ooh, I knew this would end up being me. Give me a couple of days, it might not be the weekend before I have time to dig through this. Thanks, Eric From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16829471283486 (code B ref 62845); Mon, 01 May 2023 13:19:02 +0000 Received: (at 62845) by debbugs.gnu.org; 1 May 2023 13:18:48 +0000 Received: from localhost ([127.0.0.1]:39180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptTQW-0000uA-95 for submit@debbugs.gnu.org; Mon, 01 May 2023 09:18:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptTQS-0000tk-J9 for 62845@debbugs.gnu.org; Mon, 01 May 2023 09:18:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptTQM-0003rC-5Y; Mon, 01 May 2023 09:18:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XcYpT4HkaXyK5STAbuSnteIHKudBTubvhN4JvSsOyVU=; b=bFXbXuvTNODz SB98CXGAY9s6wnw8tHnH//Sqo/fxOsqT1evHiW4olws7KNYo1JoxZNr/qK/emDBB5/XOQWpjteq1u wgOVtYWhxPczbzsf8ySBBkpHGoV9Jw+EY5Fr/eZAyOE6FevJGsMhTVAwgWb+tATQuNEgaBY7HKeEf VsFeywE1QymsZ9O7ITvxUqr0DtTTe5Rv67VomSsLO5yz1oRiN1zklfdHtoQAny4QNaDWaOq85ou45 86yyhAs75oxtVgKGRgQ6xy+XNVWpeVv3T+oNJIS4VTWOgwlQb2weBOnFFJvCSkS1rsTU35DcFpOIk VnJ/J+t32JSuHMB7WgciIQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptTQL-00065j-BH; Mon, 01 May 2023 09:18:37 -0400 Date: Mon, 01 May 2023 16:19:20 +0300 Message-Id: <83r0s0nq93.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87leieqawq.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Wed, 26 Apr 2023 20:08:53 -0700) References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eric Abrahamsen > Cc: Eli Zaretskii , 62845@debbugs.gnu.org > Date: Wed, 26 Apr 2023 20:08:53 -0700 > > Andreas Schwab writes: > > > commit 032969e8c65 "Don't have nntp-report signal an error" > > Ooh, I knew this would end up being me. Give me a couple of days, it > might not be the weekend before I have time to dig through this. Eric, Any progress? I'd like to make another pretest of Emacs 29 soon, and I'm waiting for this fix. TIA. From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 00:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168333143319670 (code B ref 62845); Sat, 06 May 2023 00:04:01 +0000 Received: (at 62845) by debbugs.gnu.org; 6 May 2023 00:03:53 +0000 Received: from localhost ([127.0.0.1]:57802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv5Oz-00057B-8S for submit@debbugs.gnu.org; Fri, 05 May 2023 20:03:53 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:35648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv5Ot-00056t-Qr for 62845@debbugs.gnu.org; Fri, 05 May 2023 20:03:51 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 651A7FA0D6; Sat, 6 May 2023 00:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683331417; bh=jj8YXgx8e1deIsAq99QHrJospjw4lcyGvnLjeXkRGW8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X34uBf3Kz1vdGkSiufCZxDqVwPAdKHlIWiYneaw2OlEly6o+lwAnEWM4AVWpi4+5E ZpGm7pybLFuf8hXA7uO0pj43NzGoHsAngJux54taGQ81wVd4l/AocigL0i2wb0AAXk YyyFxZmksZ5KdVjkKKZPfK973FSd5DASlEvu0Jmk= From: Eric Abrahamsen In-Reply-To: <83r0s0nq93.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 May 2023 16:19:20 +0300") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> Date: Fri, 05 May 2023 17:03:35 -0700 Message-ID: <87354axr54.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Eric Abrahamsen >> Cc: Eli Zaretskii , 62845@debbugs.gnu.org >> Date: Wed, 26 Apr 2023 20:08:53 -0700 >> >> Andreas Schwab writes: >> >> > commit 032969e8c65 "Don't have nntp-report signal an error" >> >> Ooh, I knew this would end up being me. Give me a couple of days, it >> might not be the weekend before I have time to dig through this. > > Eric, > > Any progress? I'd like to make another pretest of Emacs 29 soon, and > I'm waiting for this fix. TIA. Sorry this has been slow! First of all, thanks very much to Andreas for pinpointing the cause of this. I'd seen this before and looked for the cause a couple of times, but obviously didn't look hard enough. So in `nntp-finish-retrieve-group-infos' we have code that does this (with all the extraneous bits left out): (with-current-buffer nntp-server-buffer (while (nntp-accept-response)) (nnheader-strip-cr)) Where `nntp-accept-response' calls `nntp-report' if it can't find its process, which it can't if `nntp-server-buffer` has been killed in the interim. `nntp-report' used to raise an error in this case, so it didn't matter what happened afterwards. That error would derail the entire process of Gnus checking for news/mail, so I took it out so that other servers could continue doing their work even if this one had lost its connection. But then the current buffer of `with-current-buffer` is gone, which as Andreas notes dumps us in the most-recently-used buffer, which could be anything. The `nnheader-strip-cr' acts on that buffer, and terrible things result. Other code in this library checks if the timer has killed the process buffer in the meantime. There's probably a safe solution in here somewhere, but if you're looking for a reliable regression fix to include in Emacs 29, it's probably best just to revert 032969e8c65. That behavior is annoying, but at least not buggy. WDYT? Eric From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168334412419680 (code B ref 62845); Sat, 06 May 2023 03:36:01 +0000 Received: (at 62845) by debbugs.gnu.org; 6 May 2023 03:35:24 +0000 Received: from localhost ([127.0.0.1]:57985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv8hg-00057M-DE for submit@debbugs.gnu.org; Fri, 05 May 2023 23:35:24 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:60450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv8hd-000574-Pq for 62845@debbugs.gnu.org; Fri, 05 May 2023 23:35:23 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 528E2FA01F; Sat, 6 May 2023 03:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683344112; bh=oWzveus1PHTj9R67kygcOsuVw4KLNR586OWTu0OfhIw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=wydAIkaTMmcBNxlLWGAa2e8BDC8vrli4hnZLPmIT7jMI+FnEaWywI/++UddiukYT5 cO5gEwnM8Jzz57iQTlgWNu+uwt02xHlV8emWNZDxcMXf80PSCULsZhtMc3ZqdejeO1 +heap0hIzSq2qdDnjRxp3l9N22udHJSoLLpDpXp4= From: Eric Abrahamsen In-Reply-To: <87354axr54.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 05 May 2023 17:03:35 -0700") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> Date: Fri, 05 May 2023 20:35:06 -0700 Message-ID: <87y1m2w2s5.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eric Abrahamsen writes: > Eli Zaretskii writes: > >>> From: Eric Abrahamsen >>> Cc: Eli Zaretskii , 62845@debbugs.gnu.org >>> Date: Wed, 26 Apr 2023 20:08:53 -0700 >>> >>> Andreas Schwab writes: >>> >>> > commit 032969e8c65 "Don't have nntp-report signal an error" >>> >>> Ooh, I knew this would end up being me. Give me a couple of days, it >>> might not be the weekend before I have time to dig through this. >> >> Eric, >> >> Any progress? I'd like to make another pretest of Emacs 29 soon, and >> I'm waiting for this fix. TIA. [...] > Other code in this library checks if the timer has killed the process > buffer in the meantime. There's probably a safe solution in here > somewhere, but if you're looking for a reliable regression fix to > include in Emacs 29, it's probably best just to revert 032969e8c65. That > behavior is annoying, but at least not buggy. Looking more closely at this, there's already a mechanism for throwing out of the `nntp-with-open-group' wrapper: if `nntp--report-1' is t, then `nntp-report' should throw the appropriate symbol and we'd get the desired effect of canceling this server connection, without raising a top-level error. `nntp--report-1' should be non-nil in the case, I'll try to figure out why it isn't working. From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 05:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16833516952815 (code B ref 62845); Sat, 06 May 2023 05:42:01 +0000 Received: (at 62845) by debbugs.gnu.org; 6 May 2023 05:41:35 +0000 Received: from localhost ([127.0.0.1]:58032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvAfn-0000jL-BM for submit@debbugs.gnu.org; Sat, 06 May 2023 01:41:35 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:42482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvAfj-0000j6-Vw for 62845@debbugs.gnu.org; Sat, 06 May 2023 01:41:34 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 77AEAFA01F; Sat, 6 May 2023 05:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683351683; bh=EuO8YayRsrrFxJcC1VhYw5tnD2VilnGW9INbihBDL+w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VdkGpR3R7+fjE73OnySEjxxkeO2Ok2PnWu6FiPYvUcCIkjiuzaCN9K8iCpEyE1qZs 4v9AdnhxVPcRtqhvXGqkYURe8E5RG5LNm8ZDwzkYH5g7EvXWE/GKJCXeINK1SRRWup +Qpq8j4SSjpoX5dcHvEGNnUjXj5Ad9c0cIfKI/HE= From: Eric Abrahamsen In-Reply-To: <87y1m2w2s5.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 05 May 2023 20:35:06 -0700") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> Date: Fri, 05 May 2023 22:41:22 -0700 Message-ID: <87ild6vwxp.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eric Abrahamsen writes: > Eric Abrahamsen writes: > >> Eli Zaretskii writes: >> >>>> From: Eric Abrahamsen >>>> Cc: Eli Zaretskii , 62845@debbugs.gnu.org >>>> Date: Wed, 26 Apr 2023 20:08:53 -0700 >>>> >>>> Andreas Schwab writes: >>>> >>>> > commit 032969e8c65 "Don't have nntp-report signal an error" >>>> >>>> Ooh, I knew this would end up being me. Give me a couple of days, it >>>> might not be the weekend before I have time to dig through this. >>> >>> Eric, >>> >>> Any progress? I'd like to make another pretest of Emacs 29 soon, and >>> I'm waiting for this fix. TIA. > > [...] > >> Other code in this library checks if the timer has killed the process >> buffer in the meantime. There's probably a safe solution in here >> somewhere, but if you're looking for a reliable regression fix to >> include in Emacs 29, it's probably best just to revert 032969e8c65. That >> behavior is annoying, but at least not buggy. > > Looking more closely at this, there's already a mechanism for throwing > out of the `nntp-with-open-group' wrapper: if `nntp--report-1' is t, > then `nntp-report' should throw the appropriate symbol and we'd get the > desired effect of canceling this server connection, without raising a > top-level error. > > `nntp--report-1' should be non-nil in the case, I'll try to figure out > why it isn't working. The answer is, that mechanism is designed to work only once. If the connection is dead or times out, it catches that condition once and tries to re-connect, and won't catch it a second time. So we'd have to be hitting the timeout twice in a row to see this (which definitely happens). I still think it's best just to revert 032969e8c65 on Emacs 29. From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 06:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: Eli Zaretskii , 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16833536346880 (code B ref 62845); Sat, 06 May 2023 06:14:02 +0000 Received: (at 62845) by debbugs.gnu.org; 6 May 2023 06:13:54 +0000 Received: from localhost ([127.0.0.1]:58045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvBB3-0001mt-VL for submit@debbugs.gnu.org; Sat, 06 May 2023 02:13:54 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:43435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvBB1-0001mj-HG for 62845@debbugs.gnu.org; Sat, 06 May 2023 02:13:52 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4QCy1B0wpHz1s89K; Sat, 6 May 2023 08:13:49 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4QCy195KXlz1qqlS; Sat, 6 May 2023 08:13:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Uf_j-_AG2u4W; Sat, 6 May 2023 08:13:49 +0200 (CEST) X-Auth-Info: KjWIYIKMV4eKeTNfsKZNano4RaHsqaR0cdHPhM6uRAPWo612Y1LTl/SWVP9mFXHq Received: from tiger.home (aftr-62-216-205-35.dynamic.mnet-online.de [62.216.205.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 6 May 2023 08:13:49 +0200 (CEST) Received: by tiger.home (Postfix, from userid 1000) id B026E19B151; Sat, 6 May 2023 08:13:48 +0200 (CEST) From: Andreas Schwab In-Reply-To: <87ild6vwxp.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 05 May 2023 22:41:22 -0700") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> X-Yow: Now I can join WEIGHT WATCHERS! Date: Sat, 06 May 2023 08:13:48 +0200 Message-ID: <875y96oulf.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Mai 05 2023, Eric Abrahamsen wrote: > The answer is, that mechanism is designed to work only once. If the > connection is dead or times out, it catches that condition once and > tries to re-connect, and won't catch it a second time. So we'd have to > be hitting the timeout twice in a row to see this (which definitely > happens). I still think it's best just to revert 032969e8c65 on Emacs 29. When the timeout happens the server buffer is killed. Reopening the connection creates a new buffer, but the current buffer remains dead. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 06:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16833546758707 (code B ref 62845); Sat, 06 May 2023 06:32:02 +0000 Received: (at 62845) by debbugs.gnu.org; 6 May 2023 06:31:15 +0000 Received: from localhost ([127.0.0.1]:58066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvBRq-0002GN-Re for submit@debbugs.gnu.org; Sat, 06 May 2023 02:31:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvBRm-0002G5-3f for 62845@debbugs.gnu.org; Sat, 06 May 2023 02:31:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvBRf-0003MN-CX; Sat, 06 May 2023 02:31:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U81wkqD1SiJ4TfkBpGHchwVBT3FLw1aahTf3+t/UrnQ=; b=E5ZpEz+UVlSU wKG0lY9yqYyG6tQjMlgKuvm2ER7nt/JV7aUH3xem4th+woJLPe/ZrK5ywRfTBUbJ6EbkMX1onyJbB DmAWvPhY7cYm/bOWqWPl1PtQKEeRqak0uJg9DRX1PfQn5WZDW9MZTEPR0efUS7jf9cX4MH/Bpc/SG qCOVhzu/6Q9y+FOUd7EcDqTG+RD9Kb+WFp1p3gOph7ZNddrAyhDlfRhOJ6retFL7+hxTvOip4GzrD njlbwilSZBYrCoLqqZFKZrPS0X9DzJqHpiPWpgMUo09joMcx1HX32CKtntqX2c0HpT8XI11XEM2kv WSk8jG8jnQVYzKKhx8giYg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvBRe-0005N7-Rk; Sat, 06 May 2023 02:31:03 -0400 Date: Sat, 06 May 2023 09:31:58 +0300 Message-Id: <83jzxmgech.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87354axr54.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Fri, 05 May 2023 17:03:35 -0700) References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eric Abrahamsen > Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org > Date: Fri, 05 May 2023 17:03:35 -0700 > > `nntp-report' used to raise an error in this case, so it didn't matter > what happened afterwards. That error would derail the entire process of > Gnus checking for news/mail, so I took it out so that other servers > could continue doing their work even if this one had lost its > connection. > > But then the current buffer of `with-current-buffer` is gone, which as > Andreas notes dumps us in the most-recently-used buffer, which could be > anything. The `nnheader-strip-cr' acts on that buffer, and terrible > things result. > > Other code in this library checks if the timer has killed the process > buffer in the meantime. There's probably a safe solution in here > somewhere, but if you're looking for a reliable regression fix to > include in Emacs 29, it's probably best just to revert 032969e8c65. That > behavior is annoying, but at least not buggy. > > WDYT? Fine with me, but what is the plan for master? If you can show the proposed solution for master, we could then try to figure out if it is safe enough for emacs-29 as well. But if it will take a significant time to come up with such a solution for master, then let's revert on emacs-29 for now. Thanks. From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 16:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: Eli Zaretskii , 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168339229727376 (code B ref 62845); Sat, 06 May 2023 16:59:01 +0000 Received: (at 62845) by debbugs.gnu.org; 6 May 2023 16:58:17 +0000 Received: from localhost ([127.0.0.1]:35685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvLEf-00077T-Gg for submit@debbugs.gnu.org; Sat, 06 May 2023 12:58:17 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:44900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvLEd-00077H-Pr for 62845@debbugs.gnu.org; Sat, 06 May 2023 12:58:16 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 63DF4FA0D6; Sat, 6 May 2023 16:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683392289; bh=MyRLMOWGNUPyeNaAIvttJrvR0EI9p0E+6qJwxDGodTM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cUs+emB76syclhPJVY6+bNY5ct2rbmUveExdS5UpzqjOvJ7m4+KQAoVm1KlNDQw3y aUT05KC9fi76kJ+nsnygdHEqhFSCQXXHIDIjQTsx95oEGVC4dPD7zY9Sa+p8gyEXTU DyLPfc9/EEBfu9wZMxT/guCEv6vRVNWr2mRVrLfY= From: Eric Abrahamsen In-Reply-To: <875y96oulf.fsf@linux-m68k.org> (Andreas Schwab's message of "Sat, 06 May 2023 08:13:48 +0200") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> Date: Sat, 06 May 2023 09:58:07 -0700 Message-ID: <87bkixwg68.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 05/06/23 08:13 AM, Andreas Schwab wrote: > On Mai 05 2023, Eric Abrahamsen wrote: > >> The answer is, that mechanism is designed to work only once. If the >> connection is dead or times out, it catches that condition once and >> tries to re-connect, and won't catch it a second time. So we'd have to >> be hitting the timeout twice in a row to see this (which definitely >> happens). I still think it's best just to revert 032969e8c65 on Emacs 29. > > When the timeout happens the server buffer is killed. Reopening the > connection creates a new buffer, but the current buffer remains dead. But doesn't the call to `nntp-possibly-change-group' at nntp.el:600 re-create the connection, including re-initializing the nntp-server-buffer, so that when the guts of `nntp-finish-retrieve-group-infos' are run for the second time, the new server buffer is found? I'm having a hell of a time reasoning about this whole flow. From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168339276728180 (code B ref 62845); Sat, 06 May 2023 17:07:01 +0000 Received: (at 62845) by debbugs.gnu.org; 6 May 2023 17:06:07 +0000 Received: from localhost ([127.0.0.1]:35690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvLME-0007KR-E8 for submit@debbugs.gnu.org; Sat, 06 May 2023 13:06:06 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:60172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvLMA-0007Jw-VH for 62845@debbugs.gnu.org; Sat, 06 May 2023 13:06:04 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5D54FFA0D6; Sat, 6 May 2023 17:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683392756; bh=kw538w85uObf08yQ9rDua5OAqXKWaSkzFNjwQV5kgtk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nr1FF5eWzXQ4rrQIjmMshYlkT90A+tCmlH6rq2OAoL0jMhAgf5VOI/+KShWEhUtje fpQRw6g+UZYr10udTkcHkRwLfkpUfrTK9R1HT+QwL30rJ+6fyPWYAQ3RxIhhHIoRRt wso/L7mi+9+syXBctV9zD85RWIAnAW4wxxzfwQ/w= From: Eric Abrahamsen In-Reply-To: <83jzxmgech.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2023 09:31:58 +0300") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <83jzxmgech.fsf@gnu.org> Date: Sat, 06 May 2023 10:05:54 -0700 Message-ID: <877ctlwft9.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 05/06/23 09:31 AM, Eli Zaretskii wrote: >> From: Eric Abrahamsen >> Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org >> Date: Fri, 05 May 2023 17:03:35 -0700 >> >> `nntp-report' used to raise an error in this case, so it didn't matter >> what happened afterwards. That error would derail the entire process of >> Gnus checking for news/mail, so I took it out so that other servers >> could continue doing their work even if this one had lost its >> connection. >> >> But then the current buffer of `with-current-buffer` is gone, which as >> Andreas notes dumps us in the most-recently-used buffer, which could be >> anything. The `nnheader-strip-cr' acts on that buffer, and terrible >> things result. >> >> Other code in this library checks if the timer has killed the process >> buffer in the meantime. There's probably a safe solution in here >> somewhere, but if you're looking for a reliable regression fix to >> include in Emacs 29, it's probably best just to revert 032969e8c65. That >> behavior is annoying, but at least not buggy. >> >> WDYT? > > Fine with me, but what is the plan for master? If you can show the > proposed solution for master, we could then try to figure out if it is > safe enough for emacs-29 as well. > > But if it will take a significant time to come up with such a solution > for master, then let's revert on emacs-29 for now. I've had a patch sitting around since forever that defines a handful of Gnus-specific errors and uses them for explicit flow control, preventing errors with individual servers from interrupting Gnus' top-level usage. Personally I think that's the right way to go, but it seems like too much for a emacs 29 fix. I will look the patch over this afternoon and see how close I got. From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: Eli Zaretskii , 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16833949908725 (code B ref 62845); Sat, 06 May 2023 17:44:01 +0000 Received: (at 62845) by debbugs.gnu.org; 6 May 2023 17:43:10 +0000 Received: from localhost ([127.0.0.1]:35723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvLw5-0002Gf-MX for submit@debbugs.gnu.org; Sat, 06 May 2023 13:43:10 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:46438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvLvz-0002GR-Di for 62845@debbugs.gnu.org; Sat, 06 May 2023 13:43:08 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4QDFJQ0Lq8z1r1sC; Sat, 6 May 2023 19:43:01 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4QDFJP6q4Dz1qqlS; Sat, 6 May 2023 19:43:01 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 1ijxdDfl5QO2; Sat, 6 May 2023 19:43:01 +0200 (CEST) X-Auth-Info: 5t0CCo5dKBtApISX9L0DlKhATsN6+R2eut4jbn3/l2EaIDu1P7/gIvKaRptXZZxV Received: from igel.home (aftr-62-216-205-94.dynamic.mnet-online.de [62.216.205.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 6 May 2023 19:43:01 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id E6C472C1E1A; Sat, 6 May 2023 19:43:00 +0200 (CEST) From: Andreas Schwab In-Reply-To: <87bkixwg68.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 06 May 2023 09:58:07 -0700") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> X-Yow: I'm QUIETLY reading the latest issue of ``BOWLING WORLD'' while my wife and two children stand QUIETLY BY.. Date: Sat, 06 May 2023 19:43:00 +0200 Message-ID: <87pm7dnyor.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Mai 06 2023, Eric Abrahamsen wrote: > But doesn't the call to `nntp-possibly-change-group' at nntp.el:600 > re-create the connection, including re-initializing the > nntp-server-buffer, so that when the guts of > `nntp-finish-retrieve-group-infos' are run for the second time, the new > server buffer is found? You cannot recreate a buffer once it is killed. You can create a new buffer, but it will always be a different buffer. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 05:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: Eli Zaretskii , 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168343875226039 (code B ref 62845); Sun, 07 May 2023 05:53:02 +0000 Received: (at 62845) by debbugs.gnu.org; 7 May 2023 05:52:32 +0000 Received: from localhost ([127.0.0.1]:36209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvXJv-0006lv-Ko for submit@debbugs.gnu.org; Sun, 07 May 2023 01:52:31 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:46884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvXJs-0006lg-1K for 62845@debbugs.gnu.org; Sun, 07 May 2023 01:52:30 -0400 Received: from localhost (c-24-16-213-171.hsd1.wa.comcast.net [24.16.213.171]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 92C95FA56B; Sun, 7 May 2023 05:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683438740; bh=8AOs9De8NwT66LJ7Au8LcN3AKIoB6tRIh1pcnWq4S0w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=u1McBBWqT8UBpKs3SiAeWb4uBszwKtVwnVpUAHo/XPmHuKHhPH83vjdMXrCjqRdZ7 ynCExwb7OvQUB2W7K0q+LtNLuo24v62S7hOG8GwXbeZKUO8bWTtnGyy80E0V7MV19s cDt3wvJqLNPU/G3BYvN8mg4X+FuiBWirm0LpeuBU= From: Eric Abrahamsen In-Reply-To: <87pm7dnyor.fsf@igel.home> (Andreas Schwab's message of "Sat, 06 May 2023 19:43:00 +0200") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> Date: Sat, 06 May 2023 22:52:17 -0700 Message-ID: <873548wuwe.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 05/06/23 19:43 PM, Andreas Schwab wrote: > On Mai 06 2023, Eric Abrahamsen wrote: > >> But doesn't the call to `nntp-possibly-change-group' at nntp.el:600 >> re-create the connection, including re-initializing the >> nntp-server-buffer, so that when the guts of >> `nntp-finish-retrieve-group-infos' are run for the second time, the new >> server buffer is found? > > You cannot recreate a buffer once it is killed. You can create a new > buffer, but it will always be a different buffer. But `nntp-possibly-change-group' re-initializes `nntp-server-buffer' to a new buffer, and the `nntp-find-connection-buffer' inside `nntp-retrieve-group-data-early' uses the value of `nntp-server-buffer' to find its process. My reading is that each time the with-open-group function runs, its `bodyfun' lambda should get a new opportunity to find a live `nntp-server-buffer'. Plus, if the buffer were already dead the second time through, `nntp-retrieve-group-data-early' has sufficient guards to simply bail before doing anything. I'm not trying to be stubborn here, I assume your analysis is essentially right, I'm just trying to make sure I actually understand what's happening in the code. Even if it does require two timeouts in a row, I get that plenty often with a `nntp-connection-timeout' value of 6. Eric From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: Eli Zaretskii , 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16834446514016 (code B ref 62845); Sun, 07 May 2023 07:31:02 +0000 Received: (at 62845) by debbugs.gnu.org; 7 May 2023 07:30:51 +0000 Received: from localhost ([127.0.0.1]:36242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvYr5-00012i-AO for submit@debbugs.gnu.org; Sun, 07 May 2023 03:30:51 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:54159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvYr0-00012U-64 for 62845@debbugs.gnu.org; Sun, 07 May 2023 03:30:50 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4QDbgS68n9z1r2Z3; Sun, 7 May 2023 09:30:44 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4QDbgS4J5Mz1qqlS; Sun, 7 May 2023 09:30:44 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 87wTh-FlYH40; Sun, 7 May 2023 09:30:43 +0200 (CEST) X-Auth-Info: H9LTU9UHr4desimBzx1sJkrkgxOJa4EQToA6pK91xhFMRzryHXf8OHbsvZKP0mCX Received: from tiger.home (aftr-62-216-205-103.dynamic.mnet-online.de [62.216.205.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 7 May 2023 09:30:43 +0200 (CEST) Received: by tiger.home (Postfix, from userid 1000) id 7AED919B8F5; Sun, 7 May 2023 09:30:43 +0200 (CEST) From: Andreas Schwab In-Reply-To: <873548wuwe.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 06 May 2023 22:52:17 -0700") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> <873548wuwe.fsf@ericabrahamsen.net> X-Yow: Four thousand different MAGNATES, MOGULS & NABOBS are romping in my gothic solarium!! Date: Sun, 07 May 2023 09:30:43 +0200 Message-ID: <878re0y4ws.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Mai 06 2023, Eric Abrahamsen wrote: > But `nntp-possibly-change-group' re-initializes `nntp-server-buffer' to > a new buffer, and the `nntp-find-connection-buffer' inside > `nntp-retrieve-group-data-early' uses the value of `nntp-server-buffer' > to find its process. My reading is that each time the with-open-group > function runs, its `bodyfun' lambda should get a new opportunity to find > a live `nntp-server-buffer'. But that only happens when nntp-report-error is called. The timer has already killed the process buffer long before, and in the mean time the function happily butchers around in a random buffer. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16837339357861 (code B ref 62845); Wed, 10 May 2023 15:53:01 +0000 Received: (at 62845) by debbugs.gnu.org; 10 May 2023 15:52:15 +0000 Received: from localhost ([127.0.0.1]:48784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwm6x-00022j-EG for submit@debbugs.gnu.org; Wed, 10 May 2023 11:52:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwm6v-00022S-Fb for 62845@debbugs.gnu.org; Wed, 10 May 2023 11:52:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwm6p-0004Oq-5o; Wed, 10 May 2023 11:52:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sU7d0XLrlZBZhqWfNkXeUKD7QO+l5mPpFhnKu0NJFhc=; b=BwoMsJNPEUFU 2iXliD5388zKKHFJVn0VoC0FSYD9fLTuq+WRAdMovTBNMA4dVfrmfZCV0TnrbPT3RlS+Lsln0qgs+ c2cogF2k0AtTihRJzTZC9BonaiwlhB1s2nO38O1qrYlZwVb+mc55YMKO03qPogVHcRUmUolQf7nqG q5R/bIk8gTl8YTGKHG0XZXwjbsndzI8vfCeaPTz0cN/x0aTRLn4qulkkFqbFWNSgFX61S6MYj5Aue //S8ggWbUPqtbzXpUAPPF08R8NUSOghbpojmXX1IHEmF9gZ7QM+ElRJ/T28ztmFfnRSvAsT61HqMo b102aq0hiHThfZHysYSMSA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwm6o-0005mO-MU; Wed, 10 May 2023 11:52:06 -0400 Date: Wed, 10 May 2023 18:53:13 +0300 Message-Id: <83pm786v4m.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <873548wuwe.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Sat, 06 May 2023 22:52:17 -0700) References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> <873548wuwe.fsf@ericabrahamsen.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eric Abrahamsen > Cc: Eli Zaretskii , 62845@debbugs.gnu.org > Date: Sat, 06 May 2023 22:52:17 -0700 > > > On 05/06/23 19:43 PM, Andreas Schwab wrote: > > On Mai 06 2023, Eric Abrahamsen wrote: > > > > You cannot recreate a buffer once it is killed. You can create a new > > buffer, but it will always be a different buffer. > > But `nntp-possibly-change-group' re-initializes `nntp-server-buffer' to > a new buffer, and the `nntp-find-connection-buffer' inside > `nntp-retrieve-group-data-early' uses the value of `nntp-server-buffer' > to find its process. My reading is that each time the with-open-group > function runs, its `bodyfun' lambda should get a new opportunity to find > a live `nntp-server-buffer'. > > Plus, if the buffer were already dead the second time through, > `nntp-retrieve-group-data-early' has sufficient guards to simply bail > before doing anything. > > I'm not trying to be stubborn here, I assume your analysis is > essentially right, I'm just trying to make sure I actually understand > what's happening in the code. > > Even if it does require two timeouts in a row, I get that plenty often > with a `nntp-connection-timeout' value of 6. Eric, any progress here? If no better ideas are ready to be implemented, I think we should revert that commit on emacs-29 and leave it on master, where work on fixing this fallout should continue. OK? From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 18:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168374291324671 (code B ref 62845); Wed, 10 May 2023 18:22:03 +0000 Received: (at 62845) by debbugs.gnu.org; 10 May 2023 18:21:53 +0000 Received: from localhost ([127.0.0.1]:49008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwoRl-0006Pq-8V for submit@debbugs.gnu.org; Wed, 10 May 2023 14:21:53 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:38912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwoRi-0006Pc-NZ for 62845@debbugs.gnu.org; Wed, 10 May 2023 14:21:51 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1ECC6FA01F; Wed, 10 May 2023 18:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683742904; bh=H7TKIctaR7cB6hVYWScR5IRKok5Pf0iTPntCrzJ2jKE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ab79GpLLDw4vFgdhLTmELYLpgR+QkhppDLEsOASZAyfV2T3f/5tGzoldbVTRB20Cc GOZu5JKN4sBpn5UuyX53asUimREok1lOpX7lOJsAlkjkL27aBKgpXi4Dpsd25KwUXT Vc+9HnosodET1WtMf5O+mtUkBOh85dTeE6OttESs= From: Eric Abrahamsen In-Reply-To: <83pm786v4m.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 May 2023 18:53:13 +0300") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> <873548wuwe.fsf@ericabrahamsen.net> <83pm786v4m.fsf@gnu.org> Date: Wed, 10 May 2023 11:21:42 -0700 Message-ID: <87h6skqc7d.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 05/10/23 18:53 PM, Eli Zaretskii wrote: >> From: Eric Abrahamsen >> Cc: Eli Zaretskii , 62845@debbugs.gnu.org >> Date: Sat, 06 May 2023 22:52:17 -0700 >> >> >> On 05/06/23 19:43 PM, Andreas Schwab wrote: >> > On Mai 06 2023, Eric Abrahamsen wrote: >> > >> > You cannot recreate a buffer once it is killed. You can create a new >> > buffer, but it will always be a different buffer. >> >> But `nntp-possibly-change-group' re-initializes `nntp-server-buffer' to >> a new buffer, and the `nntp-find-connection-buffer' inside >> `nntp-retrieve-group-data-early' uses the value of `nntp-server-buffer' >> to find its process. My reading is that each time the with-open-group >> function runs, its `bodyfun' lambda should get a new opportunity to find >> a live `nntp-server-buffer'. >> >> Plus, if the buffer were already dead the second time through, >> `nntp-retrieve-group-data-early' has sufficient guards to simply bail >> before doing anything. >> >> I'm not trying to be stubborn here, I assume your analysis is >> essentially right, I'm just trying to make sure I actually understand >> what's happening in the code. >> >> Even if it does require two timeouts in a row, I get that plenty often >> with a `nntp-connection-timeout' value of 6. > > Eric, any progress here? > > If no better ideas are ready to be implemented, I think we should > revert that commit on emacs-29 and leave it on master, where work on > fixing this fallout should continue. OK? Yeah, I haven't made much progress in the time I've had to look at this (and I still don't completely understand the current error!). I think the commit should be reverted on both emacs-29 and master. It was there to fix an inconvenience (an nntp failure would halt a Gnus refresh at the top level), but it caused an actual bug (Gnus messes with the contents of random buffers). Better to go back to the inconvenience until a fuller solution is found. Thanks, Eric From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 May 2023 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168379926021538 (code B ref 62845); Thu, 11 May 2023 10:01:02 +0000 Received: (at 62845) by debbugs.gnu.org; 11 May 2023 10:01:00 +0000 Received: from localhost ([127.0.0.1]:49761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px36Z-0005bJ-Mo for submit@debbugs.gnu.org; Thu, 11 May 2023 06:00:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px36X-0005b5-Nv for 62845@debbugs.gnu.org; Thu, 11 May 2023 06:00:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px36R-0000CB-0a; Thu, 11 May 2023 06:00:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6AKqsGDLD0LZbpb4tIHV6aRvvi10b/RPE/kxoRIvicM=; b=nvSYlvSI7TtV F3zmsGvGwS+TFMw7QE2lQZGDls7KqGXJxdrSA/N/pnv1KN8xV3l/AU1pB/BDYNfhTvwZAYy1+cmlk oWyAZuTGUsM3hrWd2HnJaYODA86kh/OlxqWsgi8UprPoCHMzZ787OC9LAVU3V34WDjAZJ3Wf8f3yG n+qa27zS+AaUBhQYnPenmC/AsE2v7Ft4nB1JufKBG9dbIvK2snWgfbz2qDwHx6WB5WCBxAh1D8A7p 6oaieqctFhUVHa+DsnjYJ9f3PVGdGyIG1yfIf9buafs7f2PqwvUZfFAg9OdQfBxwOt62zLBY3+v9t IETyZ58KLwG/e5L0OUzHCg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px36P-0003Iv-Od; Thu, 11 May 2023 06:00:50 -0400 Date: Thu, 11 May 2023 13:01:58 +0300 Message-Id: <83lehv5gq1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h6skqc7d.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Wed, 10 May 2023 11:21:42 -0700) References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> <873548wuwe.fsf@ericabrahamsen.net> <83pm786v4m.fsf@gnu.org> <87h6skqc7d.fsf@ericabrahamsen.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eric Abrahamsen > Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org > Date: Wed, 10 May 2023 11:21:42 -0700 > > > > Eric, any progress here? > > > > If no better ideas are ready to be implemented, I think we should > > revert that commit on emacs-29 and leave it on master, where work on > > fixing this fallout should continue. OK? > > Yeah, I haven't made much progress in the time I've had to look at this > (and I still don't completely understand the current error!). > > I think the commit should be reverted on both emacs-29 and master. It > was there to fix an inconvenience (an nntp failure would halt a Gnus > refresh at the top level), but it caused an actual bug (Gnus messes with > the contents of random buffers). Better to go back to the inconvenience > until a fuller solution is found. Thanks, I've now reverted commit 032969e8c65 on the emacs-29 branch; soon to be merged to master. Should I now close this bug, or do you want it to stay open? From unknown Tue Jun 17 01:46:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 May 2023 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168381894016208 (code B ref 62845); Thu, 11 May 2023 15:29:01 +0000 Received: (at 62845) by debbugs.gnu.org; 11 May 2023 15:29:00 +0000 Received: from localhost ([127.0.0.1]:53157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px8Dz-0004DM-Oy for submit@debbugs.gnu.org; Thu, 11 May 2023 11:29:00 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:54860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px8Dx-0004D6-Ia for 62845@debbugs.gnu.org; Thu, 11 May 2023 11:28:58 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A0ACBFA01F; Thu, 11 May 2023 15:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683818930; bh=xbHRptH6/qDPNTK/b4efttkakm0rWlPFjgwdgwmxQsw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=S3vVfLw6FBy4owWQAQrI3DFE4PhC5KkvZkti6rMBAGxPkXkIDij66PLU8SQze5be3 Y2OxqemRhtxsm16/I9LSzYoLhrWfFR0UaM4Iodlccg9Vz17FjSDZfypCZ2R3KdPiRJ KIv1Toy8Pf0HAUovq8s7rmA8BjCOjVNTnlzpXHgI= From: Eric Abrahamsen In-Reply-To: <83lehv5gq1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 May 2023 13:01:58 +0300") References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> <873548wuwe.fsf@ericabrahamsen.net> <83pm786v4m.fsf@gnu.org> <87h6skqc7d.fsf@ericabrahamsen.net> <83lehv5gq1.fsf@gnu.org> Date: Thu, 11 May 2023 08:28:49 -0700 Message-ID: <87cz36rioe.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 05/11/23 13:01 PM, Eli Zaretskii wrote: >> From: Eric Abrahamsen >> Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org >> Date: Wed, 10 May 2023 11:21:42 -0700 >> >> >> > Eric, any progress here? >> > >> > If no better ideas are ready to be implemented, I think we should >> > revert that commit on emacs-29 and leave it on master, where work on >> > fixing this fallout should continue. OK? >> >> Yeah, I haven't made much progress in the time I've had to look at this >> (and I still don't completely understand the current error!). >> >> I think the commit should be reverted on both emacs-29 and master. It >> was there to fix an inconvenience (an nntp failure would halt a Gnus >> refresh at the top level), but it caused an actual bug (Gnus messes with >> the contents of random buffers). Better to go back to the inconvenience >> until a fuller solution is found. > > Thanks, I've now reverted commit 032969e8c65 on the emacs-29 branch; > soon to be merged to master. > > Should I now close this bug, or do you want it to stay open? Please leave it open, thanks!