GNU bug report logs - #62843
[PATCH core-updates] gnu: python-numpy: Skip failing tests on i686.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62843 in the body.
You can then email your comments to 62843 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kaelyn Takata <kaelyn.alexi <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Kaelyn Takata <kaelyn.alexi <at> protonmail.com>
Subject: [PATCH core-updates] gnu: python-numpy: Skip failing tests on i686.
Date: Fri, 14 Apr 2023 19:59:42 +0000

* gnu/packages/python-xyz.scm (python-numpy): Skip failing tests on i686.
---
 gnu/packages/python-xyz.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index ae20f48ac6..26502a6d81 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -135,6 +135,7 @@
 ;;; Copyright © 2023 Gabriel Wicki <gabriel <at> erlikon.ch>
 ;;; Copyright © 2023 Amade Nemes <nemesamade <at> gmail.com>
 ;;; Copyright © 2023 Bruno Victal <mirai <at> makinata.eu>
+;;; Copyright © 2023 Kaelyn Takata <kaelyn.alexi <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6300,6 +6301,15 @@ (define-public python-numpy
                               ;; x86_64 CPUs such as the Core 2 Duo (see:
                               ;; https://github.com/numpy/numpy/issues/22170).
                               "and not test_rint_big_int "
+                              ;; The huge_array test is too large for 32-bit (see:
+                              ;; https://bugs.gentoo.org/843599 and
+                              ;; https://bugs.gentoo.org/846548).
+                              ;; TestKind.test_all is a Fortran type failure
+                              ;; that may be toolchain or environment related.
+                              #$@(if (or (target-x86?) (target-arm32?))
+                                     `(" and not test_identityless_reduction_huge_array"
+                                       " and not (TestKind and test_all)")
+                                   '())
                               ;; These tests seem to fail on machines without
                               ;; an FPU is still under investigation upstream.
                               ;; https://github.com/numpy/numpy/issues/20635

base-commit: 1e28aed2eb7049c8a40092071ac1ca1142869b6d
--
2.39.2

Message #8 received at 62843 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Kaelyn <kaelyn.alexi <at> protonmail.com>
Cc: guix-devel <guix-devel <at> gnu.org>, 62843 <at> debbugs.gnu.org
Subject: Re: python-pytest on core-updates (was: i686 core-updates failure.)
Date: Sat, 15 Apr 2023 13:20:07 +0200

Am Fri, Apr 14, 2023 at 08:05:46PM +0000 schrieb Kaelyn:
> I just sent in https://issues.guix.gnu.org/62843 to disable the two tests for i686 and armhf (disabling TestKind.test_all for armhf might not be needed, but the Gentoo package definition suggests the huge array test will fail for armhf as well).

Thanks for taking care of this! Disabling the large array test on all 32 bit
architectures sounds reasonable, and I think that disabling the fortran test
on armhf is a reasonable approach also given that we have no CI for this
architecture.

The recent master/staging merge apparently broke python-pytest even on
x86_64, see message below, which should be sorted out first.

Andreas


=================================== FAILURES ===================================
___________________ test_raise_assertion_error_raising_repr ____________________

pytester = <Pytester PosixPath('/tmp/guix-build-python-pytest-7.1.3.drv-0/pytest-of-nixbld/pytest-0/test_raise_assertion_error_raising_repr0')>

    def test_raise_assertion_error_raising_repr(pytester: Pytester) -> None:
        pytester.makepyfile(
            """
            class RaisingRepr(object):
                def __repr__(self):
                    raise Exception()
            def test_raising_repr():
                raise AssertionError(RaisingRepr())
        """
        )
        result = pytester.runpytest()
        if sys.version_info >= (3, 11):
            # python 3.11 has native support for un-str-able exceptions
            result.stdout.fnmatch_lines(
                ["E       AssertionError: <exception str() failed>"]
            )
        else:
>           result.stdout.fnmatch_lines(
                ["E       AssertionError: <unprintable AssertionError object>"]
            )
E           Failed: nomatch: 'E       AssertionError: <unprintable AssertionError object>'
E               and: '============================= test session starts =============================='
E               and: 'platform linux -- Python 3.10.7, pytest-7.1.3, pluggy-1.0.0'
E               and: 'rootdir: /tmp/guix-build-python-pytest-7.1.3.drv-0/pytest-of-nixbld/pytest-0/test_raise_assertion_error_raising_repr0'
E               and: 'collected 1 item'
E               and: ''
E               and: 'test_raise_assertion_error_raising_repr.py F                             [100%]'
E               and: ''
E               and: '=================================== FAILURES ==================================='
E               and: '______________________________ test_raising_repr _______________________________'
E               and: ''
E               and: '    def test_raising_repr():'
E               and: '>       raise AssertionError(RaisingRepr())'
E               and: 'E       AssertionError: <exception str() failed>'
E               and: ''
E               and: 'test_raise_assertion_error_raising_repr.py:5: AssertionError'
E               and: '=========================== short test summary info ============================'
E               and: 'FAILED test_raise_assertion_error_raising_repr.py::test_raising_repr - Assert...'
E               and: '============================== 1 failed in 0.01s ==============================='
E           remains unmatched: 'E       AssertionError: <unprintable AssertionError object>'

/tmp/guix-build-python-pytest-7.1.3.drv-0/pytest-7.1.3/testing/test_assertion.py:1655: Failed
----------------------------- Captured stdout call -----------------------------
============================= test session starts ==============================
platform linux -- Python 3.10.7, pytest-7.1.3, pluggy-1.0.0
rootdir: /tmp/guix-build-python-pytest-7.1.3.drv-0/pytest-of-nixbld/pytest-0/test_raise_assertion_error_raising_repr0
collected 1 item

test_raise_assertion_error_raising_repr.py F                             [100%]

=================================== FAILURES ===================================
______________________________ test_raising_repr _______________________________

    def test_raising_repr():
>       raise AssertionError(RaisingRepr())
E       AssertionError: <exception str() failed>

test_raise_assertion_error_raising_repr.py:5: AssertionError
=========================== short test summary info ============================
FAILED test_raise_assertion_error_raising_repr.py::test_raising_repr - Assert...
============================== 1 failed in 0.01s ===============================
=========================== short test summary info ============================
FAILED testing/test_assertion.py::test_raise_assertion_error_raising_repr - F...
= 1 failed, 3040 passed, 92 skipped, 15 deselected, 9 xfailed in 290.90s (0:04:50) =
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "pytest" arguments: ("-vv" "-k" " not test_argcomplete and not test_code_highlight and not test_color_yes") exit-status: 1 term-signal: #f stop-signal: #f>
phase `check' failed after 292.0 seconds
command "pytest" "-vv" "-k" " not test_argcomplete and not test_code_highlight and not test_color_yes" failed with status 1
builder for `/gnu/store/rd9aiszfkb8k96magk1y59hya79c9ch4-python-pytest-7.1.3.drv' failed with exit code 1
@ build-failed /gnu/store/rd9aiszfkb8k96magk1y59hya79c9ch4-python-pytest-7.1.3.drv - 1 builder for `/gnu/store/rd9aiszfkb8k96magk1y59hya79c9ch4-python-pytest-7.1.3.drv' failed with exit code 1
derivation '/gnu/store/rd9aiszfkb8k96magk1y59hya79c9ch4-python-pytest-7.1.3.drv' offloaded to '141.80.167.159' failed: build of `/gnu/store/rd9aiszfkb8k96magk1y59hya79c9ch4-python-pytest-7.1.3.drv' failed
build of /gnu/store/rd9aiszfkb8k96magk1y59hya79c9ch4-python-pytest-7.1.3.drv failed
View build log at '/var/log/guix/drvs/rd/9aiszfkb8k96magk1y59hya79c9ch4-python-pytest-7.1.3.drv.gz'.

Message #13 received at 62843-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Kaelyn <kaelyn.alexi <at> protonmail.com>
Cc: guix-devel <guix-devel <at> gnu.org>, 62843-done <at> debbugs.gnu.org
Subject: Re: python-pytest on core-updates (was: i686 core-updates failure.)
Date: Sat, 15 Apr 2023 22:49:09 +0200

Am Sat, Apr 15, 2023 at 01:20:07PM +0200 schrieb Andreas Enge:
> The recent master/staging merge apparently broke python-pytest even on
> x86_64, see message below, which should be sorted out first.

With pytest repaired, your patch builds numpy successfully on both x86
architectures. Pushed, thanks again!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.