GNU bug report logs - #62823
29.0.60; Fixing a small leak in tree-sitter search functions

Previous Next

Full log

Message #11 received at 62823 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62823 <at> debbugs.gnu.org
Subject: Re: bug#62823: 29.0.60; Fixing a small leak in tree-sitter search
 functions
Date: Fri, 14 Apr 2023 11:27:22 -0700

> On Apr 13, 2023, at 11:45 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Thu, 13 Apr 2023 15:48:43 -0700
>> 
>> When we switch to using cursors instead of nodes [1] in treesit.c for
>> search functions, we introduced a small leak: the search functions
>> allows the user to pass a predicate function, which can signal. And
>> because we are now using cursors, which needs to be freed, everytime the
>> predicate function signals, the cursor is leaked.
>> 
>> I pushed a fix to master (a5eb9f6ad4e), the change is relatively
>> straightforward so I hope we can pick it into the next pretest.
> 
> Thanks, but this kind of bugs should be fixed on the release branch to
> begin with (I've backported it now).  If you are unsure on which
> branch to install such changes, please ask before installing.

Oops. I’ll do that the next time.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.