From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 10:46:18 2023 Received: (at submit) by debbugs.gnu.org; 13 Apr 2023 14:46:18 +0000 Received: from localhost ([127.0.0.1]:44414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmyDD-0003cI-Gf for submit@debbugs.gnu.org; Thu, 13 Apr 2023 10:46:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:34400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmyD7-0003c0-Od for submit@debbugs.gnu.org; Thu, 13 Apr 2023 10:46:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmyD6-0002mT-GQ for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 10:46:04 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmyCh-0008G1-Rl for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 10:46:02 -0400 Received: by mail-wr1-x431.google.com with SMTP id v6so14428018wrv.8 for ; Thu, 13 Apr 2023 07:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681397135; x=1683989135; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=r4v94dtbiCwnp1hGLHJjf8OYoEhKsWDqsiLdita8F3E=; b=lhmlVPsLVoAAMoH4cU5TvbfkEpSj/dFkud+I8bcwUwFrHtfgWAIjf8fDVhVvbviz2m J8P4lijCWsqq0jDcW4zeVnU0HErRXWYwP7eFQmfAmTOP3kOIWgXxmmCXnq9YzZUSLv7T KvJ39+y91EbKx53nHbNNLq7vDfWP8oO+/kjRn/tRmCGN7xbdOWQeNTkeHjdEu3PUyRj+ O3ifFb9A6DguyHPzzQlel2ooJ690Q7aOMvPNwjmGCoGg2/Jz9EgPSRdyBNSEcmVQaWOy 1RW653O3q1ySKLhUmUZJwQ9oM5DuWOuVLmid1WZqRKORbi3V8x9wzoDFoWXivwiVVCEG 6c0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681397135; x=1683989135; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r4v94dtbiCwnp1hGLHJjf8OYoEhKsWDqsiLdita8F3E=; b=L9l4sklUbDYUviHu+Q/PdscrgFzv5dvAn7gAKT9EcAEvxrIxwjCBUiXNXDCC+UcAEf geuygQp1CWkJJKd9iiQ24pgUaVbNJjJCjhiWu9Al7lETnrTwAJeLyL70zmqTKmCicCou rl/A9ekal0hGaqSRFrOdIZ8vJWwqmh394xqjXNN/+3ybRxoI/bZDZqZOQPVcJh0ujBdE S36YbVt1JakqTKJmu5i+V4hGJHpjIwsF0Kut3HqX57iWpO3BSDxSYGurgDVAwNH75qLs 5cURlfRmU7yxw3KWFtF96HQD2Ihm5Wevn23Csg3J0GM4Jshr7wPZn3oknO7pW1TsjPv1 U6TQ== X-Gm-Message-State: AAQBX9eC/l/ilRdDzSL//Lusn3/dt5fVty+Hk0Ep0CjkAtDR+qAKHaM0 6GLRMAYlwNOOXQUc74Z1G8y9vy+UoAg= X-Google-Smtp-Source: AKy350YHj5yfKMULOERnsA4atJJRZ/1pA1Z0yPgU/hEQKYsnVxPEoOayUQtmhwqhrYodu4zXdDQLxQ== X-Received: by 2002:a05:6000:18cd:b0:2f2:86cd:3e11 with SMTP id w13-20020a05600018cd00b002f286cd3e11mr1832877wrq.36.1681397135088; Thu, 13 Apr 2023 07:45:35 -0700 (PDT) Received: from krug ([87.196.73.56]) by smtp.gmail.com with ESMTPSA id n21-20020a7bc5d5000000b003e91b9a92c9sm2003893wmk.24.2023.04.13.07.45.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 07:45:34 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: bug-gnu-emacs@gnu.org Subject: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used X-Debbugs-Cc: Dmitry Gutov Date: Thu, 13 Apr 2023 15:47:40 +0100 Message-ID: <87leivsusz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, Originally reported by Dmitry Gutov over at bug#62029: > It's trivially reproduced even with 'emacs -Q': just add somewhere > inside an Elisp buffer: > (remove-hook asd) > when flymake-mode is enabled and eldoc-documentation-strategy is > 'eldoc-documentation-compose, and eldoc-echo-area-use-multiline-p is > not 1, and move around 'asd' with C-f and C-b. I've confirmed this in a graphical Emacs frame. In a TTY frame, it's harder or impossible to spot.=20=20 Traced the problem down to a misimplementation of the 'eldoc-documentation-compose' strategy, which leads to potentially one eldoc-message call to be issued for each member of 'eldoc-documentation-functions'. In fact, with this particular strategy, the intention at most one such call should occur (after all the documentation items of different backends have been collected). It's reasonably easy to fix, and I've been running the patch after my sig all day with no problems either in Elisp or other modes. The "blinking" observed before is gone. I'll push it to master soon, but leave this issue open for comments and/or feedback a little longer. Jo=C3=A3o diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el index 1eb0d38c5ce..55fb518f990 100644 --- a/lisp/emacs-lisp/eldoc.el +++ b/lisp/emacs-lisp/eldoc.el @@ -681,29 +681,34 @@ eldoc-documentation-default (lambda (f) (funcall f (eldoc--make-callback :eager f))))) =20 -(defun eldoc--documentation-compose-1 (eagerlyp) - "Helper function for composing multiple doc strings. -If EAGERLYP is non-nil show documentation as soon as possible, -else wait for all doc strings." - (run-hook-wrapped 'eldoc-documentation-functions - (lambda (f) - (let* ((callback (eldoc--make-callback - (if eagerlyp :eager :patient) - f)) - (str (funcall f callback))) - (if (or (null str) (stringp str)) (funcall callbac= k str)) - nil))) - t) - (defun eldoc-documentation-compose () "Show multiple documentation strings together after waiting for all of t= hem. This is meant to be used as a value for `eldoc-documentation-strategy'." - (eldoc--documentation-compose-1 nil)) + (let (fns-and-callbacks) + ;; Make all the callbacks, this sets up state inside + ;; `eldoc--invoke-strategy' to know how many to wait for before + ;; displaying (bug#xxxxx) + (run-hook-wrapped 'eldoc-documentation-functions + (lambda (f) + (push (cons f (eldoc--make-callback :patient f)) + fns-and-callbacks) + nil)) + ;; Now call them. The last one will trigger the display. + (cl-loop for (f . callback) in fns-and-callbacks + for str =3D (funcall f callback) + when (or (null str) (stringp str)) do (funcall callback str))) + t) =20 (defun eldoc-documentation-compose-eagerly () "Show multiple documentation strings one by one as soon as possible. This is meant to be used as a value for `eldoc-documentation-strategy'." - (eldoc--documentation-compose-1 t)) + (run-hook-wrapped 'eldoc-documentation-functions + (lambda (f) + (let* ((callback (eldoc--make-callback :eager f)) + (str (funcall f callback))) + (if (or (null str) (stringp str)) (funcall callbac= k str)) + nil))) + t) =20 (defun eldoc-documentation-enthusiast () "Show most important documentation string produced so far. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 18:58:32 2023 Received: (at 62816) by debbugs.gnu.org; 13 Apr 2023 22:58:32 +0000 Received: from localhost ([127.0.0.1]:45012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn5tf-00065n-LA for submit@debbugs.gnu.org; Thu, 13 Apr 2023 18:58:32 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:53961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn5tb-00065Y-Tp for 62816@debbugs.gnu.org; Thu, 13 Apr 2023 18:58:30 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id B052D582366; Thu, 13 Apr 2023 18:58:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 13 Apr 2023 18:58:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681426702; x=1681430302; bh=14RPQgkgnEB2UZeS265euT/GO28uOC28AmV KoWanoAc=; b=JR611/XqKzT5qW3Zn+t7FbcKvZls8HPw0OijPoMVtXTHDguSL23 0ZPzwy1f0WSOb5CztpzKqfciRVq1QI3xxEL7OWS8nX0FeCqGvTVtYYbk3Gm8xMHw rhGLR9xBF5PXORTiIvvwg5cduI8xXUwELrv5OQnyN/916/cWuOQqHmOc/Yj9F9Iz UvHhAQhj0EkWYYzhWFktdpVr0Leg7zdPZAwaIvrT70Vd8X9uX9vnGT75OzhKjW9J 9bQQPUqhP1xoML8eHueDtYZ5jiD8xz8+o6h4PYgMVPotKSgqoShP0PA222bu9TMc Pi6+x5y6Nym2BZo1i6ctpQsmi/FwVKLGedg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681426702; x= 1681430302; bh=14RPQgkgnEB2UZeS265euT/GO28uOC28AmVKoWanoAc=; b=W DRrlRs2v4Nh5fHqdYOs/9r6+PYLqsJtiiv+VVUMrf7WCaSvy3KLLV2yYuEtdVdbz 2Eb/RZ8Yk7FlTxOZmLNScnHLxvy4zoCyfYU7pGQTuwsY/lI1UK5QWghTSg4YXYwM Ev+Snz29aWqxYZ9d8uQGAJaURFO3O4F+57rFcLZkznmmsp93Ek9yRDZYOzYguJzx A5lnsRYyXTaFYTlN9fSr3Liswkk9qWJd9yv2fDNPHp/3KrXDStuEZpmjEEsJyyew 2xw2Bpj1u01D7ltLBJGy0iX5ZDNLDMOkiNJ+dBwO7vIVNil5h2T9KOO7IRtH53p5 CCS6dm4qUguv4xUfWPpaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekledgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeehffetfeeuiefggeekgefgfeekjeeuuedtheegveejueelfeeiieeuveegfffg tdenucffohhmrghinhepuhhguhhurdhsvgenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Apr 2023 18:58:21 -0400 (EDT) Message-ID: Date: Fri, 14 Apr 2023 01:58:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used Content-Language: en-US To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , 62816@debbugs.gnu.org References: <87leivsusz.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87leivsusz.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62816 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 13/04/2023 17:47, João Távora wrote: > Hello, > > Originally reported by Dmitry Gutov over > at bug#62029: > >> It's trivially reproduced even with 'emacs -Q': just add somewhere >> inside an Elisp buffer: > >> (remove-hook asd) > >> when flymake-mode is enabled and eldoc-documentation-strategy is >> 'eldoc-documentation-compose, and eldoc-echo-area-use-multiline-p is >> not 1, and move around 'asd' with C-f and C-b. > > I've confirmed this in a graphical Emacs frame. In a TTY frame, it's > harder or impossible to spot. > > Traced the problem down to a misimplementation of the > 'eldoc-documentation-compose' strategy, which leads to potentially one > eldoc-message call to be issued for each member of > 'eldoc-documentation-functions'. In fact, with this particular > strategy, the intention at most one such call should occur (after all > the documentation items of different backends have been collected). > > It's reasonably easy to fix, and I've been running the patch after my > sig all day with no problems either in Elisp or other modes. The > "blinking" observed before is gone. > > I'll push it to master soon, but leave this issue open for comments > and/or feedback a little longer. Thank you, it does seems to fix the issue with C-f/C-b in elisp-mode, in the described situation. I still see the problem with window jumping and blinking when typing with company-mode enabled, though. You say: "I do use company and multi-line echo areas liberally". Do you have some extra configuration for company-frontends? Here's a screencast that demonstrates the problem: https://a.uguu.se/csTMrzxc.webm One way to fix that is (delq 'company-echo-metadata-frontend company-frontends) but I wonder whether some better solution exists. OTOH, Eglot implements the attribute which this frontend plugs into via :company-docsig, and it seems like both with LSP servers that I just tried it returns nil. If the feature is generally unused, I could understand if Eglot users all disable this frontend anyway. It is handy to have in emacs-lisp-mode, though. At least when there is no documentation popup floating nearby. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 19:21:32 2023 Received: (at 62816) by debbugs.gnu.org; 13 Apr 2023 23:21:32 +0000 Received: from localhost ([127.0.0.1]:45031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn6Fn-0006dw-A4 for submit@debbugs.gnu.org; Thu, 13 Apr 2023 19:21:32 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:54965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn6Fi-0006df-8l for 62816@debbugs.gnu.org; Thu, 13 Apr 2023 19:21:21 -0400 Received: by mail-wm1-f42.google.com with SMTP id q5so9432380wmo.4 for <62816@debbugs.gnu.org>; Thu, 13 Apr 2023 16:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681428072; x=1684020072; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J524clMWrmXGwyT5N9iibxAMp2DYfFASViypa8l9I0k=; b=E0hIabf0igWePwBOx4dYaur6p9WPrAYz9I3qURIfoEf7Bv34YzbqQjt9zdkHAeWBxN qTpvx45uZUXjMy+qGZvGZv4oWTfJ5D1YaYtob14FM5610Tgy3XxvKS9/+H/BljGqReZs YZOG4PqVUQiN2miW/qBkT2Yd2isaDfijGcSvYxPc5lhvXoqQIEFHVQ07VM0mXWesbG8p TCcfHyQSxLEwbvrGFgVh/ZvmoZ3DCthMklQtqIbOIgrXhWn7xRZ4AEFgNDqJ5joWEJ7y UX9iMeBA3bKJZ0RqvWh5OsBifLe1ciVBGRqEWTWgh5b8kGg2ZlAF7kneaSBxVRIXJGyH juVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681428072; x=1684020072; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J524clMWrmXGwyT5N9iibxAMp2DYfFASViypa8l9I0k=; b=aLwnAuhDmiVIGR6pX1wlCUkpsp/TtdSZAwwmHFYfCWZjtZdwH7pZ1lsJA30GTfwLVz 48mRGMW/uJHBO0E/qhWcHeiO/xhQXfv4qgBcIHHyBGl9iIqY/XaryEOF2DJpFL1T3oH1 3qWsxk6aU6MQ6NJAZLugFyUbxzDvA2mrT84adsPru/ZfwWKTqzJQiSzNEgZeNLFghh8E I6Vnene9EgnA3ub8U68DCCbxIJjJQRVmqSoC41jAwh7XUjgj3YF0yQhICHbTpnjCnHHC O8PPJQ4052dWS26IBtNvgyH+7hbrHnEmWyJS3PueqKqFXUA+glesf3LDPM+41kdy1V+I EhvQ== X-Gm-Message-State: AAQBX9cSeJ5luNdprSoLOj07nBPsDzf4sGc1UjDVquk5JwZ7Cixz3jBO xdXmHZKBC0r6dLa10wYJlC/ageWRYC0= X-Google-Smtp-Source: AKy350YoWWhgMQUq0EueqNE2ZF8U3n7ueV6OnANebu5rb4NcOm44M4fV1/0Hx5/+bnUY+snhMdu9HQ== X-Received: by 2002:a7b:cd93:0:b0:3ed:320a:3721 with SMTP id y19-20020a7bcd93000000b003ed320a3721mr3095375wmj.22.1681428071941; Thu, 13 Apr 2023 16:21:11 -0700 (PDT) Received: from krug ([87.196.73.56]) by smtp.gmail.com with ESMTPSA id f20-20020a1c6a14000000b003eae73f0fc1sm2938735wmc.18.2023.04.13.16.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 16:21:11 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Dmitry Gutov Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used In-Reply-To: (Dmitry Gutov's message of "Fri, 14 Apr 2023 01:58:19 +0300") References: <87leivsusz.fsf@gmail.com> Date: Fri, 14 Apr 2023 00:23:17 +0100 Message-ID: <87ttxj2wpm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62816 Cc: 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > I still see the problem with window jumping and blinking when typing > with company-mode enabled, though. You say: "I do use company and > multi-line echo areas liberally". Do you have some extra configuration > for company-frontends? Not that I know of. I just use a TTY frame. I don't see it. The echo area is frequently empty for me when selecting Eglot completions (in clangd, the server I most use nowadays). > Here's a screencast that demonstrates the problem: > https://a.uguu.se/csTMrzxc.webm Ugh, that indeed looks awful. We must fix it. > One way to fix that is > (push 'company-echo-metadata-frontend company-frontends) > but I wonder whether some better solution exists. I hope so. > OTOH, Eglot implements the attribute which this frontend plugs into > via :company-docsig, and it seems like both with LSP servers that I > just tried it returns nil. If the feature is generally unused, I could > understand if Eglot users all disable this frontend anyway. I don't think that's the best solution. Though you're right that only one server, pyright, uses this (it's some user's hack in eglot.el I let through: I don't even know what it does, i think it tells) But, perhaps to ask the obvious, why can't Company just detect when nil is passed to it via :company-docsig and not do any echoing in that situation? Isn't it Company doing the clearing we want to avoid? Another option is just to temporarily disable eldoc during the duration of the Company completion session.=20=20 I think Company could/should do both of these things, but I haven't studied the problem so I might be missing something. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 19:37:52 2023 Received: (at 62816) by debbugs.gnu.org; 13 Apr 2023 23:37:52 +0000 Received: from localhost ([127.0.0.1]:45075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn6Vj-000738-Ue for submit@debbugs.gnu.org; Thu, 13 Apr 2023 19:37:52 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:46467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn6Vh-00072v-Dc for 62816@debbugs.gnu.org; Thu, 13 Apr 2023 19:37:51 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 7BA3D581FE1; Thu, 13 Apr 2023 19:37:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 13 Apr 2023 19:37:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681429063; x=1681432663; bh=U9qRD3vjpZBqazwcjEHjVFFkcXWTzXSqxE1 0cUAH2T8=; b=TXfmHdeppkn+jStGRL+4Dd4dEUVjw9/d3lNhUqQdTN6a2A1/nRl wDDcS+AYK7DpD4LWnu080H/8hVpEKJvof82iEolxHwYjoRoHT2g+qffTrVOPMGs/ Ni0kdGZdNnJQ1wQ/Zbp7tCRNJW6jfijKcCw+aAm/81rQ/72JLTAehIEsaQMQDJep Pk4nw2B4qGCaiHQvgq05JDja+qU64SDlmI+1TTdBw0epBVeDL08iX9UYabuCKau7 9JbG7P2sKIZLGhCuZ5xp6JckNMyYdam3yvewhpcN7r5qvrAHtIV+edIUWZ/GnZnJ 4dM0sLBXLSOCNwhP34/1lWKyeewdG27RYNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681429063; x=1681432663; bh=U9qRD3vjpZBqazwcjEHjVFFkcXWTzXSqxE1 0cUAH2T8=; b=FUeXzKQ6L20s77vUATSRC6VRCQz5IupnzyZRgP3q4SW3bReVJDT H/Rb5yY2Pl+AHvfsg05VlFmVliflAEvFwpZDQTcfft5Om3d8yh0RnupQ/oxzqmLt z5c+tcq0dhFvsCTwSS/ifJRllklXkjfiVgPlqHaZR9/ApetmFocKCkrs/1lnfRB+ 2cxs+Q9LcfEehCYETuPbZmOETfncYe9Cr6MSDBngEl/7HE0yRgMIa/2+8o88HDHK O+Q8q6RveJk+KFqHUSWFwzw0cZ7RlTKG4cTxWuV0IbAQxyrSOYLfHH7PCUZv8OAq sErYD6mVmdvtRAbQjGQrv5aBI0/Z3MdHrxA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekledgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepueefuedtleekueeuvddvvdfhvddvtdefgfelgfeifedvkeeffeevudeivedv uedunecuffhomhgrihhnpehughhuuhdrshgvpdhgihhthhhusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhu thhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Apr 2023 19:37:41 -0400 (EDT) Message-ID: <2e04fa32-d52e-73ac-dabb-7ed5396dce0a@gutov.dev> Date: Fri, 14 Apr 2023 02:37:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used Content-Language: en-US To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <87leivsusz.fsf@gmail.com> <87ttxj2wpm.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87ttxj2wpm.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62816 Cc: 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) On 14/04/2023 02:23, João Távora wrote: > Dmitry Gutov writes: > >> I still see the problem with window jumping and blinking when typing >> with company-mode enabled, though. You say: "I do use company and >> multi-line echo areas liberally". Do you have some extra configuration >> for company-frontends? > > Not that I know of. I just use a TTY frame. I don't see it. The echo > area is frequently empty for me when selecting Eglot completions (in > clangd, the server I most use nowadays). > >> Here's a screencast that demonstrates the problem: >> https://a.uguu.se/csTMrzxc.webm > > Ugh, that indeed looks awful. We must fix it. > >> One way to fix that is >> (push 'company-echo-metadata-frontend company-frontends) Sorry, that was supposed to be (delete ...). The one above restores the configuration -- I needed it for a repeat comparison. >> but I wonder whether some better solution exists. > > I hope so. > >> OTOH, Eglot implements the attribute which this frontend plugs into >> via :company-docsig, and it seems like both with LSP servers that I >> just tried it returns nil. If the feature is generally unused, I could >> understand if Eglot users all disable this frontend anyway. > > I don't think that's the best solution. Though you're right that only > one server, pyright, uses this (it's some user's hack in eglot.el I let > through: I don't even know what it does, i think it tells) Maybe other servers have different bits of info that could be used for this? > But, perhaps to ask the obvious, why can't Company just detect when nil > is passed to it via :company-docsig and not do any echoing in that > situation? Isn't it Company doing the clearing we want to avoid? I think it does need to clear the echo area when it was previously echoed to by the same backend (showing meta from a different completion). E.g. after the user just presses C-n with completion popup already visible. So the idea to "just not do any echoes" would require some bookkeeping about where the current message came from, compare the current message contents, and possibly still fail sometimes where the exact same message came from a different source. The last one is unlikely, though. > Another option is just to temporarily disable eldoc during the duration > of the Company completion session. Right. And yet another solution would be to detect that Eldoc will be used, and try to plug into its documentation functions to display the meta thingy alongside the other info. That's at least 3 potential solutions now. > I think Company could/should do both of these things, but I haven't > studied the problem so I might be missing something. I've looked into that issue in the past, but haven't picked one yet. Related: https://github.com/company-mode/company-mode/issues/797 https://github.com/company-mode/company-mode/issues/588 https://github.com/company-mode/company-mode/issues/796 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 20:14:43 2023 Received: (at 62816) by debbugs.gnu.org; 14 Apr 2023 00:14:43 +0000 Received: from localhost ([127.0.0.1]:45121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn75O-0008EN-US for submit@debbugs.gnu.org; Thu, 13 Apr 2023 20:14:43 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:40924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn75N-0008E5-2y for 62816@debbugs.gnu.org; Thu, 13 Apr 2023 20:14:41 -0400 Received: by mail-wm1-f48.google.com with SMTP id o6-20020a05600c4fc600b003ef6e6754c5so7182883wmq.5 for <62816@debbugs.gnu.org>; Thu, 13 Apr 2023 17:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681431275; x=1684023275; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hHlyiKCPMJqxKJfjiYDphmVapFQyZi1mDl+jzah4GWY=; b=R5eA6mPzhGh9fA8lQlGAJBixNttFYzNnIzUdPwIJNRsSN6yVAvjT3/aZ8E1nRPRK3o CWbuo5lIK8hC/nMhYBVFn5OPrA6LjfnSullbZBR+Ep3yCpLPJpfoNglbmgrcFdBf7mv7 0bWNhlJZw1Pat6HruU7tpUzGCnraNoVDWu2u8m4S287K4sJwob2H2v+B2zZtKh14Wfgw VcdMQ/lhFBbZOz/o9r2P7tOaKgFCGX9+FVGELWq8oYWtgsHhxL9/uZJVsGRWBetDMOVR eTD1DMuD5+DK+/c6hFeOPU3L2D4e89/BdWWDUTXT3s+zGk4HGh5TqK5S8RRA7FJJAKCZ GP7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681431275; x=1684023275; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hHlyiKCPMJqxKJfjiYDphmVapFQyZi1mDl+jzah4GWY=; b=VtxIuwfPBTOZ2NxP9f8LjfKxSXNW65xLbOFrlnS4TLnnXg+6l8KodHGhtIgAo2xpRR f0z7NuT1HCvCFFfc3FMatj3w3zJCvAgw3UrOt+jXQP8CW35r12BL0cmkNvY+Mv+1PgAQ +ZDIdzH6vh1LSE/rbHBITMb7jwMuklJUQ2wFAq5Wpa0tUlRsfggyJpRSYa/Eo0d2OIA3 BBgi7ZKa6o9obUEgahYEpy0cPleA5F/1xTgXBXTxDQ85cpy/xkJaKm8WpwGZfJKtdUJD c0oS4ZPwWVRVLnXBlQ2983qHK+NFI6WEyWIzbugqe7kFcMhp0U0RKgXAoIJ9rRWNopYX CsaQ== X-Gm-Message-State: AAQBX9c+baqPaB6go9g7QsjMD6G7+UvPKt9mqpawRd2ST3d2B0Tv3Mej Zrbfp52NR5WnQJAW/ZYNS9p7CfqRqMo= X-Google-Smtp-Source: AKy350ZUqzlFGNB/IT3INEXiMGqRw+yZOj9KVExNNI5ydisjDfHy34agUbDrg+hksxRex9BFaM/tGg== X-Received: by 2002:a1c:ed07:0:b0:3ef:6eeb:c25a with SMTP id l7-20020a1ced07000000b003ef6eebc25amr2992974wmh.6.1681431274883; Thu, 13 Apr 2023 17:14:34 -0700 (PDT) Received: from krug ([87.196.73.56]) by smtp.gmail.com with ESMTPSA id l42-20020a05600c1d2a00b003ef6988e54csm6728603wms.15.2023.04.13.17.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 17:14:34 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Dmitry Gutov Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used In-Reply-To: <2e04fa32-d52e-73ac-dabb-7ed5396dce0a@gutov.dev> (Dmitry Gutov's message of "Fri, 14 Apr 2023 02:37:39 +0300") References: <87leivsusz.fsf@gmail.com> <87ttxj2wpm.fsf@gmail.com> <2e04fa32-d52e-73ac-dabb-7ed5396dce0a@gutov.dev> Date: Fri, 14 Apr 2023 01:16:40 +0100 Message-ID: <87jzyf2u8n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62816 Cc: 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 14/04/2023 02:23, Jo=C3=A3o T=C3=A1vora wrote: >> Dmitry Gutov writes: >>=20 >>> I still see the problem with window jumping and blinking when typing >>> with company-mode enabled, though. You say: "I do use company and >>> multi-line echo areas liberally". Do you have some extra configuration >>> for company-frontends? >> Not that I know of. I just use a TTY frame. I don't see it. The >> echo >> area is frequently empty for me when selecting Eglot completions (in >> clangd, the server I most use nowadays). >>=20 >>> Here's a screencast that demonstrates the problem: >>> https://a.uguu.se/csTMrzxc.webm >> Ugh, that indeed looks awful. We must fix it. >>=20 >>> One way to fix that is >>> (push 'company-echo-metadata-frontend company-frontends) > > Sorry, that was supposed to be (delete ...). The one above restores > the configuration -- I needed it for a repeat comparison. Ahaha :-) No, no, I did exactly the same and misquoted you. I put the push there to restore it, with a quick C-x C-e. You did send the delq. >>> but I wonder whether some better solution exists. >> I hope so. >>=20 >>> OTOH, Eglot implements the attribute which this frontend plugs into >>> via :company-docsig, and it seems like both with LSP servers that I >>> just tried it returns nil. If the feature is generally unused, I could >>> understand if Eglot users all disable this frontend anyway. >> I don't think that's the best solution. Though you're right that >> only >> one server, pyright, uses this (it's some user's hack in eglot.el I let >> through: I don't even know what it does, i think it tells) > > Maybe other servers have different bits of info that could be used for > this? Probably. Just looked at the spec, there's are two different "detail" fields (though it's not clear which one to pick or where exactly to send them). See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.1= 7/specification/#textDocument_completion if you're interested, and search down for "detail". But are you saying that if that :company-docsig is taken out completely, the problem will not happen? Maybe I can put it in only for the pyright server. >> But, perhaps to ask the obvious, why can't Company just detect when nil >> is passed to it via :company-docsig and not do any echoing in that >> situation? Isn't it Company doing the clearing we want to avoid? > > I think it does need to clear the echo area when it was previously > echoed to by the same backend (showing meta from a different > completion). E.g. after the user just presses C-n with completion > popup already visible. So the idea to "just not do any echoes" would > require some bookkeeping about where the current message came from, > compare the current message contents, and possibly still fail > sometimes where the exact same message came from a different > source. The last one is unlikely, though. I see. Eglot only uses one Company source, company-capf, if that helps. >> Another option is just to temporarily disable eldoc during the duration >> of the Company completion session. > > Right. > > And yet another solution would be to detect that Eldoc will be used, > and try to plug into its documentation functions to display the meta > thingy alongside the other info. > > That's at least 3 potential solutions now. I think you should do the "bookkeeping" one, at least a very simple version. Just record in your concept of a "company session" if there was ever a non-nil :company-docsig sent from anywhere that required echoing. Until there is, never clear on nil :company-docsig. Eventually, if there is something to echo, tough luck: display it and proceed as currently, clearing always on nil, risking flickering. Suspect this should fix 95% of the cases, certainly Eglot usages. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 20:23:11 2023 Received: (at 62816) by debbugs.gnu.org; 14 Apr 2023 00:23:11 +0000 Received: from localhost ([127.0.0.1]:45126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn7Db-0008Su-5Z for submit@debbugs.gnu.org; Thu, 13 Apr 2023 20:23:11 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:60759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn7DW-0008S6-Eo for 62816@debbugs.gnu.org; Thu, 13 Apr 2023 20:23:10 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 2B91F5821F3; Thu, 13 Apr 2023 20:23:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 13 Apr 2023 20:23:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681431780; x=1681435380; bh=c3tagmJJSf1kV/eRZCFS4XocB21kLZ5ccO5 HWDL8HG8=; b=W/mNw2IwVOGvfGxc+Xi+6QCi+0czg73/CBAzwTEbzItJuWEMUpH dCQJRxJYYtzkr4pTrrXZmU9etUj4fU4BFEbnZvGj2igO9tOz2b/KJPYD20d+t5Jo RkSiPdEWSiOo/YsJtYbdD3EoZhuhKHRLQS0Bdqk0DZLdQg3epdJJgi+iirSyjzOl W1Rmw72ffEfjQIKSc+5IUsSyZ8M1ekFO0h6FoHeFH9Jp3NslaUycXkTHFYYQtURk 7DnFTNy0jFqNycLdvVOFfQ/qHMpnhLpZfveeOqu5Gi8KqH3925dYfFvDUrGIkp1f ezyVokCHW29FVGb2ajUgKwRGwN5YvlqvZ/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681431780; x=1681435380; bh=c3tagmJJSf1kV/eRZCFS4XocB21kLZ5ccO5 HWDL8HG8=; b=KzYsyyRmpJljsfgZrpkdj3S0HUQ0Tf0X2NIBTJOb1WjQQj8Vyek zr1Hpb6K9lIB4gXJUuncCayayIoMIy+a4rMWOMsAA15MBP6HVscuLvxhF9barEC5 dCC0YFMqVOlgAEdPCIWgJo7IG75R37h36mVbNpavhuXOfK9Fl9qmrIrTA+s16zE/ QGFYCp8gOraLeei9cMZFX9cJxEeECRz4qXlgX3Aipu84Vcb1B/bPFZtyAQs97LrY oRiR3SxzxkfYs6F0iA7iH/ffIH3jazsbceiuGFXZbQzVGjno0Q/kDtu3SrmMQtJ4 Mt0GOvFHdA/zl4NsrBZ9NqMJIudPXc/u83Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekledgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne goufhushhpvggtthffohhmrghinhculdegledmnecujfgurhepkfffgggfuffvvehfhfgj tgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhith hrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvghrnhepheekjeelueefudekledu udeljeeuhfevgfeikeelffehjedtheegveehleejgedunecuffhomhgrihhnpehughhuuh drshgvpdhgihhthhhusgdrihhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Apr 2023 20:22:58 -0400 (EDT) Message-ID: Date: Fri, 14 Apr 2023 03:22:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used Content-Language: en-US To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <87leivsusz.fsf@gmail.com> <87ttxj2wpm.fsf@gmail.com> <2e04fa32-d52e-73ac-dabb-7ed5396dce0a@gutov.dev> <87jzyf2u8n.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87jzyf2u8n.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62816 Cc: 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) On 14/04/2023 03:16, João Távora wrote: >>>> Here's a screencast that demonstrates the problem: >>>> https://a.uguu.se/csTMrzxc.webm >>> Ugh, that indeed looks awful. We must fix it. >>> >>>> One way to fix that is >>>> (push 'company-echo-metadata-frontend company-frontends) >> >> Sorry, that was supposed to be (delete ...). The one above restores >> the configuration -- I needed it for a repeat comparison. > > Ahaha :-) No, no, I did exactly the same and misquoted you. I put the > push there to restore it, with a quick C-x C-e. You did send the delq. Oh. :-) >>>> but I wonder whether some better solution exists. >>> I hope so. >>> >>>> OTOH, Eglot implements the attribute which this frontend plugs into >>>> via :company-docsig, and it seems like both with LSP servers that I >>>> just tried it returns nil. If the feature is generally unused, I could >>>> understand if Eglot users all disable this frontend anyway. >>> I don't think that's the best solution. Though you're right that >>> only >>> one server, pyright, uses this (it's some user's hack in eglot.el I let >>> through: I don't even know what it does, i think it tells) >> >> Maybe other servers have different bits of info that could be used for >> this? > > Probably. Just looked at the spec, there's are two different "detail" > fields (though it's not clear which one to pick or where exactly to send > them). See > https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_completion > if you're interested, and search down for "detail". "Detail" does sound relevant. But it depends on what info the servers actually provide in it. > But are you saying > that if that :company-docsig is taken out completely, the problem will > not happen? Maybe I can put it in only for the pyright server. Not exactly: the backend interface doesn't differentiate between a not implemented action and action returning nil. Not for 'meta' anyway. >>> But, perhaps to ask the obvious, why can't Company just detect when nil >>> is passed to it via :company-docsig and not do any echoing in that >>> situation? Isn't it Company doing the clearing we want to avoid? >> >> I think it does need to clear the echo area when it was previously >> echoed to by the same backend (showing meta from a different >> completion). E.g. after the user just presses C-n with completion >> popup already visible. So the idea to "just not do any echoes" would >> require some bookkeeping about where the current message came from, >> compare the current message contents, and possibly still fail >> sometimes where the exact same message came from a different >> source. The last one is unlikely, though. > > I see. Eglot only uses one Company source, company-capf, if that helps. Alas no. >>> Another option is just to temporarily disable eldoc during the duration >>> of the Company completion session. >> >> Right. >> >> And yet another solution would be to detect that Eldoc will be used, >> and try to plug into its documentation functions to display the meta >> thingy alongside the other info. >> >> That's at least 3 potential solutions now. > > I think you should do the "bookkeeping" one, at least a very simple > version. Just record in your concept of a "company session" if there > was ever a non-nil :company-docsig sent from anywhere that required > echoing. Until there is, never clear on nil :company-docsig. > Eventually, if there is something to echo, tough luck: display it and > proceed as currently, clearing always on nil, risking flickering. > Suspect this should fix 95% of the cases, certainly Eglot usages. Yeah, that should be the most conservative solution. Maybe I'll start with it. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 14 14:03:29 2023 Received: (at 62816) by debbugs.gnu.org; 14 Apr 2023 18:03:29 +0000 Received: from localhost ([127.0.0.1]:47571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnNlh-0005aX-IQ for submit@debbugs.gnu.org; Fri, 14 Apr 2023 14:03:29 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:46557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnNlf-0005aH-4r for 62816@debbugs.gnu.org; Fri, 14 Apr 2023 14:03:28 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id EA95C58233B; Fri, 14 Apr 2023 14:03:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 14 Apr 2023 14:03:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681495400; x=1681499000; bh=9wtEpoWcrALAinqmbkwB+wdYf0Y10rWyooO BWktWZqU=; b=uGo3443Flnw7Dqp5rzxEUWQIlvW59XXsWt43nv2MiJg3Odm8Atb +HyOCp7c1BYTaGAgCBEIZyzn5MYwDuARrWJjKKCvi/0oMbC5VelFkcW1PAKnEZxy ligoVHqhgh6bGwjsVgB2UDA1pWogXnGOIaFaw+6+sciqesyRVLeB0a133UjwK5pj oit+uwMDcSCqMaFWO6wQ99+kD7W5VLuJXU2ZxZfW20W6ADvrsym8x3f6Jf4bHA0+ QDWgL6UepD34cEP0amjrIPb2GDY+QN67z4iT6uQ0dcG5lhCgA0/qz2waCr4KSJ3T utNxmZA/7DZp9tnMGTuEG0dCtsTmmo9qjVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681495400; x= 1681499000; bh=9wtEpoWcrALAinqmbkwB+wdYf0Y10rWyooOBWktWZqU=; b=d 08AevGAWgDqLCsx2pNqz1/aiinX7fe7Es1WxdqJSAlrwCAwOxB3qWtHJSEXQtYuR bI0cJKJnNTmYMaa/NJUZZTrDAT2cLxr/UVA/N1J2JsrN4yvyUZBhAyuKlDSuDFSP w1ZwwFQha6mqJwz1QfUJpyEmt9qi2lCQlU3KYzWv+OpB2j03hXtQvFWITM66IAfh fKT8PJIZTNAz7RoZVgK9HXUAob+6+tr3RUqtEzksQfk6F0QepIF+fxEDjzWGFFvU azll6CYkXr193dZ6d5BHuLrhAky8ZD2eAU5iIe43HKTpIVROd6JpEEiSepJBFRxm FuArQvgcTGt1LncXdvZgQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeltddguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepfeejkeevvdefleefudefveegtedvveekledvtdeuteetfedufefgudeikeff ieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Apr 2023 14:03:19 -0400 (EDT) Message-ID: <16986ddd-e47b-c092-38d3-1e19da4229c4@gutov.dev> Date: Fri, 14 Apr 2023 21:03:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used Content-Language: en-US To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , 62816@debbugs.gnu.org References: <87leivsusz.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87leivsusz.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62816 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 13/04/2023 17:47, João Távora wrote: > I'll push it to master soon, but leave this issue open for comments > and/or feedback a little longer. Perhaps we want to backport it to emacs-29 as well? It *is* a bug, after all. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 14 14:07:32 2023 Received: (at 62816) by debbugs.gnu.org; 14 Apr 2023 18:07:32 +0000 Received: from localhost ([127.0.0.1]:47581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnNpc-0005hP-B3 for submit@debbugs.gnu.org; Fri, 14 Apr 2023 14:07:32 -0400 Received: from mail-ot1-f42.google.com ([209.85.210.42]:35795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnNpa-0005h8-7X for 62816@debbugs.gnu.org; Fri, 14 Apr 2023 14:07:30 -0400 Received: by mail-ot1-f42.google.com with SMTP id l13-20020a0568302b0d00b006a416ec44ccso5102864otv.2 for <62816@debbugs.gnu.org>; Fri, 14 Apr 2023 11:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681495644; x=1684087644; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JgMkcdyVZOPCk99fmjmptdmvSkzazaoAAfaa3N54LHo=; b=Llaa58Vdu/+sluowQJl4B72cydHZmTUF62h/Dxx4Ss1K2mtPkNl19zWZLcDOu3bE8f ASCTnNvZGPIvtpoM9xCrhjwW5M0ZbjNawQWz1AFHWDL5SfJYaXabTUaab47JaLR7nsEu s82z2I7JTlDvD3sRZ4oibTHurehv66VwQJl7WgeJaGrMSfcN5GI2ASNGVzEn7uZ6I6bt RZQJm7U68/brj6ETz6OwLFX+OBRcUEI1nvW2LmEAQk7hO8kw+PiBU7aqxiaIQUtb5RLn zhWCaWhw8s8INdxMs75zi4DKPocsA/cI7YUefWCWSZxJ5JMYjyrDB1eIGQOP6udohXef Eleg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681495644; x=1684087644; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JgMkcdyVZOPCk99fmjmptdmvSkzazaoAAfaa3N54LHo=; b=BrCrj4fx9vn68Dn+zcnygIWgcC/cqSqpGXxLWLTMZ1oiohnxyi94vq46q8XEvmFUyr NgWASdthEBgvepBPk62BFQ/XR/z598PkoccucBnWpV18VY3y4WvLu0B+9abImi8mo7Th EMNyPf/E+38M4gh8x7DKqZCXsxb3KTUOBRdgaRSUcXBGr0uaA4QZdAaFnHOM7GRdgei4 4MaTIoibGNCPWDcp5CP3R1jwj8ISqON75imSWk0PiTlj9phJzX0SL7lRu70vy4r1pmmp xgcJEwK4FZpu2cU5YOtDiG7prETDv2f2MDGQ4i8GAETVUHgYcg0YlOCs76VU8Gi6785d lmsQ== X-Gm-Message-State: AAQBX9eLf73fHZ07WKmWfxHUchg/2D8w0Z/ltlxKyOAK0seQanVkAvo/ GtWEtbSsnrlhED7tZ2EmmFR1DWoogKiDDdQfk0aXFQXy1Pc= X-Google-Smtp-Source: AKy350Y53agVwRyUEkH6f6/xjjXh97xODidVs796Yf5ZKdqJmcL5wS2PGugLUmgs1WvgK9ON+wMUJlK8M3M7cmW+NYc= X-Received: by 2002:a9d:6a95:0:b0:6a4:2997:9636 with SMTP id l21-20020a9d6a95000000b006a429979636mr1670265otq.4.1681495644544; Fri, 14 Apr 2023 11:07:24 -0700 (PDT) MIME-Version: 1.0 References: <87leivsusz.fsf@gmail.com> <16986ddd-e47b-c092-38d3-1e19da4229c4@gutov.dev> In-Reply-To: <16986ddd-e47b-c092-38d3-1e19da4229c4@gutov.dev> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 14 Apr 2023 19:09:20 +0100 Message-ID: Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62816 Cc: 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Apr 14, 2023 at 7:03=E2=80=AFPM Dmitry Gutov wro= te: > > On 13/04/2023 17:47, Jo=C3=A3o T=C3=A1vora wrote: > > I'll push it to master soon, but leave this issue open for comments > > and/or feedback a little longer. > > Perhaps we want to backport it to emacs-29 as well? It *is* a bug, after > all. Perhaps. Yes it's a bug. But at this point, I think that's for Eli to decide (i.e. I don't exactly what the policy is now vs two/three weeks ago). Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 14 14:53:57 2023 Received: (at 62816) by debbugs.gnu.org; 14 Apr 2023 18:53:57 +0000 Received: from localhost ([127.0.0.1]:47639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnOYX-00074I-Gl for submit@debbugs.gnu.org; Fri, 14 Apr 2023 14:53:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnOYV-000745-PF for 62816@debbugs.gnu.org; Fri, 14 Apr 2023 14:53:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnOYQ-00076k-GK; Fri, 14 Apr 2023 14:53:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=eTEql3GJsbTDxxlLscCkpe0LaYvPbT7VfbhwYSGbN8U=; b=N/0XuvE5nXz7QrR5J1de 1vCxAYS4cgieLy95r8LH6vw5n8gckpOybiVsVH3Oqx6Sw3vkhKKibwltqWWjtyLDOIe5FKs3dHJ+0 eRgSMWSJ0z9YKuMT5ZgqnE0a9mleJN7olVIFTcujUK4Jbt7FI0D6SW3vS3a9zEgOTiPgH7TCR6CPG Wi8KYtalKi5qwxJXTpjs2KJ6h1ohToxiQxlFJHx8cECD+xp6t/L7Zlp9ryVAhJgDaoPlUzGCC2aSf 88LCIsEQfnZIRlrF+PYkLvqcb3iwwRQw30BumoQEzaikde8z+s0v3efkL6nm23yBT24dUPVADGWz0 fjChV7VXi/3scg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnOYP-0005qe-Lk; Fri, 14 Apr 2023 14:53:49 -0400 Date: Fri, 14 Apr 2023 21:53:49 +0300 Message-Id: <83wn2ee1mr.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Fri, 14 Apr 2023 19:09:20 +0100) Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used References: <87leivsusz.fsf@gmail.com> <16986ddd-e47b-c092-38d3-1e19da4229c4@gutov.dev> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62816 Cc: dmitry@gutov.dev, 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 62816@debbugs.gnu.org > From: João Távora > Date: Fri, 14 Apr 2023 19:09:20 +0100 > > On Fri, Apr 14, 2023 at 7:03 PM Dmitry Gutov wrote: > > > > On 13/04/2023 17:47, João Távora wrote: > > > I'll push it to master soon, but leave this issue open for comments > > > and/or feedback a little longer. > > > > Perhaps we want to backport it to emacs-29 as well? It *is* a bug, after > > all. > > Perhaps. Yes it's a bug. But at this point, I think that's for Eli > to decide (i.e. I don't exactly what the policy is now vs two/three > weeks ago). It depends on how bad is the bug, whether it's a regression since Emacs 28, and how safe is the fix. In general, bugs should be fixed on the release branch, unless the risk associated with the fix is too high. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 14 15:56:28 2023 Received: (at 62816) by debbugs.gnu.org; 14 Apr 2023 19:56:28 +0000 Received: from localhost ([127.0.0.1]:47767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnPX1-0000WF-No for submit@debbugs.gnu.org; Fri, 14 Apr 2023 15:56:28 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:43784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnPX0-0000W2-86 for 62816@debbugs.gnu.org; Fri, 14 Apr 2023 15:56:26 -0400 Received: by mail-oi1-f174.google.com with SMTP id x22so1302445oiv.10 for <62816@debbugs.gnu.org>; Fri, 14 Apr 2023 12:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681502180; x=1684094180; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zHdcKuqM/RA6g77KcBgaeGeic+lVFuX4hChesInmmiM=; b=ZjDLaISwftRd9viGuIubptp+2M+cyzgrTy32j4eOjXVfNn9xDhcWQazEt9gjU4ViAA mV12uKjFx93mGb4h2EHVUBJFuPcHhL+1gE5er3S/0AhDo49VShkm0JmLwO5M1sDG0y0y ChMikzlQwZMYQHfauWZmXLm9XR+Y3HEdDK5PnpACRygByXWsZ/6jrRsCbBJPNcAP/Wo/ H+kJZMdbj+G80OtigUY8nB+6zHVfvehVfxciLDZXbHgv1q8pPxkbzBC86/OKo4vhyzoC 5/52PWN3hr1wosOBwhelxYwg0wJ940v433U6KVW5TUf3mBo//b8jrdk1Sa9pxl5V0lpN 9fkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681502180; x=1684094180; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zHdcKuqM/RA6g77KcBgaeGeic+lVFuX4hChesInmmiM=; b=Vucw+1WCikCUdRNL6DrV/MdpDUMBMm5zkCDUAgoDe/YktiSnOwJOEsfmDEhruqVJS0 3rzb3FEXWge4XV7W/OhV3uddx3kruCBNUDaa/Io4wFuxdng5Pa9ths40JlfzAaCC6lT0 ZzTOBusXH309A86jyfr6IrCTU2Jxb8FZbdX8nX3ChFeX8R3LFRy3usXBDfAvPUCpl1zY aIMEU3HcCWBVldq77rJ8lGjPYM8m9UKZYA6jo3YB23VNjZJiadtASFOob/3TbpaAXhh7 7S0aCyquXSishvFRnOpczBJlhzKmGEgtMPD7jF5EvdRxiasL6CeTSAanAAOrPcMVNG52 QVuA== X-Gm-Message-State: AAQBX9dLrCaipKAt8wYFv5Wgo0Bf4wLqfatvvQNNjCiWnn5By8/RyBWb MCt2Jm4mjvdJtvKDJ7UdxLuFQ4E0kcfn2G37F70= X-Google-Smtp-Source: AKy350YkPB1+qjIkUHIDAGO886oG4dAFmbGcXn40tUwF13gaCTg3pvBtNaHzkU0vF+ZxTc1qvHHytfQds8bMSdY7DPk= X-Received: by 2002:a05:6808:14f:b0:36e:f6f7:bb1a with SMTP id h15-20020a056808014f00b0036ef6f7bb1amr1870214oie.5.1681502180619; Fri, 14 Apr 2023 12:56:20 -0700 (PDT) MIME-Version: 1.0 References: <87leivsusz.fsf@gmail.com> <16986ddd-e47b-c092-38d3-1e19da4229c4@gutov.dev> <83wn2ee1mr.fsf@gnu.org> In-Reply-To: <83wn2ee1mr.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 14 Apr 2023 20:58:16 +0100 Message-ID: Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62816 Cc: dmitry@gutov.dev, 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Apr 14, 2023 at 7:53=E2=80=AFPM Eli Zaretskii wrote: > > > Cc: 62816@debbugs.gnu.org > > From: Jo=C3=A3o T=C3=A1vora > > Date: Fri, 14 Apr 2023 19:09:20 +0100 > > > > On Fri, Apr 14, 2023 at 7:03=E2=80=AFPM Dmitry Gutov = wrote: > > > > > > On 13/04/2023 17:47, Jo=C3=A3o T=C3=A1vora wrote: > > > > I'll push it to master soon, but leave this issue open for comments > > > > and/or feedback a little longer. > > > > > > Perhaps we want to backport it to emacs-29 as well? It *is* a bug, af= ter > > > all. > > > > Perhaps. Yes it's a bug. But at this point, I think that's for Eli > > to decide (i.e. I don't exactly what the policy is now vs two/three > > weeks ago). > > It depends on how bad is the bug, whether it's a regression since > Emacs 28, and how safe is the fix. In general, bugs should be fixed > on the release branch, unless the risk associated with the fix is too > high. Right, exactly. We were just talking about that. This is not a regression from Emacs 28 (I'm 99% sure). It was already there. But the bug is so-so-serious (somewhat annoying flickering, though not in TTY frames). The fix is simple enough (IMHO, of course, because I wrote the code ... and the bug). Do note, also, Eli, that ElDoc is a :core package. So, if we don't backport, people really really annoyed with this bug ( which manifests itself with Eglot primarily, though it could manifest with other packages) can get the bugfix if they simply upgrade ElDoc OR Eglot. Whether it's easy or not to do that is a matter for bug#62720. Of course they might also get _other_ bugs and new features, etc if they upgrade. So maybe that weighs on your decision. You can check out the fix in 83b5e9cd24ddcbb04dbd5db9a07248ff7fa301ab. If you don't say anything I will backport in a few days. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 14 21:03:28 2023 Received: (at 62816) by debbugs.gnu.org; 15 Apr 2023 01:03:28 +0000 Received: from localhost ([127.0.0.1]:47954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnUK8-0001mS-Ea for submit@debbugs.gnu.org; Fri, 14 Apr 2023 21:03:28 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:52215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnUK6-0001lv-Ex for 62816@debbugs.gnu.org; Fri, 14 Apr 2023 21:03:27 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 3ED005823B9; Fri, 14 Apr 2023 21:03:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 14 Apr 2023 21:03:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681520599; x=1681524199; bh=gWKQvy+l7PcbO0A0zrhRVCmAo/pe2URSY2d UTuVLQIA=; b=NjyvMufhIer5v8HYWVnu6qDJ0rE/4MNDbGO9Npx6MCE8qVa2ZT9 nFO+AS1RWQMNQg53qja+5ipckVtTvsAPDir9BsazhofOzJYZJUvlm20DMgWOUieB YRxQqmp98ac9mZh0ieCL2X6bxoyNCSMzn9LaZ7Nc4KpxLburPA99Q3Z0NISglYIC I0Kvut2e9fxcvlCa/TK1UI5c4o2/4G+FlTxdogMANYGplMMklfm18ZGooE5ZWm+D EDfOe5uTSJmpCEjlxyXZXPCPkA6ivSGpKw/DgOAHFXDgJWrEbxFZcvHZFuq0JrWo XWWBLfMMltsBhzLz4h/Ux0yfPCLMLfcd0JA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681520599; x=1681524199; bh=gWKQvy+l7PcbO0A0zrhRVCmAo/pe2URSY2d UTuVLQIA=; b=JnJVLWht1Cm7bsfK90p4KMra/QRcBl8W8dQc1qYUZGfPjFJZVy7 zAxk8/GjV2U8VyL+A2niHVLCEEV0CDum05qoCJYbnppajdaozk6JLI3qsiXcSTqs r/UIw0GDnuRv0L52u2Oqi/smaBM+kqtD+w1UsCoULs13cK572FButI03FjUCkUMK /xlJJty3xF6qRTH23U/aKJlWMty9z+aXIii6aIx2SrkXiCKD96gRG2PQZCSYvovp KTr/2KzXA99+h/YcptsPKCHYttg7L7HwN1acM0BWMwa8/414FzQYT2290sfXhG/D vL7CjltIx/+J9wr7TYdDNL7gxFr8KQ4I0aA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeluddggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffhvfevfhgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfeftdejleetffelhfffteefgfeggfejgfdtudeuvedttdetvdelffekvdeg udetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Apr 2023 21:03:17 -0400 (EDT) Message-ID: <38c5efc6-2b28-b09d-eef6-e9e8c97d7bbd@gutov.dev> Date: Sat, 15 Apr 2023 04:03:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used Content-Language: en-US From: Dmitry Gutov To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <87leivsusz.fsf@gmail.com> <87ttxj2wpm.fsf@gmail.com> <2e04fa32-d52e-73ac-dabb-7ed5396dce0a@gutov.dev> <87jzyf2u8n.fsf@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 62816 Cc: 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 14/04/2023 03:22, Dmitry Gutov wrote: >>>> Another option is just to temporarily disable eldoc during the duration >>>> of the Company completion session. >>> >>> Right. >>> >>> And yet another solution would be to detect that Eldoc will be used, >>> and try to plug into its documentation functions to display the meta >>> thingy alongside the other info. >>> >>> That's at least 3 potential solutions now. >> >> I think you should do the "bookkeeping" one, at least a very simple >> version.  Just record in your concept of a "company session" if there >> was ever a non-nil :company-docsig sent from anywhere that required >> echoing.  Until there is, never clear on nil :company-docsig. >> Eventually, if there is something to echo, tough luck: display it and >> proceed as currently, clearing always on nil, risking flickering. >> Suspect this should fix 95% of the cases, certainly Eglot usages. > > Yeah, that should be the most conservative solution. Maybe I'll start > with it. I've pushed a halfway-there solution which still seems to satisfy both main scenarios (exemplified by Elisp and Eglot), so that seems addressed. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 15 05:13:31 2023 Received: (at 62816) by debbugs.gnu.org; 15 Apr 2023 09:13:31 +0000 Received: from localhost ([127.0.0.1]:48224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnbyN-0003sW-0H for submit@debbugs.gnu.org; Sat, 15 Apr 2023 05:13:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnbyL-0003sJ-O0 for 62816@debbugs.gnu.org; Sat, 15 Apr 2023 05:13:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnbyF-0000X7-Ra; Sat, 15 Apr 2023 05:13:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=29/jNETAOxDSJQEJkM1TYUyWdMiFcvQH9kGCg95cesM=; b=lveWaoui1YM39+MO8Ugr VIx/bl0oIZq8U3Ghx7yrEavy3vq6BuHBXpaAtm+c81GL2UORzrDAGs85iqqo4KS7y3fmBwKEMIWHs wa37f+DR/q+YK9Xo9IbkxiU9Ei3CgHbwOB/mp9UjPJ4TEua7gXbkOt6B/XmKVtuIK7FsXpZAMY3Ag jjPwIT378wBVKRjqOeysWXoDTDA49xVxegjFV2x7QFmp4m4v/PIWL6WXjjvnXg88M/fDzdvbixSvn K6Gh1HEWCB4Yv/d7QgZv16uNYQl9LDqTf8B894htcvw2iqtRkVlkEz6/nK+AtzFYX4DZ1pSH1O/7v pa+oBncXhiAaTg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnbyF-0001J2-BM; Sat, 15 Apr 2023 05:13:23 -0400 Date: Sat, 15 Apr 2023 12:13:23 +0300 Message-Id: <834jphecek.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Fri, 14 Apr 2023 20:58:16 +0100) Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used References: <87leivsusz.fsf@gmail.com> <16986ddd-e47b-c092-38d3-1e19da4229c4@gutov.dev> <83wn2ee1mr.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62816 Cc: dmitry@gutov.dev, 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Fri, 14 Apr 2023 20:58:16 +0100 > Cc: dmitry@gutov.dev, 62816@debbugs.gnu.org > > > > > Perhaps we want to backport it to emacs-29 as well? It *is* a bug, after > > > > all. > > > > > > Perhaps. Yes it's a bug. But at this point, I think that's for Eli > > > to decide (i.e. I don't exactly what the policy is now vs two/three > > > weeks ago). > > > > It depends on how bad is the bug, whether it's a regression since > > Emacs 28, and how safe is the fix. In general, bugs should be fixed > > on the release branch, unless the risk associated with the fix is too > > high. > > Right, exactly. We were just talking about that. This is not a > regression from Emacs 28 (I'm 99% sure). It was already there. > But the bug is so-so-serious (somewhat annoying flickering, though > not in TTY frames). The fix is simple enough (IMHO, of course, > because I wrote the code ... and the bug). What is the bug, exactly? Is it just that the mini-window gets resized back and forth in some scenario? Or is it something else? > Do note, also, Eli, that ElDoc is a :core package. So, if we > don't backport, people really really annoyed with this bug ( > which manifests itself with Eglot primarily, though it could > manifest with other packages) can get the bugfix if they simply > upgrade ElDoc OR Eglot. Whether it's easy or not to do that > is a matter for bug#62720. Of course they might also get > _other_ bugs and new features, etc if they upgrade. Right, so I don't think this aspect is very relevant to the decision whether to backport the fix. > So maybe that weighs on your decision. You can check out the fix > in 83b5e9cd24ddcbb04dbd5db9a07248ff7fa301ab. Sounds scary. I'd prefer to leave it on master at this time. Unless the bug it fixes is more than just resizing of the mini-window. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 15 07:03:06 2023 Received: (at 62816-done) by debbugs.gnu.org; 15 Apr 2023 11:03:06 +0000 Received: from localhost ([127.0.0.1]:48356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pndgQ-0001cA-0V for submit@debbugs.gnu.org; Sat, 15 Apr 2023 07:03:06 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:33509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pndgN-0001bf-Pd for 62816-done@debbugs.gnu.org; Sat, 15 Apr 2023 07:03:04 -0400 Received: by mail-ot1-f52.google.com with SMTP id v15-20020a9d7d0f000000b006a43af689b6so3157853otn.0 for <62816-done@debbugs.gnu.org>; Sat, 15 Apr 2023 04:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681556578; x=1684148578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RlfN+14hYGR95QCCmVVx3VC2De3+cTpcTb5JVtGvzrU=; b=G3UxMN8W4UV1XL6ddCZTvc5rKi1oOcfHm5E4XBjYmIX/LpS4cSB5EVVs5DoXjakZpd G5pthkd02kRbl/QlIeah4+kyPzRKLgxnd7+encOeCp4PtShH1tg7+VRiZl8agX/eFEf7 t1Flvof4avTdp8GdU6cF/hFZBk2egeDFkRai0nKLbvSVOH/GNGypft44Qeh0ohGwX6Lw iIE9iOQY6c/Wq12MNh+z/z4oW+38dUULDl5Zh6RYwWKTM1QZXFsyAMAKwHEOodTwhUug iNWCdgqmWW8AFDWjeZfibBStg9Dzwf3vsgEw31eJYxvOdNDAjq7CHn2poN+HN5gKj20Y Lu3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681556578; x=1684148578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RlfN+14hYGR95QCCmVVx3VC2De3+cTpcTb5JVtGvzrU=; b=A3ucsEkmzcucR/5ywx+Aqh0BY5zq/hD/jMaq6AseWIA1AdI9qcIprovkWTzOwRgtrc cIabExUiMuoQOjAhUAfgr8GMcMoqG+iIY55otm/wzTVfIxRkRvoj5zSIb6D1PDju/4Wn TYWTmekoe4n1Z9OWI5BDmllrrAJ8tMWKeY83X7LzQ6VJpK0W+XtaD2xXHpc8dvLaCdFP Vkf1fo7IgTny7GeWP1836C37UZY37dVNiZGO6dP5vwHjwDiriVU85Yo/xqDbhl0By6eR UnQmZjVHipAu88r/tVYnoQ3IKDh4i5X0cfhwwIv0I5Z903/hpGMg64fANpRuGn9vxFhN 6b3A== X-Gm-Message-State: AAQBX9fFKcC7saNe587+GX1Ws3Xz68Z5TofS+0g3Gcfd2nJklxdLIdMo nFTwsbit/N7D/4LMJXw5c7yNN3gfxIMA/eWyPHY= X-Google-Smtp-Source: AKy350ZoapMU3WGmAY/fg9lhcO6KWeNY0ZjGyekDdUyOw+UaaD3i8roLoPtATltPSt66Y4HlJDKE7zLOvx46iexfa5Y= X-Received: by 2002:a9d:4d86:0:b0:6a5:cf74:d56f with SMTP id u6-20020a9d4d86000000b006a5cf74d56fmr290623otk.4.1681556577942; Sat, 15 Apr 2023 04:02:57 -0700 (PDT) MIME-Version: 1.0 References: <87leivsusz.fsf@gmail.com> <16986ddd-e47b-c092-38d3-1e19da4229c4@gutov.dev> <83wn2ee1mr.fsf@gnu.org> <834jphecek.fsf@gnu.org> In-Reply-To: <834jphecek.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 15 Apr 2023 12:04:54 +0100 Message-ID: Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used To: Eli Zaretskii , 62816-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62816-done Cc: dmitry@gutov.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Apr 15, 2023 at 10:13=E2=80=AFAM Eli Zaretskii wrote= : > > So maybe that weighs on your decision. You can check out the fix > > in 83b5e9cd24ddcbb04dbd5db9a07248ff7fa301ab. > > Sounds scary. I'd prefer to leave it on master at this time. Unless > the bug it fixes is more than just resizing of the mini-window. OK. That was my initial assessment too (though I wouldn't call it scary). So I guess I'm closing the bug, as there's nothing more to do. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 15 07:40:31 2023 Received: (at 62816) by debbugs.gnu.org; 15 Apr 2023 11:40:32 +0000 Received: from localhost ([127.0.0.1]:48404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pneGd-00056b-MN for submit@debbugs.gnu.org; Sat, 15 Apr 2023 07:40:31 -0400 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:43229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pneGb-00056M-KN for 62816@debbugs.gnu.org; Sat, 15 Apr 2023 07:40:29 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id A9DC62B06A40; Sat, 15 Apr 2023 07:40:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 15 Apr 2023 07:40:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681558823; x=1681562423; bh=hYqyieX5foNSS+OfaTnZnu4P7K+UJtrZWP9 6cUAM+zM=; b=HAr7LUoQSDJk3xtyqpAbVv5MPt4uqt4XmePObOSRPcJ5whAcE2Q M+QKrRs3v56nOEkMw7HerI7gzL24YpzgKnvZgfUCWJ/eGTX+CRF773K7hAzlICco ylkdO8THsz8EDREYXfgV7mF26Kh6azJGyIvwxGMqLWYqx+An9lDzdW4fJp90PkXQ h4tVKHEE8YxO489MnILNkB4VsVeVhsrk7S7iS7MmcGY8vzx8U1GkhnylBjnKlPZf bKNJbP/i3DuLYLDPQUfFOv6P+JayTTAIHtngeII7XycXIri5lWuhQXJ4xU8PJcWK z/dReCmKLhkXZUB8C7y0vu7hjdjiIs5GAgw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681558823; x=1681562423; bh=hYqyieX5foNSS+OfaTnZnu4P7K+UJtrZWP9 6cUAM+zM=; b=VXTLCxi82a/sFKSyxCNxpaGTiIHGACFSVoekOeD9l5TarVZ0aVW 8pV507tFxqlYGL3RMzastfmso9BZPAoloTMq4gFdsPbjilqQfk3AbuDInevWI9xB 8UwAaS5ObUK7BDiQUqQZxe8gHMkTx8Wah+3FsZgKJMH+0faWPQKu8Q+cVOPHrJeh BCSMvdC3hnUsyuwKhwroL8Wu2bS9bpBtkNVrrGWYYsK8PwLhNhGg+Thg6uf3UQI5 k/N0Z60lCsulhKsMyv1MPpr5R6axm+DxC7VM07imkEjy2DOg8Am11vY1Qxl/+wi5 fuXIX7JquPyQstYQ96C/NEsaEyewV9BCLzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelvddggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 15 Apr 2023 07:40:21 -0400 (EDT) Message-ID: <472de165-ea1b-817e-f8b6-d4b70e4e5613@gutov.dev> Date: Sat, 15 Apr 2023 14:40:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used Content-Language: en-US To: Eli Zaretskii , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <87leivsusz.fsf@gmail.com> <16986ddd-e47b-c092-38d3-1e19da4229c4@gutov.dev> <83wn2ee1mr.fsf@gnu.org> <834jphecek.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <834jphecek.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 62816 Cc: 62816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On 15/04/2023 12:13, Eli Zaretskii wrote: >> Right, exactly. We were just talking about that. This is not a >> regression from Emacs 28 (I'm 99% sure). It was already there. >> But the bug is so-so-serious (somewhat annoying flickering, though >> not in TTY frames). The fix is simple enough (IMHO, of course, >> because I wrote the code ... and the bug). > What is the bug, exactly? Is it just that the mini-window gets > resized back and forth in some scenario? Or is it something else? Resized back and forth, and "blinks" with blank content after every user keypress. Which makes it quite annoying to use eldoc-documentation-compose in GUI Emacs. The effect is only visual, though. From unknown Sat Aug 09 09:34:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 14 May 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator