GNU bug report logs - #62812
29.0.60; Persistent article cache not working properly

Previous Next

Packages: gnus, emacs;

Reported by: James Thomas <jimjoe <at> gmx.net>

Date: Thu, 13 Apr 2023 10:07:01 UTC

Severity: normal

Found in version 29.0.60

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Andrew G Cohen <cohen <at> andy.bu.edu>, 62812 <at> debbugs.gnu.org, James Thomas <jimjoe <at> gmx.net>
Subject: bug#62812: [PATCH] Re: bug#62812: 29.0.60; Persistent article cache not working properly
Date: Wed, 23 Aug 2023 09:47:17 -0700
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: James Thomas <jimjoe <at> gmx.net>
>> Date: Wed, 23 Aug 2023 19:07:51 +0530
>> 
>> James Thomas wrote:
>> 
>> > Turned out to be a trivial fix:
>> >
>> > diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el
>> > index e8f157392d4..904b564409a 100644
>> > --- a/lisp/gnus/nnmail.el
>> > +++ b/lisp/gnus/nnmail.el
>> > @@ -667,7 +667,9 @@ nnmail-parse-active
>> >  		  (cond ((symbolp group)
>> >  			 (symbol-name group))
>> >  			((numberp group)
>> > -			 (number-to-string group))))
>> > +			 (number-to-string group))
>> > +                        ((stringp group)
>> > +			 group)))
>> >  	    (if (and (numberp (setq max (read buffer)))
>> >  		     (numberp (setq min (read buffer))))
>> >  		(push (list group (cons min max))
>> 
>> And it'll merely make it the same as this already-existing code
>> elsewhere:
>> 
>> diff -u --label ./lisp/gnus/gnus-start.el --label \#\<buffer\ gnus-start.el\> ./lisp/gnus/gnus-start.el /tmp/buffer-content-IYvzRp
>> --- ./lisp/gnus/gnus-start.el
>> +++ #<buffer gnus-start.el>
>> @@ -2149,8 +2149,6 @@
>>  					     (number-to-string group))
>>  					    ((symbolp group)
>>  					     (symbol-name group))
>> -					    ((stringp group)
>> -					     group)))))
>>  		     (numberp (setq max (read cur)))
>>  		     (numberp (setq min (read cur)))
>>  		     (null (progn
>> 
>> --
>
> Eric, Andrew: any comments?

Yes! This looks like a correct fix to me.




This bug report was last modified 1 year and 269 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.