From unknown Wed Jun 18 23:17:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62770 <62770@debbugs.gnu.org> To: bug#62770 <62770@debbugs.gnu.org> Subject: Status: [PATCH] services: dhcp-client-configuration: Add 'shepherd-requirement' field. Reply-To: bug#62770 <62770@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:17:09 +0000 retitle 62770 [PATCH] services: dhcp-client-configuration: Add 'shepherd-re= quirement' field. reassign 62770 guix-patches submitter 62770 Sergey Trofimov severity 62770 normal tag 62770 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 11 03:34:19 2023 Received: (at submit) by debbugs.gnu.org; 11 Apr 2023 07:34:19 +0000 Received: from localhost ([127.0.0.1]:36520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm8WB-0000QK-BC for submit@debbugs.gnu.org; Tue, 11 Apr 2023 03:34:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:59882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm8W8-0000QC-VL for submit@debbugs.gnu.org; Tue, 11 Apr 2023 03:34:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm8W8-00022R-JD for guix-patches@gnu.org; Tue, 11 Apr 2023 03:34:16 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pm8W5-00057l-R1 for guix-patches@gnu.org; Tue, 11 Apr 2023 03:34:15 -0400 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-50489acccdfso1726639a12.1 for ; Tue, 11 Apr 2023 00:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sarg.org.ru; s=google; t=1681198450; x=1683790450; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PQQ+Qpk7Izjc93OjfK96zBqMMHAmjHi5a3USV97opUU=; b=SDj6eLW755Klselvx+YfOkQCMOryB9YzFFugdGYsUjHuiGnAQNlSCAGT4A2d2ftzoi nXAoMnK0GXnZMPmDgXnaVA3h3B9jWdlQ8dPekb8JzrNAwNT1H4H/Qj2I7ejodDFAtIxe fZJa4rkfnfgucZ1ctT24b4syBqAAP83Sp7oZ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681198450; x=1683790450; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PQQ+Qpk7Izjc93OjfK96zBqMMHAmjHi5a3USV97opUU=; b=x90nPWuk7zylkb1k25oM2qWVdZ+a65jos16W1kW23lqvpymXcs3TgGeC3wIfc2mIrM ZLTVc6oyaWy4q64wbeO9iFaj2QQkIxEPCW55MujwAyPJlsWnXqWo3xuN/FM1ZGtT9QS9 kzhGwPgnO3hbJE1zd35jqY2Lwvo8L3Ary7BMbZKEFZmMokbEtAL+sWvsKbdLxO85Nb0L d2cqdBLlrq6xtxdV0IX7ZWiUtkmwMlh+vhATDagATcpmiHlN/coytIqdKQdcvg6PdmGA ygyBF9MUJ5AA+nyxhksElXJ0nt4Cx1GkmMpdoB07IDPv0i3QtIMyeSPUt/p4H9b5QIYu 9H9Q== X-Gm-Message-State: AAQBX9eHppFeGVvlKqYryo7EeE4ztz33WF3xOcb7qMKIXVho1U/fCN6E jQvgjX9yWiOIT76Mj5mMePOErdEDW9fo0/UB87Tdng== X-Google-Smtp-Source: AKy350Y/iF/x0zcaSPo7Oa0CJBRPQJ6nhqpBWDspGpd4YJS+Dlbswag3scDuYfA4r6VmwWJZFSjVwg== X-Received: by 2002:a05:6402:643:b0:4fb:98e2:3df8 with SMTP id u3-20020a056402064300b004fb98e23df8mr11905108edx.27.1681198449670; Tue, 11 Apr 2023 00:34:09 -0700 (PDT) Received: from localhost ([95.168.154.15]) by smtp.gmail.com with ESMTPSA id f6-20020a50d546000000b00501d39f1d2dsm5609191edj.41.2023.04.11.00.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 00:34:09 -0700 (PDT) From: Sergey Trofimov To: guix-patches@gnu.org Subject: [PATCH] services: dhcp-client-configuration: Add 'shepherd-requirement' field. Date: Tue, 11 Apr 2023 09:33:57 +0200 Message-Id: <20230411073357.30021-1-sarg@sarg.org.ru> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=2a00:1450:4864:20::52b; envelope-from=sarg@sarg.org.ru; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Sergey Trofimov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/services/networking.scm () [shepherd-requirement]: New field. (dhcp-client-shepherd-service): Honor it. (dhcp-client-configuration-shepherd-requirement): Export accessor. * doc/guix.texi (Networking Setup): Document it. --- doc/guix.texi | 8 +++++++- gnu/services/networking.scm | 6 +++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index ac60acf98c..25f06fd0a8 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -19892,6 +19892,12 @@ should listen on---e.g., @code{'("eno1")}. When set to @code{'all}, the DHCP client listens on all the available non-loopback interfaces that can be activated. Otherwise the DHCP client listens only on the specified interfaces. + +@item @code{shepherd-requirement} (default: @code{'()}) +This option can be used to provide a list of symbols naming Shepherd services +that this service will depend on, such as @code{'wpa-supplicant} or +@code{'iwd} if you require authenticated access for encrypted WiFi or Ethernet +networks. @end table @end deftp @@ -19995,7 +20001,7 @@ Data Type representing the configuration of connman. @item @code{connman} (default: @var{connman}) The connman package to use. -@item @code{shepherd-requirement} (default: @code{()}) +@item @code{shepherd-requirement} (default: @code{'()}) This option can be used to provide a list of symbols naming Shepherd services that this service will depend on, such as @code{'wpa-supplicant} or @code{'iwd} if you require authenticated access for encrypted WiFi or Ethernet diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index 19c109d238..1b2e6a8c53 100644 --- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -89,6 +89,7 @@ (define-module (gnu services networking) dhcp-client-configuration? dhcp-client-configuration-package dhcp-client-configuration-interfaces + dhcp-client-configuration-shepherd-requirement dhcpd-service-type dhcpd-configuration @@ -279,6 +280,8 @@ (define-record-type* dhcp-client-configuration? (package dhcp-client-configuration-package ;file-like (default isc-dhcp)) + (shepherd-requirement dhcp-client-configuration-shepherd-requirement + (default '())) (interfaces dhcp-client-configuration-interfaces (default 'all))) ;'all | list of strings @@ -286,11 +289,12 @@ (define dhcp-client-shepherd-service (match-lambda ((? dhcp-client-configuration? config) (let ((package (dhcp-client-configuration-package config)) + (shepherd-requirement (dhcp-client-configuration-shepherd-requirement config)) (interfaces (dhcp-client-configuration-interfaces config)) (pid-file "/var/run/dhclient.pid")) (list (shepherd-service (documentation "Set up networking via DHCP.") - (requirement '(user-processes udev)) + (requirement `(user-processes udev ,@shepherd-requirement)) ;; XXX: Running with '-nw' ("no wait") avoids blocking for a minute when ;; networking is unavailable, but also means that the interface is not up -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Thu May 11 08:35:54 2023 Received: (at 62770-done) by debbugs.gnu.org; 11 May 2023 12:35:54 +0000 Received: from localhost ([127.0.0.1]:49965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px5WU-0004HI-4U for submit@debbugs.gnu.org; Thu, 11 May 2023 08:35:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px5WS-0004H4-Ab for 62770-done@debbugs.gnu.org; Thu, 11 May 2023 08:35:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px5WL-0008SH-GS; Thu, 11 May 2023 08:35:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=yOpidUZavBbZ+5+bbT4SNpkpAIZ4mQUM5rtHihQ40uk=; b=Hhcty6CMAPaYw2K0Weha Kd/alhgP5o6WlYE4Z6RVFE+1RQxXnP/kV13dAlFvBdOxMhR0kb2cWnkmFI1ZKAgLuxVoA3j73BP9H SLk+fDMwpLm+gPjWkQ8+hVtgnZXHOkZ1BMXDWeTsLV+RPh50JN1d78ubi4lKNsfMNHYmpWzcbMOvv nw2ENsR4SCmhFb3eyF47GqseY08RLof79ts+uHMWDuxIUqNy70C75i8fiAbt11N27aZU4DxK69Y2d ccVIEEeN+V80ULE0eM65ZM3hFAOgN125qYfNCFkA0KTkKrj27+kt2O2yyeHqLK7AmRH1x5Wpt1Md2 bFbB1Vy4CUSB/Q==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px5WK-00083S-PM; Thu, 11 May 2023 08:35:45 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Sergey Trofimov Subject: Re: bug#62770: [PATCH] services: dhcp-client-configuration: Add 'shepherd-requirement' field. References: <20230411073357.30021-1-sarg@sarg.org.ru> Date: Thu, 11 May 2023 14:35:43 +0200 In-Reply-To: <20230411073357.30021-1-sarg@sarg.org.ru> (Sergey Trofimov's message of "Tue, 11 Apr 2023 09:33:57 +0200") Message-ID: <87ilcz3v1c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62770-done Cc: 62770-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Sergey Trofimov skribis: > * gnu/services/networking.scm () > [shepherd-requirement]: New field. > (dhcp-client-shepherd-service): Honor it. > (dhcp-client-configuration-shepherd-requirement): Export accessor. > * doc/guix.texi (Networking Setup): Document it. Applied, thanks! Ludo=E2=80=99. From unknown Wed Jun 18 23:17:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Jun 2023 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator