From unknown Tue Jun 17 22:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62769: pcre: correct overpessimistic error checking of pcre2_jit_compile() Resent-From: Carlo Arenas Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Tue, 11 Apr 2023 06:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62769 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: 62769@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168119564928648 (code B ref -1); Tue, 11 Apr 2023 06:48:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Apr 2023 06:47:29 +0000 Received: from localhost ([127.0.0.1]:36422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm7mr-0007S0-Hz for submit@debbugs.gnu.org; Tue, 11 Apr 2023 02:47:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:54744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm7mq-0007Rs-0v for submit@debbugs.gnu.org; Tue, 11 Apr 2023 02:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm7mm-0008UJ-H1 for bug-grep@gnu.org; Tue, 11 Apr 2023 02:47:25 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pm7mk-0003tG-Cp for bug-grep@gnu.org; Tue, 11 Apr 2023 02:47:23 -0400 Received: by mail-wr1-x436.google.com with SMTP id q29so6249499wrc.3 for ; Mon, 10 Apr 2023 23:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681195640; x=1683787640; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=KpHLb++OLnaS1ktsx7s2H70toy7/8oC+TjccudWTMao=; b=bETEMJCNABxZj3zMFvstUrqr9jUiunsTLb+Ux8hBidprKSYUZ3hHKo9ITMkTflxEKB rVVXNoocrCHq6RHsA1dCXKZVeW7ncuKxiJC+eLtACNzypbKltV/bbh4NhNY8i1DtNkJW HF+IAXhtehYAu9xAwMy4QKOuIXfMBdby4QShj3pdwkYZN7PrA7E/pANb+pCF7FqKFk8s IkzkjeHGzJwiNFXdZOg9h8rzyp65rzhjjaDK+nzNxnXO0yucN8sH/MUFvvNI0idCakHw cjFmtc64mdM5q87ovYJjs4VM3neM9vTaMk8bD6mCZVCfm+G623xJv/HDsVLZap4T91Po idWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681195640; x=1683787640; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KpHLb++OLnaS1ktsx7s2H70toy7/8oC+TjccudWTMao=; b=JuE5E4KNE1JyrzfikJdDiZEVPRTzJfHCqgPp2HOjo0sdwG5Dk2fcaKt4bMXVF+V1wY L7Abtw20zEBgtDUkD3pRRpj4ukFRGvXlmjUjgIbgD/v4qmASCdtuU2vfS7m6FGLgIL0a 6rJRwOg2ua4JA0HliALLbbPHDGDm7Rfmgl73TZnLhMFIjn8ppDxGE4WLfL6EBFLE3QST VHnujILKkMtS1h5IFsYV2QXxBfEg3+T0UjoFZPebgzhcjyk5AkJrWhx0qhVmy2MMStR+ 5ZDepmlLrv2ApvT9b5mLKvurcLMpFBZPVUZTGDS1tl0Nvx6qqLaGIVm9Tk15YmKOyanY 2jyg== X-Gm-Message-State: AAQBX9fJ7Jg/kPvXbRafgDWjBMVNhRJRdIdAfQOYRKnt9owKeIsluzwd PNqatDqWCW5xqnm8dAkcLTrrAkWxiOhWpEdFHJp0Ft4G X-Google-Smtp-Source: AKy350b2pxA6Sn0V5xKOPUks+4TYRhUxg91wJmFBTqmaNjP89p+9m9Q227dXI1ygsoA+3yr0xaMFcLl/V/u2PwiHdd8= X-Received: by 2002:a5d:59a7:0:b0:2cf:ef9f:33f6 with SMTP id p7-20020a5d59a7000000b002cfef9f33f6mr3940870wrr.1.1681195640006; Mon, 10 Apr 2023 23:47:20 -0700 (PDT) MIME-Version: 1.0 From: Carlo Arenas Date: Mon, 10 Apr 2023 23:47:08 -0700 Message-ID: Content-Type: multipart/mixed; boundary="000000000000ec038e05f909dcb4" Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=carenas@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000ec038e05f909dcb4 Content-Type: text/plain; charset="UTF-8" The original code was done in a way that would be useful during porting, but that would hinder future work unnecessarily. Carlo --000000000000ec038e05f909dcb4 Content-Type: application/octet-stream; name="0001-pcre-correct-overpessimistic-error-checking-of-pcre2.patch" Content-Disposition: attachment; filename="0001-pcre-correct-overpessimistic-error-checking-of-pcre2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lgbwgn9g0 RnJvbSBhMTVjYTM5NGM5MmNjZjQwMjEwMGEyYTEzOGRlMjhiYzE3MjkyOTFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Q2FybG89MjBNYXJjZWxvPTIwQXJlbmFzPTIw QmVsPUMzPUIzbj89IDxjYXJlbmFzQGdtYWlsLmNvbT4KRGF0ZTogTW9uLCAxMCBBcHIgMjAyMyAy MzoyMjo1MyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHBjcmU6IGNvcnJlY3Qgb3ZlcnBlc3NpbWlz dGljIGVycm9yIGNoZWNraW5nIG9mCiBwY3JlMl9qaXRfY29tcGlsZSgpCk1JTUUtVmVyc2lvbjog MS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgoqIHNyYy9wY3Jlc2VhcmNoLmM6IGZpeCBpbXBsZW1lbnRhdGlv biB0byBtYXRjaCBkb2N1bWVudGF0aW9uWzFdCmtlZXAgdGhlIGZhdGFsIGVycm9yIG9ubHkgZm9y IHRoZSBlcnJvciBtZXNzYWdlIHRoYXQgd2FycmFudHMgaXQgYW5kIHRoYXQKd291bGQgYmUgaW5k aWNhdGl2ZSBvZiBhIGJ1ZyAoUENSRTJfRVJST1JfSklUX0JBRE9QVElPTikgYW5kIG1ha2UgdGhl CmNvbW1vbmx5IHRyaWdnZXJlZCAoZXg6IHVuZGVyIFNFTGludXgpIFBDUkUyX0VSUk9SX05PTUVN T1JZIGFuZCB0aGF0IGlzCm1lYW50IHRvIGJlIGlnbm9yZWQuCgpbMV0gaHR0cHM6Ly9wY3JlMnBy b2plY3QuZ2l0aHViLmlvL3BjcmUyL2RvYy9odG1sL3BjcmUyX2ppdF9jb21waWxlLmh0bWwKClNp Z25lZC1vZmYtYnk6IENhcmxvIE1hcmNlbG8gQXJlbmFzIEJlbMOzbiA8Y2FyZW5hc0BnbWFpbC5j b20+Ci0tLQogc3JjL3BjcmVzZWFyY2guYyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvcGNyZXNlYXJjaC5j IGIvc3JjL3BjcmVzZWFyY2guYwppbmRleCA5ZTJmMzkzLi5jZDZjZTcxIDEwMDY0NAotLS0gYS9z cmMvcGNyZXNlYXJjaC5jCisrKyBiL3NyYy9wY3Jlc2VhcmNoLmMKQEAgLTI0NCw4ICsyNDQsOCBA QCBQY29tcGlsZSAoY2hhciAqcGF0dGVybiwgaWR4X3Qgc2l6ZSwgcmVnX3N5bnRheF90IGlnbm9y ZWQsIGJvb2wgZXhhY3QpCiAgIHBjLT5kYXRhID0gcGNyZTJfbWF0Y2hfZGF0YV9jcmVhdGVfZnJv bV9wYXR0ZXJuIChwYy0+Y3JlLCBnY29udGV4dCk7CiAKICAgZWMgPSBwY3JlMl9qaXRfY29tcGls ZSAocGMtPmNyZSwgUENSRTJfSklUX0NPTVBMRVRFKTsKLSAgaWYgKGVjICYmIGVjICE9IFBDUkUy X0VSUk9SX0pJVF9CQURPUFRJT04gJiYgZWMgIT0gUENSRTJfRVJST1JfTk9NRU1PUlkpCi0gICAg ZGllIChFWElUX1RST1VCTEUsIDAsIF8oIkpJVCBpbnRlcm5hbCBlcnJvcjogJWQiKSwgZWMpOwor ICBpZiAoZWMgPCAwICYmIGVjID09IFBDUkUyX0VSUk9SX0pJVF9CQURPUFRJT04pCisgICAgZGll IChFWElUX1RST1VCTEUsIDAsIF8oIkpJVCB1bmV4cGVjdGVkIGludGVybmFsIGVycm9yOiAlZCIp LCBlYyk7CiAKICAgLyogVGhlIFBDUkUgZG9jdW1lbnRhdGlvbiBzYXlzIHRoYXQgYSAzMiBLaUIg c3RhY2sgaXMgdGhlIGRlZmF1bHQuICAqLwogICBwYy0+aml0X3N0YWNrID0gTlVMTDsKLS0gCjIu MzkuMiAoQXBwbGUgR2l0LTE0MykKCg== --000000000000ec038e05f909dcb4-- From unknown Tue Jun 17 22:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62769: pcre: correct overpessimistic error checking of pcre2_jit_compile() Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Tue, 11 Apr 2023 22:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62769 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: Carlo Arenas Cc: 62769@debbugs.gnu.org Received: via spool by 62769-submit@debbugs.gnu.org id=B62769.168125113312718 (code B ref 62769); Tue, 11 Apr 2023 22:13:01 +0000 Received: (at 62769) by debbugs.gnu.org; 11 Apr 2023 22:12:13 +0000 Received: from localhost ([127.0.0.1]:38444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmMDj-0003J1-6R for submit@debbugs.gnu.org; Tue, 11 Apr 2023 18:12:12 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:53542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmMDc-0003IS-Ss for 62769@debbugs.gnu.org; Tue, 11 Apr 2023 18:12:09 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A91843C097AFB; Tue, 11 Apr 2023 15:11:58 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id OKRkvWopssdJ; Tue, 11 Apr 2023 15:11:58 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 0A7723C097AFD; Tue, 11 Apr 2023 15:11:58 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 0A7723C097AFD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1681251118; bh=Wb+EBtMUoTg7v03jBkMfR4Q/sZ1z2+FHMZSB38H7OrM=; h=Message-ID:Date:MIME-Version:To:From; b=aOFX79iE0XD9Xi/T1pz2TKFaRgcSzinnztyOXIMmaZLBeIg90OGQ48p5Wt5OXtg73 0P/wQ5aEj/+cyTJZtB/qFyvBMbchGvJAeP01YYht8ixkY/fkBxV0wmaTjEbEirfqbZ cdXqAebUxq2rn6QkAxzDKHskgS4WkhTJGvJ3OyDpZ8fjZsOjPhzgwi3vYTqCW1DGFm XyNKHNDdD5bFYhltD4IbSL20Clcq6NudL5Mlx/9WokKRKv4gMHFpqy60Ybhk0IwbKH MRgNuiuCZ6G52UEvlv37F457l/0jzDJX44LI68Pj+iiIeLIJwK//9wZ1esK7XDD1h2 UqSlFdjkLk8YA== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3Ey8jzjcRMsQ; Tue, 11 Apr 2023 15:11:57 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id E6B523C097AFA; Tue, 11 Apr 2023 15:11:57 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------601JkwiFc5fILsqYFkxGUepZ" Message-ID: Date: Tue, 11 Apr 2023 15:11:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US References: From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------601JkwiFc5fILsqYFkxGUepZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/10/23 23:47, Carlo Arenas wrote: > The original code was done in a way that would be useful during > porting, but that would hinder future work unnecessarily. Thanks, but wouldn't the attached patch be better? If I understand you correctly, we can simply ignore pcre2_jit_compile failure as the search will still succeed (albet perhaps more slowly). --------------601JkwiFc5fILsqYFkxGUepZ Content-Type: text/x-patch; charset=UTF-8; name="0001-grep-make-P-survive-JIT-compilation-failure.patch" Content-Disposition: attachment; filename="0001-grep-make-P-survive-JIT-compilation-failure.patch" Content-Transfer-Encoding: base64 RnJvbSAyNzg2NGY1ZDBjZmQ3ZGNiNzA0YzZiYTFhZmUxZGZkY2M3NDU2OTI1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDExIEFwciAyMDIzIDE1OjEwOjA2IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZ3JlcDogbWFrZSAtUCBzdXJ2aXZlIEpJVCBjb21waWxhdGlvbiBmYWlsdXJlCgoqIHNy Yy9wY3Jlc2VhcmNoLmMgKFBjb21waWxlKTogSWdub3JlIGZhaWx1cmUgcmV0dXJucwpmcm9t IHBjcmUyX2ppdF9jb21waWxlLgotLS0KIHNyYy9wY3Jlc2VhcmNoLmMgfCA2ICsrKy0tLQog MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9zcmMvcGNyZXNlYXJjaC5jIGIvc3JjL3BjcmVzZWFyY2guYwppbmRleCA5ZTJm MzkzLi5lODY3ZjQ5IDEwMDY0NAotLS0gYS9zcmMvcGNyZXNlYXJjaC5jCisrKyBiL3NyYy9w Y3Jlc2VhcmNoLmMKQEAgLTI0Myw5ICsyNDMsOSBAQCBQY29tcGlsZSAoY2hhciAqcGF0dGVy biwgaWR4X3Qgc2l6ZSwgcmVnX3N5bnRheF90IGlnbm9yZWQsIGJvb2wgZXhhY3QpCiAgIHBj LT5tY29udGV4dCA9IE5VTEw7CiAgIHBjLT5kYXRhID0gcGNyZTJfbWF0Y2hfZGF0YV9jcmVh dGVfZnJvbV9wYXR0ZXJuIChwYy0+Y3JlLCBnY29udGV4dCk7CiAKLSAgZWMgPSBwY3JlMl9q aXRfY29tcGlsZSAocGMtPmNyZSwgUENSRTJfSklUX0NPTVBMRVRFKTsKLSAgaWYgKGVjICYm IGVjICE9IFBDUkUyX0VSUk9SX0pJVF9CQURPUFRJT04gJiYgZWMgIT0gUENSRTJfRVJST1Jf Tk9NRU1PUlkpCi0gICAgZGllIChFWElUX1RST1VCTEUsIDAsIF8oIkpJVCBpbnRlcm5hbCBl cnJvcjogJWQiKSwgZWMpOworICAvKiBJZ25vcmUgYW55IGZhaWx1cmUgcmV0dXJuIGZyb20g cGNyZTJfaml0X2NvbXBpbGUsIGFzIHRoYXQgbWVyZWx5CisgICAgIG1lYW5zIEpJVCB3b24n dCBiZSB1c2VkIGR1cmluZyBtYXRjaGluZy4gICovCisgIHBjcmUyX2ppdF9jb21waWxlIChw Yy0+Y3JlLCBQQ1JFMl9KSVRfQ09NUExFVEUpOwogCiAgIC8qIFRoZSBQQ1JFIGRvY3VtZW50 YXRpb24gc2F5cyB0aGF0IGEgMzIgS2lCIHN0YWNrIGlzIHRoZSBkZWZhdWx0LiAgKi8KICAg cGMtPmppdF9zdGFjayA9IE5VTEw7Ci0tIAoyLjM5LjIKCg== --------------601JkwiFc5fILsqYFkxGUepZ-- From unknown Tue Jun 17 22:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62769: pcre: correct overpessimistic error checking of pcre2_jit_compile() Resent-From: Carlo Arenas Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Wed, 12 Apr 2023 06:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62769 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: Paul Eggert Cc: 62769@debbugs.gnu.org Received: via spool by 62769-submit@debbugs.gnu.org id=B62769.168127974730952 (code B ref 62769); Wed, 12 Apr 2023 06:10:01 +0000 Received: (at 62769) by debbugs.gnu.org; 12 Apr 2023 06:09:07 +0000 Received: from localhost ([127.0.0.1]:38777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmTfG-00083A-Sb for submit@debbugs.gnu.org; Wed, 12 Apr 2023 02:09:07 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:33390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmTfD-00082e-6Y for 62769@debbugs.gnu.org; Wed, 12 Apr 2023 02:09:05 -0400 Received: by mail-wr1-f44.google.com with SMTP id j1so13702788wrb.0 for <62769@debbugs.gnu.org>; Tue, 11 Apr 2023 23:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681279737; x=1683871737; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zAk8x16QcS2s5VKlR7tBEczIi5TxhnfPJYONywnwgcg=; b=P/7pyyxPkwtYDiZGqD0kVfNtGPnSW3o5+MvK6hcN1VMFHfOJOJSzyc4m/TDZErXPWO 5z/4hh2VTToPD+qTa8LlaSGxOxlp7b37uswV7zR68l7TSBctPeHhn+2rX+3bB5ygtxg8 rzxhjS0KbitRXvZa+nKlmLKxOY0kMMdqFIsP6Fl7tQPV19qESc/EhaEZpZLoyVuK70ys S3nnle3icGSG7VGNrl9ALV9Gks2Kps0oNjPIogB/TryrtMlVkAyFnPQhLNJVz5qvD1nE kSd5YgMcEtMFw+4DEUpNHHUOq1VW5UDSMmRoMVyl9o/382jMhilLYFVVHXOUKFSYntwX Q+HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681279737; x=1683871737; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zAk8x16QcS2s5VKlR7tBEczIi5TxhnfPJYONywnwgcg=; b=XvGMjVcTQGgh1njUMsDvTLAlnkS/b+dI3BkeD2lPids5AJmcaHXTt3M7Dg0EsFZJUe nJGEyNiu4nRTvGzVBoaqoZwtqcK5YtpJskGRIWsCLm1BepfpSz13yjRblLUFGpAwXrck yTIfV+KHsHj+m3FkoTrkuWTdYCU9dGNqYcy49tZytTzaXQ1il0EO7feoH4dYottN2wFs O7IjYrG038iDKVqnqNXGYclWym1HnaN4IMYrFcjUBVmtulcZ3WYsVmvCccPQ/CmmmULQ 2VrnEogNIM49mS3pkzQc4t0SEa1G48H6JCwHcNfZNFNh+yZG/JT6KWEC9lHggxkdTOZe eJuA== X-Gm-Message-State: AAQBX9cmmnBYdaVAtFCBOZ2RuaL3BN9PjcXTW1EnuL0GWYSOJ4VyJik2 D1r415WqcLUd8WPvGq3HVxWhMNPbvq7pBLVh+sM= X-Google-Smtp-Source: AKy350ZYGDXXewCMgJZ6FUNGRBWBRVENQhpciaYs634pMTJL7gCcP12NP7fCAacp8+AojRu4fNn+Wm8zwzTgan1T4L4= X-Received: by 2002:a5d:4bd0:0:b0:2ce:a0c2:d9ee with SMTP id l16-20020a5d4bd0000000b002cea0c2d9eemr2081457wrt.1.1681279736897; Tue, 11 Apr 2023 23:08:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carlo Arenas Date: Tue, 11 Apr 2023 23:08:45 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Apr 11, 2023 at 3:11=E2=80=AFPM Paul Eggert wr= ote: > > On 4/10/23 23:47, Carlo Arenas wrote: > > The original code was done in a way that would be useful during > > porting, but that would hinder future work unnecessarily. > > Thanks, but wouldn't the attached patch be better? Yes. but I would probably prefer voiding the return value to make it explic= it. > If I understand you > correctly, we can simply ignore pcre2_jit_compile failure as the search > will still succeed (albeit perhaps more slowly). correct. Carlo From unknown Tue Jun 17 22:24:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Carlo Arenas Subject: bug#62769: closed (Re: bug#62769: pcre: correct overpessimistic error checking of pcre2_jit_compile()) Message-ID: References: X-Gnu-PR-Message: they-closed 62769 X-Gnu-PR-Package: grep Reply-To: 62769@debbugs.gnu.org Date: Thu, 13 Apr 2023 21:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1681423082-17551-1" This is a multi-part message in MIME format... ------------=_1681423082-17551-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #62769: pcre: correct overpessimistic error checking of pcre2_jit_compile() which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 62769@debbugs.gnu.org. --=20 62769: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62769 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1681423082-17551-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 62769-done) by debbugs.gnu.org; 13 Apr 2023 21:57:39 +0000 Received: from localhost ([127.0.0.1]:44974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn4wl-0004YT-BV for submit@debbugs.gnu.org; Thu, 13 Apr 2023 17:57:39 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:41204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn4wi-0004YC-8E for 62769-done@debbugs.gnu.org; Thu, 13 Apr 2023 17:57:37 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 52B843C02213D; Thu, 13 Apr 2023 14:57:30 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id hRcz9ye3ftx3; Thu, 13 Apr 2023 14:57:30 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 1CAA83C097AFB; Thu, 13 Apr 2023 14:57:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 1CAA83C097AFB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1681423050; bh=+NOA0yJ3FUKdyGx8QMxv/Wuy6XQJpadi2Zt194nsgcs=; h=Message-ID:Date:MIME-Version:To:From; b=LgsRXMpezHBmcuWH/8yhkShHY6OLbtuMSFYCyHL42/QryBmtYmLlMYBsQ7fq7vNW3 fc3TH9iiqHAm94fUtXOu5foS2HzQ7oGsU0oPXQ8O3yuKw+f+Le5aSYnZcalQfcJett 0flJeSI84TQgc+qZHLjtfStNqKA/C8G/xD3IsYERu9QrKUQXz3hNxhmJadUFga0sid 7oNrtIlPQisFwKsJqvQjC9q7vzDkamziixh2rH/EjkGW9OXZLETk8Ad5+NQ/wRQYZj 1Xh1clPhgpIWqIWVCuQ67YcZvASCGZtH29ybB7OoJaeJxnsY2gs3ZqNeuO+5G7Pck3 fYW2gtLD7eUHA== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IvB6SpNpnVXD; Thu, 13 Apr 2023 14:57:30 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 03B2C3C02213D; Thu, 13 Apr 2023 14:57:30 -0700 (PDT) Message-ID: Date: Thu, 13 Apr 2023 14:57:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: bug#62769: pcre: correct overpessimistic error checking of pcre2_jit_compile() Content-Language: en-US To: Carlo Arenas References: From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62769-done Cc: 62769-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 4/11/23 23:08, Carlo Arenas wrote: > Yes. but I would probably prefer voiding the return value to make it explicit. Thanks for checking. Casting expressions to void is not our style so I'll omit that (the comment makes things obvious to the reader anyway). So I installed the patch without the cast. ------------=_1681423082-17551-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Apr 2023 06:47:29 +0000 Received: from localhost ([127.0.0.1]:36422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm7mr-0007S0-Hz for submit@debbugs.gnu.org; Tue, 11 Apr 2023 02:47:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:54744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm7mq-0007Rs-0v for submit@debbugs.gnu.org; Tue, 11 Apr 2023 02:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm7mm-0008UJ-H1 for bug-grep@gnu.org; Tue, 11 Apr 2023 02:47:25 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pm7mk-0003tG-Cp for bug-grep@gnu.org; Tue, 11 Apr 2023 02:47:23 -0400 Received: by mail-wr1-x436.google.com with SMTP id q29so6249499wrc.3 for ; Mon, 10 Apr 2023 23:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681195640; x=1683787640; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=KpHLb++OLnaS1ktsx7s2H70toy7/8oC+TjccudWTMao=; b=bETEMJCNABxZj3zMFvstUrqr9jUiunsTLb+Ux8hBidprKSYUZ3hHKo9ITMkTflxEKB rVVXNoocrCHq6RHsA1dCXKZVeW7ncuKxiJC+eLtACNzypbKltV/bbh4NhNY8i1DtNkJW HF+IAXhtehYAu9xAwMy4QKOuIXfMBdby4QShj3pdwkYZN7PrA7E/pANb+pCF7FqKFk8s IkzkjeHGzJwiNFXdZOg9h8rzyp65rzhjjaDK+nzNxnXO0yucN8sH/MUFvvNI0idCakHw cjFmtc64mdM5q87ovYJjs4VM3neM9vTaMk8bD6mCZVCfm+G623xJv/HDsVLZap4T91Po idWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681195640; x=1683787640; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KpHLb++OLnaS1ktsx7s2H70toy7/8oC+TjccudWTMao=; b=JuE5E4KNE1JyrzfikJdDiZEVPRTzJfHCqgPp2HOjo0sdwG5Dk2fcaKt4bMXVF+V1wY L7Abtw20zEBgtDUkD3pRRpj4ukFRGvXlmjUjgIbgD/v4qmASCdtuU2vfS7m6FGLgIL0a 6rJRwOg2ua4JA0HliALLbbPHDGDm7Rfmgl73TZnLhMFIjn8ppDxGE4WLfL6EBFLE3QST VHnujILKkMtS1h5IFsYV2QXxBfEg3+T0UjoFZPebgzhcjyk5AkJrWhx0qhVmy2MMStR+ 5ZDepmlLrv2ApvT9b5mLKvurcLMpFBZPVUZTGDS1tl0Nvx6qqLaGIVm9Tk15YmKOyanY 2jyg== X-Gm-Message-State: AAQBX9fJ7Jg/kPvXbRafgDWjBMVNhRJRdIdAfQOYRKnt9owKeIsluzwd PNqatDqWCW5xqnm8dAkcLTrrAkWxiOhWpEdFHJp0Ft4G X-Google-Smtp-Source: AKy350b2pxA6Sn0V5xKOPUks+4TYRhUxg91wJmFBTqmaNjP89p+9m9Q227dXI1ygsoA+3yr0xaMFcLl/V/u2PwiHdd8= X-Received: by 2002:a5d:59a7:0:b0:2cf:ef9f:33f6 with SMTP id p7-20020a5d59a7000000b002cfef9f33f6mr3940870wrr.1.1681195640006; Mon, 10 Apr 2023 23:47:20 -0700 (PDT) MIME-Version: 1.0 From: Carlo Arenas Date: Mon, 10 Apr 2023 23:47:08 -0700 Message-ID: Subject: pcre: correct overpessimistic error checking of pcre2_jit_compile() To: bug-grep@gnu.org Content-Type: multipart/mixed; boundary="000000000000ec038e05f909dcb4" Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=carenas@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000ec038e05f909dcb4 Content-Type: text/plain; charset="UTF-8" The original code was done in a way that would be useful during porting, but that would hinder future work unnecessarily. Carlo --000000000000ec038e05f909dcb4 Content-Type: application/octet-stream; name="0001-pcre-correct-overpessimistic-error-checking-of-pcre2.patch" Content-Disposition: attachment; filename="0001-pcre-correct-overpessimistic-error-checking-of-pcre2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lgbwgn9g0 RnJvbSBhMTVjYTM5NGM5MmNjZjQwMjEwMGEyYTEzOGRlMjhiYzE3MjkyOTFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Q2FybG89MjBNYXJjZWxvPTIwQXJlbmFzPTIw QmVsPUMzPUIzbj89IDxjYXJlbmFzQGdtYWlsLmNvbT4KRGF0ZTogTW9uLCAxMCBBcHIgMjAyMyAy MzoyMjo1MyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHBjcmU6IGNvcnJlY3Qgb3ZlcnBlc3NpbWlz dGljIGVycm9yIGNoZWNraW5nIG9mCiBwY3JlMl9qaXRfY29tcGlsZSgpCk1JTUUtVmVyc2lvbjog MS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgoqIHNyYy9wY3Jlc2VhcmNoLmM6IGZpeCBpbXBsZW1lbnRhdGlv biB0byBtYXRjaCBkb2N1bWVudGF0aW9uWzFdCmtlZXAgdGhlIGZhdGFsIGVycm9yIG9ubHkgZm9y IHRoZSBlcnJvciBtZXNzYWdlIHRoYXQgd2FycmFudHMgaXQgYW5kIHRoYXQKd291bGQgYmUgaW5k aWNhdGl2ZSBvZiBhIGJ1ZyAoUENSRTJfRVJST1JfSklUX0JBRE9QVElPTikgYW5kIG1ha2UgdGhl CmNvbW1vbmx5IHRyaWdnZXJlZCAoZXg6IHVuZGVyIFNFTGludXgpIFBDUkUyX0VSUk9SX05PTUVN T1JZIGFuZCB0aGF0IGlzCm1lYW50IHRvIGJlIGlnbm9yZWQuCgpbMV0gaHR0cHM6Ly9wY3JlMnBy b2plY3QuZ2l0aHViLmlvL3BjcmUyL2RvYy9odG1sL3BjcmUyX2ppdF9jb21waWxlLmh0bWwKClNp Z25lZC1vZmYtYnk6IENhcmxvIE1hcmNlbG8gQXJlbmFzIEJlbMOzbiA8Y2FyZW5hc0BnbWFpbC5j b20+Ci0tLQogc3JjL3BjcmVzZWFyY2guYyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvcGNyZXNlYXJjaC5j IGIvc3JjL3BjcmVzZWFyY2guYwppbmRleCA5ZTJmMzkzLi5jZDZjZTcxIDEwMDY0NAotLS0gYS9z cmMvcGNyZXNlYXJjaC5jCisrKyBiL3NyYy9wY3Jlc2VhcmNoLmMKQEAgLTI0NCw4ICsyNDQsOCBA QCBQY29tcGlsZSAoY2hhciAqcGF0dGVybiwgaWR4X3Qgc2l6ZSwgcmVnX3N5bnRheF90IGlnbm9y ZWQsIGJvb2wgZXhhY3QpCiAgIHBjLT5kYXRhID0gcGNyZTJfbWF0Y2hfZGF0YV9jcmVhdGVfZnJv bV9wYXR0ZXJuIChwYy0+Y3JlLCBnY29udGV4dCk7CiAKICAgZWMgPSBwY3JlMl9qaXRfY29tcGls ZSAocGMtPmNyZSwgUENSRTJfSklUX0NPTVBMRVRFKTsKLSAgaWYgKGVjICYmIGVjICE9IFBDUkUy X0VSUk9SX0pJVF9CQURPUFRJT04gJiYgZWMgIT0gUENSRTJfRVJST1JfTk9NRU1PUlkpCi0gICAg ZGllIChFWElUX1RST1VCTEUsIDAsIF8oIkpJVCBpbnRlcm5hbCBlcnJvcjogJWQiKSwgZWMpOwor ICBpZiAoZWMgPCAwICYmIGVjID09IFBDUkUyX0VSUk9SX0pJVF9CQURPUFRJT04pCisgICAgZGll IChFWElUX1RST1VCTEUsIDAsIF8oIkpJVCB1bmV4cGVjdGVkIGludGVybmFsIGVycm9yOiAlZCIp LCBlYyk7CiAKICAgLyogVGhlIFBDUkUgZG9jdW1lbnRhdGlvbiBzYXlzIHRoYXQgYSAzMiBLaUIg c3RhY2sgaXMgdGhlIGRlZmF1bHQuICAqLwogICBwYy0+aml0X3N0YWNrID0gTlVMTDsKLS0gCjIu MzkuMiAoQXBwbGUgR2l0LTE0MykKCg== --000000000000ec038e05f909dcb4-- ------------=_1681423082-17551-1--