GNU bug report logs - #62764
[PATCH] adds clojure tree-sitter mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62764 in the body.
You can then email your comments to 62764 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Patrick Delaney <pd <at> patrickdelaney.dev>
To: bug-gnu-emacs <at> gnu.org
Cc: Patrick Delaney <pd <at> patrickdelaney.dev>
Subject: [PATCH] adds clojure tree-sitter mode
Date: Mon, 10 Apr 2023 12:33:30 -0700

---
 eglot.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eglot.el b/eglot.el
index 6c1b9ea..9b4206e 100644
--- a/eglot.el
+++ b/eglot.el
@@ -242,7 +242,7 @@ chosen (interactively or automatically)."
                                                           ("css-languageserver" "--stdio"))))
                                 (html-mode . ,(eglot-alternatives '(("vscode-html-language-server" "--stdio") ("html-languageserver" "--stdio"))))
                                 ((dockerfile-mode dockerfile-ts-mode) . ("docker-langserver" "--stdio"))
-                                ((clojure-mode clojurescript-mode clojurec-mode)
+                                ((clojure-mode clojure-ts-mode clojurescript-mode clojurec-mode)
                                  . ("clojure-lsp"))
                                 ((csharp-mode csharp-ts-mode)
                                  . ,(eglot-alternatives
-- 
2.40.0

Message #8 received at 62764 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: pd <at> patrickdelaney.dev
Cc: 62764 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#62764: [PATCH] adds clojure tree-sitter mode
Date: Wed, 12 Apr 2023 00:09:02 -0700

Patrick Delaney <pd <at> patrickdelaney.dev> writes:

> ---
>  eglot.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eglot.el b/eglot.el
> index 6c1b9ea..9b4206e 100644
> --- a/eglot.el
> +++ b/eglot.el
> @@ -242,7 +242,7 @@ chosen (interactively or automatically)."
>                                                            ("css-languageserver" "--stdio"))))
>                                  (html-mode . ,(eglot-alternatives '(("vscode-html-language-server" "--stdio") ("html-languageserver" "--stdio"))))
>                                  ((dockerfile-mode dockerfile-ts-mode) . ("docker-langserver" "--stdio"))
> -                                ((clojure-mode clojurescript-mode clojurec-mode)
> +                                ((clojure-mode clojure-ts-mode clojurescript-mode clojurec-mode)
>                                   . ("clojure-lsp"))
>                                  ((csharp-mode csharp-ts-mode)
>                                   . ,(eglot-alternatives

Let me CC João for you :-)

Yuan

Message #11 received at 62764 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: pd <at> patrickdelaney.dev, 62764 <at> debbugs.gnu.org
Subject: Re: bug#62764: [PATCH] adds clojure tree-sitter mode
Date: Wed, 12 Apr 2023 08:25:31 +0100

[Message part 1 (text/plain, inline)]

On Wed, Apr 12, 2023, 08:09 Yuan Fu <casouri <at> gmail.com> wrote:

>
> Patrick Delaney <pd <at> patrickdelaney.dev> writes:
>
> > ---
> >  eglot.el | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/eglot.el b/eglot.el
> > index 6c1b9ea..9b4206e 100644
> > --- a/eglot.el
> > +++ b/eglot.el
> > @@ -242,7 +242,7 @@ chosen (interactively or automatically)."
> >
> ("css-languageserver" "--stdio"))))
> >                                  (html-mode . ,(eglot-alternatives
> '(("vscode-html-language-server" "--stdio") ("html-languageserver"
> "--stdio"))))
> >                                  ((dockerfile-mode dockerfile-ts-mode) .
> ("docker-langserver" "--stdio"))
> > -                                ((clojure-mode clojurescript-mode
> clojurec-mode)
> > +                                ((clojure-mode clojure-ts-mode
> clojurescript-mode clojurec-mode)
> >                                   . ("clojure-lsp"))
> >                                  ((csharp-mode csharp-ts-mode)
> >                                   . ,(eglot-alternatives
>
> Let me CC João for you :-)
>

I normally let these patches through, but i haven't followed clojure
things, i don't know where this mode exists or where to install: emacs 29
or master. Also it would help to have the patch to the right file and with
a proper commit message.

João

>

[Message part 2 (text/html, inline)]

Message #14 received at 62764 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: pd <at> patrickdelaney.dev, casouri <at> gmail.com, 62764 <at> debbugs.gnu.org
Subject: Re: bug#62764: [PATCH] adds clojure tree-sitter mode
Date: Wed, 12 Apr 2023 10:39:04 +0300

> Cc: pd <at> patrickdelaney.dev, 62764 <at> debbugs.gnu.org
> From: João Távora <joaotavora <at> gmail.com>
> Date: Wed, 12 Apr 2023 08:25:31 +0100
> 
> On Wed, Apr 12, 2023, 08:09 Yuan Fu <casouri <at> gmail.com> wrote:
> 
>  Patrick Delaney <pd <at> patrickdelaney.dev> writes:
> 
>  > ---
>  >  eglot.el | 2 +-
>  >  1 file changed, 1 insertion(+), 1 deletion(-)
>  >
>  > diff --git a/eglot.el b/eglot.el
>  > index 6c1b9ea..9b4206e 100644
>  > --- a/eglot.el
>  > +++ b/eglot.el
>  > @@ -242,7 +242,7 @@ chosen (interactively or automatically)."
>  >                                                            ("css-languageserver" "--stdio"))))
>  >                                  (html-mode . ,(eglot-alternatives '(("vscode-html-language-server" "--stdio")
>  ("html-languageserver" "--stdio"))))
>  >                                  ((dockerfile-mode dockerfile-ts-mode) . ("docker-langserver" "--stdio"))
>  > -                                ((clojure-mode clojurescript-mode clojurec-mode)
>  > +                                ((clojure-mode clojure-ts-mode clojurescript-mode clojurec-mode)
>  >                                   . ("clojure-lsp"))
>  >                                  ((csharp-mode csharp-ts-mode)
>  >                                   . ,(eglot-alternatives
> 
>  Let me CC João for you :-)
> 
> I normally let these patches through, but i haven't followed clojure things, i don't know where this mode
> exists or where to install: emacs 29 or master. Also it would help to have the patch to the right file and
> with a proper commit message.

This mode is already in eglot.el on master, so no change is needed.

Message #17 received at 62764 <at> debbugs.gnu.org (full text, mbox):

From: Patrick Delaney <pd <at> patrickdelaney.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: casouri <at> gmail.com, 62764 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#62764: [PATCH] adds clojure tree-sitter mode
Date: Wed, 12 Apr 2023 10:23:03 -0700

Sorry for the noise, this was based off the master branch on 
GitHub which I was told isn't the upstream anymore.
Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: pd <at> patrickdelaney.dev, 62764 <at> debbugs.gnu.org
>> From: João Távora <joaotavora <at> gmail.com>
>> Date: Wed, 12 Apr 2023 08:25:31 +0100
>> 
>> On Wed, Apr 12, 2023, 08:09 Yuan Fu <casouri <at> gmail.com> wrote:
>> 
>>  Patrick Delaney <pd <at> patrickdelaney.dev> writes:
>> 
>>  > ---
>>  >  eglot.el | 2 +-
>>  >  1 file changed, 1 insertion(+), 1 deletion(-)
>>  >
>>  > diff --git a/eglot.el b/eglot.el
>>  > index 6c1b9ea..9b4206e 100644
>>  > --- a/eglot.el
>>  > +++ b/eglot.el
>>  > @@ -242,7 +242,7 @@ chosen (interactively or 
>>  > automatically)."
>>  >                                                            ("css-languageserver" 
>>  >                                                            "--stdio"))))
>>  >                                  (html-mode 
>>  >                                  . ,(eglot-alternatives 
>>  >                                  '(("vscode-html-language-server" 
>>  >                                  "--stdio")
>>  ("html-languageserver" "--stdio"))))
>>  >                                  ((dockerfile-mode 
>>  >                                  dockerfile-ts-mode) 
>>  >                                  . ("docker-langserver" 
>>  >                                  "--stdio"))
>>  > -                                ((clojure-mode 
>>  > clojurescript-mode clojurec-mode)
>>  > +                                ((clojure-mode 
>>  > clojure-ts-mode clojurescript-mode clojurec-mode)
>>  >                                   . ("clojure-lsp"))
>>  >                                  ((csharp-mode 
>>  >                                  csharp-ts-mode)
>>  >                                   . ,(eglot-alternatives
>> 
>>  Let me CC João for you :-)
>> 
>> I normally let these patches through, but i haven't followed 
>> clojure things, i don't know where this mode
>> exists or where to install: emacs 29 or master. Also it would 
>> help to have the patch to the right file and
>> with a proper commit message.
>
> This mode is already in eglot.el on master, so no change is 
> needed.

Message #22 received at 62764-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Patrick Delaney <pd <at> patrickdelaney.dev>
Cc: 62764-done <at> debbugs.gnu.org, casouri <at> gmail.com, joaotavora <at> gmail.com
Subject: Re: bug#62764: [PATCH] adds clojure tree-sitter mode
Date: Wed, 12 Apr 2023 20:28:32 +0300

> From: Patrick Delaney <pd <at> patrickdelaney.dev>
> Cc: João Távora <joaotavora <at> gmail.com>,
>  casouri <at> gmail.com,
>  62764 <at> debbugs.gnu.org
> Date: Wed, 12 Apr 2023 10:23:03 -0700
> 
> Sorry for the noise, this was based off the master branch on 
> GitHub which I was told isn't the upstream anymore.

OK, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.