GNU bug report logs - #62759
[PATCH] add support for prompting for projects by name

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62759 in the body.
You can then email your comments to 62759 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] add support for prompting for projects by name
Date: Mon, 10 Apr 2023 15:14:53 -0400

[Message part 1 (text/plain, inline)]

Tags: patch


This add a new function project-prompt-project-name, and a
project-prompter customize variable which can be used to switch between
that function and the existing project-prompt-project-dir.

In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2023-03-13 built on
 igm-qws-u22796a
Repository revision: e759905d2e0828eac4c8164b09113b40f6899656
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: CentOS Linux 7 (Core)

Configured using:
 'configure --with-x-toolkit=lucid --with-modules
 --with-gif=ifavailable'

[0001-add-support-for-prompting-for-projects-by-name.patch (text/patch, attachment)]

Message #10 received at 62759-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Spencer Baugh <sbaugh <at> janestreet.com>, 62759-done <at> debbugs.gnu.org
Subject: Re: bug#62759: [PATCH] add support for prompting for projects by name
Date: Tue, 11 Apr 2023 02:20:22 +0300

Hi! Thanks for the patch. Pushed to master.

Next time please also add the full common message, though.

Also note that the idea behind the current default (and also why it 
doesn't return a project instance: just the dir) was to avoid visiting 
all the directories -- because some might be unavailable at this exact 
moment (e.g. remote, over Tramp, and currently disconnected), and some 
simply slow.

It shouldn't hurt to have this as an alternative behavior, though.

Message #13 received at 62759-done <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 62759-done <at> debbugs.gnu.org
Subject: Re: bug#62759: [PATCH] add support for prompting for projects by name
Date: Mon, 10 Apr 2023 20:08:19 -0400

[Message part 1 (text/plain, inline)]

On Mon, Apr 10, 2023, 19:20 Dmitry Gutov <dmitry <at> gutov.dev> wrote:

> Hi! Thanks for the patch. Pushed to master.
>
> Next time please also add the full common message, though.
>

Sorry, will do. I was expecting to need to iterate through some review
cycles :)

Also note that the idea behind the current default (and also why it
> doesn't return a project instance: just the dir) was to avoid visiting
> all the directories -- because some might be unavailable at this exact
> moment (e.g. remote, over Tramp, and currently disconnected), and some
> simply slow.


Yes, I figured that was the reason. I should also mention that I was
thinking about automatically pruning zombie projects (my backend yields
lots of those) but instead I just had project-prompt-project-name skip
zombies, for exactly this reason (that it avoids excess FS access).

It shouldn't hurt to have this as an alternative behavior, though.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.