GNU bug report logs - #62753
[PATCH] gnu: Add emacs-eradio.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62753 in the body.
You can then email your comments to 62753 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dominik Delgado Steuter <d <at> delgado.nrw>
To: guix-patches <at> gnu.org
Cc: Dominik Delgado Steuter <d <at> delgado.nrw>
Subject: [PATCH] gnu: Add emacs-eradio.
Date: Mon, 10 Apr 2023 10:49:37 +0200

    * gnu/packages/emacs-xyz.scm (emacs-eradio): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 486740c..e2ad86e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -124,6 +124,7 @@
 ;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan <at> selidor.net>
 ;;; Copyright © 2022 Demis Balbach <db <at> minikn.xyz>
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew <at> trop.in>
+;;; Copyright © 2023 Dominik Delgado Steuter <d <at> delgado.nrw>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3078,6 +3079,27 @@ (define-public emacs-emprise
 Selectrum.")
     (license license:gpl3+)))
 
+(define-public emacs-eradio
+  (package
+    (name "emacs-eradio")
+    (version "20210327.1000")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/eradio-"
+                           version ".el"))
+       (sha256
+        (base32
+         "0i9mfy5xck0qbbgjhagd35hxd091254w0wga60wd44n04m46h05l"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/olavfosse/eradio")
+    (synopsis "The simple radio player for GNU Emacs")
+    (description
+     "eradio is a simple Internet radio player for Emacs. Start, stop or
+toggle custom-defined channels. An external media player like mpv or vlc is
+required.")
+    (license license:gpl3)))
+
 (define-public emacs-marginalia-emprise
   (package
     (name "emacs-marginalia-emprise")

base-commit: a4e9842a70775a54bbe1369881b739e7ea9a6432
-- 
2.39.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Dominik Delgado Steuter via Guix-patches via <guix-patches <at> gnu.org>
Cc: Dominik Delgado Steuter <d <at> delgado.nrw>, 62753 <at> debbugs.gnu.org
Subject: Re: [bug#62753] [PATCH] gnu: Add emacs-eradio.
Date: Tue, 11 Apr 2023 21:13:32 +0200

Hello,

Dominik Delgado Steuter via Guix-patches via <guix-patches <at> gnu.org>
writes:

>     * gnu/packages/emacs-xyz.scm (emacs-eradio): New variable.

Thank you for the patch. Some comments follow.

> +(define-public emacs-eradio
> +  (package
> +    (name "emacs-eradio")
> +    (version "20210327.1000")

We don't use MELPA date-based versioning system, unless it is also used
upstream. It isn't the case here as upstream set library's version to
0.1.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/eradio-"
> +                           version ".el"))

I suggest to use GitHub as upstream.

> +       (sha256
> +        (base32
> +         "0i9mfy5xck0qbbgjhagd35hxd091254w0wga60wd44n04m46h05l"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/olavfosse/eradio")
> +    (synopsis "The simple radio player for GNU Emacs")

You should drop "The" in front of the synopsis. I think "./pre-inst-env
guix lint emacs-eradio" should warn about it.

> +    (description
> +     "eradio is a simple Internet radio player for Emacs. Start, stop or
> +toggle custom-defined channels. An external media player like mpv or vlc is
> +required.")

I would capitalize "Eradio", but not "internet". Also I suggest to write
"Mpv" and "VLC".

On this topic, would it make sense to provide VLC as an input, so the
Emacs library works out of the box?

You also need to separate sentences with two spaces, according to
Texinfo syntax.

> +    (license license:gpl3)))

License is actually GPL3+.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at 62753 <at> debbugs.gnu.org (full text, mbox):

From: Dominik Delgado Steuter <d <at> delgado.nrw>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 62753 <at> debbugs.gnu.org
Subject: Re: [bug#62753] [PATCH] gnu: Add emacs-eradio.
Date: Wed, 12 Apr 2023 16:41:07 +0200

Hi,

thank you for the review.

Am 11.04.23 um 21:13 schrieb Nicolas Goaziou:

> I suggest to use GitHub as upstream.

I saw that a couple of other Emacs-packages in this file fetched from 
melpa.org, but you are right, GitHub makes more sense.

> I would capitalize "Eradio", but not "internet". Also I suggest to write
> "Mpv" and "VLC".

I am in favor of "mpv" as that is how the project stylizes itself. 
Wikipedia also uses that notation.

> On this topic, would it make sense to provide VLC as an input, so the
> Emacs library works out of the box?

In my opinion the user should be encouraged to choose the player themself.
I for example only use mpv and would not like my system to be cluttered 
with another full-blown media player I don't use.

> Could you send an updated patch?

It comes with the next mail.

I also relocated the package definition so that it's not between two 
packages related to emprise anymore.

Regards,

Dominik D.S.

Message #17 received at 62753 <at> debbugs.gnu.org (full text, mbox):

From: Dominik Delgado Steuter <d <at> delgado.nrw>
To: 62753 <at> debbugs.gnu.org
Cc: Dominik Delgado Steuter <d <at> delgado.nrw>, mail <at> nicolasgoaziou.fr
Subject: [PATCH] gnu: Add emacs-eradio.
Date: Wed, 12 Apr 2023 17:16:02 +0200

* gnu/packages/emacs-xyz.scm (emacs-eradio): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6264d4d..2a1ee30 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -124,6 +124,7 @@
 ;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan <at> selidor.net>
 ;;; Copyright © 2022 Demis Balbach <db <at> minikn.xyz>
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew <at> trop.in>
+;;; Copyright © 2023 Dominik Delgado Steuter <d <at> delgado.nrw>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3101,6 +3102,30 @@ (define-public emacs-marginalia-emprise
 playback status, artist name and title for Emprise using Marginalia.")
     (license license:gpl3+)))
 
+(define-public emacs-eradio
+  (let ((commit "47769986c79def84307921f0277e9bb2714756c2")
+        (revision "0"))
+    (package
+      (name "emacs-eradio")
+      (version (git-version "0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/olavfosse/eradio")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0lks2pph44qxc9l34nr55ha667974r8ckxdwmvcp6v9mnm05317s"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/olavfosse/eradio")
+      (synopsis "Simple radio player for GNU Emacs")
+      (description
+       "Eradio is a simple internet radio player for Emacs.  Start, stop or
+toggle custom-defined channels.  An external media player like mpv or VLC is
+required.")
+      (license license:gpl3+))))
+
 
 ;;;
 ;;; Miscellaneous.

base-commit: dd3e5e71104a2bcbad80e52e062a144ea96b8c6a
-- 
2.39.2

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Dominik Delgado Steuter via Guix-patches via <guix-patches <at> gnu.org>
Cc: Dominik Delgado Steuter <d <at> delgado.nrw>, 62753-done <at> debbugs.gnu.org
Subject: Re: [bug#62753] [PATCH] gnu: Add emacs-eradio.
Date: Sun, 16 Apr 2023 15:53:50 +0200

Hello,

Dominik Delgado Steuter via Guix-patches via <guix-patches <at> gnu.org>
writes:

> * gnu/packages/emacs-xyz.scm (emacs-eradio): New variable.

Thank you.

I added a normalized commit message, bumped the revision binding, and
applied your patch.

I also subsequently fixed package license as it seems to be GPL2+, not
GPL3+.

Regards,
-- 
Nicolas Goaziou

Message #28 received at 62753 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 62753 <at> debbugs.gnu.org
Cc: Dominik Delgado Steuter <d <at> delgado.nrw>, 62753-done <at> debbugs.gnu.org
Subject: Re: [bug#62753] [PATCH] gnu: Add emacs-eradio.
Date: Sun, 16 Apr 2023 15:55:46 +0200

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> I added a normalized commit message, bumped the revision binding, and
> applied your patch.
>
> I also subsequently fixed package license as it seems to be GPL2+, not
> GPL3+.

Please forget about this part, I was writing about another patch, not
related to this one. Sorry for the noise.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.