GNU bug report logs - #62751
29.0.90; New libraries that still need to be assigned to packages

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jonas <at> bernoul.li, stefankangas <at> gmail.com, 62751 <at> debbugs.gnu.org
Subject: bug#62751: 29.0.90; New libraries that still need to be assigned to packages
Date: Sat, 14 Oct 2023 10:39:09 -0400

>> BTW, how 'bout we drop the `millisec` arg of `sleep-for` as well (and
>> the pretense that there are still systems that can only sleep for whole
>> seconds)?
>
> Do we know which systems are/were those?

I don't.
And my intuition tells me that "waiting for a fraction of a second"
was only part of the problem, and Emacs support for floating points
was another.  :-)

> If not, how can we be sure they are no longer interesting?

Because the code doesn't accommodate them any more anyway.
Removing the arg (as opposed to just marking it obsolete) amounts to:

    -DEFUN ("sleep-for", Fsleep_for, Ssleep_for, 1, 2, 0,
    +DEFUN ("sleep-for", Fsleep_for, Ssleep_for, 1, 1, 0,
            doc: /* Pause, without updating display, for SECONDS seconds.
     SECONDS may be a floating-point value, meaning that you can wait for a
    -fraction of a second.  Optional second arg MILLISECONDS specifies an
    -additional wait period, in milliseconds; this is for backwards compatibility.
    -\(Not all operating systems support waiting for a fraction of a second.)  */)
    -  (Lisp_Object seconds, Lisp_Object milliseconds)
    +fraction of a second.  */)
    +  (Lisp_Object seconds)
     {
       double duration = extract_float (seconds);
     
    -  if (!NILP (milliseconds))
    -    {
    -      CHECK_FIXNUM (milliseconds);
    -      duration += XFIXNUM (milliseconds) / 1000.0;
    -    }
    -
       if (duration > 0)
         {
           struct timespec t = dtotimespec (duration);


-- Sefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.