Subject: bug#62747: 29.0.90; Invalid desktop file

From: Ulrich Mueller <[email-masked]>
Date: Mon, 10 Apr 2023 16:05:19 +0200

>> invalid-desktopfile /usr/share/applications/emacsclient.desktop value "sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %F" for key "Exec" in group "Desktop Entry" contains a non-escaped character '$' in a quote, but it should be escaped with two backslashes ("\\$")
>> invalid-desktopfile /usr/share/applications/emacsclient.desktop value "sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %F" for key "Exec" in group "Desktop Entry" contains a non-escaped character '$' in a quote, but it should be escaped with two backslashes ("\\$")
>> invalid-desktopfile /usr/share/applications/emacsclient.desktop value "sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %F" for key "Exec" in group "Desktop Entry" contains a quote which is not closed
>> invalid-desktopfile /usr/share/applications/emacsclient.desktop value "sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %F" for key "Exec" in group "Desktop Entry" contains a reserved character '$' outside of a quote

BTW, emacsclient.desktop in 29.0.90 is identical to the file shipped
with Emacs 28.1 and 28.2, except for replacing "placeholder" by "sh"
for the command name.