GNU bug report logs - #62741
30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master

Previous Next

Full log

Message #14 received at 62741 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Basil Contovounesios <contovob <at> tcd.ie>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 62741 <at> debbugs.gnu.org
Subject: Re: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29,
 fail on master
Date: Mon, 10 Apr 2023 09:17:29 +0100

Basil Contovounesios <contovob <at> tcd.ie> writes:

> João Távora [2023-04-09 20:13 +0100] wrote:
>
>> Basil Contovounesios <contovob <at> tcd.ie> writes:
>>
>>> diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot-tests.el
>>> index 62e04539ebf..041aafabe8e 100644
>>> --- a/test/lisp/progmodes/eglot-tests.el
>>> +++ b/test/lisp/progmodes/eglot-tests.el
>>> @@ -325,8 +325,7 @@ eglot-test-eclipse-connect
>>>    "Connect to eclipse.jdt.ls server."
>>>    (skip-unless (executable-find "jdtls"))
>>>    (eglot--with-fixture
>>> -      '(("project/src/main/java/foo" . (("Main.java" . "")))
>>> -        ("project/.git/" . nil))
>>> +      '(("project/src/main/java/foo" . (("Main.java" . ""))))
>>>      (with-current-buffer
>>>          (eglot--find-file-noselect "project/src/main/java/foo/Main.java")
>>>        (eglot--sniffing (:server-notifications s-notifs)
>>>
>>>
>>> Which I assume means that project-current picks up .git as a project
>>> root marker, but project-files unexpectedly finds no registered files.
>>>
>>> I'm not sure whether this is expected on either the project or eglot
>>> side.  If I squint hard enough it kind of reminds me of bug#62735.
>>
>> I think the change is fine, please install it, and thanks.
>
> Done:
>
> Avoid Git project in eglot-test-eclipse-connect
> 6674ac17eb4 2023-04-09 23:32:14 +0100
> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=6674ac17eb4
>
>> Let's hope it doesn't break on Emacs 26.3, 27 and 28
>>
>> (f you could test, it would be great, if not it's OK.  It'd involve
>> making a GitHub fork and using the GitHub actions scripts)
>
> Seems to work there too:
> https://github.com/basil-conto/eglot/commit/e915db94a6
> https://github.com/basil-conto/eglot/actions/runs/4652799056

Thanks!

>> A safer, but slightly slower route:
>>
>>    (should (zerop (shell-command "git init")))
>>
>> Some tests known to need project-files already do this.
>
> This continues to fail in the same way, both in emacs.git and eglot.git:
> https://github.com/basil-conto/eglot/commit/1b2d13eaf6
> https://github.com/basil-conto/eglot/actions/runs/4652805286

This is very odd then.  Why would project-files fail in the face of
(presumably) a perfectly well-behaved Git repository?

Pasting the backtrace here for Dmitry to have a look.

Test eglot-test-eclipse-connect backtrace:
  string-match("\0" nil 0)
  split-string(nil "\0" t)
  project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil)
  #f(compiled-function (dir) #<bytecode -0xa5be45661654310>)("/tmp/eglot--fixturernYTOR/project/")
  mapcan(#f(compiled-function (dir) #<bytecode -0xa5be45661654310>) ("/tmp/eglot--fixturernYTOR/project/"))
  #f(compiled-function (project &optional dirs) #<bytecode 0x114f4cd06dfc2088>)((vc Git "/tmp/eglot--fixturernYTOR/project/"))
  apply(#f(compiled-function (project &optional dirs) #<bytecode 0x114f4cd06dfc2088>) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil)
  project-files((vc Git "/tmp/eglot--fixturernYTOR/project/"))

It would seem that the problem here is there are no files versioned yet,
so this expression in project--vc-list-files

   (apply #'vc-git--run-command-string nil "ls-files" args)

Returns nil.  

But I cannot reproduce this locally.

I'll leave it up to you, Basil, to decide whether to close or leave this
bug open.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.