GNU bug report logs - #62741
30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master

Previous Next

Full log

View this message in rfc822 format

From: Basil Contovounesios <contovob <at> tcd.ie>
To: João Távora <joaotavora <at> gmail.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 62741 <at> debbugs.gnu.org
Subject: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master
Date: Mon, 10 Apr 2023 00:13:25 +0100

João Távora [2023-04-09 20:13 +0100] wrote:

> Basil Contovounesios <contovob <at> tcd.ie> writes:
>
>> diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot-tests.el
>> index 62e04539ebf..041aafabe8e 100644
>> --- a/test/lisp/progmodes/eglot-tests.el
>> +++ b/test/lisp/progmodes/eglot-tests.el
>> @@ -325,8 +325,7 @@ eglot-test-eclipse-connect
>>    "Connect to eclipse.jdt.ls server."
>>    (skip-unless (executable-find "jdtls"))
>>    (eglot--with-fixture
>> -      '(("project/src/main/java/foo" . (("Main.java" . "")))
>> -        ("project/.git/" . nil))
>> +      '(("project/src/main/java/foo" . (("Main.java" . ""))))
>>      (with-current-buffer
>>          (eglot--find-file-noselect "project/src/main/java/foo/Main.java")
>>        (eglot--sniffing (:server-notifications s-notifs)
>>
>>
>> Which I assume means that project-current picks up .git as a project
>> root marker, but project-files unexpectedly finds no registered files.
>>
>> I'm not sure whether this is expected on either the project or eglot
>> side.  If I squint hard enough it kind of reminds me of bug#62735.
>
> I think the change is fine, please install it, and thanks.

Done:

Avoid Git project in eglot-test-eclipse-connect
6674ac17eb4 2023-04-09 23:32:14 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=6674ac17eb4


> Let's hope it doesn't break on Emacs 26.3, 27 and 28
>
> (f you could test, it would be great, if not it's OK.  It'd involve
> making a GitHub fork and using the GitHub actions scripts)

Seems to work there too:
https://github.com/basil-conto/eglot/commit/e915db94a6
https://github.com/basil-conto/eglot/actions/runs/4652799056

> A safer, but slightly slower route:
>
>    (should (zerop (shell-command "git init")))
>
> Some tests known to need project-files already do this.

This continues to fail in the same way, both in emacs.git and eglot.git:
https://github.com/basil-conto/eglot/commit/1b2d13eaf6
https://github.com/basil-conto/eglot/actions/runs/4652805286

> But why does it pass on Emacs 29?? Maybe project-files simply doesn't
> error there?

Maybe, but why not?

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.