From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 09 13:47:11 2023 Received: (at submit) by debbugs.gnu.org; 9 Apr 2023 17:47:11 +0000 Received: from localhost ([127.0.0.1]:33612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plZ8A-0001wR-CF for submit@debbugs.gnu.org; Sun, 09 Apr 2023 13:47:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:54508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plZ87-0001wF-1i for submit@debbugs.gnu.org; Sun, 09 Apr 2023 13:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plZ82-0004gO-8n for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 13:47:03 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plZ7z-0003ge-5u for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 13:47:02 -0400 Received: by mail-wm1-x331.google.com with SMTP id v14-20020a05600c470e00b003f06520825fso6826106wmo.0 for ; Sun, 09 Apr 2023 10:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1681062415; x=1683654415; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=z3i2x/N4rHgxgu/Av58shZ8MUO3/YyxwysV0SHHMbFk=; b=Mu7DfoQxX6VX2qvm8UfBgoArv6yplDYHsg4soVnQSrdN7p5KP/Vr9G4TOngeUlAGhu PXKAxV2Aoh2XL5HBgMnnoEaD3SMRty/qDcoyjPROm38w6qbtKT9Czg8Kl4wr/CT4dV0+ MTzIIphZA/8PAwuVg/LxjkwOxVMvdPiPiFGlGD2bvlIX0BpJHhpIdFKMsD8uaPfkRdMU R3tGtmMUBFnx+jH6PwSA/uX0EzdTmpUpwuLZXFquh3lLr++x1ALqNoWhbeebQv1thM0y 9E8/cwbS/VyBKW0Lrem2qVgH88bOeCNuuE2WPhgUvNgU9aPhPWD+/kTi6vWBdntNVeWl Hilg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681062415; x=1683654415; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z3i2x/N4rHgxgu/Av58shZ8MUO3/YyxwysV0SHHMbFk=; b=IxVi8/H10YGsn7+LmTbaNKy2R88LImy7PmT1pVaM5DxEHFGf7OtZpjuvn8FzPegpII 1p9Qn6PtRH506vJ4hSOzS3fCocZkDeIjY0T2uDbNRdkV3f/U0S9iEmf16Mp1+cU75g27 FOBmSmYQDOuneeXbTpSouZ6xMngZg/WlbSUdO/hvN80SSk7D38Z6TCfqUfRUOA5rrIDP FXHJo1vCybGdKyJBTMTHHWE1se3yyAGe8ICTIDE27Iq+fEMHZeLpsIFa8uS93yihYtc1 uRuMCJjyZJVKuEmmsIbLl9+HEUhqFNkhoPl+rojhXZ6rovDkEVaDhLfaAWIuPfuNnQ+W NWqw== X-Gm-Message-State: AAQBX9e+ejA+u752vyZWl2/vVUe26sLCO/no6qJi6niHsAqsAdSlFTek LBcYn7g+/reoXOt8kC0pQn11Vr8IV8WF2eajOywBOA== X-Google-Smtp-Source: AKy350Z3VaTW/TxePrNgD4fFY6yacNr6H0vyplfJV+kuE61ZGTISFjde5Q56hs7vqNdJDNOjBAJ8oA== X-Received: by 2002:a7b:cb97:0:b0:3db:8de:6993 with SMTP id m23-20020a7bcb97000000b003db08de6993mr5172766wmi.4.1681062414815; Sun, 09 Apr 2023 10:46:54 -0700 (PDT) Received: from localhost ([51.37.99.170]) by smtp.gmail.com with ESMTPSA id n6-20020a7bc5c6000000b003f072b22dbbsm10269198wmk.16.2023.04.09.10.46.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 10:46:54 -0700 (PDT) From: Basil Contovounesios To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master X-Debbugs-Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , Dmitry Gutov Date: Sun, 09 Apr 2023 18:46:53 +0100 Message-ID: <87pm8dne2a.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=contovob@tcd.ie; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain With the following JDT LS binary release: https://download.eclipse.org/jdtls/milestones/1.21.0/ The test eglot-test-eclipse-connect passes on emacs-29: --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=emacs-29-check.txt -*- mode: compilation; default-directory: "~/.local/src/emacs-29/" -*- Compilation started at Sun Apr 9 18:24:01 make TEST_LOAD_EL=no TEST_BACKTRACE_LINE_LENGTH=120 SELECTOR='"eclipse"' test/eglot-tests make -C test eglot-tests make[1]: Entering directory '/home/bic/.local/src/emacs-29/test' make[2]: Entering directory '/home/bic/.local/src/emacs-29/test' GEN lisp/progmodes/eglot-tests.log Running 1 tests (2023-04-09 18:24:01+0100, selector `"eclipse"') [eglot] project 649b9e33-b84f-4a6f-9674-9e7c0d7bbf3f: \ [eglot] project 649b9e33-b84f-4a6f-9674-9e7c0d7bbf3f: | Refreshing Maven model Refreshing Maven model [eglot] project 649b9e33-b84f-4a6f-9674-9e7c0d7bbf3f: / Updating Maven Dependencies [eglot] project 649b9e33-b84f-4a6f-9674-9e7c0d7bbf3f: \ [eglot] project 649b9e33-b84f-4a6f-9674-9e7c0d7bbf3f: | project jdt.ls-java-project Updating Maven Dependencies [eglot] project 649b9e33-b84f-4a6f-9674-9e7c0d7bbf3f: / Updating Maven Dependencies [eglot] project c2a93e31-26af-433e-a8c3-9f605affe120: \ [eglot] project c2a93e31-26af-433e-a8c3-9f605affe120: | Initialize Workspace Initialize Workspace [eglot] Connected! Server `EGLOT (project/(java-mode java-ts-mode))' now managing `(java-mode java-ts-mode)' buffers in project `project'. [eglot] Event detected: (:jsonrpc "2.0" :method "language/status" :params (:type "Starting" :message "0% Starting Java Language Server")) [eglot] Test body was OK [eglot] Asking EGLOT (project/(java-mode java-ts-mode)) politely to terminate [eglot] project 0a7b40e9-2cdd-4cfd-8e09-e1dea42e4280: \ [eglot] project 0a7b40e9-2cdd-4cfd-8e09-e1dea42e4280: | Repository registry initialization Repository registry initialization [eglot] project 0a7b40e9-2cdd-4cfd-8e09-e1dea42e4280: / Repository registry initialization [eglot] project c2a93e31-26af-433e-a8c3-9f605affe120: / Initialize Workspace [eglot] project c2a93e31-26af-433e-a8c3-9f605affe120: - Initialize Workspace [eglot] project 3cb15c07-f157-482a-ada4-5186a38038cc: \ [eglot] project 3cb15c07-f157-482a-ada4-5186a38038cc: | Synchronizing projects Synchronizing projects [eglot] project d6974c61-c657-4934-b1b4-33542dccd530: \ [eglot] project d6974c61-c657-4934-b1b4-33542dccd530: | Synchronizing projects Synchronizing projects [eglot] project c2a93e31-26af-433e-a8c3-9f605affe120: \ [eglot] project c2a93e31-26af-433e-a8c3-9f605affe120: | Initialize Workspace Initialize Workspace [eglot] project c2a93e31-26af-433e-a8c3-9f605affe120: / Initialize Workspace [eglot] project 3cb15c07-f157-482a-ada4-5186a38038cc: / Synchronizing projects [eglot] project 3cb15c07-f157-482a-ada4-5186a38038cc: \ [eglot] project 3cb15c07-f157-482a-ada4-5186a38038cc: | Synchronizing projects Synchronizing projects [eglot] project 3cb15c07-f157-482a-ada4-5186a38038cc: / Synchronizing projects [eglot] project d6974c61-c657-4934-b1b4-33542dccd530: / Synchronizing projects [eglot] project d6974c61-c657-4934-b1b4-33542dccd530: \ [eglot] project d6974c61-c657-4934-b1b4-33542dccd530: | Synchronizing projects Synchronizing projects [eglot] project d6974c61-c657-4934-b1b4-33542dccd530: / Synchronizing projects [eglot] (warning) Server tried to register unsupported capability `workspace/didChangeWorkspaceFolders' Warning (eglot): Server tried to register unsupported capability `workspace/didChangeWorkspaceFolders' [jsonrpc] Server exited with status 9 [eglot] Killing (Main.java), wiping /tmp/eglot--fixtureIeG1kx, restoring nil passed 1/1 eglot-test-eclipse-connect (2.025192 sec) Ran 1 tests, 1 results as expected, 0 unexpected (2023-04-09 18:24:03+0100, 2.025296 sec) make[2]: Leaving directory '/home/bic/.local/src/emacs-29/test' make[1]: Leaving directory '/home/bic/.local/src/emacs-29/test' Compilation finished at Sun Apr 9 18:24:03 --=-=-= Content-Type: text/plain But fails on master: --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=emacs-check.txt -*- mode: compilation; default-directory: "~/.local/src/emacs/" -*- Compilation started at Sun Apr 9 18:23:12 make TEST_LOAD_EL=no TEST_BACKTRACE_LINE_LENGTH=120 SELECTOR='"eclipse"' test/eglot-tests make -C test eglot-tests make[1]: Entering directory '/home/bic/.local/src/emacs/test' make[2]: Entering directory '/home/bic/.local/src/emacs/test' GEN lisp/progmodes/eglot-tests.log Loading project... Loading eldoc... Loading seq... Loading flymake... Loading xref... Loading jsonrpc... Loading external-completion... Running 1 tests (2023-04-09 18:23:12+0100, selector `"eclipse"') [eglot-tests] [eglot-test-eclipse-connect]: test start [eglot] Connected! Server `EGLOT (project/(java-mode java-ts-mode))' now managing `(java-mode java-ts-mode)' buffers in project `project'. [eglot-tests] waiting for `(string= method language/status)' [eglot-tests] detected: language/status [eglot-tests] [eglot-test-eclipse-connect]: OK [eglot] Asking EGLOT (project/(java-mode java-ts-mode)) politely to terminate [jsonrpc] Server exited with status 9 [eglot-tests] Killing (Main.java), wiping /tmp/eglot--fixture4dC9ZE, restoring nil Test eglot-test-eclipse-connect backtrace: string-match("\0" nil 0) split-string(nil "\0" t) project--vc-list-files("/tmp/eglot--fixture4dC9ZE/project/" Git nil) #f(compiled-function (dir) #)("/tmp/eglot--fixture4dC9ZE/project/") mapcan(#f(compiled-function (dir) #) ("/tmp/eglot--fixture4dC9ZE/project/")) #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixture4dC9ZE/proje apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixture4dC9ZE project-files((vc Git "/tmp/eglot--fixture4dC9ZE/project/")) #f(compiled-function (arg1 arg2 arg3 &rest rest) "Handle dynamic registration of workspace/didChangeWatchedFiles." # workspace/didChangeWatchedFiles "50f10b8a- apply(eglot-register-capability # workspace/didChangeWatchedFiles "50f eglot--register-unregister(# [(:id "50f10b8a-3194-4cc6-bbf1-57160d2a51 #f(compiled-function (arg1 arg2 &rest rest) "Handle server request client/registerCapability." # client/registerCapability :registrations [(:id apply(eglot-handle-request # client/registerCapability (:registrations #f(compiled-function (server method params) #)(# (:jsonrpc "2.0" :id "1" :method "client/r jsonrpc--process-filter(# "Content-Length: 120\15\n\15\n{\"jsonrpc\" accept-process-output(nil 30) jsonrpc-request(# :shutdown nil :timeout 3 :cancel-on-input nil :cance eglot--request(# :shutdown nil :timeout 3) eglot-shutdown(# nil 3 nil) #f(compiled-function () #)() eglot--call-with-fixture((("project/src/main/java/foo" ("Main.java" . "")) ("project/.git/")) #f(compiled-function () #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test :name eglot-test-eclipse-connect :documentation " ert-run-test(#s(ert-test :name eglot-test-eclipse-connect :documentation "Connect to eclipse.jdt.ls server..." :body # ert-run-or-rerun-test(#s(ert--stats :selector "eclipse" :tests ... :test-map # :tes ert-run-tests("eclipse" #f(compiled-function (event-type &rest event-args) #) nil) ert-run-tests-batch("eclipse") ert-run-tests-batch-and-exit("eclipse") eval((ert-run-tests-batch-and-exit '"eclipse") t) command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq ert-batch-backtrace-right-margin 120)" "-l" "lisp/progmodes/eglot command-line() normal-top-level() Test eglot-test-eclipse-connect condition: (wrong-type-argument stringp nil) FAILED 1/1 eglot-test-eclipse-connect (1.765819 sec) at lisp/progmodes/eglot-tests.el:324 Ran 1 tests, 0 results as expected, 1 unexpected (2023-04-09 18:23:14+0100, 1.827689 sec) 1 unexpected results: FAILED eglot-test-eclipse-connect make[2]: *** [Makefile:181: lisp/progmodes/eglot-tests.log] Error 1 make[2]: Leaving directory '/home/bic/.local/src/emacs/test' make[1]: *** [Makefile:247: lisp/progmodes/eglot-tests] Error 2 make[1]: Leaving directory '/home/bic/.local/src/emacs/test' make: *** [Makefile:1100: test/eglot-tests] Error 2 Compilation exited abnormally with code 2 at Sun Apr 9 18:23:14 --=-=-= Content-Type: text/plain The following change lets it pass on both branches: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=eglot.diff diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot-tests.el index 62e04539ebf..041aafabe8e 100644 --- a/test/lisp/progmodes/eglot-tests.el +++ b/test/lisp/progmodes/eglot-tests.el @@ -325,8 +325,7 @@ eglot-test-eclipse-connect "Connect to eclipse.jdt.ls server." (skip-unless (executable-find "jdtls")) (eglot--with-fixture - '(("project/src/main/java/foo" . (("Main.java" . ""))) - ("project/.git/" . nil)) + '(("project/src/main/java/foo" . (("Main.java" . "")))) (with-current-buffer (eglot--find-file-noselect "project/src/main/java/foo/Main.java") (eglot--sniffing (:server-notifications s-notifs) --=-=-= Content-Type: text/plain Which I assume means that project-current picks up .git as a project root marker, but project-files unexpectedly finds no registered files. I'm not sure whether this is expected on either the project or eglot side. If I squint hard enough it kind of reminds me of bug#62735. WDYT? Thanks, -- Basil In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-04-09 built on blc Repository revision: 57490fff6ecf3cc1de7d8d833d1b6c895330b762 Repository branch: wt/emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Ubuntu 22.04.2 LTS Configured using: 'configure CC=gcc-12 'CFLAGS=-Og -ggdb3' --prefix=/home/bic/.local --with-program-suffix=-29 --with-file-notification=yes --with-x --with-x-toolkit=lucid' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_MONETARY: en_IE.UTF-8 value of $LC_NUMERIC: en_IE.UTF-8 value of $LC_TIME: en_IE.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 36570 7455) (symbols 48 5149 0) (strings 32 13868 1570) (string-bytes 1 379298) (vectors 16 9299) (vector-slots 8 148612 10553) (floats 8 23 25) (intervals 56 248 0) (buffers 984 10)) In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-04-09 built on blc Repository revision: c9e13048bb9b1b5fb156fb128b32030ae2f1003b Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Ubuntu 22.04.2 LTS Configured using: 'configure CC=gcc-12 'CFLAGS=-Og -ggdb3' --prefix=/home/bic/.local --with-file-notification=yes --with-x --with-x-toolkit=lucid' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_MONETARY: en_IE.UTF-8 value of $LC_NUMERIC: en_IE.UTF-8 value of $LC_TIME: en_IE.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 36595 9309) (symbols 48 5171 0) (strings 32 13872 1628) (string-bytes 1 377598) (vectors 16 9294) (vector-slots 8 148577 11099) (floats 8 23 25) (intervals 56 244 0) (buffers 984 10)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 09 15:11:10 2023 Received: (at 62741) by debbugs.gnu.org; 9 Apr 2023 19:11:10 +0000 Received: from localhost ([127.0.0.1]:33728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plaRS-0004RY-A6 for submit@debbugs.gnu.org; Sun, 09 Apr 2023 15:11:10 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:37663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plaRP-0004RJ-D8 for 62741@debbugs.gnu.org; Sun, 09 Apr 2023 15:11:08 -0400 Received: by mail-wr1-f47.google.com with SMTP id w21so2791726wra.4 for <62741@debbugs.gnu.org>; Sun, 09 Apr 2023 12:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681067461; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4zNDJW+Dt8GBKLCC1oJDkF3Ah2bya0arz6huYdyIJag=; b=I1YlqvnXwBRTJ6953jrHW/mYki+MLqetsMEsaNb4Huez6SjRTxoD5j6yHBQP8JLxYP nIzYh/Z+ma76+J0HokkoMSVVHvopSfD1JGlxkkBwIFHrXog4qLzYG98z+mcSv+VTQaSR 7kbtFEfK24K5hKbHoGJ2uJaGVYwnjXVMmR91lKo6Nxiu+x5gI/i83y1KAI39Nawj1AA8 d8uB9gAnglFAQ2dj4mQd8kox+/iF+qClZqfjoixLMrQfig2//8VBe0DWcX6RI7d4xOb3 KfYE6D8X/2KPHUiA6zsBw3vD/EySo0qkhtY5jwLpzf8bA8H1sJr5mplutKBGgfsLpIlJ NgcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681067461; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4zNDJW+Dt8GBKLCC1oJDkF3Ah2bya0arz6huYdyIJag=; b=Bz+b7IKp/oYBLuLKesVeSeWP+XJRD+yblmXsflPsoUGri+77YCYRw92gcJTcuVbRff BJwlJg6Pu5s4C5lIiU5+j05hzujGTCVx6BxdCuCuvpAcvYU9imOWA+rqynWRmwlUaOJC drhWL1gKFUUAGkMlxAJbA6r7UfMcOdHkY07hftQL4SUsUbkpiUPm5eOfhTwedixxCjZ0 WogOArLkLogZDVK9/n3kuGmR/rl4TEW8V3AUz3Rt69IW09YfepTnjEa9p5rCJ8zeUqyx dTpvS7ZAgbBRufFt5daiOlSZnci+C3dcM5hRYO5DI51b08/he+v4HBWU9HpnSbwYA1XV JNMQ== X-Gm-Message-State: AAQBX9dxANpqIk6Bi4CldTQTuTUg7DyjJMv2Rg9hK5qOnmEz9w7XloLF uHpzgZ+2ubQpVu2L8Eq/k7k= X-Google-Smtp-Source: AKy350YtBmjfNhtmakMY2kEjR2ylYD8dGbuPKUkIFkqZDl3KRvWJo6GhaguKIdHglCE0fs2foiqq4w== X-Received: by 2002:adf:ef43:0:b0:2c5:5ec7:43bc with SMTP id c3-20020adfef43000000b002c55ec743bcmr5652928wrp.18.1681067461605; Sun, 09 Apr 2023 12:11:01 -0700 (PDT) Received: from krug (98.142.114.89.rev.vodafone.pt. [89.114.142.98]) by smtp.gmail.com with ESMTPSA id z23-20020a1c4c17000000b003f07f0405b5sm6848263wmf.43.2023.04.09.12.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 12:11:00 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Basil Contovounesios Subject: Re: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master In-Reply-To: <87pm8dne2a.fsf@tcd.ie> (Basil Contovounesios's message of "Sun, 09 Apr 2023 18:46:53 +0100") References: <87pm8dne2a.fsf@tcd.ie> Date: Sun, 09 Apr 2023 20:13:05 +0100 Message-ID: <87zg7gna2m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62741 Cc: Dmitry Gutov , 62741@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Basil Contovounesios writes: > diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/egl= ot-tests.el > index 62e04539ebf..041aafabe8e 100644 > --- a/test/lisp/progmodes/eglot-tests.el > +++ b/test/lisp/progmodes/eglot-tests.el > @@ -325,8 +325,7 @@ eglot-test-eclipse-connect > "Connect to eclipse.jdt.ls server." > (skip-unless (executable-find "jdtls")) > (eglot--with-fixture > - '(("project/src/main/java/foo" . (("Main.java" . ""))) > - ("project/.git/" . nil)) > + '(("project/src/main/java/foo" . (("Main.java" . "")))) > (with-current-buffer > (eglot--find-file-noselect "project/src/main/java/foo/Main.java") > (eglot--sniffing (:server-notifications s-notifs) > > > Which I assume means that project-current picks up .git as a project > root marker, but project-files unexpectedly finds no registered files. > > I'm not sure whether this is expected on either the project or eglot > side. If I squint hard enough it kind of reminds me of bug#62735. I think the change is fine, please install it, and thanks. Let's hope it doesn't break on Emacs 26.3, 27 and 28=20 (f you could test, it would be great, if not it's OK. It'd involve making a GitHub fork and using the GitHub actions scripts) A safer, but slightly slower route: (should (zerop (shell-command "git init"))) Some tests known to need project-files already do this. But why does it pass on Emacs 29?? Maybe project-files simply doesn't error there? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 09 19:13:36 2023 Received: (at 62741) by debbugs.gnu.org; 9 Apr 2023 23:13:36 +0000 Received: from localhost ([127.0.0.1]:33919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pleE4-00034z-8G for submit@debbugs.gnu.org; Sun, 09 Apr 2023 19:13:36 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:40498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pleE1-00034l-82 for 62741@debbugs.gnu.org; Sun, 09 Apr 2023 19:13:35 -0400 Received: by mail-wr1-f54.google.com with SMTP id t4so41255932wra.7 for <62741@debbugs.gnu.org>; Sun, 09 Apr 2023 16:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1681082007; x=1683674007; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n+jcq54goMrU3YB9e02A5o/gNbqhhmtCHx4xXwo/IpI=; b=adR21NnFDKy/nuKLnvS5MK0DI5FBK7MuezE49KG5v6ExFHjASV7fLlDVZnydDjVDvI 7pLRpW0GzkebLdL6UjN7v5fDCH2RwWh6kXFkHTULA0ZeLSkw+E6VH/RO3jRhk69DIT7y Nbc4gQzBrBwOWoECAuuajSg7isAr9hACrKgBkIQNRggQvB31b5YaTSSviKaesPUttvMQ Rw6XgnkbrFQPPVWGJSaUbLxZDWosOvpdAfNwxXJ50tZjnXv1Xx5irRGnrg8PphRmbFnW wR1FpvqivbtN8Kj3sm12L8o3fX2xs6nHRZyu492YCUO7xJmxMpsXgVOH51Bi0j4cbM9G 878Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681082007; x=1683674007; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n+jcq54goMrU3YB9e02A5o/gNbqhhmtCHx4xXwo/IpI=; b=s+ZTbml2oMD8JxP0TtHr0s05oHtL0L9DUvmfIyI8+KHu3nOTXtEZ0iQZxNxH2z0A+R hUPZIYF0qAUfb7e1aO4btRnpQXQPqqBbo/NB64cRC1D3jAEvOsSvbF4jIj9Eb0hkpe01 14APy7xEZPu6kTOMwl3NoM93SeyVu9g6QmFAg2jvejqBnduLl4JOeYUn/v6C0waxHNZ5 5xhEKSQ40xVW7BdLKp/2CiNCW3OV1ZcN2CXyPRXffiX8BA0j0lVRxTFv1UXetczY1TGa hObBKnkacFu/OFr4bkLR1iWqzekk/f8oYzSzn7o4sDqwHGygMtajh7CuR0+FwWGmT67r jLPg== X-Gm-Message-State: AAQBX9eKnDoYtYnybDUWjwaABhCjnToVNNYgIMAJhtUdtiaGtqp6ze4i W7edqQ2ZzGGbMBkeVBUL8oiDUw== X-Google-Smtp-Source: AKy350bT4tGpu9HPvuqxwb3rg5JOI1Ua9/GCNgLlPjfeIteiRwWCC7cZ6JSDNhM/5Zoq14ayBGgWOg== X-Received: by 2002:a5d:534c:0:b0:2f0:2d96:1c5a with SMTP id t12-20020a5d534c000000b002f02d961c5amr1885157wrv.32.1681082007264; Sun, 09 Apr 2023 16:13:27 -0700 (PDT) Received: from localhost ([51.37.99.170]) by smtp.gmail.com with ESMTPSA id j12-20020a5d604c000000b002efb5f0cf44sm5797390wrt.3.2023.04.09.16.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 16:13:26 -0700 (PDT) From: Basil Contovounesios To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master In-Reply-To: <87zg7gna2m.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Sun, 09 Apr 2023 20:13:05 +0100") References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> Date: Mon, 10 Apr 2023 00:13:25 +0100 Message-ID: <875ya4k5t6.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62741 Cc: Dmitry Gutov , 62741@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora [2023-04-09 20:13 +0100] wrote: > Basil Contovounesios writes: > >> diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eg= lot-tests.el >> index 62e04539ebf..041aafabe8e 100644 >> --- a/test/lisp/progmodes/eglot-tests.el >> +++ b/test/lisp/progmodes/eglot-tests.el >> @@ -325,8 +325,7 @@ eglot-test-eclipse-connect >> "Connect to eclipse.jdt.ls server." >> (skip-unless (executable-find "jdtls")) >> (eglot--with-fixture >> - '(("project/src/main/java/foo" . (("Main.java" . ""))) >> - ("project/.git/" . nil)) >> + '(("project/src/main/java/foo" . (("Main.java" . "")))) >> (with-current-buffer >> (eglot--find-file-noselect "project/src/main/java/foo/Main.java= ") >> (eglot--sniffing (:server-notifications s-notifs) >> >> >> Which I assume means that project-current picks up .git as a project >> root marker, but project-files unexpectedly finds no registered files. >> >> I'm not sure whether this is expected on either the project or eglot >> side. If I squint hard enough it kind of reminds me of bug#62735. > > I think the change is fine, please install it, and thanks. Done: Avoid Git project in eglot-test-eclipse-connect 6674ac17eb4 2023-04-09 23:32:14 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D6674ac17eb4 > Let's hope it doesn't break on Emacs 26.3, 27 and 28 > > (f you could test, it would be great, if not it's OK. It'd involve > making a GitHub fork and using the GitHub actions scripts) Seems to work there too: https://github.com/basil-conto/eglot/commit/e915db94a6 https://github.com/basil-conto/eglot/actions/runs/4652799056 > A safer, but slightly slower route: > > (should (zerop (shell-command "git init"))) > > Some tests known to need project-files already do this. This continues to fail in the same way, both in emacs.git and eglot.git: https://github.com/basil-conto/eglot/commit/1b2d13eaf6 https://github.com/basil-conto/eglot/actions/runs/4652805286 > But why does it pass on Emacs 29?? Maybe project-files simply doesn't > error there? Maybe, but why not? Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 10 04:15:35 2023 Received: (at 62741) by debbugs.gnu.org; 10 Apr 2023 08:15:36 +0000 Received: from localhost ([127.0.0.1]:34252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plmgZ-0001iI-I9 for submit@debbugs.gnu.org; Mon, 10 Apr 2023 04:15:35 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:37481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plmgU-0001hz-Mt for 62741@debbugs.gnu.org; Mon, 10 Apr 2023 04:15:33 -0400 Received: by mail-wm1-f51.google.com with SMTP id i8-20020a05600c354800b003ee93d2c914so3637322wmq.2 for <62741@debbugs.gnu.org>; Mon, 10 Apr 2023 01:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681114525; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s7GZDGnZuDeY6omF2T3WDZtH8Dtd+vzVvozOLaQjtdw=; b=PgJyR9i6P1YemXqJj4uTRHYaqPPL+/K1T3wFi1tE3SoS188ebJMFa6FszK87cI/I9q QjKwYfYq1EQQOdSJMjio7faNh4t2pgEpODqwbceywc+IjM8K8h6sihhCDCu7S0fMtARg 3pKB+0bN4eFST1krT5gFw3ZhP1F4r/DxBHq+ZZTF4EGbffMM0JoAcfp2WUHAlSqpGkRQ fapd8ny6+ZQI1d898Tq9nS7AJJxh3Ghz49uLe3/LwCd4mC2MdzzSKtdvXVVVupNV9t1W pBJXTN8Cz39zUkerAbEyR0c32Q5si2T1TWgbGQ+iFsU3dE0gPiJB8E8hqIZKNXbsfPTU /IkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681114525; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=s7GZDGnZuDeY6omF2T3WDZtH8Dtd+vzVvozOLaQjtdw=; b=g8DlOEpy1YGboJ+yPvXvyNe4ooPGVFYfsuZJG33yvPpQKdI/vkXaCR7RdXN1UN0E4D rjfuDa21meEmjvH7Tzd1IKtBjyKpfChAvewrJK0rTZpDPtbREQY/OC7tJc1QMFL6mKr2 IMoJNtAwuSrZKGv6Hz24lx/7xjgALYXqlNU5Z5xSke8XyblbdMsQF9XLovJ6yKPCja2P DP71jTQshZR/R/RNI1/u1HwVD/9L26HTzo1z898SGcRCCcZxmZmyLF280/ydcNPf34cZ VNJ4I2Wumxfxci13nibBUVEdqedP153JaJO1lKFkPzL/Jd91EsmYwdEdT1aXIXeDj9Jy d03g== X-Gm-Message-State: AAQBX9cHHvppO4LIENLW0aK8UI1U8d8LCub2Q1nC30R/cS9GW9xOgcmk 1+WNLo2KUMSy3y7Qc+6fsus= X-Google-Smtp-Source: AKy350aAm3m0HasRNJsLRmy3X8fvroS2zUMsVStH7eDqNxUm4W/W77vKlDZjbtraIO4CSdma+2r0Ig== X-Received: by 2002:a7b:c5cd:0:b0:3ef:622c:26d3 with SMTP id n13-20020a7bc5cd000000b003ef622c26d3mr6782583wmk.35.1681114524798; Mon, 10 Apr 2023 01:15:24 -0700 (PDT) Received: from krug ([87.196.73.56]) by smtp.gmail.com with ESMTPSA id f4-20020a7bcd04000000b003ed1f6878a5sm13022855wmj.5.2023.04.10.01.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 01:15:24 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Basil Contovounesios Subject: Re: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master In-Reply-To: <875ya4k5t6.fsf@tcd.ie> (Basil Contovounesios's message of "Mon, 10 Apr 2023 00:13:25 +0100") References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> Date: Mon, 10 Apr 2023 09:17:29 +0100 Message-ID: <87r0ssm9ra.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62741 Cc: Dmitry Gutov , 62741@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Basil Contovounesios writes: > Jo=C3=A3o T=C3=A1vora [2023-04-09 20:13 +0100] wrote: > >> Basil Contovounesios writes: >> >>> diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/e= glot-tests.el >>> index 62e04539ebf..041aafabe8e 100644 >>> --- a/test/lisp/progmodes/eglot-tests.el >>> +++ b/test/lisp/progmodes/eglot-tests.el >>> @@ -325,8 +325,7 @@ eglot-test-eclipse-connect >>> "Connect to eclipse.jdt.ls server." >>> (skip-unless (executable-find "jdtls")) >>> (eglot--with-fixture >>> - '(("project/src/main/java/foo" . (("Main.java" . ""))) >>> - ("project/.git/" . nil)) >>> + '(("project/src/main/java/foo" . (("Main.java" . "")))) >>> (with-current-buffer >>> (eglot--find-file-noselect "project/src/main/java/foo/Main.jav= a") >>> (eglot--sniffing (:server-notifications s-notifs) >>> >>> >>> Which I assume means that project-current picks up .git as a project >>> root marker, but project-files unexpectedly finds no registered files. >>> >>> I'm not sure whether this is expected on either the project or eglot >>> side. If I squint hard enough it kind of reminds me of bug#62735. >> >> I think the change is fine, please install it, and thanks. > > Done: > > Avoid Git project in eglot-test-eclipse-connect > 6674ac17eb4 2023-04-09 23:32:14 +0100 > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D6674ac17eb4 > >> Let's hope it doesn't break on Emacs 26.3, 27 and 28 >> >> (f you could test, it would be great, if not it's OK. It'd involve >> making a GitHub fork and using the GitHub actions scripts) > > Seems to work there too: > https://github.com/basil-conto/eglot/commit/e915db94a6 > https://github.com/basil-conto/eglot/actions/runs/4652799056 Thanks! >> A safer, but slightly slower route: >> >> (should (zerop (shell-command "git init"))) >> >> Some tests known to need project-files already do this. > > This continues to fail in the same way, both in emacs.git and eglot.git: > https://github.com/basil-conto/eglot/commit/1b2d13eaf6 > https://github.com/basil-conto/eglot/actions/runs/4652805286 This is very odd then. Why would project-files fail in the face of (presumably) a perfectly well-behaved Git repository? Pasting the backtrace here for Dmitry to have a look. Test eglot-test-eclipse-connect backtrace: string-match("\0" nil 0) split-string(nil "\0" t) project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) #f(compiled-function (dir) #)("/tmp/eglot--f= ixturernYTOR/project/") mapcan(#f(compiled-function (dir) #) ("/tmp/= eglot--fixturernYTOR/project/")) #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) It would seem that the problem here is there are no files versioned yet, so this expression in project--vc-list-files (apply #'vc-git--run-command-string nil "ls-files" args) Returns nil.=20=20 But I cannot reproduce this locally. I'll leave it up to you, Basil, to decide whether to close or leave this bug open. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 10 05:11:38 2023 Received: (at control) by debbugs.gnu.org; 10 Apr 2023 09:11:38 +0000 Received: from localhost ([127.0.0.1]:34329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plnYn-0003SG-SD for submit@debbugs.gnu.org; Mon, 10 Apr 2023 05:11:38 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:44016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plnYh-0003Rl-5k for control@debbugs.gnu.org; Mon, 10 Apr 2023 05:11:35 -0400 Received: by mail-wm1-f50.google.com with SMTP id n9-20020a05600c4f8900b003f05f617f3cso9048460wmq.2 for ; Mon, 10 Apr 2023 02:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1681117885; x=1683709885; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=swRrecGujgS9g35mApFuFp0ImVh0sw66L+PBD6VkUxM=; b=RJF6Iy4NLKFlu1XnkOywQyRsPR7wG48vInSPTJcZc+p712aTZrbMyqTJuEgMTTJ8it Lmy3Etb9A3IYlcD+MqavMAscLE87VJhSPzMqhIouOuudlY1UExtoDXjxtPC+KM1OSgw6 uVuo6KUIr9HAl67vJNHwmPuEucQBH0IAxRCR4lZfdeoq1lATsy252zIgorzoJgZIz8Ic gunehp98ZGEl2N5nNhG060NUvl/yU9kcNWzHjuJcwaBbdBp2zubCQD7YwyoK3SxLMDby R+UcsdCzo5vo8phv9tL+ep++nh/LSiJv5Anav4Xc34KCtJrZhMJjckbMsE94YxOBnsgU SnEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681117885; x=1683709885; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=swRrecGujgS9g35mApFuFp0ImVh0sw66L+PBD6VkUxM=; b=F8pEK5gpmSOEPJH9QlbpBmMN2jQts9Q3ONASxBWpc7UsWN31hpxsSkeS9hfIiHkkjj 4gDW4/HcnbbXO5DQE08CgafjrgxPUhmA0RBA204vICmvKYuDmUxHPqfAG+X8XcDLWttv 9w7lSrvFfh2wKFSN0bmY+VP2+6Mf6gGPzL28JDGXKaCpoymU5fkv1X33Vtlg8Tr88ZV6 xGTjzdjriZnAntYqF5Wy7O+PlLxju1PAaL/ojUI2RIzay55UM8+rfedW5ZExUaq72YAj D1FNsN6+3hY6TO1a7ybatUofI/SotuYbFIeYkRe7F9CnscfOzD6xrcrzxwEN7RvbF8fW NpNw== X-Gm-Message-State: AAQBX9eHgMCU3o8wc/BnlZoN3wCtkjaMhqxlkF7vSqSdtDRoDdDOLzx5 y17O6OIecw7aklO1fgZrlFq82w== X-Google-Smtp-Source: AKy350ZbxBkbuKT3dUU/lMr/Q8zSOa2lY7KEGOb+FZ+gwPjR2AtAtluKUox2WEVBPMV8RryqjmrCZg== X-Received: by 2002:a1c:7214:0:b0:3ed:b56c:9496 with SMTP id n20-20020a1c7214000000b003edb56c9496mr6608735wmc.31.1681117885327; Mon, 10 Apr 2023 02:11:25 -0700 (PDT) Received: from localhost ([109.78.216.163]) by smtp.gmail.com with ESMTPSA id x10-20020a05600c21ca00b003edf2dc7ca3sm13038689wmj.34.2023.04.10.02.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 02:11:24 -0700 (PDT) From: Basil Contovounesios To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master In-Reply-To: <87r0ssm9ra.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Mon, 10 Apr 2023 09:17:29 +0100") References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> <87r0ssm9ra.fsf@gmail.com> Date: Mon, 10 Apr 2023 10:11:23 +0100 Message-ID: <87zg7ggkzo.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: Dmitry Gutov , 62741-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 62741 30.1 severity 62741 minor quit Jo=C3=A3o T=C3=A1vora [2023-04-10 09:17 +0100] wrote: > Pasting the backtrace here for Dmitry to have a look. > > Test eglot-test-eclipse-connect backtrace: > string-match("\0" nil 0) > split-string(nil "\0" t) > project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) > #f(compiled-function (dir) #)("/tmp/eglot-= -fixturernYTOR/project/") > mapcan(#f(compiled-function (dir) #) ("/tm= p/eglot--fixturernYTOR/project/")) > #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) > apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) > project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > It would seem that the problem here is there are no files versioned yet, > so this expression in project--vc-list-files > > (apply #'vc-git--run-command-string nil "ls-files" args) > > Returns nil.=20=20 > > But I cannot reproduce this locally. It's easy to reproduce the backtrace without Eglot, and it happens both on master and emacs-29. From emacs -Q: (let ((dir (make-nearby-temp-file "my-" t))) (unwind-protect (let ((default-directory (file-name-as-directory dir))) (make-directory ".git") (make-empty-file "file") ; Optional. (require 'project) (project-files (project-current))) (delete-directory dir t))) C-x C-e Debugger entered--Lisp error: (wrong-type-argument stringp nil) string-match("\0" nil 0) split-string(nil "\0" t) project--vc-list-files("/tmp/my-VHbIUg/" Git nil) #f(compiled-function (dir) #)("/tmp/my-VHb= IUg/") mapcan(#f(compiled-function (dir) #) ("/tm= p/my-VHbIUg/")) #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/my-VHbIUg/")) apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/my-VHbIUg/") nil) project-files((vc Git "/tmp/my-VHbIUg/")) > I'll leave it up to you, Basil, to decide whether to close or leave this > bug open. Closing, since the difference between master and emacs-29 materialised in the context of Eglot. If Dmitry thinks project-files is doing something unexpected, we can open a new ticket if necessary. Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 10 05:51:28 2023 Received: (at 62741-done) by debbugs.gnu.org; 10 Apr 2023 09:51:28 +0000 Received: from localhost ([127.0.0.1]:34354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ploBL-0006zQ-NJ for submit@debbugs.gnu.org; Mon, 10 Apr 2023 05:51:28 -0400 Received: from mail-oo1-f48.google.com ([209.85.161.48]:34565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ploBI-0006yp-UG for 62741-done@debbugs.gnu.org; Mon, 10 Apr 2023 05:51:26 -0400 Received: by mail-oo1-f48.google.com with SMTP id m20-20020a4ae3d4000000b00538c0ec9567so635596oov.1 for <62741-done@debbugs.gnu.org>; Mon, 10 Apr 2023 02:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681120279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k/S73ZHW9ma2AVueYEn4DBNCSmceVVrVobkAitwZnME=; b=e22tUCVDDXGHXfrHlCRcZkfmDqcPJ0L2t4GAftbqVvCtR9p7vQ4mcUk/ZSgGKRjOvI Mz6fw9gacTnaV0660QXCVLpXFo0/Nm2UZ+X27Oy97APwJiNJGPtYebvx5MVsaKAZr1NM Zx6WgDHRaRN4lUJ68RYFDXl/JANqje4Nn1kp7/LNmDQ8RuMeNmHGCa/Hh3TClztr8elA jOqNwQ7yW6x756RU/3+KEDT64kq9X0LmiLEGAkGZcebb4wLqBIyWeA6S8FFmWDugXPeU XYGS6nVkcuz2Hu18llDXynnf2EzYkrf3Z/E+YR2CzM97TZMBNLZFMsajuIkmlG3dbDQE 7KhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681120279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k/S73ZHW9ma2AVueYEn4DBNCSmceVVrVobkAitwZnME=; b=n1CRWD/FFK9lBb6/kuQCxV4yoyuVZFC9GmQKagCG0vfc7/gw3tyL9JdXgsbb6bEjwq DMTDWCGhMe4gPvnyynVOXmcdLsmldRQ5/QWP2dukcfEHkLy56JSk2t5lhLhlZZd5Gu1D iLkobIWnRyAIZ3RH06bTOB6Y+I2OHO3Vz5Qsp25gZkPqI0s7IX71d0t8CIwVeGvBkV8h UBwZrBYq+2vazcmTR8DgoLddhzMz86kPWf4r5Pin/3Jo5IsEtnJJYeLwvavODGeTBFOS /C3t0alpS8FcL3Z5VX1FSKUxoHEVY9NXkWO5MK0RsIt5u0vCqNcZUTvUXxMh988iDNV+ +itQ== X-Gm-Message-State: AAQBX9cvGm7oCjSd+dqI7PqkdtPsuY5oN5lVCiD2YeP4A9aPDxNyLR+O A3Tqzfpf+/eyb+QjdQTk2ZNt2qZt1pSYax07DKQ= X-Google-Smtp-Source: AKy350YGhAK55IH9m3HRLIULLX6nXbdjEI4ZPXu3dFtUowTXi1t0ZVUuRy8i+sI/1QKJ1Bv4FX+PSmBkJCxrn4/j+ZU= X-Received: by 2002:a4a:a584:0:b0:538:d154:cbc2 with SMTP id d4-20020a4aa584000000b00538d154cbc2mr3402728oom.1.1681120279011; Mon, 10 Apr 2023 02:51:19 -0700 (PDT) MIME-Version: 1.0 References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> <87r0ssm9ra.fsf@gmail.com> <87zg7ggkzo.fsf@tcd.ie> In-Reply-To: <87zg7ggkzo.fsf@tcd.ie> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 10 Apr 2023 10:51:08 +0100 Message-ID: Subject: Re: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master To: Basil Contovounesios Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62741-done Cc: Dmitry Gutov , 62741-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Apr 10, 2023 at 10:11=E2=80=AFAM Basil Contovounesios wrote: > > close 62741 30.1 > severity 62741 minor > quit > > Jo=C3=A3o T=C3=A1vora [2023-04-10 09:17 +0100] wrote: > > > Pasting the backtrace here for Dmitry to have a look. > > > > Test eglot-test-eclipse-connect backtrace: > > string-match("\0" nil 0) > > split-string(nil "\0" t) > > project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) > > #f(compiled-function (dir) #)("/tmp/eglo= t--fixturernYTOR/project/") > > mapcan(#f(compiled-function (dir) #) ("/= tmp/eglot--fixturernYTOR/project/")) > > #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) > > project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > > > It would seem that the problem here is there are no files versioned yet= , > > so this expression in project--vc-list-files > > > > (apply #'vc-git--run-command-string nil "ls-files" args) > > > > Returns nil. > > > > But I cannot reproduce this locally. > > It's easy to reproduce the backtrace without Eglot, and it happens both > on master and emacs-29. From emacs -Q: > > (let ((dir (make-nearby-temp-file "my-" t))) > (unwind-protect > (let ((default-directory (file-name-as-directory dir))) > (make-directory ".git") > (make-empty-file "file") ; Optional. > (require 'project) > (project-files (project-current))) > (delete-directory dir t))) > > C-x C-e This indeed breaks, but it doesn't break if you replace the 'make-directory' with '(shell-command "git init")'. And yet, when you tried that in Eglot's CI, it seem it _did_ break with the same error. So I don't know what's going on. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 10 07:56:58 2023 Received: (at 62741) by debbugs.gnu.org; 10 Apr 2023 11:56:58 +0000 Received: from localhost ([127.0.0.1]:34455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plq8o-0007Lo-40 for submit@debbugs.gnu.org; Mon, 10 Apr 2023 07:56:58 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:54653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plq8l-0007LW-Vp for 62741@debbugs.gnu.org; Mon, 10 Apr 2023 07:56:56 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id BA1275820AB; Mon, 10 Apr 2023 07:56:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 10 Apr 2023 07:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681127810; x=1681131410; bh=FAoXV6u48yll8GHqbvky7Osu5buFEOr2fMb /Xjn2Ulc=; b=v84DNLwrxotWLc4Qk+vyxBlXOhjBB3kM/QASJ1yGje13NOwCcQ9 JUGB2PNZ6yyzRVEDOLLcyuts3EjcE1CuPbYFWh4LIeuRnil2SbdOWr1rKJ4fLy9F v7GZgMC9zWYDO7KK324wcHbhSROk7rEFHqNsyfKPPcfiISQFo80jnY1xft9UYVOp VdpbNd6iPTtIc61+yuI8MLEC/GnXu+afVrwR6L9dYUplP2EKckfjeOawD/9xjilp 2jRmaEyt8UAIOiI50ZqsjFjWmUvtPqLCftLTZ3J/RYWjptXUKpG4Vn9ayzrVbIa+ QBb8VDDvHOsWyZIeumzL9EITGPTs1wOBixQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1681127810; x=1681131410; bh=FAoXV6u48yll8GHqbvky7Osu5buFEOr2fMb /Xjn2Ulc=; b=u/FI0UDy4zgdOgNz6RalUhuw+fmbcUMTt+hvK0DyLmIAP2ycaHF aMkNfW9UjQXkcR00NSIJpbdk7mrVW6MILXUdu/HmRkE2byhAAKpxZti0Ssv39PSG TnXW85HKKh8c72sqP/oGI9vlVRCfwXKXDUoKZBrguC649YIlplb7tOLtztT+w2vy 1mfBWaEYdMRX+9e6WtzAVsQwOnvj03YuHL585YDEEo5YqqBk1MmHhGPgg6TtVFSr j/AeBlEzoe/BgmqUt9pn7b5ynI2Htk2vyWmT86trZBLMuK1IU00G64VKX3rFTJZ/ NpFG+ms/X3qVQT8ItJVqoSQe1xUkQcicaaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekvddggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Apr 2023 07:56:49 -0400 (EDT) Message-ID: <83e7126a-d0b0-b3a7-7cb1-809c041ba622@gutov.dev> Date: Mon, 10 Apr 2023 14:56:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master Content-Language: en-US To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Basil Contovounesios References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> <87r0ssm9ra.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87r0ssm9ra.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62741 Cc: 62741@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi! On 10/04/2023 11:17, João Távora wrote: > This is very odd then. Why would project-files fail in the face of > (presumably) a perfectly well-behaved Git repository? > > Pasting the backtrace here for Dmitry to have a look. > > Test eglot-test-eclipse-connect backtrace: > string-match("\0" nil 0) > split-string(nil "\0" t) > project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) > #f(compiled-function (dir) #)("/tmp/eglot--fixturernYTOR/project/") > mapcan(#f(compiled-function (dir) #) ("/tmp/eglot--fixturernYTOR/project/")) > #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) > apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) > project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > It would seem that the problem here is there are no files versioned yet, > so this expression in project--vc-list-files > > (apply #'vc-git--run-command-string nil "ls-files" args) > > Returns nil. > > But I cannot reproduce this locally. I haven't been able to reproduce this locally either. If I just use a repo after 'git init', the return value of vc-git--run-command-string (inside project--vc-list-files) is an empty string, not nil. Could this be that the repo in the test isn't actually initialized? Or maybe there's something different in the test environment. My Git version is 2.37.2. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 10 08:00:53 2023 Received: (at 62741) by debbugs.gnu.org; 10 Apr 2023 12:00:53 +0000 Received: from localhost ([127.0.0.1]:34466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plqCa-0007UC-Jh for submit@debbugs.gnu.org; Mon, 10 Apr 2023 08:00:52 -0400 Received: from mail-oi1-f171.google.com ([209.85.167.171]:39761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plqCX-0007Tr-LX for 62741@debbugs.gnu.org; Mon, 10 Apr 2023 08:00:51 -0400 Received: by mail-oi1-f171.google.com with SMTP id bx42so19401520oib.6 for <62741@debbugs.gnu.org>; Mon, 10 Apr 2023 05:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681128044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LVNrIwVi3rfes3hoQTRNqgZ0RE6GYze10K28FK5/BXY=; b=PdYhrwv3n+WPMTqPQL6KNlZ5cLUsKNSEhpwZZDaNqaaWaqAFHmZOpi1tfYgvEi5//d boOTanUbDVlpnhnieq/7J+IPs2zE9II/aR/oQkSulQAirWr9K2n20ZtFS/4Bpcxws1ms IEHqd4e7zmu7HRhe6ktDLs2v38kz31xkqU7nfj9wBgpoaDksvafz3mkmbG5NbxoHDJym QxhS4kxpK57CQ9jQOHCQ50TsSQCycSG+vcAlDJ4JcVXEhc1lDgjKG1LVhcBWEbFCVYKA XqMKBh3GGLnpExACCnAdq8/cIB8uNWl7UjrVjGb0zqq8w++znMp1LTKrebeCMlB0gihp Uxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681128044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LVNrIwVi3rfes3hoQTRNqgZ0RE6GYze10K28FK5/BXY=; b=6x1hrHEry7HG7n36dXh/i8hJgmUD8z58Br/7dMSr7B1Gcjr0XJG8i6cLTIUrmOA0Zp +PXo8Vb0hJuYrndcEyXP0rvoayG9Gp/LdW5Kmp+alhoOza8rcZ558Rc2X4QdlcBoUd86 7qIJAljaeZmjeJAKo4diBZyxJzuAygbyWNrdl9UT3MJNjFo7NdOto+GJSxvbxiDzMYKo scPgybAXtvW86B6YZQbXi95XLQrq4gqOobPTDYJXWEqlqLY1+N6oggS6EsrzThIWTdCG idpZPoOuwYHMeImPzKkl1mzYvjSRUQyFHuLryrbdqauU0LTE7vCKBRrSm5DXUnqUWidE ajTQ== X-Gm-Message-State: AAQBX9dIndWE5B1DAz85XFVovq9Ria+lmdT3j1zs39J9DGaTWqt7a6bB cnfy60RcRAIWYgDJsAxKXzIW3uLb3WuWLvhheWc= X-Google-Smtp-Source: AKy350aKh9CUgh1pmTzV+ZSD4kdesEbRLwXr1vKyDnFWMfh0bffbz4GmPROM5/J/v6M+k4tSE76EArVQ9OH8lenq4As= X-Received: by 2002:a05:6808:2195:b0:386:a109:57c8 with SMTP id be21-20020a056808219500b00386a10957c8mr2417097oib.5.1681128043924; Mon, 10 Apr 2023 05:00:43 -0700 (PDT) MIME-Version: 1.0 References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> <87r0ssm9ra.fsf@gmail.com> <83e7126a-d0b0-b3a7-7cb1-809c041ba622@gutov.dev> In-Reply-To: <83e7126a-d0b0-b3a7-7cb1-809c041ba622@gutov.dev> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 10 Apr 2023 13:00:32 +0100 Message-ID: Subject: Re: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62741 Cc: Basil Contovounesios , 62741@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Apr 10, 2023 at 12:56=E2=80=AFPM Dmitry Gutov wr= ote: > > Hi! > > On 10/04/2023 11:17, Jo=C3=A3o T=C3=A1vora wrote: > > This is very odd then. Why would project-files fail in the face of > > (presumably) a perfectly well-behaved Git repository? > > > > Pasting the backtrace here for Dmitry to have a look. > > > > Test eglot-test-eclipse-connect backtrace: > > string-match("\0" nil 0) > > split-string(nil "\0" t) > > project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) > > #f(compiled-function (dir) #)("/tmp/egl= ot--fixturernYTOR/project/") > > mapcan(#f(compiled-function (dir) #) ("= /tmp/eglot--fixturernYTOR/project/")) > > #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) > > project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > > > It would seem that the problem here is there are no files versioned yet= , > > so this expression in project--vc-list-files > > > > (apply #'vc-git--run-command-string nil "ls-files" args) > > > > Returns nil. > > > > But I cannot reproduce this locally. > > I haven't been able to reproduce this locally either. If I just use a > repo after 'git init', the return value of vc-git--run-command-string > (inside project--vc-list-files) is an empty string, not nil. > > Could this be that the repo in the test isn't actually initialized? Or > maybe there's something different in the test environment. My Git > version is 2.37.2. In the GitHub CI, Basil used both strategies, iow he invoked "git init" in a directory that already had an empty ".git" directory. Maybe the Git version in GitHub's ubuntu machines doesn't react to that the same way my Git version does (which is to not be bothered by the existing directory, and do its work all the same). I don't think this is extremely important though. It'll pop up eventually if it is a real problem. Jo=C3=A3o From unknown Fri Jun 20 07:29:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 May 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator