From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 08 03:20:49 2023 Received: (at submit) by debbugs.gnu.org; 8 Apr 2023 07:20:49 +0000 Received: from localhost ([127.0.0.1]:57584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl2sS-0008GZ-Pt for submit@debbugs.gnu.org; Sat, 08 Apr 2023 03:20:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:55194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl2sP-0008GQ-Jj for submit@debbugs.gnu.org; Sat, 08 Apr 2023 03:20:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl2sP-00006h-21 for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 03:20:45 -0400 Received: from smtp-25.smtpout.orange.fr ([80.12.242.25] helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pl2sM-0000Pl-Fe for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 03:20:44 -0400 Received: from fedora.home ([109.210.14.182]) by smtp.orange.fr with ESMTPA id l2sGpERBpV6zQl2sGpVt59; Sat, 08 Apr 2023 09:20:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1680938437; bh=GIZMSMUUug/0fdnJKU0/GzDVy3mrnztZsnHCkoQzt7g=; h=From:To:Subject:Date; b=PO+ZpfiqTPfsyAffZA4iZ1va4iHyljRcDTIYRt5dL9FoFgV7GWO+YNpvoTf9PEEtH nE2zTcTB2UzAmenngrkLyRSC+4Gt3uRcdqJPD1EMS0NRIgvPYMqJ8vjAo/R6c1vU5L ppXhVq6erVeHH0w1CV48HrcLEkM5tF3OSm+YMzAlOc0PmU6sQAI5vhICpDfqJd4ctW RDsyM/w8NsSgMerNmruZLx3vHzUVzU2IhYpyWrMRPLN5uE7dApldqW8NUTalg0i5pF y3oR7KXsc34KGo5AKSw71wsAXXHOSI2p37Z+xNddzTy6HJTQWEA11qNVnl+7Ke1QBS Q8O0987sN/W1Q== X-ME-Helo: fedora.home X-ME-Auth: YmF1emFjLXN0ZWhseS5mYWJyaWNlQG9yYW5nZS5mcg== X-ME-Date: Sat, 08 Apr 2023 09:20:37 +0200 X-ME-IP: 109.210.14.182 Received: from noon by fedora.home with local (Exim 4.96) (envelope-from ) id 1pl2sG-0004cB-0e for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 09:20:36 +0200 From: Fabrice Bauzac-Stehly To: bug-gnu-emacs@gnu.org Subject: 30.0.50; EUDC: stop adding a wildcard to LDAP searches Date: Sat, 08 Apr 2023 09:20:36 +0200 Message-ID: <874jpqalh7.fsf@fedora.home> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=80.12.242.25; envelope-from=libnoon@orange.fr; helo=smtp.smtpout.orange.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Hello, I use EUDC to search entries from LDAP. I routinely search for a username to retrieve the email address. The LDAP server contains lots of entries, and a username is often a prefix of lots of other usernames. For example, when I search for the "js" username, I don't want to have dozens of results of usernames that just start with "js" like "jsmith" or "jscott". However, that's what eudcb-ldap does: for reasons I don't understand, the eudc-ldap-format-query-as-rfc1558 defun automatically appends the wildcard character "*" to the last field. This is annoying as I get dozens of results. I want to have the choice of adding a wildcard or not to my searches, I don't want that imposed on me. I propose the attached patch to fix this behaviour. The result is a simplification of the existing code. Could you please review it? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Don-t-add-a-wildcard-to-LDAP-query-items.patch Content-Description: patch >From 128e243175763606c73cb23beea0b0b25739ce2d Mon Sep 17 00:00:00 2001 From: Fabrice Bauzac Date: Fri, 13 Jan 2023 15:44:35 +0100 Subject: [PATCH] Don't add a wildcard to LDAP query items lisp/net/eudcb-ldap.el (eudc-ldap-format-query-as-rfc1558): don't add an arbitrary wildcard to the last query item. --- lisp/net/eudcb-ldap.el | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/lisp/net/eudcb-ldap.el b/lisp/net/eudcb-ldap.el index b1733e99f5c..f39df13c391 100644 --- a/lisp/net/eudcb-ldap.el +++ b/lisp/net/eudcb-ldap.el @@ -174,21 +174,13 @@ eudc-ldap-escape-query-special-chars (defun eudc-ldap-format-query-as-rfc1558 (query) "Format the EUDC QUERY list as a RFC1558 LDAP search filter." - (let ((formatter - (lambda (item &optional wildcard) - (format "(%s=%s)" - (car item) - (concat - (eudc-ldap-escape-query-special-chars - (cdr item)) - (if (and wildcard - (not (memq (car item) - eudc-ldap-no-wildcard-attributes))) - "*" "")))))) - (format "(&%s)" - (concat - (mapconcat formatter (butlast query) "") - (funcall formatter (car (last query)) t))))) + (let ((formatter (lambda (item) + (format "(%s=%s)" + (car item) + (concat + (eudc-ldap-escape-query-special-chars + (cdr item))))))) + (format "(&%s)" (mapconcat formatter query "")))) ;;}}} -- 2.25.1 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, cairo version 1.16.0) of 2023-03-07 built on ncelrnd2571 Repository revision: 4e8b50ec57bc0d70bdb1279756eec679eb4eab0d Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Ubuntu 20.04.6 LTS Configured using: 'configure -C --with-x-toolkit=no' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_MONETARY: fr_FR.UTF-8 value of $LC_NUMERIC: fr_FR.UTF-8 value of $LC_TIME: C.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Outline Minor modes in effect: bug-reference-mode: t global-git-commit-mode: t magit-auto-revert-mode: t auto-revert-mode: t shell-dirtrack-mode: t electric-pair-mode: t server-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/fbauzac/.emacs.d/shared/el/1a-snipit hides /home/fbauzac/.emacs.d/elpa/1a-snipit-1.0/1a-snipit /home/fbauzac/.emacs.d/elpa/transient-0.3.7/transient hides /home/fbauzac/git/emacs-master-2023-03-07/lisp/transient Features: (shadow sort mail-extr emacsbug magit-patch magit-subtree magit-extras magit-gitignore magit-ediff ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util dcl-mode tempo conf-mode genpass vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view vc bug-reference face-remap cal-iso cal-move tabify man goto-addr network-stream url-cache 1a-snipit dired-aux pcmpl-unix my-present webjump godjira whitespace org-element org-persist org-id org-refile avl-tree generator oc-basic ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range gnus-win ol-docview doc-view image-mode exif ol-bibtex bibtex iso8601 ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-version org-compat org-macs my-shell epa-file url-http url-auth url-gw nsm secrets dbus xml kinit jka-compr my-timeline ert ewoc calc-arith dabbrev apropos files-x anyconnect shortdoc copyright char-fold misearch multi-isearch help-fns radix-tree cl-print debug backtrace find-func cus-start my-host-resolve fb-jira-menu aproach bms mule-util cal-china lunar solar cal-dst cal-islam holidays holiday-loaddefs vc-git vc-dispatcher appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs find-lisp filecache my-magit magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode easy-mmode git-commit log-edit message sendmail yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor shell pcomplete magit-mode transient cl-extra edmacro kmacro help-mode format-spec magit-git magit-section magit-utils crm dash my-bazel my-skeletons skeleton sh-script smie executable cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs python rx project pcase treesit comint ansi-osc ring ansi-color ibuf-macs ibuffer ibuffer-loaddefs calc-prog calc-ext calc calc-loaddefs rect calc-macs gnus nnheader gnus-util text-property-search time-date mail-utils range mm-util mail-prsvr elec-pair delsel eudcb-ldap ldap eudc eudc-options-file eudc-vars auth-source-pass server jira-markup-mode derived thingatpt noutline outline cus-edit pp cus-load icons wid-edit info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 690616 125578) (symbols 48 38019 3) (strings 32 161896 18152) (string-bytes 1 5147041) (vectors 16 85900) (vector-slots 8 1803819 116939) (floats 8 919 748) (intervals 56 42691 2868) (buffers 976 77)) -- Fabrice Bauzac-Stehly PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 10 10:29:47 2023 Received: (at 62721) by debbugs.gnu.org; 10 Apr 2023 14:29:47 +0000 Received: from localhost ([127.0.0.1]:35610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plsWg-0003UF-MP for submit@debbugs.gnu.org; Mon, 10 Apr 2023 10:29:46 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:38277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plsWe-0003U2-TH for 62721@debbugs.gnu.org; Mon, 10 Apr 2023 10:29:45 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 517D7320090A; Mon, 10 Apr 2023 10:29:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 10 Apr 2023 10:29:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1681136978; x=1681223378; bh=bn OF1raACvCG9Zt2dzaR+Pk3mDpDjxRTiC4wOpK+ujQ=; b=zCCxHpQNCjYjikatCf HlK2bZg9ulIZAuLKrJH/nAZvpG5gudIG9lqRUhnLx24SsjloJ3yjnadbdmYekylH HqBHUnDskRQtHTyZsOgJwxPdc92n2V48gVkW/yW0vBdi9G8dpNBPFg+7esZeY5vr TWJXL6Jz/0ArelbzN8OZq6kmeKHahHxxk/pYkKu7ibzjVwEBLHCm6fBXFiTPpR+J 3JQtg8fH5uGyJJZFpT26Vzqhz8ccTPOU/jlICw85Y+qYNuJSRxH7ZYlola4a8IqL CXenB1rjTnCFfwArnlJKCE+lwAy2IIazL5YnZy24JjXyMGyOw6TOEHlCXaQCaMa1 ydag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1681136978; x=1681223378; bh=bnOF1raACvCG9 Zt2dzaR+Pk3mDpDjxRTiC4wOpK+ujQ=; b=aH7p5yAz8Zh/cRsW6MjZPGDG/nusS gCDUk66JpXe7ABf/tQGJq+mCXgOg9qPuZPt8e7um1gVSTIjCU5uHFPLLPKu6B13w +R1R99SXxIP2e/AXzdapQPYZX+LU0rnPuGLgUWHGgXo35aTfw8fSTYoFTIam2lUs M7lJp+gA+d8O96eMcDF16/eAdiwXSEclhESpvuOQUVV3UsrGNaapl+lEY+EDMPC7 Zllv+LUAREw80knIM+01D/FlfUHka6AnaqIur1tELdh4Sgwuk4fBYEEjE5igpk2P JMUCPRYVfb9+9SkAV2ar+GwfsbFxU2lY+f05VLbP2FMUcWnT+kxSovW8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekvddgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhgffffkgggtsehttd ertddtredtnecuhfhrohhmpefhihhlihhpphcuifhunhgsihhnuceofhhguhhnsghinhes fhgrshhtmhgrihhlrdhfmheqnecuggftrfgrthhtvghrnhepfffhjeevieeiiedutefghe ffleeiveeffeeftdekleehledufeeuueduheevieffnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepfhhguhhnsghinhesfhgrshhtmhgrihhlrd hfmh X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Apr 2023 10:29:37 -0400 (EDT) From: Filipp Gunbin To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: <874jpqalh7.fsf@fedora.home> (Fabrice Bauzac-Stehly's message of "Sat, 08 Apr 2023 09:20:36 +0200") References: <874jpqalh7.fsf@fedora.home> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 10 Apr 2023 17:29:35 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 08/04/2023 09:20 +0200, Fabrice Bauzac-Stehly wrote: > Hello, > > I use EUDC to search entries from LDAP. I routinely search for a > username to retrieve the email address. The LDAP server contains lots > of entries, and a username is often a prefix of lots of other usernames. > For example, when I search for the "js" username, I don't want to have > dozens of results of usernames that just start with "js" like "jsmith" > or "jscott". > > However, that's what eudcb-ldap does: for reasons I don't understand, > the eudc-ldap-format-query-as-rfc1558 defun automatically appends the > wildcard character "*" to the last field. This is annoying as I get > dozens of results. I want to have the choice of adding a wildcard or > not to my searches, I don't want that imposed on me. > > I propose the attached patch to fix this behaviour. The result is a > simplification of the existing code. Could you please review it? > Hi, The wildcard is there so you can use partial values with M-x eudc-expand-inline (and also in M-x eudc-query-form and others). You can customize eudc-ldap-no-wildcard-attributes, or just let-bind it around your code. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 10 15:09:50 2023 Received: (at 62721) by debbugs.gnu.org; 10 Apr 2023 19:09:50 +0000 Received: from localhost ([127.0.0.1]:35938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plwti-00088t-JX for submit@debbugs.gnu.org; Mon, 10 Apr 2023 15:09:50 -0400 Received: from smtp-16.smtpout.orange.fr ([80.12.242.16]:64077 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plwtg-00088h-Fi for 62721@debbugs.gnu.org; Mon, 10 Apr 2023 15:09:49 -0400 Received: from fedora.home ([109.210.14.182]) by smtp.orange.fr with ESMTPA id lwtepfe2xmRIzlwtepHlL6; Mon, 10 Apr 2023 21:09:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1681153786; bh=DU6IFEozC3wyH2+jVGCxl8KE/7CPn3SgkzFjsLKTZ54=; h=From:To:Cc:Subject:In-Reply-To:Date; b=js+7JJApWw4Pyly4E7o36/8Vm/5cjv2pwr1yc4kgA2nEpk3jTMeTKPdOAYQl2cKe5 bl6cyzux+EYCqyMCEPSlFfg4x1Do7OjZHS6L91nMgXNTf+GZ+2CetSiz5aCop4i8XE NA9gTzGZH+dR0V5O2JyM4Yq9rz5vFS/ANpiMpDhmnSqnkVYF4Rgllpwh0fKVqzu3C/ 4Nhm472gvaioGBdJaaIY6C7IvN/jc1o4Hq5E1+Hm6PyNd6VP1Urh9AVK/HkUDPCT00 px5eCAOoHtUmna38AOaGBS67c1niWGmT9UcelP3ZlYoiNaRT90KOvJeu/ph1q5rEYV 6qzxsu79JwWCQ== X-ME-Helo: fedora.home X-ME-Auth: YmF1emFjLXN0ZWhseS5mYWJyaWNlQG9yYW5nZS5mcg== X-ME-Date: Mon, 10 Apr 2023 21:09:46 +0200 X-ME-IP: 109.210.14.182 Received: from noon by fedora.home with local (Exim 4.96) (envelope-from ) id 1plwte-000Abg-1N; Mon, 10 Apr 2023 21:09:46 +0200 From: Fabrice Bauzac-Stehly To: Filipp Gunbin Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (message from Filipp Gunbin on Mon, 10 Apr 2023 17:29:35 +0300) Date: Mon, 10 Apr 2023 21:09:46 +0200 Message-ID: <873557pn9h.fsf@fedora.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Sorry, I have not put sufficient information in my initial message. In my case, I'm using eudc-query-form, where I know I can add wildcards to the fields if I want. My complaint is about the fact that a wildcard is imposed on me in this case, with annoying consequences. Thanks to your message, I understand though that this automatic wildcard may be useful in other contexts where `eudc-ldap-format-query-as-rfc1558' is called. Customizing `eudc-ldap-no-wildcard-attributes' would work in the sense that I could disable the wildcards in all cases, but I suspect this solution is not ideal as it would also disable it in the case of eudc-expand-inline where (as I understand from your message) it would actually be useful. I think that in the case of eudc-query-form, no wildcard should ever be added. What do you think? Should we pass some parameter so that eudc-ldap-format-query-as-rfc1558 knows what to do? Thanks! From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 10 15:36:31 2023 Received: (at 62721) by debbugs.gnu.org; 10 Apr 2023 19:36:31 +0000 Received: from localhost ([127.0.0.1]:35980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plxJX-0002pB-9F for submit@debbugs.gnu.org; Mon, 10 Apr 2023 15:36:31 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:56563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plxJV-0002ox-NY for 62721@debbugs.gnu.org; Mon, 10 Apr 2023 15:36:30 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 977233200035; Mon, 10 Apr 2023 15:36:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 10 Apr 2023 15:36:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1681155383; x=1681241783; bh=bD pWc2Qcq6GnUg5KUJThFtIfj0+4iibYRf2iGCsdNB4=; b=p5nST0p3oMJ/KdCQp9 JCgHOpcn9NUKjL92NOWUbX6TEl7Eh7C+VoIG7Wdm1K33ikuiUuwB8AqydtLhaqv9 SsWWP8eQdqtkNFAOKcoGwmbpr+ylNsdke0W804s7EXHCkA1CzCclEVTxzaQTzlNV N8f+OKcKWCWTPevEGPGIBX+sDRFM8+wNPxKpx9eYapaw2XsgJMAtzFVH7PVqNjsr 68vm8/0CxEFqLjleH9FAmKY7TuAJMzaVcyXdZqdfKPbpVa+8jg/IBQY/h7bVGK3W Dic95/BEaf5RQaIj3+g3eb44/BxIFvMypXUKx8DSJrN415o6fJHwNoH2uytopvWv O76w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1681155383; x=1681241783; bh=bDpWc2Qcq6GnU g5KUJThFtIfj0+4iibYRf2iGCsdNB4=; b=PTQiZ3ZbZZvLd0CUZZe2XJoBSrwDr DD8P+I8bCHVhQviUvVfEDJInm0q7T2+YJM20lukRW60rvxHTlMiVJhGzxtWZpFZC SG/c9ckh1Sqny7BK51oz6rF5OdVAuMRukhf+ZTJadgilDnto8vJDMWaygkDlYG1R onUF56R1aWjMr+LFwXRgc8Q/CmR8CnMvF+7U1UasPIC7c0UMZjIxx/EHoD/I7iBk rLykLYmzMIjDsjpHHPY3dD5rt/pRCAbFGPeRjL9C6mdr1QBbHoTAVL8RCWnaZEMp HdFgvCWi+4jfTaT8Tw+l7+sqStAXq2tWO5rRSMGf3MQKhdQ7goxf+IY3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekvddgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffgffkfggtgesth dtredttdertdenucfhrhhomhephfhilhhiphhpucfiuhhnsghinhcuoehfghhunhgsihhn sehfrghsthhmrghilhdrfhhmqeenucggtffrrghtthgvrhhnpeffhfejveeiieeiudetgf ehffelieevfeeffedtkeelheeludefueeuudehveeiffenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehfghhunhgsihhnsehfrghsthhmrghilh drfhhm X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Apr 2023 15:36:22 -0400 (EDT) From: Filipp Gunbin To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: <873557pn9h.fsf@fedora.home> (Fabrice Bauzac-Stehly's message of "Mon, 10 Apr 2023 21:09:46 +0200") References: <874jpqalh7.fsf@fedora.home> <873557pn9h.fsf@fedora.home> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 10 Apr 2023 22:36:18 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 10/04/2023 21:09 +0200, Fabrice Bauzac-Stehly wrote: > Hello, > > Sorry, I have not put sufficient information in my initial message. In > my case, I'm using eudc-query-form, where I know I can add wildcards to > the fields if I want. My complaint is about the fact that a wildcard is > imposed on me in this case, with annoying consequences. Thanks to your > message, I understand though that this automatic wildcard may be useful > in other contexts where `eudc-ldap-format-query-as-rfc1558' is called. > > Customizing `eudc-ldap-no-wildcard-attributes' would work in the sense > that I could disable the wildcards in all cases, but I suspect this > solution is not ideal as it would also disable it in the case of > eudc-expand-inline where (as I understand from your message) it would > actually be useful. > > I think that in the case of eudc-query-form, no wildcard should ever be > added. What do you think? Should we pass some parameter so that > eudc-ldap-format-query-as-rfc1558 knows what to do? > > Thanks! To me, it's always useful to have wildcard. Would this simple advice help in your case? I tried it with mail, replace it with your attributes. (defun my/eudc-process-form (orig &rest args) (let ((eudc-ldap-no-wildcard-attributes (cons 'mail eudc-ldap-no-wildcard-attributes))) (apply orig args))) (advice-add 'eudc-process-form :around #'my/eudc-process-form) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 08:49:05 2023 Received: (at 62721) by debbugs.gnu.org; 19 Apr 2023 12:49:05 +0000 Received: from localhost ([127.0.0.1]:33011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pp7FB-00065y-05 for submit@debbugs.gnu.org; Wed, 19 Apr 2023 08:49:05 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:45682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pp7F8-00065T-Ld for 62721@debbugs.gnu.org; Wed, 19 Apr 2023 08:49:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jiGGUE69Nle2VZAb04edYp3JcoYj/4QEK1sSkf9tIbw=; b=R9TjsIkPAP5crCc2udYm2Ga8xK Rj1gj8vJaxHdrzMiMOKW+in1CUxH/Du483IUeXrdTcQgHie+s8emmzDH5QEqWC6zDJEz30Afbg62b OKRTGjrP0eeKzQ5csOxi+cO8etxuct2gtKzQSBI8FXvs+xlLU+fN4xkNq8F/XT4c6jB94UuIUGIVZ jd+t1Srl/hFQ6xWa3lj1prgxBdBLghV2hPjRTe+pN2jaE5IIFopOGxZn3hR3B4BSqvv6R+/Nx1O4+ aB9mSYVQ7mKbSBVQKgvUC5YElYtqVH+AHSn6BpKYEW7nzVxMQDrueJcMYGi30pWaYcwYOQX/vEK/G e76tEFLg==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pp7F1-000Nho-K0; Wed, 19 Apr 2023 08:48:56 -0400 From: Thomas Fitzsimmons To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (Filipp Gunbin's message of "Mon, 10 Apr 2023 22:36:18 +0300") References: <874jpqalh7.fsf@fedora.home> <873557pn9h.fsf@fedora.home> Date: Wed, 19 Apr 2023 08:48:54 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, Filipp Gunbin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Fabrice, Filipp Gunbin writes: > On 10/04/2023 21:09 +0200, Fabrice Bauzac-Stehly wrote: > >> Hello, >> >> Sorry, I have not put sufficient information in my initial message. In >> my case, I'm using eudc-query-form, where I know I can add wildcards to >> the fields if I want. My complaint is about the fact that a wildcard is >> imposed on me in this case, with annoying consequences. Thanks to your >> message, I understand though that this automatic wildcard may be useful >> in other contexts where `eudc-ldap-format-query-as-rfc1558' is called. >> >> Customizing `eudc-ldap-no-wildcard-attributes' would work in the sense >> that I could disable the wildcards in all cases, but I suspect this >> solution is not ideal as it would also disable it in the case of >> eudc-expand-inline where (as I understand from your message) it would >> actually be useful. >> >> I think that in the case of eudc-query-form, no wildcard should ever be >> added. What do you think? Should we pass some parameter so that >> eudc-ldap-format-query-as-rfc1558 knows what to do? >> >> Thanks! > > To me, it's always useful to have wildcard. > > Would this simple advice help in your case? I tried it with mail, > replace it with your attributes. > > (defun my/eudc-process-form (orig &rest args) > (let ((eudc-ldap-no-wildcard-attributes > (cons 'mail eudc-ldap-no-wildcard-attributes))) > (apply orig args))) > > (advice-add 'eudc-process-form :around #'my/eudc-process-form) Did the advice that Filipp suggested work for you? Maybe we could add a checkbox to eudc-query-form whether to tack on a wildcard or not, defaulted to the value of eudc-ldap-no-wildcard-attributes. Thomas From debbugs-submit-bounces@debbugs.gnu.org Sun May 14 15:11:01 2023 Received: (at 62721) by debbugs.gnu.org; 14 May 2023 19:11:01 +0000 Received: from localhost ([127.0.0.1]:41580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyH7U-0004NL-PY for submit@debbugs.gnu.org; Sun, 14 May 2023 15:11:01 -0400 Received: from smtp-27.smtpout.orange.fr ([80.12.242.27]:49612 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyH7R-0004NB-Qb for 62721@debbugs.gnu.org; Sun, 14 May 2023 15:10:59 -0400 Received: from fedora.home ([109.210.14.182]) by smtp.orange.fr with ESMTPA id yH7MpXy8JarguyH7Mpz8pL; Sun, 14 May 2023 21:10:56 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1684091456; bh=3gx6tGxSpPAkniMqZbWicZeqj+/Xsfdfolyrw1NrMf0=; h=From:To:Cc:Subject:In-Reply-To:Date; b=IGg8d/vyUeUx35tBYtH4YfEsAUGi0ZAwpM3zNglpgOn/yTAwY7gvvLfZ8Wmcmh6pN iZ190jF1rYhOAG5BcKzITjZyZx0M2d9Mkcj9jzeZNXaiDjM1gc8qNmH0BXa/OnORxs 9cVmDiVH6UiqsXL0ilbVR33zYZPnlCGQLl0+kAd5C37Xcifx6mm9VNM4zL6sHsGzec 70AnBlxUU+xXnjtk67BcvXMEXG3o77a7Rff0OXvz3j8uqm3HDL9FsTHUHV98UOIu+8 z9KQThZG4Jt9Q4yxgFdtU8KVrKS4NkkAcQSBGQ7d6c7zfIBC6gWOwJKOJAG9WWgc5O Nmy+yaygDtj6A== X-ME-Helo: fedora.home X-ME-Auth: YmF1emFjLXN0ZWhseS5mYWJyaWNlQG9yYW5nZS5mcg== X-ME-Date: Sun, 14 May 2023 21:10:56 +0200 X-ME-IP: 109.210.14.182 Received: from noon by fedora.home with local (Exim 4.96) (envelope-from ) id 1pyH7M-0006YZ-1O; Sun, 14 May 2023 21:10:52 +0200 From: Fabrice Bauzac-Stehly To: Thomas Fitzsimmons Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (message from Thomas Fitzsimmons on Wed, 19 Apr 2023 08:48:54 -0400) Date: Sun, 14 May 2023 21:10:52 +0200 Message-ID: <878rdqg24j.fsf@fedora.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, For the time being, on my side, I customize "Eudc Ldap No Wildcard Attributes" by adding to this list the attribute for which I don't want an automatic "*" wildcard appended. As a software engineer, I suspect this issue could be better addressed by the Emacs codebase, because I don't think it is wise for eudc-query-form to arbitrarily add an automatic wildcard to the last field, this does not make sense to me. But I'll let Emacs experts think about it. As far as I'm concerned, I have this workaround that works for me. Thanks! Best regards -- Fabrice Bauzac-Stehly PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6 From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 14:28:49 2023 Received: (at 62721) by debbugs.gnu.org; 15 May 2023 18:28:49 +0000 Received: from localhost ([127.0.0.1]:44380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pycwC-0002DS-Ui for submit@debbugs.gnu.org; Mon, 15 May 2023 14:28:49 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:44752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pycwA-0002DF-UM for 62721@debbugs.gnu.org; Mon, 15 May 2023 14:28:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NYnrTKh1jLg0edn5dN9yoVPiTyxoOPuExRGT9SZQjXc=; b=RyUrQ8svHmUgFRQ8eAPmw8qywz nVsMfcAB0bl+M9m16RfLX3gvLiKNdqfKxQibDD+9W7lh2Coq+LUlLF1/0QPSmhqT/XLHRoR/AMuFF 63wXWFTFEf3An8O3STF6NE2AhbpPc+qHG632dhKculIJK/dcRrLWzpKPFHwoEoKs5NAzhpbCEYl3v +e7aQYn3xx16Kejz9Boe1wt05pCP305W6K4mBzGd6huVvFTasIU6PS2NDmfWW3mbb640JcXd7ttbA 26VsttPWptpnlJKmL6hW5+A71bSxEDi/LY70L9ybxjQvAv8D9V5tzg/nklGAAq4aiJYqPOI7ZehBs d4RcyOig==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pycw4-000DCi-L6; Mon, 15 May 2023 14:28:40 -0400 From: Thomas Fitzsimmons To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: <878rdqg24j.fsf@fedora.home> (Fabrice Bauzac-Stehly's message of "Sun, 14 May 2023 21:10:52 +0200") References: <874jpqalh7.fsf@fedora.home> <878rdqg24j.fsf@fedora.home> Date: Mon, 15 May 2023 14:28:39 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Fabrice, Fabrice Bauzac-Stehly writes: > For the time being, on my side, I customize "Eudc Ldap No Wildcard > Attributes" by adding to this list the attribute for which I don't want > an automatic "*" wildcard appended. Do you mind posting the `eudc-ldap-no-wildcard-attributes' setting you ended up with? The docstring for that variable doesn't mention adjusting this as a preference, only LDAP failure workarounds. I would like to update the docstring with an example, to make your use case more discoverable. > As a software engineer, I suspect this issue could be better addressed > by the Emacs codebase, because I don't think it is wise for > eudc-query-form to arbitrarily add an automatic wildcard to the last > field, this does not make sense to me. But I'll let Emacs experts think > about it. > > As far as I'm concerned, I have this workaround that works for me. OK, thanks for following up. My feeling is that someone using both `eudc-query-form' and `eudc-expand-inline' would want the behaviour of both functions to match with respect to wildcard addition. And `eudc-ldap-no-wildcard-attributes' allows the user to customize the behaviour to their preference/expectation (which you've done), so I think this is fine as-is (except the docstring). Thomas From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 16:15:58 2023 Received: (at 62721) by debbugs.gnu.org; 15 May 2023 20:15:58 +0000 Received: from localhost ([127.0.0.1]:44512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyebt-0005KK-Lu for submit@debbugs.gnu.org; Mon, 15 May 2023 16:15:57 -0400 Received: from smtp-24.smtpout.orange.fr ([80.12.242.24]:50915 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyebq-0005KA-Sl for 62721@debbugs.gnu.org; Mon, 15 May 2023 16:15:56 -0400 Received: from fedora.home ([109.210.14.182]) by smtp.orange.fr with ESMTPA id yebmpgAY5qrnXyebmpctXS; Mon, 15 May 2023 22:15:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1684181753; bh=Nnco65xbyk8dBpRUCJaLktLGrMDPJ0ENSoeWtDwzEwk=; h=From:To:Cc:Subject:In-Reply-To:Date; b=F3VcdHfDbwgR3hmFOxrAoFeh6+gCzjpVc7N83sB1Fgm5/BlHz+j3VzBO6GDE1ntz0 TvcjgRigs00rCXLJmNaxw06GShcr2AJad6pYS16s9gcSio0E1dibk+58BsbZYMjcOh nfWgjg4EU+O1bDv3CAsgUBtzCsGhkmUTm8/f2ih8UT8/+SsO1iy7WN6/IZsVVXhebp E3TpcjMjwp0LQjR3o92bekEq+FSfXmjBOOxayeO9nrrDmZCzsOsRNRZs9yn9H7m42m gaUno/luYpI+QiwziGGOmIn6kU9npsiWGRdUaRF9bJK1Iodn7MalK9gkiLcTAhCrFv vrm2P/qwMb53g== X-ME-Helo: fedora.home X-ME-Auth: YmF1emFjLXN0ZWhseS5mYWJyaWNlQG9yYW5nZS5mcg== X-ME-Date: Mon, 15 May 2023 22:15:53 +0200 X-ME-IP: 109.210.14.182 Received: from noon by fedora.home with local (Exim 4.96) (envelope-from ) id 1pyebl-0002bG-2p; Mon, 15 May 2023 22:15:49 +0200 From: Fabrice Bauzac-Stehly To: Thomas Fitzsimmons Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (message from Thomas Fitzsimmons on Mon, 15 May 2023 14:28:39 -0400) Date: Mon, 15 May 2023 22:15:49 +0200 Message-ID: <871qjhs64q.fsf@fedora.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Thomas, Thomas Fitzsimmons writes: > Do you mind posting the `eudc-ldap-no-wildcard-attributes' setting you > ended up with? The docstring for that variable doesn't mention > adjusting this as a preference, only LDAP failure workarounds. I > would like to update the docstring with an example, to make your use > case more discoverable. Sure. I have kept the two default items of the list, and added 'samaccountname (the attribute for which I don't want any wildcard). As I've used Customize, it appears like this in my ~/.emacs.d/init.el: '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname)) Thanks! -- Fabrice Bauzac-Stehly PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6 From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 16:36:52 2023 Received: (at 62721) by debbugs.gnu.org; 15 May 2023 20:36:52 +0000 Received: from localhost ([127.0.0.1]:44559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyew8-0005qv-D1 for submit@debbugs.gnu.org; Mon, 15 May 2023 16:36:52 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:54036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyew6-0005qi-PG for 62721@debbugs.gnu.org; Mon, 15 May 2023 16:36:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DW7LWzSzhmPNGSmg/XWB8P5jkFyY+3MD1u6ui1NPa/4=; b=JdOTpuSe8ISAirQ3wPoHRqSRcS NRoC1ADZljnSsV0gGW0iLa9ZF8OZ+S/xNLk0ub2vueaTTGiS9gx+aj/kFGSDWBu0IDlmpOPrJChtA HgUAM60biN7ne/plx4BpuBIWfXWPJoMGQ7FHp6Mu5VgW9yU0lh6b5J6JWy2uMB4am25OM1j3FsDDa GwvIvlBOM9JiZL8paH+ewfVCtOSsXN9EDdt3A575f1SmmIpYReoQGosYp9+YGNjYOoGygmGjBTKcy FbfNC/PIyKvZ+LWhwAlyYFSNBstp3mQRc89iMqtkO2nLOqF99n6I7kMJnuPR322FPFgn67K5EYv+K IJzbPy7g==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pyew0-000DGm-BZ; Mon, 15 May 2023 16:36:44 -0400 From: Thomas Fitzsimmons To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: <871qjhs64q.fsf@fedora.home> (Fabrice Bauzac-Stehly's message of "Mon, 15 May 2023 22:15:49 +0200") References: <871qjhs64q.fsf@fedora.home> Date: Mon, 15 May 2023 16:36:43 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fabrice Bauzac-Stehly writes: > Hello Thomas, > > Thomas Fitzsimmons writes: > >> Do you mind posting the `eudc-ldap-no-wildcard-attributes' setting you >> ended up with? The docstring for that variable doesn't mention >> adjusting this as a preference, only LDAP failure workarounds. I >> would like to update the docstring with an example, to make your use >> case more discoverable. > > Sure. I have kept the two default items of the list, and added > 'samaccountname (the attribute for which I don't want any wildcard). As > I've used Customize, it appears like this in my ~/.emacs.d/init.el: > > '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname)) Thanks, and what field of `eudc-query-form' does that affect? "E-Mail"? Thomas From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 16:40:20 2023 Received: (at 62721) by debbugs.gnu.org; 15 May 2023 20:40:20 +0000 Received: from localhost ([127.0.0.1]:44570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyezT-0005wS-Uh for submit@debbugs.gnu.org; Mon, 15 May 2023 16:40:20 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:48570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyezS-0005wF-Dh for 62721@debbugs.gnu.org; Mon, 15 May 2023 16:40:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PStN9MiaC0elWRJRB1XT5YpHgjEakfXPdyi4C0iDcyw=; b=ogsQ4KLR/vHPYiMpp0dcFdZkBR gF/j0Y5EWEskwYgx49aI3XyxKM7qmtLXmESgmjAgq3bcSD304VhvfUKD9pcvisIeTsJ+hBnurGFMt MxfIA+8M3Q0GF3wzL7EACgVKzsrfDatnYLfSd2FP2vJMykj/KVbqgIX3O/qz3vSqCd0FqyPM+7dwF DpptGSSnso7O5B8G1vbjEyQzj38njriyo8xU89MCo6gIX9lRqqJcZHdbOxgIjcSqCs6VA2BjIUecp uI6QDtp0wfSkbdcCAAeZNDC7LtBgYEqNPP2yBFImCu42XyJPNYAl0gLyXeft3MsHOAn5/w8gouoPK BbvloJHA==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pyezN-000DGx-55; Mon, 15 May 2023 16:40:12 -0400 From: Thomas Fitzsimmons To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 15 May 2023 16:36:43 -0400") References: <871qjhs64q.fsf@fedora.home> Date: Mon, 15 May 2023 16:40:12 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > Fabrice Bauzac-Stehly writes: > >> Hello Thomas, >> >> Thomas Fitzsimmons writes: >> >>> Do you mind posting the `eudc-ldap-no-wildcard-attributes' setting you >>> ended up with? The docstring for that variable doesn't mention >>> adjusting this as a preference, only LDAP failure workarounds. I >>> would like to update the docstring with an example, to make your use >>> case more discoverable. >> >> Sure. I have kept the two default items of the list, and added >> 'samaccountname (the attribute for which I don't want any wildcard). As >> I've used Customize, it appears like this in my ~/.emacs.d/init.el: >> >> '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname)) > > Thanks, and what field of `eudc-query-form' does that affect? > "E-Mail"? I'll just share my proposed patch. Does the documentation change capture your use case? Thanks, Thomas EUDC: Document disabling default LDAP wildcard expansion * lisp/net/eudc-vars.el (eudc-ldap-no-wildcard-attributes): Cover `eudc-query-form' and `eudc-expand-inline' behavior in the customization docstring. (Bug#62721) diff --git a/lisp/net/eudc-vars.el b/lisp/net/eudc-vars.el index 12f5347bd35..b3aa23f5827 100644 --- a/lisp/net/eudc-vars.el +++ b/lisp/net/eudc-vars.el @@ -441,7 +441,12 @@ eudc-ldap-no-wildcard-attributes "LDAP attributes which are always searched for without wildcard character. This is the list of special dictionary-valued attributes, where wildcarded search may fail. For example, it fails with -objectclass in Active Directory servers." +objectclass in Active Directory servers. + +You may not want functions like `eudc-query-form' and +`eudc-expand-inline' to do LDAP wildcard expansion by default on +certain fields. If so, add the relevant symbol to this list, for +example `samaccountname' for the \"E-Mail\" field." :type '(repeat (symbol :tag "Directory attribute"))) From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 17:56:35 2023 Received: (at 62721-done) by debbugs.gnu.org; 15 May 2023 21:56:35 +0000 Received: from localhost ([127.0.0.1]:44644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pygBG-0008JR-RA for submit@debbugs.gnu.org; Mon, 15 May 2023 17:56:35 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:35222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pygBD-0008J9-MH for 62721-done@debbugs.gnu.org; Mon, 15 May 2023 17:56:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7k/mtM6E4Kl/xG14grNfwmmTxyYKuhhvhXa62dlPOQY=; b=gHX5AMA6biTqcz6YS55oKaTZKl yokYHXtNsqrhUunMf+lYtkgnyEdcw5P2WhZPy9X/yx2IGi8fel3ERgmC1x0zPXdacOgQ4mG38brs/ 4HyX9w7izpaxePFVBqvAA5wdsj/qthAO0vyk7vCVwwVx4CDyhEwSnPXek3yvetEn4GpjHyGeNuA6m 3NCRpY34+i1hh8/RKyJcpWcjTBy2cUrEImUhynhU1ZM4BAva3Uv46nGXMctwFTbN5yEDD4P2QRLjW PCYJITFMWw/Izo0BLcA7aRfuyu9TQzUzpgl2sIDxQqPtZ3h3Q4HcMBEEtiQUOaukeYrk1jCzx0SPU gphKFesA==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pygB6-000DJ7-H9; Mon, 15 May 2023 17:56:25 -0400 From: Thomas Fitzsimmons To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 15 May 2023 16:40:12 -0400") References: <871qjhs64q.fsf@fedora.home> Date: Mon, 15 May 2023 17:56:23 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721-done Cc: fgunbin@fastmail.fm, 62721-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Fabrice, I pushed the documentation change. Let me know if it doesn't accurately describe your use case, and I'll push a rewording. I'm closing this bug report. Thank you for creating it. Thomas From debbugs-submit-bounces@debbugs.gnu.org Tue May 16 04:14:22 2023 Received: (at 62721) by debbugs.gnu.org; 16 May 2023 08:14:22 +0000 Received: from localhost ([127.0.0.1]:45122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pypp8-00013U-6k for submit@debbugs.gnu.org; Tue, 16 May 2023 04:14:22 -0400 Received: from smtp-23.smtpout.orange.fr ([80.12.242.23]:63747 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pypp4-00013K-Sp for 62721@debbugs.gnu.org; Tue, 16 May 2023 04:14:20 -0400 Received: from fedora.home ([109.210.14.182]) by smtp.orange.fr with ESMTPA id ypp0ps8jpzHjQypp0pqWkv; Tue, 16 May 2023 10:14:17 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1684224857; bh=+yKVCGudCogwXDBg5RGx/VXSLhiWy8F3EKSGT7a8Dn4=; h=From:To:Cc:Subject:In-Reply-To:Date; b=QHdKHVmuw2IV7tFcyCrQ4oKDdUTXEYNGW8zCRu1PItT+scZdzgXHXN+vHXBnMYkZg MwO5LmMzF6Sh+gILnqJh78Vb0b7ZVV1AKkoC8NTDkBNYYxzSKkbYTGGvgJYxeAMNpd Z7o8Gf3dF0d/X/n9XHpr/+8uDbyTpNiPQhdOIJGXbL9rcK89sdgnuhoS1fJH362Tzc obD2eCcaGQLRasdcfAm+INQ7MNhLI0X8gbSj0T/reybR0vYFYDKUB4v/f3h2vaC0sB MnLZa3lnDlibUqbLTwZChvp8pEHqlXnpY0YU2d760o5D+FOcu2K0isiuFBFYUCclgt 8SvWwWcWXuDHA== X-ME-Helo: fedora.home X-ME-Auth: YmF1emFjLXN0ZWhseS5mYWJyaWNlQG9yYW5nZS5mcg== X-ME-Date: Tue, 16 May 2023 10:14:17 +0200 X-ME-IP: 109.210.14.182 Received: from noon by fedora.home with local (Exim 4.96) (envelope-from ) id 1pypp0-0001QD-1x; Tue, 16 May 2023 10:14:14 +0200 From: Fabrice Bauzac-Stehly To: Thomas Fitzsimmons Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (message from Thomas Fitzsimmons on Mon, 15 May 2023 16:36:43 -0400) Date: Tue, 16 May 2023 10:14:14 +0200 Message-ID: <87ttwchew9.fsf@fedora.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > Fabrice Bauzac-Stehly writes: > >> Sure. I have kept the two default items of the list, and added >> 'samaccountname (the attribute for which I don't want any wildcard). As >> I've used Customize, it appears like this in my ~/.emacs.d/init.el: >> >> '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname)) > > Thanks, and what field of `eudc-query-form' does that affect? "E-Mail"? It affects samaccountname. Indeed, I forgot to indicate that I have also customized eudc-query-form-attributes: '(eudc-default-return-attributes '(displayname firstname name thumbnailphoto mail samaccountname ...)) '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname)) '(eudc-query-form-attributes '(name firstname email samaccountname)) Thanks! -- Fabrice Bauzac-Stehly PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6 From debbugs-submit-bounces@debbugs.gnu.org Tue May 16 04:24:38 2023 Received: (at 62721) by debbugs.gnu.org; 16 May 2023 08:24:38 +0000 Received: from localhost ([127.0.0.1]:45132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pypz4-0003m4-6w for submit@debbugs.gnu.org; Tue, 16 May 2023 04:24:38 -0400 Received: from smtp-30.smtpout.orange.fr ([80.12.242.30]:56086 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pypyz-0003lt-53 for 62721@debbugs.gnu.org; Tue, 16 May 2023 04:24:36 -0400 Received: from fedora.home ([109.210.14.182]) by smtp.orange.fr with ESMTPA id ypyvpGL5s8Gm8ypyvpYkLt; Tue, 16 May 2023 10:24:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1684225472; bh=YXa+vF97qFXNLolx0mRSxIb2p1CKwcx0N+U2xVYfk6g=; h=From:To:Cc:Subject:In-Reply-To:Date; b=IxSd3vwBEBDNgAaNTIsX7zEo0X4f/FnLN4QZYuJNdkK/fW+vGt0Llh5zJGxtY4Ih6 DztJElnTro9EwkD0mYFWb48viMI5AszLhCbQqtzKw0aN+OruJX3Iyf4R3UB1qWcGfq ZBQBDi1qNuKtW/HGlCxih5B8PHWPR07uf3zl2qftd203HAVvV9y0neGOJS89N8C1wZ fExM3n7CCWmOJJ6+mYPMthGIgn72sOztI7tsCNhAE1TDpY7Qx2Ej0ze7qb3B0l73u4 9i+m8IaZv2KkyM6p6hagkjODa40PJKO8Il01RMA7NtzW72FoXzwBbxE4TcFXoz/Rnt WW7n2NoZDLrXw== X-ME-Helo: fedora.home X-ME-Auth: YmF1emFjLXN0ZWhseS5mYWJyaWNlQG9yYW5nZS5mcg== X-ME-Date: Tue, 16 May 2023 10:24:32 +0200 X-ME-IP: 109.210.14.182 Received: from noon by fedora.home with local (Exim 4.96) (envelope-from ) id 1pypyu-0001WK-2w; Tue, 16 May 2023 10:24:28 +0200 From: Fabrice Bauzac-Stehly To: Thomas Fitzsimmons Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (message from Thomas Fitzsimmons on Mon, 15 May 2023 16:40:12 -0400) Date: Tue, 16 May 2023 10:24:28 +0200 Message-ID: <87r0rghef7.fsf@fedora.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > I'll just share my proposed patch. Does the documentation change > capture your use case? Apart from the fact that the symbol "samaccountname" corresponds to the field of the same name, this looks good to me! Thanks! -- Fabrice Bauzac-Stehly PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6 From debbugs-submit-bounces@debbugs.gnu.org Tue May 16 06:58:09 2023 Received: (at 62721) by debbugs.gnu.org; 16 May 2023 10:58:09 +0000 Received: from localhost ([127.0.0.1]:45332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pysNd-0000PW-6M for submit@debbugs.gnu.org; Tue, 16 May 2023 06:58:09 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:55864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pysNa-0000Ob-RC for 62721@debbugs.gnu.org; Tue, 16 May 2023 06:58:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J9wudeAeUb6/Mnw35gUvKprN210XhmZdeq6InX/68Lo=; b=eP8n51/1siHocyiF5rfJ7yGbqd 0xXmZvKOAVN8D1WU55WoBsExn+zRA6CZdRDQVlyglcBtr5kpLd6rTHhLSV9CGdbH3ttwy0ho4CT3H coNx8oiqvIrlU2bhOzf2GiLOYY9HwW28t+N/i6prx129VO149gkvji27eALU4G3N9U8Il1BSlPhWE x2QqS5tcoEmDWe8Iu0QjMKRhjhWiIn/Ce/ygzLtnSMgU9oXp+Sp5BNI9x3raTOdJToYff/q8xIDN7 ZRFMcpvaL6GK/WLe/5HHO+l58vnUevAQGuR5/3/VhgS5OBlFNPSQk53BMugLRG+7Al0I35jQhx6An S7IxZzfQ==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pysNU-000DdS-7h; Tue, 16 May 2023 06:58:00 -0400 From: Thomas Fitzsimmons To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: <87ttwchew9.fsf@fedora.home> (Fabrice Bauzac-Stehly's message of "Tue, 16 May 2023 10:14:14 +0200") References: <87ttwchew9.fsf@fedora.home> Date: Tue, 16 May 2023 06:57:59 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fabrice Bauzac-Stehly writes: > Thomas Fitzsimmons writes: > >> Fabrice Bauzac-Stehly writes: >> >>> Sure. I have kept the two default items of the list, and added >>> 'samaccountname (the attribute for which I don't want any wildcard). As >>> I've used Customize, it appears like this in my ~/.emacs.d/init.el: >>> >>> '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname)) >> >> Thanks, and what field of `eudc-query-form' does that affect? "E-Mail"? > > It affects samaccountname. Indeed, I forgot to indicate that I have > also customized eudc-query-form-attributes: > > '(eudc-default-return-attributes > '(displayname firstname name thumbnailphoto mail samaccountname ...)) > '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname)) > '(eudc-query-form-attributes '(name firstname email samaccountname)) Oh, OK. Can you test how to apply this to the standard "E-Mail" attribute in `eudc-query-form'? I forget if I want "mail" or "email" for SYMBOL here: You may not want functions like `eudc-query-form' and `eudc-expand-inline' to do LDAP wildcard expansion by default on certain fields. If so, add the relevant symbol to this list, for example `SYMBOL' for the \"E-Mail\" field. Then I'll push the updated patch. Thanks, Thomas From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 02:12:29 2023 Received: (at 62721) by debbugs.gnu.org; 17 May 2023 06:12:29 +0000 Received: from localhost ([127.0.0.1]:48613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzAOj-0007ty-HK for submit@debbugs.gnu.org; Wed, 17 May 2023 02:12:29 -0400 Received: from smtp-22.smtpout.orange.fr ([80.12.242.22]:49278 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzAOg-0007tn-ES for 62721@debbugs.gnu.org; Wed, 17 May 2023 02:12:28 -0400 Received: from fedora.home ([109.210.14.182]) by smtp.orange.fr with ESMTPA id zAObpeW6ReE2SzAOcpxWwi; Wed, 17 May 2023 08:12:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1684303945; bh=XxyLtUz+CDFDD+tBJyZCN0+sRNuJEsPAY5XDkBbc1Zc=; h=From:To:Cc:Subject:In-Reply-To:Date; b=dfwEeiMCc4w3wYbFS40ozYnyU2q/G+tMkaPr8EoAxRei7detWryqFNZUsT5Q6wVU9 ipCqEPiaFztuM58FQKb7Lsx5Dcla00t0bW33bp49JuD76u5lT9bpI2vrGVqG7itWYk 11vCJp4pss9M5hlGZoXQpGhYSxzplXngQizlYU2aMSlTEA7MBHlp5YllTJ75AWE7EN R9CztNjrfijfedB1Grmu6fBeaYmERL9ZpWudgjyI7hJLgBYlckk1qwy8xSRbN7uKrm m+6KbiERbtq8Yd7CoDKsAxK9p6hg1ffgsfuIOpblgFudyhH5OOVXINkC+/6olhe+2k Rfmvsdl7NjDog== X-ME-Helo: fedora.home X-ME-Auth: YmF1emFjLXN0ZWhseS5mYWJyaWNlQG9yYW5nZS5mcg== X-ME-Date: Wed, 17 May 2023 08:12:25 +0200 X-ME-IP: 109.210.14.182 Received: from noon by fedora.home with local (Exim 4.96) (envelope-from ) id 1pzAOb-0007U5-2Y; Wed, 17 May 2023 08:12:21 +0200 From: Fabrice Bauzac-Stehly To: Thomas Fitzsimmons Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: (message from Thomas Fitzsimmons on Tue, 16 May 2023 06:57:59 -0400) Date: Wed, 17 May 2023 08:12:21 +0200 Message-ID: <87o7mjh4fu.fsf@fedora.home> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > Can you test how to apply this to the standard "E-Mail" > attribute in `eudc-query-form'? I forget if I want "mail" or "email" > for SYMBOL here: I have just tested: to disable wildcards for E-Mail, the symbol to put into eudc-ldap-no-wildcard-attributes is 'mail. > Then I'll push the updated patch. Thanks a lot! -- Fabrice Bauzac-Stehly PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6 From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 07:01:30 2023 Received: (at 62721) by debbugs.gnu.org; 17 May 2023 11:01:30 +0000 Received: from localhost ([127.0.0.1]:49088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzEuP-0008Ex-NP for submit@debbugs.gnu.org; Wed, 17 May 2023 07:01:29 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:54310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzEuN-0008Ek-ME for 62721@debbugs.gnu.org; Wed, 17 May 2023 07:01:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0IwM2tUIl30IfZjN3DXZU9jPXho0NJC/tWlbvrBfZW8=; b=bKNfxe1tag7FctFtACNhMQOk1I vd6YFqknLsv3o3Tx9qPVilyO6lN4kIlOW1piwY3SE/RpU0cjLorXiuSy93EKUr56hrcZ2EZ/ERpz6 1R5NDIZPJoL8eeVBdGYvZFppS9q6iRz3rqhszLiTX9bw+skFQ3GRsJNTFLRJMaoFIo0kgozk7UaV6 vs7JR5pUPir32F4M61ji3NzGkHDDnwM9vv54oUgHaZwAcGi7M6U4XupJevX6yXDqSqiMyh2VL55G/ YHMxCYgsPsNELaRvTAX8mdMl6QAv2rJMQ7P07iKGcxGlPruczrBYUKED/q3u6J+CIqqgTRdEuScBZ DVJK64QA==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pzEuH-000EIs-Ni; Wed, 17 May 2023 07:01:21 -0400 From: Thomas Fitzsimmons To: Fabrice Bauzac-Stehly Subject: Re: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches In-Reply-To: <87o7mjh4fu.fsf@fedora.home> (Fabrice Bauzac-Stehly's message of "Wed, 17 May 2023 08:12:21 +0200") References: <87o7mjh4fu.fsf@fedora.home> Date: Wed, 17 May 2023 07:01:21 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62721 Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fabrice Bauzac-Stehly writes: > Thomas Fitzsimmons writes: > >> Can you test how to apply this to the standard "E-Mail" >> attribute in `eudc-query-form'? I forget if I want "mail" or "email" >> for SYMBOL here: > > I have just tested: to disable wildcards for E-Mail, the symbol to put > into eudc-ldap-no-wildcard-attributes is 'mail. > >> Then I'll push the updated patch. Pushed, thanks. Thomas From unknown Sun Jun 22 08:08:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 14 Jun 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator