GNU bug report logs - #62713
29.0.60; DocView shows wrong conversion indicator when configured to use svg images

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62713: closed (29.0.60; DocView shows wrong conversion
 indicator when configured to use svg images)
Date: Sun, 01 Oct 2023 13:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 1 Oct 2023 06:00:43 -0700
with message-id <CADwFkm=Ds7SBjVRCXUyQjTrbep3F7iGoy9N_Hx_G3StZONvHZg <at> mail.gmail.com>
and subject line Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images
has caused the debbugs.gnu.org bug report #62713,
regarding 29.0.60; DocView shows wrong conversion indicator when configured to use svg images
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62713: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62713
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gregor Zattler <grfz <at> gmx.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; DocView shows wrong conversion indicator when configured
 to use svg images
Date: Fri, 07 Apr 2023 18:02:02 +0200

Package: emacs
Version: 29.0.60
Severity: minor

Dear Emacs developers,

1. start emacs -Q,
2. evaluate `(setq doc-view-mupdf-use-svg t)' in *scratch* buffer, then
3. open a (preferably large) pdf file:

While the pdf file is converted to images in the
background, a modeline indicator is shown:

DocView:pdf->png

which is wrong in this case since the conversion is
configured to produce svg images.

The indicator should look like

DocView: pdf->svg

or

DocView:pdf->img

or

DocView:pdf conversion

or something like that.

Admittedly a very minor issue.
Thanks, Gregor



In GNU Emacs 29.0.60 (build 9, x86_64-pc-linux-gnu,
 cairo version 1.16.0) of 2023-03-18 built on no
Repository revision: 11592bcfda6cf85d797d333072453c98994790e1
Repository branch: HEAD
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-sound=yes --without-gconf
 --with-mailutils --build x86_64-linux-gnu
 --infodir=/usr/share/info --with-json
 --with-file-notification=yes --with-cairo --with-x=yes
 --with-x-toolkit=no --without-toolkit-scroll-bars
 --enable-checking=yes,glyphs
 --enable-check-lisp-object-type
 --with-native-compilation 'CFLAGS=-g3 -Os
 -ffile-prefix-map=/home/grfz/src/emacs-emacs-29--11592bcfda6cf85d797d333072453c98994790e1--2023-03-18T17-21+01-00=. -fstack-protector-strong
 -Wformat -Werror=format-security ''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM
GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX
LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY
INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF X11 XDBE XIM XINPUT2 XPM ZLIB

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 62713-done <at> debbugs.gnu.org, Gregor Zattler <grfz <at> gmx.de>,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when
 configured to use svg images
Date: Sun, 1 Oct 2023 06:00:43 -0700

Version: 30.1

Visuwesh <visuweshm <at> gmail.com> writes:

> [வெள்ளி செப்டம்பர் 29, 2023] Stefan Kangas wrote:
>
>> Tassilo Horn <tsdh <at> gnu.org> writes:
>>
>>> Stefan Kangas <stefankangas <at> gmail.com> writes:
>>>
>>>>> This particular problem can be easily solved by the following simple
>>>>> patch instead:
>>>>
>>>> Tassilo, could you perhaps take a look at this patch?
>>>
>>> Yes, the simple patch looks good and fixes the bug.  Feel free to commit
>>> it.
>>
>> Great, thanks.
>>
>> Visuwesh, could you please send the patch as an attachment instead?  We
>> prefer that patches are created with a command like `git format-patch
>> -1'.
>
> Please find attached patch.

Thanks, installed on master [1: f0abc9bc0d5], and I'm consequently
closing this bug report.

[1: f0abc9bc0d5]: 2023-10-01 14:58:48 +0200
  Fix doc-view conversion indicator for svg images
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f0abc9bc0d536e5b2834c04714d75d18fde431c3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.