From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 07 12:02:50 2023 Received: (at submit) by debbugs.gnu.org; 7 Apr 2023 16:02:50 +0000 Received: from localhost ([127.0.0.1]:57118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkoY5-000817-Kc for submit@debbugs.gnu.org; Fri, 07 Apr 2023 12:02:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:60884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkoY3-00080z-1q for submit@debbugs.gnu.org; Fri, 07 Apr 2023 12:02:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkoY1-0004JO-KQ for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 12:02:45 -0400 Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkoXy-0005t0-IH for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 12:02:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680883357; i=grfz@gmx.de; bh=qiK+oAoI/+UKR5xA6Mf1/QQcJewJ2+p5tCVK57t+nrQ=; h=X-UI-Sender-Class:From:To:Subject:Date; b=YSEelhZGsLxCDZO8DjdNpXECnRnaQSEaEZbzCOx1aT1cxwSWPU9avjTVb2xUZkrEj QzgoJKtmTNmKNf28aClSInTxzL+TQN+56kRJOdZ3Az8JNK7rUhP6qjNgmhRMC0pc6w dI+6t4v/lcecjGSz45qOSOVkO9U4Ga2HgYT5T2S1/WSGE+3+RVT18bq204gODxe6w1 2RaxZwWOcIZYMIyG14k4bqideFfO/xbGhuPaElU4UAEBh/5/9qcdTgoBPFM05m7YHo TvNmxjw1Ngp5aszxXwuF3YpULXBxtGgN4oLWRSQWs5x8PzQwh4Uj9rmWPDIa34tSXG xh/j5wPeNqgyg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost ([95.90.234.37]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M6UZl-1pirfJ3UiH-006tIj; Fri, 07 Apr 2023 18:02:36 +0200 From: Gregor Zattler To: bug-gnu-emacs@gnu.org Subject: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images Date: Fri, 07 Apr 2023 18:02:02 +0200 Message-ID: <87v8i7llz9.fsf@no.lan> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:8qYCoO86JAlMR90miXqtbxWehxl9+BztEkB5a4qlmqexOobieyl KloT7IeAogwyZxWuImQMxNLhO1iUZZtdWQVzfrfnFjlzOHfuc+6HBpVlKQkDKmToWUbR/ZO DntumqaNKAwSHZJB9pCsuE12uSZrXaTSpROrb4GrDg8OoAwnk9HU8YXdLbozrLEC5zED7IV 3kBmstT+WtEYdA8MA3zVg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:C9JS4ust5Jk=;orARLTW42MDx6IzHveA/jYFwWjt TVAX2dz2zHOilIYv5WyMnJi/kgOIvHrs4r/1UKiXGrFod1F/iygtYgZesRagKrP12VynB3jOp UvSQBDE0UxZVn/kqF0qimti3fsrZF1CSPqU7zmoyaOf2XonerAkWJ1Yki0owsLoAaPeb6y+21 ZJhSBDOIw7R/Y07s+s6oxbXUVgr/hy0GLOHSFB6Y9qoqwp6hyLG9SYeuAprci2tDL4hNTYpCn dNe20dJyZS5yNELQ9CjyWlGfWnWZY5SDxCudGtn2RrwMnSK0EdFvUKaXVFUHIi6N9AC1cN1wn jlUVFZ9Bss5fqw4tEoKTpuDdqwBqj9tNU1xjSCC3ID6qTpW9wtQfh7vnO45E/8cI7CPe4pSlM 5p0tBuv5uZvIPm1akcjWRtl2CionWHBlrcDP9bmTtelG4G373/Md/SxwnBLCrUaLTvT/LGW03 fJ/1Ios37A/VTiW3RU9BLERHsrlYqF+pbWLfcpzEwC6l2KDVn7nJyB6xdMxoTzg7AptAHj7Nj 4BoF98lmxGiz4eyHNhlu4Jx+IvFcBdIGIMQ2XjKW4AianvEoVvp0qkckaHfiNlTpMknbx8ZI0 P9shsK761OlrU+xb3p8j0eqUOrWZNb24G/ZUqcG05iEHh9v5oCNvFhCOr18YiymwUATA1oRJI ZT1q+v6bn4YDYI2enNnOiQS2JiXhYoWIaCt0ZTd2pcxAfDyjW48eoPlWaIbpjRkXoRovF4Bzc up8lhMGb/QX0Wwrmoe7kEeVYWLRRlSU9IIX+U/Ru+5gFFHhmwNBfpjCBW4rKqZQmauDxCN2ss Bua8kUqOcLa7NqoVUpgOox5Pm0peydOfj7R0pkVBg/js/PwcwHToOvdHdOMTD5oFpmKf5/2ap yuOJYyCPFzFUf1wvuVGtNtebrJlHO0hOWeOytlN7K9KuzKqKQ7JT92leyYlgC683xic3kw2Ja nxCfIJGjCEwqOJ6tj0XSv7yiB6Q= Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.227.17.20; envelope-from=grfz@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Package: emacs Version: 29.0.60 Severity: minor Dear Emacs developers, 1. start emacs -Q, 2. evaluate `(setq doc-view-mupdf-use-svg t)' in *scratch* buffer, then 3. open a (preferably large) pdf file: While the pdf file is converted to images in the background, a modeline indicator is shown: DocView:pdf->png which is wrong in this case since the conversion is configured to produce svg images. The indicator should look like DocView: pdf->svg or DocView:pdf->img or DocView:pdf conversion or something like that. Admittedly a very minor issue. Thanks, Gregor In GNU Emacs 29.0.60 (build 9, x86_64-pc-linux-gnu, cairo version 1.16.0) of 2023-03-18 built on no Repository revision: 11592bcfda6cf85d797d333072453c98994790e1 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --with-sound=3Dyes --without-gconf --with-mailutils --build x86_64-linux-gnu --infodir=3D/usr/share/info --with-json --with-file-notification=3Dyes --with-cairo --with-x=3Dyes --with-x-toolkit=3Dno --without-toolkit-scroll-bars --enable-checking=3Dyes,glyphs --enable-check-lisp-object-type --with-native-compilation 'CFLAGS=3D-g3 -Os -ffile-prefix-map=3D/home/grfz/src/emacs-emacs-29--11592bcfda6cf85d797d33= 3072453c98994790e1--2023-03-18T17-21+01-00=3D. -fstack-protector-strong -Wformat -Werror=3Dformat-security '' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF X11 XDBE XIM XINPUT2 XPM ZLIB From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 24 19:32:03 2023 Received: (at 62713) by debbugs.gnu.org; 24 Sep 2023 23:32:03 +0000 Received: from localhost ([127.0.0.1]:43758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkYa2-0000d4-QJ for submit@debbugs.gnu.org; Sun, 24 Sep 2023 19:32:03 -0400 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:44506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkYZx-0000cS-W2 for 62713@debbugs.gnu.org; Sun, 24 Sep 2023 19:32:00 -0400 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-502a4f33440so8772293e87.1 for <62713@debbugs.gnu.org>; Sun, 24 Sep 2023 16:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695598299; x=1696203099; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=A65tgtN0FhSui7C61c8SPgSpy8xJpMyQgtHC4T9AXXg=; b=DvI1iMXsGZ8YW7Xz8FExq50Rqu/Rf46xQRrIaeZ10wPx8pHMDEVYCC4ffsf+SpudAG HeJNJBTc7WY1VNtp3ifOMy0Bjd1+K76f2O/hNAhYBtP7J0Isq5mmVbJZw6rfFr7YdEiK LxA6fvoyB389LlLRlA9KDsXKJRnhyfRXlgj4cjCk6hd3DrW7F+QILVmJOJ53Oeq7UZvj /12ESlEIWtUwckz9+p7pn+eXLC7jmheMMcaiH3GQ+Xm/XXQ9/vRgFDhM9m7pmkNuUuRC n1qBAMYiWpW1n7sIuZSeYb/WH81sYZdaNApO3mMOh5oZbl17+UQCAxHXoiKfqQnBcCFM 3bag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695598299; x=1696203099; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A65tgtN0FhSui7C61c8SPgSpy8xJpMyQgtHC4T9AXXg=; b=g9MANzI6naNTchI6yD0epxQOhMVwQI+3WY0iSRLqylpvIe3Q/s5tfcfByCqedjOnhH WO1vjyA0TEDWfgZLHWsV3aQVFjnUQpkEUt+IOMVwENiOujUWXqoIdQL71K5g2jdr2oge CZ6mE18QAGZlrBJzPi1CPGFuZSpJIERMgZyvDHcyiNmPa5XA7wPgCH7BJfAeES8j6CuI ckTehFAiGns7n7bZTHgRgX1LiKkrh8xH7rP/WmEcXV3IXXz4QF2V03zadxvch9kEK5p3 os3BTqHAoLa7sAlnyHmI236+cq5Ea3uKjAme7MKKMzxkD0GT+5h1n+Vp5vR0y5dA9DZk GAqA== X-Gm-Message-State: AOJu0YxA0Ku8+CbZSGgx6rNI6mq3iuv5/oR7c3H6TNKfiFyIpBS5GkGD G699dJhrv9JwczhHGA4Nd1GT4g39qIwE/dz64WE= X-Google-Smtp-Source: AGHT+IGcz2LI1D4Qd3dbTZGNUQ3+iIhOyYGL73VLARyFHcOpa4UL8FG1E8OO50gvwEfVlyscxj6Tozkxh4+bPx5ZF4U= X-Received: by 2002:a05:6512:158f:b0:503:2924:f8dd with SMTP id bp15-20020a056512158f00b005032924f8ddmr4537496lfb.47.1695598298583; Sun, 24 Sep 2023 16:31:38 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Sep 2023 16:31:38 -0700 From: Stefan Kangas In-Reply-To: <87v8i7llz9.fsf@no.lan> References: <87v8i7llz9.fsf@no.lan> MIME-Version: 1.0 Date: Sun, 24 Sep 2023 16:31:38 -0700 Message-ID: Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images To: Gregor Zattler , 62713@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62713 Cc: Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gregor Zattler writes: > Package: emacs > Version: 29.0.60 > Severity: minor > > Dear Emacs developers, > > 1. start emacs -Q, > 2. evaluate `(setq doc-view-mupdf-use-svg t)' in *scratch* buffer, then > 3. open a (preferably large) pdf file: > > While the pdf file is converted to images in the > background, a modeline indicator is shown: > > DocView:pdf->png > > which is wrong in this case since the conversion is > configured to produce svg images. > > The indicator should look like > > DocView: pdf->svg > > or > > DocView:pdf->img > > or > > DocView:pdf conversion > > or something like that. > > Admittedly a very minor issue. > Thanks, Gregor Visuwesh, what do you think? > In GNU Emacs 29.0.60 (build 9, x86_64-pc-linux-gnu, > cairo version 1.16.0) of 2023-03-18 built on no > Repository revision: 11592bcfda6cf85d797d333072453c98994790e1 > Repository branch: HEAD > Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 > System Description: Debian GNU/Linux 11 (bullseye) > > Configured using: > 'configure --with-sound=yes --without-gconf > --with-mailutils --build x86_64-linux-gnu > --infodir=/usr/share/info --with-json > --with-file-notification=yes --with-cairo --with-x=yes > --with-x-toolkit=no --without-toolkit-scroll-bars > --enable-checking=yes,glyphs > --enable-check-lisp-object-type > --with-native-compilation 'CFLAGS=-g3 -Os > -ffile-prefix-map=/home/grfz/src/emacs-emacs-29--11592bcfda6cf85d797d333072453c98994790e1--2023-03-18T17-21+01-00=. -fstack-protector-strong > -Wformat -Werror=format-security '' > > Configured features: > ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM > GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX > LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY > INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 > THREADS TIFF X11 XDBE XIM XINPUT2 XPM ZLIB From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 00:31:10 2023 Received: (at 62713) by debbugs.gnu.org; 25 Sep 2023 04:31:10 +0000 Received: from localhost ([127.0.0.1]:43872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkdFV-0000Hi-LU for submit@debbugs.gnu.org; Mon, 25 Sep 2023 00:31:10 -0400 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:55802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkdFS-0000HB-4J for 62713@debbugs.gnu.org; Mon, 25 Sep 2023 00:31:08 -0400 Received: by mail-pj1-x1044.google.com with SMTP id 98e67ed59e1d1-27736c2a731so1651882a91.3 for <62713@debbugs.gnu.org>; Sun, 24 Sep 2023 21:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695616248; x=1696221048; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:references :message-id:date:in-reply-to:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qQTymTWDF3nC5WWhDhdrt26I031ytZyB3tGDp48HOcY=; b=IsGvLI53TBdQSj1otFJLnwMDPpc44YFZ8nCmmlW3J1jQQtlw3nW8u84AK06iFvKocr w4im9Qfbz7rZ7jHfjdl47EEDcmmPThobzhMsd5hMDlj1uLgOOjqW+Xyg4MaMktQsQKmh dkjGFVkoKL8sE45xB2JhclPrVqba0vIZTDYqTkP5ixhHHSK8YgUTaAMs1vVs1X0RRVoE irrNZzu3Kd+OY1vlapZ3zdEVF9/qsQPkFmkDR/Sgwtc2scKt0qVhZFxXW6Sc0i6ywHeY oh9rG5KLNqyYCYiFJbUdCIlnumqvAnZCcOkqJ4uacqj5beDCjZRQmPY4ld8hQNi1XGdd e2XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695616248; x=1696221048; h=content-transfer-encoding:mime-version:user-agent:references :message-id:date:in-reply-to:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qQTymTWDF3nC5WWhDhdrt26I031ytZyB3tGDp48HOcY=; b=tt1ymifrYLpMgOkRZrKJ2g3qUUdFtjKU2cK71ttlDhNd6CRrT4lI47uYWzkf6ShU50 WqWdOelL3EYfU8vKTxd8FpOOfxSv9JxMzX1piyQoQWpOyO17JkRQEbZw7xRXNVv3bN+R 4C2kk6xCZFVTR9g53pyqTdEb6kpxOhtl4r9tGMiwDcih7DXvwgBwk8rv5CDbcMRZq1Cr og5nbbTtd81P8LcePsTY/NZdVdxN9Y2iAfmpLt+ymA+TV/jcpNkGk96szwcXX+TxFaIu nmVoCiV1QtExk3o1mHD1SsA3uhxdBnzPmgz30kW3vRzxYI/H8esxJquzk0NT5E+ngOP1 6aDA== X-Gm-Message-State: AOJu0YyfZ+2bNqNb+00AZw/NlH+PiVbkHxCG2KLpYdpT5AHMFdqwrof1 NAe6C9yNIXUdTZQdvV+6uWI= X-Google-Smtp-Source: AGHT+IE0JUIovsd2H6FIry76VNAii2MMSs0oSc9sPsoTXjgKAtqg8gDSBUrkVX0/n1aETKBqDKShTQ== X-Received: by 2002:a17:90a:34c3:b0:277:4057:b752 with SMTP id m3-20020a17090a34c300b002774057b752mr2842127pjf.46.1695616248039; Sun, 24 Sep 2023 21:30:48 -0700 (PDT) Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id 20-20020a17090a019400b002775f7dbd7esm735857pjc.49.2023.09.24.21.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 21:30:47 -0700 (PDT) From: Visuwesh To: Stefan Kangas Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images In-Reply-To: (Stefan Kangas's message of "Sun, 24 Sep 2023 16:31:38 -0700") Date: Mon, 25 Sep 2023 10:00:40 +0530 Message-ID: <87ttriri1b.fsf@gmail.com> References: <87v8i7llz9.fsf@no.lan> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62713 Cc: 62713@debbugs.gnu.org, Gregor Zattler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Good day, Stefan! [=E0=AE=9E=E0=AE=BE=E0=AE=AF=E0=AE=BF=E0=AE=B1=E0=AF=81 =E0=AE=9A=E0=AF=86= =E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 24= , 2023] Stefan Kangas wrote: >> The indicator should look like >> >> DocView: pdf->svg >> >> or >> >> DocView:pdf->img >> >> or >> >> DocView:pdf conversion >> >> or something like that. >> >> Admittedly a very minor issue. >> Thanks, Gregor > > Visuwesh, what do you think? It is better solved by writing a separate pdf->svg converter function. Right now, the svg conversion is tacked on top of pdf->png converter function used for MuPDF. This was done because I thought only MuPDF supported pdf->svg conversion but later I was informed that poppler has utilities to do too. Such a generic approach was discussed in [1] with the other Stefan but it fell off my radar since I rarely use docview and hence lost my motivation. I will try to whip something up in the coming week. 1. https://yhetil.org/emacs-bugs/87zganwvgp.fsf@gmail.com/ From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 04:20:59 2023 Received: (at 62713) by debbugs.gnu.org; 25 Sep 2023 08:20:59 +0000 Received: from localhost ([127.0.0.1]:44079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkgpv-0006f8-5l for submit@debbugs.gnu.org; Mon, 25 Sep 2023 04:20:59 -0400 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:58847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkgpq-0006er-VU for 62713@debbugs.gnu.org; Mon, 25 Sep 2023 04:20:58 -0400 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c022ce8114so92981441fa.1 for <62713@debbugs.gnu.org>; Mon, 25 Sep 2023 01:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695630036; x=1696234836; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=HbBBEdPb2olelDQSdPYYkTLEhvRMxhlXLfUio0Gf6hM=; b=RE51INEWzJSGQp52Bt+NAbMXUdAa8qEvhI3R7ZG+c7ZN67OfNtdOPwmBBW2JiKZmMG qfYYqRVkKxYkfFvo4t0JsI3G4MjbbMFhQtJSQdYTq01gmUjrIsNNpJvqkIkP6PXoKdhg JvzQ+be3SLeT6tIaM/qFiReYaN9kdoU55xo33xr8ZBk0JkB9I8m3ObDWFBVLcCQcvgvc h8oC338BsfbY5CLwRXAwCyIH+GquTZlyjjnXocBAv3XSm+4muZucpjAcYQHkPhrE12Ll NCjpT/YsdHsB8FiMVaCnqNPVtbcnSB9/GQt0bc/R0ZY1mfGqVLMAyMC7JHQHF9XxFOwk VBLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695630036; x=1696234836; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HbBBEdPb2olelDQSdPYYkTLEhvRMxhlXLfUio0Gf6hM=; b=IaC+X2BEhjdDozMcg6YqskS5q3rfB0g+k0wnIthjo59OvHh5cFkNgci95FXHRR6F20 Ais+Ej/+akY8b1Xf3lGAcBaFJeHpmoJkwAzTEGUlYrOTLj0YlM1KqIrPiqIp/afvTIkt l1G1W8lFi9my7Z1BLEatnLX1DyNFLHcYDAsZXQ5Uxqe21mE1OstrCZeVSyF07aZtjrNl Xl7kAmWPSQoMpK8bbDkAhPs4T/9Iw5mI5P3vNRgqIxtw4BPxRlKfwEqRPbwg4BzBfTm0 j1R+zR13FNwEhNHfHJmaDkJ7ILgkWkcqePxhkZyJqMMJD6cinuQn2fQ8jeX4D12srlrK YOpQ== X-Gm-Message-State: AOJu0YzJy6hLNXIHqYIW/FXiC+1l5oPfAvo+w5NePRbrpJC4wcl9jjRB Q4AajM03LRI/RLgJiwGNypjL21v6X/D4hsuGxso= X-Google-Smtp-Source: AGHT+IFkuZXNcfSWSlN760FZTVE8N/Bcol4qVMUoaL+OG14gXhmATE+1Si/vPOxDVp95Jr+eLAMKOq/+4rqFp8iRD4Y= X-Received: by 2002:a2e:8718:0:b0:2bf:9664:b761 with SMTP id m24-20020a2e8718000000b002bf9664b761mr5094142lji.53.1695630036207; Mon, 25 Sep 2023 01:20:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 25 Sep 2023 01:20:35 -0700 From: Stefan Kangas In-Reply-To: <87ttriri1b.fsf@gmail.com> References: <87v8i7llz9.fsf@no.lan> <87ttriri1b.fsf@gmail.com> MIME-Version: 1.0 Date: Mon, 25 Sep 2023 01:20:35 -0700 Message-ID: Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images To: Visuwesh Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62713 Cc: 62713@debbugs.gnu.org, Gregor Zattler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Visuwesh writes: > It is better solved by writing a separate pdf->svg converter function. > Right now, the svg conversion is tacked on top of pdf->png converter > function used for MuPDF. This was done because I thought only MuPDF > supported pdf->svg conversion but later I was informed that poppler has > utilities to do too. > > Such a generic approach was discussed in [1] with the other Stefan but > it fell off my radar since I rarely use docview and hence lost my > motivation. I will try to whip something up in the coming week. Sounds good! Thanks for working on this. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 08:47:30 2023 Received: (at 62713) by debbugs.gnu.org; 25 Sep 2023 12:47:30 +0000 Received: from localhost ([127.0.0.1]:44538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkkzp-0008FV-U9 for submit@debbugs.gnu.org; Mon, 25 Sep 2023 08:47:30 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:53268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkkzk-0008FE-J6 for 62713@debbugs.gnu.org; Mon, 25 Sep 2023 08:47:28 -0400 Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-1c0ecb9a075so41221355ad.2 for <62713@debbugs.gnu.org>; Mon, 25 Sep 2023 05:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695646026; x=1696250826; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=CRzbZ9VPB7SwbitgDycRT55E8KTk9Re6iBMbJ4ymxgs=; b=MkglgepamT2EegOvR/iOY3WbfOtnLMNqCws99VmSxKinjl+oIi26vwDDugtGezPuxc Gf9nOzdTMCc1lgYsdhsgnEsMrW/OMrqWTCI1r12GMQVLHZOjlk43bXD/DC7PIeaYjYIb r5zSTHEU8q2G7x/nNg3SbTXFVtj8hgrVo9MAsKOOmcaAZRcRm3XqVIGtKCtMCCrtRDxE 9jc1F0wt+Ah+le0xF6/wvLkvKhyzYGMZ3VS5Y1uL37lqf2SSU87QHXPcIkiN+XOVUnWi 1sq+fT1XhJRPHOYqoaHabd/a9iw7/0+DlmxHHMlKkNgEUpv1zxwUZYk6dVHAeW20luW6 BRzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695646026; x=1696250826; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CRzbZ9VPB7SwbitgDycRT55E8KTk9Re6iBMbJ4ymxgs=; b=IisI1/mjz2Ut5vecA/8u2JgcpXyJscWZcnM4FjtNu1DzKqMaPjgxG7YLT2lGnv8CJu 95vtuVYsLG4YTmq16Sb7psP9W7Bh3Y2cE/DTLWpRhyb/18ovWGo76LmoH45mlKiNCkhI IQJbG7j/6cVBOh7sL+FYJCXokK+ujqMLqHTTRWVvfQJnPgygTzriZiGXT0CVcjvFkE4A 3dJG+vd+fyYB1KhXuiSDB6K0UO4bn3RjjKq+SqNEraQsSt9sXWtlOkg+aH21btb+FdMo t+vLfCcUL0mxMmBBJwYvV0wGBxVj1pTjz0wdoNgrbbOqh6fAfaD/fqbTs1NSSmB47VJ8 1VDw== X-Gm-Message-State: AOJu0YwDn6VllvpWHNnjKhtLHwZFvijoKAdZ1GSw2Xtg+LbjZB+TaBSx uNQoY1Y8e99fU7YeVd5Khxc= X-Google-Smtp-Source: AGHT+IE2Rjr16XSu8hhnJVQvw4rfhVjcGQc63iR7cCsbP+NBsg2uPrnDWayJKqVt2xU4Ov2zVVIcGA== X-Received: by 2002:a17:902:c38d:b0:1bd:f69e:6630 with SMTP id g13-20020a170902c38d00b001bdf69e6630mr4429079plg.65.1695646025991; Mon, 25 Sep 2023 05:47:05 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id u6-20020a170902b28600b001c61acd5bd2sm2117556plr.112.2023.09.25.05.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 05:47:05 -0700 (PDT) From: Visuwesh To: Stefan Kangas Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images In-Reply-To: <87ttriri1b.fsf@gmail.com> (Visuwesh's message of "Mon, 25 Sep 2023 10:00:40 +0530") References: <87v8i7llz9.fsf@no.lan> <87ttriri1b.fsf@gmail.com> Date: Mon, 25 Sep 2023 18:17:01 +0530 Message-ID: <87edimmncq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62713 Cc: 62713@debbugs.gnu.org, Gregor Zattler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [=E0=AE=A4=E0=AE=BF=E0=AE=99=E0=AF=8D=E0=AE=95=E0=AE=B3=E0=AF=8D =E0=AE=9A= =E0=AF=86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0= =AF=8D 25, 2023] Visuwesh wrote: > It is better solved by writing a separate pdf->svg converter function. > Right now, the svg conversion is tacked on top of pdf->png converter > function used for MuPDF. This was done because I thought only MuPDF > supported pdf->svg conversion but later I was informed that poppler has > utilities to do too. And looks like the poppler utility pdftocairo does not work the doc-view expects it to when generating svg images. AFAICT, there is no way to make pdftocairo to generate a svg image per page like other tools do. I cannot loop either as there is also no way to know the number of pages beforehand. The png function also has hacks since pdftocairo is not cooperative, and changing doc-view to not use doc-view--image-file-pattern does not seem to be easy. I attach the patch named "doc-view-general-svg-wip.patch" which has my WIP and it works just fine for MuPDF. This particular problem can be easily solved by the following simple patch instead: diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b856b09c8b7..c0d27bdc68a 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -1283,7 +1283,8 @@ doc-view-pdf->png-converter-mupdf (expand-file-name doc-view-epub-user-stylesheet))))))) (doc-view-start-process - "pdf->png" doc-view-pdfdraw-program + (concat "pdf->" (symbol-name doc-view--image-type)) + doc-view-pdfdraw-program `(,@(doc-view-pdfdraw-program-subcommand) ,@options ,pdf But if you say we don't bother about pdftocairo support and implement the generic support system, I can prepare a patch without the pdftocairo stuff, and add some documentation to aid the users to write custom converter functions. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=doc-view-general-svg-wip.patch diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b856b09c8b7..03b01de5033 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -193,28 +193,63 @@ doc-view-pdfdraw-program :type 'file :version "24.4") +(defcustom doc-view-poppler-program "pdftocairo" + "Name of pdfcairo program from Poppler." + :type 'file + :version "30.1") + (defcustom doc-view-pdftotext-program-args '("-raw") "Parameters to give to the pdftotext command." :version "27.1" :type '(repeat string)) (defcustom doc-view-pdf->png-converter-function - (if (executable-find doc-view-pdfdraw-program) - #'doc-view-pdf->png-converter-mupdf - #'doc-view-pdf->png-converter-ghostscript) + (cond + ((executable-find doc-view-poppler-program) + #'doc-view-pdf->png-converter-poppler) + ((executable-find doc-view-pdfdraw-program) + #'doc-view-pdf->png-converter-mupdf) + (t #'doc-view-pdf->png-converter-ghostscript)) "Function to call to convert a PDF file into a PNG file." :type '(radio (function-item doc-view-pdf->png-converter-ghostscript :doc "Use ghostscript") (function-item doc-view-pdf->png-converter-mupdf :doc "Use mupdf") + (function-item doc-view-pdf->png-converter-poppler + :doc "Use pdfcairo from poppler") function) :version "24.4") +(defcustom doc-view-pdf->svg-converter-function + (cond + ((executable-find doc-view-poppler-program) + #'doc-view-pdf->svg-converter-poppler) + ((executable-find doc-view-pdfdraw-program) + #'doc-view-pdf->svg-converter-mupdf) + (t #'doc-view-pdf->svg-converter-mupdf)) + "Function to call to convert a PDF file into a SVG file." + :type '(radio + (function-item doc-view-pdf->svg-converter-mupdf + :doc "Use mupdf") + (function-item doc-view-pdf->svg-converter-poppler + :doc "Use pdfcairo from poppler") + function) + :version "30.1") + +(defcustom doc-view-use-svg (image-type-available-p 'svg) + "Whether to use svg images for files whenever possible." + :type 'boolean + :version "30.1") + (defcustom doc-view-mupdf-use-svg (image-type-available-p 'svg) "Whether to use svg images for PDF files." :type 'boolean - :version "30.1") + :version "30.1" + :set (lambda (sym val) + (set-default-toplevel-value sym val) + (setq doc-view-use-svg val))) +(make-obsolete 'doc-view-mupdf-use-svg 'doc-view-use-svg "30.1") (defcustom doc-view-imenu-enabled (and (executable-find "mutool") t) "Whether to generate an imenu outline when \"mutool\" is available." @@ -241,7 +276,7 @@ doc-view-imenu-flatten (defface doc-view-svg-face '((t :inherit default)) "Face used for SVG images. Only background and foreground colors are used. -See `doc-view-mupdf-use-svg'." +See `doc-view-use-svg'." :version "30.1") (make-obsolete 'doc-view-svg-background 'doc-view-svg-face "30.1") @@ -1266,10 +1301,10 @@ doc-view-pdf-password-protected-pdfdraw-p (goto-char (point-min)) (search-forward "error: cannot authenticate password" nil t))) -(defun doc-view-pdf->png-converter-mupdf (pdf png page callback) +(defun doc-view-pdf->img-converter-mupdf (pdf type img page callback) (let* ((pdf-passwd (if (doc-view-pdf-password-protected-pdfdraw-p pdf) (read-passwd "Enter password for PDF file: "))) - (options `(,(concat "-o" png) + (options `(,(concat "-o" img) ,(format "-r%d" (round doc-view-resolution)) ,@(if pdf-passwd `("-p" ,pdf-passwd))))) (when (eq doc-view-doc-type 'epub) @@ -1283,13 +1318,74 @@ doc-view-pdf->png-converter-mupdf (expand-file-name doc-view-epub-user-stylesheet))))))) (doc-view-start-process - "pdf->png" doc-view-pdfdraw-program + (concat "pdf->" type) doc-view-pdfdraw-program `(,@(doc-view-pdfdraw-program-subcommand) ,@options ,pdf ,@(if page `(,(format "%d" page)))) callback))) +(defun doc-view-pdf->png-converter-mupdf (pdf img page callback) + (doc-view-pdf->img-converter-mupdf pdf "png" img page callback)) + +(defun doc-view-pdf->svg-converter-mupdf (pdf img page callback) + (doc-view-pdf->img-converter-mupdf pdf "svg" img page callback)) + +(defun doc-view-pdf-password-protected-poppler-p (pdf) + "Return non-nil if a PDF file is password-protected." + (with-temp-buffer + (let* ((tmp (make-temp-name "emacs-doc-view-test")) + (abs (expand-file-name (concat tmp ".png") temporary-file-directory))) + (call-process doc-view-poppler-program nil (current-buffer) nil + "-png" "-f" "1" "-singlefile" pdf abs) + (when (file-regular-p abs) + (delete-file abs)) + (goto-char (point-min)) + (search-forward "Incorrect password" nil t)))) + +(defun doc-view-pdf->png-converter-poppler (pdf imgfile page callback) + (let ((passwd (when (doc-view-pdf-password-protected-poppler-p pdf) + (read-passwd "Enter password for PDF file: ")))) + ;; HACK: pdftocairo doesn't accept format arguments in the image + ;; filename argument for PNG, JPEG, TIFF, and doc-view relies on a + ;; valid `doc-view--image-file-pattern' that can be passed to + ;; `format' to change pages in `doc-view-goto-page'. But + ;; thankfully, when PAGE is nil it means to fetch all pages. + (when (and (null page) (string-match-p "%d" imgfile)) + (setq imgfile (string-remove-suffix + (concat "-%d." (symbol-name doc-view--image-type)) + imgfile))) + (doc-view-start-process + "pdf->png" + doc-view-poppler-program + `("-png" "-r" ,(format "%d" (round doc-view-resolution)) + ,@(when passwd `("-opw" ,passwd)) + ,pdf + ,@(if page ; Single page. + (list "-f" (format "%d" page) "-singlefile" + (file-name-sans-extension imgfile)) + (list imgfile))) + callback))) + +(defun doc-view-pdf->svg-converter-poppler (pdf imgfile page callback) + (let ((passwd (when (doc-view-pdf-password-protected-poppler-p pdf) + (read-passwd "Enter password for PDF file: ")))) + ;; For vector formats such as svg, output-file name is handled + ;; differently. *Sigh* + ;; There seems to be no way to generate separate image per-page so + ;; we give up? + (unless (null page) + (doc-view-start-process + "pdf->svg" + doc-view-poppler-program + `("-svg" "-r" ,(format "%d" (round doc-view-resolution)) + ,@(when passwd `("-opw" ,passwd)) + ,pdf + ;; -singlefile is not supported for svg... + "-f" ,(format "%d" page) "-l" ,(format "%d" page) + ,imgfile) + callback)))) + (defun doc-view-odf->pdf-converter-unoconv (odf callback) "Convert ODF to PDF asynchronously and call CALLBACK when finished. The converted PDF is put into the current cache directory, and it @@ -1329,7 +1425,9 @@ doc-view-pdf/ps->png (funcall (pcase doc-view-doc-type ((or 'pdf 'odf 'epub 'cbz 'fb2 'xps 'oxps) - doc-view-pdf->png-converter-function) + (if doc-view-use-svg + doc-view-pdf->svg-converter-function + doc-view-pdf->png-converter-function)) ('djvu #'doc-view-djvu->tiff-converter-ddjvu) (_ #'doc-view-ps->png-converter-ghostscript)) pdf-ps png nil @@ -2148,10 +2246,8 @@ doc-view-set-up-single-converter (pcase-let ((`(,conv-function ,type ,extension) (pcase doc-view-doc-type ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif")) - (_ (if (and (eq doc-view-pdf->png-converter-function - #'doc-view-pdf->png-converter-mupdf) - doc-view-mupdf-use-svg) - (list doc-view-pdf->png-converter-function 'svg "svg") + (_ (if doc-view-use-svg + (list doc-view-pdf->svg-converter-function 'svg "svg") (list doc-view-pdf->png-converter-function 'png "png")))))) (setq-local doc-view-single-page-converter-function conv-function) (setq-local doc-view--image-type type) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 07:43:27 2023 Received: (at 62713) by debbugs.gnu.org; 26 Sep 2023 11:43:27 +0000 Received: from localhost ([127.0.0.1]:47488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6TP-0007Jo-3a for submit@debbugs.gnu.org; Tue, 26 Sep 2023 07:43:27 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:53618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6TN-0007JX-HG for 62713@debbugs.gnu.org; Tue, 26 Sep 2023 07:43:26 -0400 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50300cb4776so14019859e87.3 for <62713@debbugs.gnu.org>; Tue, 26 Sep 2023 04:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695728587; x=1696333387; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=CvUuxTua4EC/YE72XsvnZVYL6o7mjje0xZ/iGZV+CkY=; b=aF/X6nC0xW0DfEj1q24XN3dskOIHBbWFqTvJGnb7QZb+T/VDHC4BBYGedJWHf8Bocd BNX5xddUTrxMiEL4aIqDvI7tDDtTYxPFMg683yH9b7v94vIebdXYqqmulnf6Kiot719P PDW2VS9RaKOj571GqkpGqLMHdVhZG6WRPjucNkzZ7KW6yDb8gsypDCNtci0HHBqhuzks RU7sKDzI/22zGB2rz7UYaoIVWHGL+om1wqKy34o/tmT6JWqkXh5S8JcH4oBYK19MY+Zl CNYoDNtfdZi9kwFqmWo7PgciaVW7y0xe/KvIN7OCLMK6zI6KvaMtUndh9BXgD+1oE2t+ 0gkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695728587; x=1696333387; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CvUuxTua4EC/YE72XsvnZVYL6o7mjje0xZ/iGZV+CkY=; b=AMYXZgG6W4o0DVevE5+RUUez+wYmXtC/mGY+R3mcAA52BOWnnCUmlxk+fl17b2F4/g vXXJRTGe56aQ6cipu77h9Ax+p6keNPUMDYCxCBZglTPDona6gtD3amEcoxomfCvSpWSf A/EdVXU3UXq2xbw0ijli6JKtD35Z8srldEYdcwZrVa9XCSBDG3awP0xKX3utffYEekZO lMRfkakLbwS6AQm/1Xju6sxaeQYcXdPXUiTKi7dDwuZWexXQ5Dh6AZ2yMC9YZturfOz2 lfaf0tzXTXommsCa38aSPzfzhxJBipk4NpfsEobKusXc/BP5icuItaM9HXQXl2eaQ207 kZCQ== X-Gm-Message-State: AOJu0YxOuCc5RYc7HK+8FslgWazoHBVxlvEQuAo16vSeDPuTrSR/VKNc DtRXEMcpSMoSP/AC5nf+zJWSkcdPu5kg73/4UmikE5Hl X-Google-Smtp-Source: AGHT+IFA3PO9oPiuCGNnXWegaLlZlTaSjtgYVPoiFwqSHhsPfkPLV75BHwhl2k2UJU7UDyAVqcvFcEm//pppk1Kn1Yk= X-Received: by 2002:a19:8c09:0:b0:503:294d:797 with SMTP id o9-20020a198c09000000b00503294d0797mr7232947lfd.11.1695728586335; Tue, 26 Sep 2023 04:43:06 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 26 Sep 2023 04:43:05 -0700 From: Stefan Kangas In-Reply-To: <87edimmncq.fsf@gmail.com> References: <87v8i7llz9.fsf@no.lan> <87ttriri1b.fsf@gmail.com> <87edimmncq.fsf@gmail.com> MIME-Version: 1.0 Date: Tue, 26 Sep 2023 04:43:05 -0700 Message-ID: Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images To: Visuwesh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62713 Cc: 62713@debbugs.gnu.org, Gregor Zattler , Tassilo Horn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Visuwesh writes: > [=E0=AE=A4=E0=AE=BF=E0=AE=99=E0=AF=8D=E0=AE=95=E0=AE=B3=E0=AF=8D =E0=AE= =9A=E0=AF=86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0= =E0=AF=8D 25, 2023] Visuwesh wrote: > >> It is better solved by writing a separate pdf->svg converter function. >> Right now, the svg conversion is tacked on top of pdf->png converter >> function used for MuPDF. This was done because I thought only MuPDF >> supported pdf->svg conversion but later I was informed that poppler has >> utilities to do too. > > And looks like the poppler utility pdftocairo does not work the doc-view > expects it to when generating svg images. AFAICT, there is no way to > make pdftocairo to generate a svg image per page like other tools do. I > cannot loop either as there is also no way to know the number of pages > beforehand. The png function also has hacks since pdftocairo is not > cooperative, and changing doc-view to not use > doc-view--image-file-pattern does not seem to be easy. I attach the > patch named "doc-view-general-svg-wip.patch" which has my WIP and it > works just fine for MuPDF. > > This particular problem can be easily solved by the following simple > patch instead: Tassilo, could you perhaps take a look at this patch? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 29 05:40:57 2023 Received: (at 62713) by debbugs.gnu.org; 29 Sep 2023 09:40:57 +0000 Received: from localhost ([127.0.0.1]:55371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qm9zU-0005SZ-TG for submit@debbugs.gnu.org; Fri, 29 Sep 2023 05:40:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qm9zS-0005SI-0M for 62713@debbugs.gnu.org; Fri, 29 Sep 2023 05:40:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm9z7-0000X9-LO; Fri, 29 Sep 2023 05:40:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=wew8CHOaQM+XDye8NRtQptiiBC81W5ISJGivGs7Iz6Q=; b=WI00k7lOsJRUJa 5a/DF3kwAQuaraCamFddlxEj9cAh6iJE8DoL7c6VwCFfjVY6jcE+ilcVcf5GgPCGZ7KLl3VxEHJH6 Qen3KsRAKjPjMfcOf7F/+qIV9fnX0v0Wnm5+MbKyvrXQniUmdRRr9OwGasdCeIysoSta8l5LtXwZR Uz63dwQeq0T0icYTbS8eoAnU5vf3uWgRqEgAvNl4gJdUTv154I+2hxv0J2TOOfOw8h+U2+tedEJDP P7Kw2jXPR4EADY07+owICv1fon4fiC6tJe/YPRSZF61J2wUn8O+44L2i2gb7aJUkVg9S4X6C+qGUs 67X090/T5I2YwL9QL/NA==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrtddvgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepud ejtdehuddvleffjeekteegvdehleehvdeufefhueekkeekhedvgfeggeffvefgnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail References: <87v8i7llz9.fsf@no.lan> <87ttriri1b.fsf@gmail.com> <87edimmncq.fsf@gmail.com> User-agent: mu4e 1.11.21; emacs 30.0.50 From: Tassilo Horn To: Stefan Kangas Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images Date: Fri, 29 Sep 2023 11:34:35 +0200 In-reply-to: Message-ID: <87r0mh9v1x.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62713 Cc: 62713@debbugs.gnu.org, Gregor Zattler , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: >> This particular problem can be easily solved by the following simple >> patch instead: > > Tassilo, could you perhaps take a look at this patch? Yes, the simple patch looks good and fixes the bug. Feel free to commit it. I've skimmed at the WIP patch, too. It also looks good but has not much to do with the bug report but adds another pdf->svg converter. Visuwesh, I noticed that the docstrings speak of pdfcairo while the program actually is pdftocairo. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 29 05:44:15 2023 Received: (at 62713) by debbugs.gnu.org; 29 Sep 2023 09:44:15 +0000 Received: from localhost ([127.0.0.1]:55379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmA2h-0005Yi-Gf for submit@debbugs.gnu.org; Fri, 29 Sep 2023 05:44:15 -0400 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:59562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmA2e-0005YR-8R for 62713@debbugs.gnu.org; Fri, 29 Sep 2023 05:44:13 -0400 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2bffc55af02so219546341fa.2 for <62713@debbugs.gnu.org>; Fri, 29 Sep 2023 02:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695980631; x=1696585431; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=UOBaTEFu1MPlH7hHNJNSgTk6B9OhIDumdfRk0mDLLFo=; b=DNqDSdl7z6MpTXpfY+NOUrlGtrC0mxCW+ue8gOPWsPx3E7ndOlgw1uRV1L/z2TG/sL OAwU8ELQpOtdF6PW6EVobN3PezHPgj5w389/MM1q/cPJ30/I0m9SGhEUK3gNig6brIOy M86c10Jl5gJJc+PB2236eh/X7vYKu/0z4raU+oYZ+bjA0fLZDWYtVdaJyx0gDSbB3PPO Nq6X2nl7NfBvFJw3yPPF7MAD1hdYuEsWsCVhiDwXnD2TnNRUk38oUBVdjjJk0BDTKE/3 zm1QkbuyUSDjzfVY6tbxmS3iDt0sj1nZd3V1fF6xbVr6KUn2IEtPypAMoYve7PBr509N ZuIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695980631; x=1696585431; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UOBaTEFu1MPlH7hHNJNSgTk6B9OhIDumdfRk0mDLLFo=; b=uBbZvlajEtzlM5pd++LnSxRFHbLst4Sx6/1j0ZZO0uLL+YLTc4ah2q7uw6/6u3fMfT Ic4doc5E4OW2Ou/nfW/jRChQ5YVxKMGq683safWhIo6iBbiDXsOx4HWePYwcC4hocTUK edC1lHqjzSLV78P5pMMAz3xynnrNi5808ZOCc5JxkKHpPKTiatptC9gg3vF4hXY2Syd3 K2NOJOEHbicvXC93G+8jRXpr2Jrq8bBgH0t5KuAOrxNCWc+EY1XoStKHofbskaAFPqaz syYUz4AxnRS5tYuk3TD6x+JcoAKVU9csUu+bdtUQ+CHCn4p8GNIGVYZptFFMeSw6U9RB LPFQ== X-Gm-Message-State: AOJu0YzoxcfA65X/B99Lz4LVuGVe9NZE5Kx3HKh+EvbEH9fgR4E+78cm qqix9rTXAjdTdP8dLZLQ3yphr38yS0kXNO7yCvA= X-Google-Smtp-Source: AGHT+IHS9Ws7zxTM2vMTZV+66xIedQwmFHB72u9BjXptddweJTn70TEHiSVKEqY+duUf9VsXpF7gbafhw0kgkHa5GqI= X-Received: by 2002:a2e:9c0f:0:b0:2bc:c1d9:6848 with SMTP id s15-20020a2e9c0f000000b002bcc1d96848mr3165541lji.44.1695980631255; Fri, 29 Sep 2023 02:43:51 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 29 Sep 2023 02:43:50 -0700 From: Stefan Kangas In-Reply-To: <87r0mh9v1x.fsf@gnu.org> References: <87v8i7llz9.fsf@no.lan> <87ttriri1b.fsf@gmail.com> <87edimmncq.fsf@gmail.com> <87r0mh9v1x.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 29 Sep 2023 02:43:50 -0700 Message-ID: Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images To: Tassilo Horn Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62713 Cc: 62713@debbugs.gnu.org, Gregor Zattler , Visuwesh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tassilo Horn writes: > Stefan Kangas writes: > >>> This particular problem can be easily solved by the following simple >>> patch instead: >> >> Tassilo, could you perhaps take a look at this patch? > > Yes, the simple patch looks good and fixes the bug. Feel free to commit > it. Great, thanks. Visuwesh, could you please send the patch as an attachment instead? We prefer that patches are created with a command like `git format-patch -1'. Please also include: - The bug number of this bug in the commit message, like so: Bug#62713 - A ChangeLog entry, as described in the file CONTRIBUTE. That would make it easier for us to review and install this patch. Thanks in advance. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 29 10:55:39 2023 Received: (at 62713) by debbugs.gnu.org; 29 Sep 2023 14:55:39 +0000 Received: from localhost ([127.0.0.1]:56901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmEu3-0000ls-7h for submit@debbugs.gnu.org; Fri, 29 Sep 2023 10:55:39 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:57581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmEtz-0000la-8b for 62713@debbugs.gnu.org; Fri, 29 Sep 2023 10:55:37 -0400 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-690d8c05784so11510187b3a.2 for <62713@debbugs.gnu.org>; Fri, 29 Sep 2023 07:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695999314; x=1696604114; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kJfI9wTSmc7zI9zu+qM++miqTVeK+CIzJT1SVhCPlc4=; b=gG3O60kOkqpG1iyfbfgUh6C5qTReKu5GI75JMwWdnxZOjINyrB1ZsTtFIwup6O3ekl SE1E9748dAkEWxgW2jkT1SK1ZsHarXgTB5ZZrJ/WiH+ycTiSk2+XmUhdNhZdRIzI+02s uSbO1VUlbUZnVZ2dNYQ1JBUaC6Qbk29BlFnYNRPpFh3r81bCscPVqa5W45sD+zbqzqUj vC8ummG8+/zXt6vmOz+jGL+ge+Xts8goQdFuUNMIrhFPCdbRa0PWGU7HYpRyR/7kqlZ2 li+14H5I7OLtitiPalC9EXGzUoEdC5gMO/tIbF/nK9hUSXEtZDWgiN3l9CROkJaq/ksE n4BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695999314; x=1696604114; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kJfI9wTSmc7zI9zu+qM++miqTVeK+CIzJT1SVhCPlc4=; b=d+hHqQ6dLG3El1ogYoyA2Oa1djRCYUzEzODMLEMDwiq2aNEB+wRZUQYW9cnipK63X/ rWPacFlaIBiFDDm5joIhkWAlqwV7FcEK/O/D1JSJotYLDdo1n32neoYIZpdKmnEP19lt eDHJXERoBNYTIhVam9TaXqhg03LBa4kJC6q/2sbF7dX4tQBoUuqr65WUf2npSmatFRvV ODBUpMHEi/VhE1OA4e90cZweuKG+qC0XRhtO/Ij1tB5nEA0Fx/dTUGVUxo32VBvgiN+y ZuDUmbAtD3OY34xGOLvE/JdlyzGhMw4J0MgEmMSoKbpCyiYjJOyPGn3knrmlYHS0NtA2 nocw== X-Gm-Message-State: AOJu0YzSfyw+PFVjLw1Bdc+ohEQ5c+rOBEFXLl/CafhDp+ymwRJwYQHw 5CsGi4eTumBTuzCNAaO/pZU= X-Google-Smtp-Source: AGHT+IHPjGXZhaTijqQFj7hImfZQTIJdB31S7Zfxz/3dO3Vu980Yv0JL5GtY/lcJ+SDdGpxkcndcZA== X-Received: by 2002:a05:6a20:5490:b0:161:5ea5:fc0b with SMTP id i16-20020a056a20549000b001615ea5fc0bmr5049218pzk.16.1695999313124; Fri, 29 Sep 2023 07:55:13 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id f25-20020aa782d9000000b00690d1269691sm4199139pfn.22.2023.09.29.07.55.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 07:55:12 -0700 (PDT) From: Visuwesh To: Stefan Kangas Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images In-Reply-To: (Stefan Kangas's message of "Fri, 29 Sep 2023 02:43:50 -0700") References: <87v8i7llz9.fsf@no.lan> <87ttriri1b.fsf@gmail.com> <87edimmncq.fsf@gmail.com> <87r0mh9v1x.fsf@gnu.org> Date: Fri, 29 Sep 2023 20:25:09 +0530 Message-ID: <87ttrddo6q.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62713 Cc: 62713@debbugs.gnu.org, Gregor Zattler , Tassilo Horn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=9A=E0=AF=86= =E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 29= , 2023] Stefan Kangas wrote: > Tassilo Horn writes: > >> Stefan Kangas writes: >> >>>> This particular problem can be easily solved by the following simple >>>> patch instead: >>> >>> Tassilo, could you perhaps take a look at this patch? >> >> Yes, the simple patch looks good and fixes the bug. Feel free to commit >> it. > > Great, thanks. > > Visuwesh, could you please send the patch as an attachment instead? We > prefer that patches are created with a command like `git format-patch > -1'. Please find attached patch. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-doc-view-conversion-indicator-for-svg-images.patch >From a73ab9af07f5867da3b6ff97c73d35230ea21c1e Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Fri, 29 Sep 2023 20:23:56 +0530 Subject: [PATCH] Fix doc-view conversion indicator for svg images * lisp/doc-view.el (doc-view-pdf->png-converter-mupdf): Show the corrector pdf->svg indicator when producing svg images. bug#62713 --- lisp/doc-view.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b856b09c8b7..c0d27bdc68a 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -1283,7 +1283,8 @@ doc-view-pdf->png-converter-mupdf (expand-file-name doc-view-epub-user-stylesheet))))))) (doc-view-start-process - "pdf->png" doc-view-pdfdraw-program + (concat "pdf->" (symbol-name doc-view--image-type)) + doc-view-pdfdraw-program `(,@(doc-view-pdfdraw-program-subcommand) ,@options ,pdf -- 2.40.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 01 09:01:09 2023 Received: (at 62713-done) by debbugs.gnu.org; 1 Oct 2023 13:01:09 +0000 Received: from localhost ([127.0.0.1]:60861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmw4K-0007dn-JC for submit@debbugs.gnu.org; Sun, 01 Oct 2023 09:01:08 -0400 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:59477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmw4I-0007O7-Cw for 62713-done@debbugs.gnu.org; Sun, 01 Oct 2023 09:01:06 -0400 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5041d6d8b10so24965301e87.2 for <62713-done@debbugs.gnu.org>; Sun, 01 Oct 2023 06:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696165244; x=1696770044; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=9W7mM6kWxh6uolsL6FkcBu3eHOFX1AJp7h3oXgizmEM=; b=UmZClGRK2kIlOEzxx3P6dhQ3Pzc8muQJSzwO40JqMLwtNv9fGIk4Mq7O5gmBhcd2y7 I0pLYYFnNMUi42y69TNFwSgBRZo3Tmh5gDaPnythCLMYdho/6tDAAhyBvGRGOZRih78I TeIj5VZbp0S23LS1VXOu0D3LFXoih9LuCZFuz01Kkr+uB7aqul91BALhV5OybwvbrtCb i1ZhE2PWbhPcfb6V435PoDzF7kalpEKs+nfbIcf2YgkE0yU5boLMblLiEkWWE86v99dH SMf8FiIz3hX34KEswHevZzouxmbKKlzHydrHM+fZIlgSDOFGBszVbRx8Jv5niI8UeCCA wVXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696165244; x=1696770044; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9W7mM6kWxh6uolsL6FkcBu3eHOFX1AJp7h3oXgizmEM=; b=h/np/UGziUJX/hRuEb860tOMqcjkXiDxbKfjmUlDrZIkrw/ALzIlDP7+UM5+ofAwEY UXo+taDC11oAlVT8BBXAKSe5tCcIJ8cWIEarIM3Q+7q2R0lCkJEja8LDpyXIjzBCPqLz onSxCFq1evVH7ahHpoKlZtJDh7ya2/h2HGMM79VVJLH4InwBVzS1wJYHkl7+Z2hBafVV clBJfVpQzrj5YnarCsOx2Z5+owlkilBtwAGiCP9bHXuv6//XBXcWttcFfWSzRnKM5i7L v2skXRkAcNqVGonU28RYmEffKTeXyYY+mMhny92CEJy5BDhmWZlRIUMB9shiUFDWj5Gz vDvw== X-Gm-Message-State: AOJu0YzYkoOH9qxn1FxxhkJ3MmsSa1SXxexPxldNqBK13ZJO+/7LwvmC ZMoF3UXeTCiMVhVREp2aWNsOOSFsNdYd8wGjHUw= X-Google-Smtp-Source: AGHT+IFPw/K8OH111LaoXDxBkdjmwucOy0/KP5MFW5Nakq9N6m7lxMjFGJCwMdhW1LpDvNZfSjerkk28szUaWCeLIL0= X-Received: by 2002:a05:6512:a84:b0:502:d743:8a6c with SMTP id m4-20020a0565120a8400b00502d7438a6cmr8500702lfu.9.1696165244169; Sun, 01 Oct 2023 06:00:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 1 Oct 2023 06:00:43 -0700 From: Stefan Kangas In-Reply-To: <87ttrddo6q.fsf@gmail.com> References: <87v8i7llz9.fsf@no.lan> <87ttriri1b.fsf@gmail.com> <87edimmncq.fsf@gmail.com> <87r0mh9v1x.fsf@gnu.org> <87ttrddo6q.fsf@gmail.com> MIME-Version: 1.0 Date: Sun, 1 Oct 2023 06:00:43 -0700 Message-ID: Subject: Re: bug#62713: 29.0.60; DocView shows wrong conversion indicator when configured to use svg images To: Visuwesh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62713-done Cc: 62713-done@debbugs.gnu.org, Gregor Zattler , Tassilo Horn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Visuwesh writes: > [=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=9A=E0=AF= =86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D= 29, 2023] Stefan Kangas wrote: > >> Tassilo Horn writes: >> >>> Stefan Kangas writes: >>> >>>>> This particular problem can be easily solved by the following simple >>>>> patch instead: >>>> >>>> Tassilo, could you perhaps take a look at this patch? >>> >>> Yes, the simple patch looks good and fixes the bug. Feel free to commi= t >>> it. >> >> Great, thanks. >> >> Visuwesh, could you please send the patch as an attachment instead? We >> prefer that patches are created with a command like `git format-patch >> -1'. > > Please find attached patch. Thanks, installed on master [1: f0abc9bc0d5], and I'm consequently closing this bug report. [1: f0abc9bc0d5]: 2023-10-01 14:58:48 +0200 Fix doc-view conversion indicator for svg images https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Df0abc9bc0d536e5b= 2834c04714d75d18fde431c3 From unknown Tue Aug 19 12:49:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 30 Oct 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator