GNU bug report logs - #62712
[PATCH 0/2] Disable keyword expansion for Subversion downloads

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Fri, 7 Apr 2023 14:07:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: 62712 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>, Timothy Sample <samplet <at> ngyro.com>, zimoun <zimon.toutoune <at> gmail.com>
Subject: [bug#62712] [PATCH 0/2] Disable keyword expansion for Subversion downloads
Date: Fri,  7 Apr 2023 16:05:51 +0200
Hello Guix!

As discussed in <https://issues.guix.gnu.org/43442>, SVN keyword
expansion during checkout is problematic because it depends on local
timezone.  This in itself isn't really a problem in Guix because
the timezone in the environment of fixed-output derivations is
always UTC.  However, SWH disables keyword expansion (for this
reason), and thus it makes sense to follow suit.

Disabling keyword expansion entails many rebuilds.  However, these
are "safe", so I'd like to have them on a branch (or simply handled
by qa.guix) that we'd merge as soon as it's built.

The second patch makes ‘recursive?’ default to #f, which AFAICS
is what all the SVN-using packages that were not explicit expected
(no changes required).

Thoughts?

Ludo’.

Ludovic Courtès (2):
  svn-download: Disable keyword expansion.
  svn-download: Default to non-recursive checkouts.

 gnu/packages/java.scm             |  2 +-
 gnu/packages/machine-learning.scm |  2 +-
 gnu/packages/tex.scm              | 16 ++++++++--------
 gnu/packages/video.scm            |  4 ++--
 guix/build/svn.scm                |  9 ++++++++-
 guix/svn-download.scm             |  6 +++---
 6 files changed, 23 insertions(+), 16 deletions(-)


base-commit: 47fe66586e0fbc177288ec91cc88ea0b081505b0
-- 
2.39.2





This bug report was last modified 2 years and 35 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.